Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22419#discussion_r219655441
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala ---
@@ -413,6 +413,7 @@ object Decimal {
val ROUND_HALF_EVEN = BigDecimal.RoundingMode.HALF_EVEN
val ROUND_CEILING = BigDecimal.RoundingMode.CEILING
val ROUND_FLOOR = BigDecimal.RoundingMode.FLOOR
+ val ROUND_DOWN = BigDecimal.RoundingMode.DOWN
--- End diff --
I guess we need to modify `Decimal.changePrecision()` as well? Could you
add it to
[DecimalSuite.scala#L207](https://github.com/apache/spark/blob/479b31fa046e8402f4f93cdbad5fe93ef1ea570f/sql/catalyst/src/test/scala/org/apache/spark/sql/types/DecimalSuite.scala#L207)
to check?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
