Github user hvanhovell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22429#discussion_r223979931
  
    --- Diff: 
external/avro/src/main/scala/org/apache/spark/sql/avro/CatalystDataToAvro.scala 
---
    @@ -52,7 +52,7 @@ case class CatalystDataToAvro(child: Expression) extends 
UnaryExpression {
         out.toByteArray
       }
     
    -  override def simpleString: String = {
    +  override def simpleString(maxFields: Option[Int]): String = {
         s"to_avro(${child.sql}, ${child.dataType.simpleString})"
    --- End diff --
    
    Should we also pass the maxFields to `child.dataType`? For example 
`StructType` fields are truncated.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to