Github user hvanhovell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22429#discussion_r223980665
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala 
---
    @@ -455,21 +457,37 @@ abstract class TreeNode[BaseType <: 
TreeNode[BaseType]] extends Product {
       }.mkString(", ")
     
       /** ONE line description of this node. */
    -  def simpleString: String = s"$nodeName $argString".trim
    +  def simpleString(maxFields: Option[Int]): String = {
    --- End diff --
    
    Please document the `maxFields` parameter. I am especially interested in 
what `None` represents here.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to