Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22597#discussion_r225014099
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcFilterSuite.scala
 ---
    @@ -383,4 +384,15 @@ class OrcFilterSuite extends OrcTest with 
SharedSQLContext {
           )).get.toString
         }
       }
    +
    +  test("SPARK-25579 ORC PPD should support column names with dot") {
    +    import testImplicits._
    --- End diff --
    
    Okay. One end to end test should be enough


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to