Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22597#discussion_r225025622
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcFilterSuite.scala
 ---
    @@ -383,4 +385,17 @@ class OrcFilterSuite extends OrcTest with 
SharedSQLContext {
           )).get.toString
         }
       }
    +
    +  test("SPARK-25579 ORC PPD should support column names with dot") {
    +    import testImplicits._
    +
    +    withSQLConf(SQLConf.ORC_FILTER_PUSHDOWN_ENABLED.key -> "true") {
    +      withTempDir { dir =>
    +        val path = new File(dir, "orc").getCanonicalPath
    +        Seq((1, 2), (3, 4)).toDF("col.dot.1", "col.dot.2").write.orc(path)
    +        val df = spark.read.orc(path).where("`col.dot.1` = 1 and 
`col.dot.2` = 2")
    +        checkAnswer(stripSparkFilter(df), Row(1, 2))
    --- End diff --
    
    Yup.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to