Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22309#discussion_r226148892
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala 
---
    @@ -376,6 +386,23 @@ object ScalaReflection extends ScalaReflection {
               dataType = ObjectType(udt.getClass))
             Invoke(obj, "deserialize", ObjectType(udt.userClass), getPath :: 
Nil)
     
    +      case t if isValueClass(t) =>
    +        // nested value class is treated as its underlying type
    +        // top level value class must be treated as a product
    --- End diff --
    
    This is not true, top level value class can be a single primitive type 
column


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to