Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22309#discussion_r226149168 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala --- @@ -632,13 +667,17 @@ object ScalaReflection extends ScalaReflection { "cannot be used as field name\n" + walkedTypePath.mkString("\n")) } + // as a field, value class is represented by its underlying type + val trueFieldType = + if (isValueClass(fieldType)) getUnderlyingTypeOf(fieldType) else fieldType --- End diff -- shall we update `dataTypeFor` to handle value class, instead of special handling it here?
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org