Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22749#discussion_r226294017
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoder.scala
---
@@ -43,10 +44,11 @@ import org.apache.spark.util.Utils
* to the name `value`.
*/
object ExpressionEncoder {
+
def apply[T : TypeTag](): ExpressionEncoder[T] = {
- // We convert the not-serializable TypeTag into StructType and
ClassTag.
val mirror = ScalaReflection.mirror
- val tpe = typeTag[T].in(mirror).tpe
+ val tpe = ScalaReflection.localTypeOf[T]
--- End diff --
why change it from `typeTag[T].in(mirror).tpe`?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
