Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22749#discussion_r226296369
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoder.scala
 ---
    @@ -103,75 +88,61 @@ object ExpressionEncoder {
        * name/positional binding is preserved.
        */
       def tuple(encoders: Seq[ExpressionEncoder[_]]): ExpressionEncoder[_] = {
    --- End diff --
    
    cool, this method is simplified a lot with the new abstraction.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to