Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22309#discussion_r228730753
  
    --- Diff: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/ScalaReflectionSuite.scala
 ---
    @@ -358,4 +368,20 @@ class ScalaReflectionSuite extends SparkFunSuite {
         assert(numberOfCheckedArguments(deserializerFor[(java.lang.Double, 
Int)]) == 1)
         assert(numberOfCheckedArguments(deserializerFor[(java.lang.Integer, 
java.lang.Integer)]) == 0)
       }
    +
    +  test("schema for case class that is a value class") {
    +    val schema = schemaFor[TestingValueClass.IntWrapper]
    +    assert(schema === Schema(IntegerType, nullable = false))
    +  }
    +
    +  test("schema for case class that contains value class fields") {
    +    val schema = schemaFor[TestingValueClass.ValueClassData]
    +    assert(schema === Schema(
    +      StructType(Seq(
    +        StructField("intField", IntegerType, nullable = false),
    +        StructField("wrappedInt", IntegerType, nullable = false),
    --- End diff --
    
    to confirm, scala value class for primitive type can't be null?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to