Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22309#discussion_r228731209
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoderSuite.scala
---
@@ -297,11 +307,16 @@ class ExpressionEncoderSuite extends
CodegenInterpretedPlanTest with AnalysisTes
ExpressionEncoder.tuple(intEnc, ExpressionEncoder.tuple(intEnc,
longEnc))
}
+ // test for Scala value class
encodeDecodeTest(
PrimitiveValueClass(42), "primitive value class")
-
encodeDecodeTest(
ReferenceValueClass(ReferenceValueClass.Container(1)), "reference
value class")
+ encodeDecodeTest(StringWrapper("a"), "value class string")
+ encodeDecodeTest(ValueContainer(1, StringWrapper("b")), "value class
nested")
+ encodeDecodeTest(
--- End diff --
can we also test with null values?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
