Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22938#discussion_r235583315
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
 ---
    @@ -1905,7 +1911,7 @@ class JsonSuite extends QueryTest with 
SharedSQLContext with TestJsonData {
               F.count($"dummy").as("valid"),
               F.count($"_corrupt_record").as("corrupt"),
               F.count("*").as("count"))
    -      checkAnswer(counts, Row(1, 4, 6))
    +      checkAnswer(counts, Row(1, 5, 7)) // null row for empty file
    --- End diff --
    
    Wait, does this mean that it reads an empty record from empty file after 
this change?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to