Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22938#discussion_r235584943
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
 ---
    @@ -1892,7 +1898,7 @@ class JsonSuite extends QueryTest with 
SharedSQLContext with TestJsonData {
             .text(path)
     
           val jsonDF = spark.read.option("multiLine", true).option("mode", 
"PERMISSIVE").json(path)
    -      assert(jsonDF.count() === corruptRecordCount)
    +      assert(jsonDF.count() === corruptRecordCount + 1) // null row for 
empty file
    --- End diff --
    
    shall we skip empty files for all the file-based data sources?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to