Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/23031#discussion_r237074727
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/RuntimeConfig.scala
---
@@ -154,5 +154,9 @@ class RuntimeConfig private[sql](sqlConf: SQLConf = new
SQLConf) {
if (SQLConf.staticConfKeys.contains(key)) {
throw new AnalysisException(s"Cannot modify the value of a static
config: $key")
}
+ if (sqlConf.setCommandRejectsSparkConfs &&
+ ConfigEntry.findEntry(key) != null &&
!SQLConf.sqlConfEntries.containsKey(key)) {
--- End diff --
we should only reject configs that are registered as SparkConf. Thinking
about configs that are either a SparkConf or SQLConf, we shouldn't reject it.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
