Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/23031#discussion_r237075170
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/RuntimeConfigSuite.scala ---
    @@ -68,4 +68,13 @@ class RuntimeConfigSuite extends SparkFunSuite {
         assert(!conf.isModifiable(""))
         assert(!conf.isModifiable("invalid config parameter"))
       }
    +
    +  test("reject SparkConf entries") {
    +    val conf = newConf()
    +
    +    val ex = intercept[AnalysisException] {
    +      conf.set("spark.task.cpus", 4)
    --- End diff --
    
    can we use `config.CPUS_PER_TASK` instead of hardcoding it?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to