Github user rdblue commented on a diff in the pull request:

    https://github.com/apache/spark/pull/23086#discussion_r237179854
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2ScanExec.scala
 ---
    @@ -54,27 +53,17 @@ case class DataSourceV2ScanExec(
         Seq(output, source, options).hashCode()
       }
     
    -  override def outputPartitioning: physical.Partitioning = readSupport 
match {
    +  override def outputPartitioning: physical.Partitioning = scan match {
    --- End diff --
    
    If you take my suggesting above to inspect the `Scan` to build the string 
representation of this node, then I think the arguments should be `scan` and 
`output`. Then the batch can be fetched here.
    
    For pushedFilters, I think that they should be fetched from the configured 
scan to build the string representation.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to