Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/23086#discussion_r237103452
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2ScanExec.scala
 ---
    @@ -54,27 +53,17 @@ case class DataSourceV2ScanExec(
         Seq(output, source, options).hashCode()
       }
     
    -  override def outputPartitioning: physical.Partitioning = readSupport 
match {
    +  override def outputPartitioning: physical.Partitioning = scan match {
    --- End diff --
    
    filter pushdown happens at the planning phase, so the physical plan is the 
only place users can know which filters are pushed. Shall we keep 
`pushedFilters` in the scan node?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to