Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/23204#discussion_r238257777
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/TungstenAggregationIterator.scala
---
@@ -374,22 +374,6 @@ class TungstenAggregationIterator(
}
}
- TaskContext.get().addTaskCompletionListener[Unit](_ => {
--- End diff --
ditto, it's better to put this code block here, let's keep this change.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
