Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/23204#discussion_r238264122
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/metric/SQLMetrics.scala
---
@@ -57,12 +57,6 @@ class SQLMetric(val metricType: String, initValue: Long
= 0L) extends Accumulato
override def add(v: Long): Unit = _value += v
- // We can set a double value to `SQLMetric` which stores only long
value, if it is
--- End diff --
I think we can keep the changes in this file as well.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
