Probably better to use labels, since we see issues change from blocker to not and then back again, so having different templates would be cumbersome.
I agree! In general the predefined structure of templates is not guaranteed to be preserved through the live of an issue / PR as we are used to with the Trac ticket box. Everyone with write access can destroy it. Surely this will demand a higher level of discipline among developers. A broader question is, which parts of the trac interface do we want to keep, and which parts can we dispense with? Also, where is the right place to have this discussion? I don’t know. Maybe a Trac ticket, since this must be clarified before we migrate? John H Palmieri schrieb am Montag, 17. Oktober 2022 um 20:59:37 UTC+2: > I like the idea of mimicking the trac setup, but moving away from trac > also lets us reconsider parts of the trac interface. I personally do not > find the "Priority" label very helpful, other than whether it's a blocker > or not. What do others think? We could just ask people to label "Blocker" > if necessary, or I suppose have one template for a blocker, one template > for everything else. (Probably better to use labels, since we see issues > change from blocker to not and then back again, so having different > templates would be cumbersome.) > > A broader question is, which parts of the trac interface do we want to > keep, and which parts can we dispense with? Also, where is the right place > to have this discussion? > > On Monday, October 17, 2022 at 10:50:45 AM UTC-7 seb....@gmail.com wrote: > >> I think there are two steps to be taken. The first step is to define a >> suitable template to collect all the important information in the header of >> issues and PRs that we are used to from the Trac ticket box. >> >> In terms of dependencies between PRs, this will map what we are used to. >> The second step according to discussion 4477 >> <https://github.com/orgs/community/discussions/4477> will go beyond >> that. So this has a lower priority. But it will be nice to have! >> >> As for the first step, I would suggest having templates that mimic the >> Trac ticket box for example: >> >> $ cat .github/ISSUE_TEMPLATE/trac_ticket_like_issue.md >> --- >> name: Issue according to Trac ticket >> about: This template provides a similar structure to a Trac ticket >> title: "[Short Description] " >> labels: 'p:major' >> milestone: 'sage-9.8' >> assignees: '' >> >> --- >> >> # Checklist for creating a Trac ticket-like issue >> >> - [ ] I have read >> [README.md](https://github.com/sagemath/sage/blob/develop/README.md) >> - [ ] I have read [the Troubleshooting section in the Installation >> Guide](https://doc.sagemath.org/html/en/installation/troubles.html) >> - [ ] I have checked that this will not be a duplicate >> - [ ] I have chosen a label from the <details><summary>Type >> list</summary><ul><li>t:bug</li><li>t:enhancement</li><li>t:task</li></ul></details> >> - [ ] I have chosen a label from the <details><summary>Priority >> list</summary><ul><li>p:blocker</li><li>p:critical</li><li>p:major</li><li>p:minor</li><li>p:trivial</li></ul></details> >> - [ ] I have chosen a label from the <details><summary>Component >> list</summary><ul><li>c:algebra</li><li>c:algebraic >> geometry</li><li>c:...</li></ul></details> >> >> # Information that used to be in the Trac ticket box >> >> ||________________________________________________||________________________________________________| >> |-|-|-|-| >> |Authors||Reviewers|| >> |Keywords||Report upstream|| >> |Dependencies||Stopgaps|| >> >> # Description of the issue >> >> This would also help with the change of habits. But it seems that this >> cannot be done only through appropriate templates. As far as I’ve seen, >> there’s no way to have radio buttons or select lists with GitHub markdown, >> even with plain HTML. Therefore, we would also need to implement >> corresponding GitHub actions (see also my comment on issue 8 >> <https://github.com/sagemath/trac-to-github/issues/8> in the trac-to-github >> repo <https://github.com/sagemath/trac-to-github/>). These would be >> needed to synchronize between corresponding Trac and GitHub features, too. >> >> If there is interest to have such a template I can volunteer to produce a >> first draft (but maybe this will take a while since I have only short >> time-slots and I’m inexperienced with these GitHub tools). >> >> Matthias Koeppe schrieb am Montag, 10. Oktober 2022 um 20:42:28 UTC+2: >> >>> As discussed previously, Issue and PR templates on GitHub can provide a >>> replacement for the Trac ticket box. See >>> https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository >>> >>> <https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository> >>> >>> https://github.com/sagemath/sage-gh-templates-sandbox is open for >>> trying out possible designs for these templates. A first draft of one >>> template: >>> https://github.com/sagemath/sage-gh-templates-sandbox/issues/new/choose >>> <https://github.com/sagemath/sage-gh-templates-sandbox/issues/new/choose> >>> >>> >>> Related: Help is needed with choosing a good replacement for our Trac >>> ticket dependencies. As suggested in >>> https://github.com/sagemath/publications/pull/142#issuecomment-1259001501 >>> <https://github.com/sagemath/publications/pull/142#issuecomment-1259001501> >>> and >>> https://groups.google.com/g/sage-devel/c/hX6ojxlNwOU/m/dup_Ywu1BQAJ >>> <https://groups.google.com/g/sage-devel/c/hX6ojxlNwOU/m/dup_Ywu1BQAJ>, >>> we should add to the transition guide >>> <https://github.com/sagemath/sage/wiki/migration-from-trac-to-Git**b#proposed-workflow-on-github-with-transition-guide-from-trac> >>> how >>> to model Trac's ticket dependencies in GitHub PRs. See >>> https://github.com/orgs/community/discussions/4477 >>> <https://github.com/orgs/community/discussions/4477> for solutions. >>> >>> >>> This is part of https://trac.sagemath.org/ticket/30363 >>> >> -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/305677be-ffdc-4815-a88f-75ac486ec630n%40googlegroups.com.
