I think it's okay to not make things mandatory. For labels, I propose a simple approach first: "Blocker" or not, "Bug" or not. (Currently, the "Task" type isn't used much, so the major distinction is between "Defect" and "Enhancement". Changing to "Bug" or not captures this.) I like the current "Component" setup, and I don't know how to replicate that well with user-generated labels: we're going to get typos and variations: "AG" or "AlgebraicGeometry" or "algebraic-geometry" or ... But it's worth trying.
On Monday, October 17, 2022 at 11:40:27 PM UTC-7 seb....@gmail.com wrote: > There are two essential disadvantages of the issue form: > > 1. It is not available for PR. > 2. The given structure is completely flattened after the issue has been > created. In particular, the entries of the dropdown menus of the issue > header are not visible (i.e. dropdown boxes are flattened to the selected > entry) . > > An advantage is that the issue is not created until all checkboxes are > set. So this can be used to make things mandatory. This doesn't seem to be > possible with the template. > > > tobias...@gmail.com schrieb am Montag, 17. Oktober 2022 um 21:07:12 UTC+2: > >> You can have advanced more advanced controls like checkboxes or >> dropdownboxes in issue forms, see >> https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/syntax-for-githubs-form-schema#dropdown. >> >> Some of this is used in >> https://github.com/sagemath/sage-gh-templates-sandbox/pull/1. >> >> On Monday, 17 October 2022 at 19:50:45 UTC+2 seb....@gmail.com wrote: >> >>> I think there are two steps to be taken. The first step is to define a >>> suitable template to collect all the important information in the header of >>> issues and PRs that we are used to from the Trac ticket box. >>> >>> In terms of dependencies between PRs, this will map what we are used to. >>> The second step according to discussion 4477 >>> <https://github.com/orgs/community/discussions/4477> will go beyond >>> that. So this has a lower priority. But it will be nice to have! >>> >>> As for the first step, I would suggest having templates that mimic the >>> Trac ticket box for example: >>> >>> $ cat .github/ISSUE_TEMPLATE/trac_ticket_like_issue.md >>> --- >>> name: Issue according to Trac ticket >>> about: This template provides a similar structure to a Trac ticket >>> title: "[Short Description] " >>> labels: 'p:major' >>> milestone: 'sage-9.8' >>> assignees: '' >>> >>> --- >>> >>> # Checklist for creating a Trac ticket-like issue >>> >>> - [ ] I have read >>> [README.md](https://github.com/sagemath/sage/blob/develop/README.md) >>> - [ ] I have read [the Troubleshooting section in the Installation >>> Guide](https://doc.sagemath.org/html/en/installation/troubles.html) >>> - [ ] I have checked that this will not be a duplicate >>> - [ ] I have chosen a label from the <details><summary>Type >>> list</summary><ul><li>t:bug</li><li>t:enhancement</li><li>t:task</li></ul></details> >>> - [ ] I have chosen a label from the <details><summary>Priority >>> list</summary><ul><li>p:blocker</li><li>p:critical</li><li>p:major</li><li>p:minor</li><li>p:trivial</li></ul></details> >>> - [ ] I have chosen a label from the <details><summary>Component >>> list</summary><ul><li>c:algebra</li><li>c:algebraic >>> geometry</li><li>c:...</li></ul></details> >>> >>> # Information that used to be in the Trac ticket box >>> >>> ||________________________________________________||________________________________________________| >>> |-|-|-|-| >>> |Authors||Reviewers|| >>> |Keywords||Report upstream|| >>> |Dependencies||Stopgaps|| >>> >>> # Description of the issue >>> >>> This would also help with the change of habits. But it seems that this >>> cannot be done only through appropriate templates. As far as I’ve seen, >>> there’s no way to have radio buttons or select lists with GitHub markdown, >>> even with plain HTML. Therefore, we would also need to implement >>> corresponding GitHub actions (see also my comment on issue 8 >>> <https://github.com/sagemath/trac-to-github/issues/8> in the trac-to-github >>> repo <https://github.com/sagemath/trac-to-github/>). These would be >>> needed to synchronize between corresponding Trac and GitHub features, too. >>> >>> If there is interest to have such a template I can volunteer to produce >>> a first draft (but maybe this will take a while since I have only short >>> time-slots and I’m inexperienced with these GitHub tools). >>> >>> Matthias Koeppe schrieb am Montag, 10. Oktober 2022 um 20:42:28 UTC+2: >>> >>>> As discussed previously, Issue and PR templates on GitHub can provide a >>>> replacement for the Trac ticket box. See >>>> https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository >>>> >>>> <https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository> >>>> >>>> https://github.com/sagemath/sage-gh-templates-sandbox is open for >>>> trying out possible designs for these templates. A first draft of one >>>> template: >>>> https://github.com/sagemath/sage-gh-templates-sandbox/issues/new/choose >>>> <https://github.com/sagemath/sage-gh-templates-sandbox/issues/new/choose> >>>> >>>> >>>> Related: Help is needed with choosing a good replacement for our Trac >>>> ticket dependencies. As suggested in >>>> https://github.com/sagemath/publications/pull/142#issuecomment-1259001501 >>>> <https://github.com/sagemath/publications/pull/142#issuecomment-1259001501> >>>> and >>>> https://groups.google.com/g/sage-devel/c/hX6ojxlNwOU/m/dup_Ywu1BQAJ >>>> <https://groups.google.com/g/sage-devel/c/hX6ojxlNwOU/m/dup_Ywu1BQAJ>, >>>> we should add to the transition guide >>>> <https://github.com/sagemath/sage/wiki/migration-from-trac-to-Git**b#proposed-workflow-on-github-with-transition-guide-from-trac> >>>> how >>>> to model Trac's ticket dependencies in GitHub PRs. See >>>> https://github.com/orgs/community/discussions/4477 >>>> <https://github.com/orgs/community/discussions/4477> for solutions. >>>> >>>> >>>> This is part of https://trac.sagemath.org/ticket/30363 >>>> >>> -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/6db05872-4ab9-42d7-98b6-3cf0c9e0ce5bn%40googlegroups.com.
