As an aside, the univariate LaurentPolynomialRing had a notion of `valuation` but the multivariate one didn't...
In the PR: https://github.com/sagemath/sage/pull/37490 I added random elements but also a notion of valuation() for the multivariate case and just made it act similarly to the univariate one. On Friday, March 1, 2024 at 6:18:01 PM UTC Nils Bruin wrote: > On Friday 1 March 2024 at 09:49:15 UTC-8 Giacomo Pope wrote: > > Following this discussion, I have made a draft PR to change the degree for > *only* the LaurentPolynomialRing and I will see if the CI detects anything. > > https://github.com/sagemath/sage/pull/37513 > > I agree that if we change the LaurentPolynomialRing we should also change > the `LaurentSeriesRing`, at the moment `LazyLaurentSeriesRing` has no > method `degree()` but *does* have a `valuation()` method... so this is odd. > > > OK, let's keep it that way then! I don't think there is a notion on > LaurentSeriesRing that deserves the name "degree". Sorry about mixing that > one in. I thought it existed. And I think it does: > > sage: R.<x>=LaurentSeriesRing(QQ) > sage: z=R(0) > sage: z.valuation() > +Infinity > sage: z.degree() > -1 > > but if it's not documented, perhaps we can just ignore it. > -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/a1a59d64-4f6a-46da-9ee4-5a414d612918n%40googlegroups.com.
