Hi,
I have checked in a change to scanimage in master and it should be in 1.2.1.

@karl, perhaps pull the change and make sure it is good for you?

Cheers,
Ralph


On 2023-02-04 11:47, m. allan noah wrote:
I'm ok with breaking code freeze if you want

On Sat, Feb 4, 2023, 2:41 PM Ralph Little <skelb...@gmail.com> wrote:

    Hi,

    On 2023-02-04 10:38, Karl Weber wrote:
    > Hi Ralf,
    >
    > On Saturday, 4 February 2023 18:06:41 CET Ralph Little wrote:
    >> The condition on SANE_OPTION_IS_SETTABLE(opt->cap) has been
    removed in
    >> version
    >>> 1.1.1 and this causes the problem.
    >> I'm a bit confused by this comment. I thought that your issue
    was caused
    >> by the backend sending NULL.
    >> Which problem do you believe this causes? Or are you saying
    that the
    >> NULL options issue is revealed by this change? That is
    certainly possible.
    > Yes, you may also say that the NULL options issue has been
    revealed by this
    > change. I didn't know, why this check has been removed and I
    don't know why it
    > had been there beforehand. I am really new to sane! I started to
    look at the
    > code two days ago. Before I was only an ignorant user of
    scanimage. So please
    > excuse me.
    >
    > But irrespective of the wording, are you going to do something
    about it? Or
    > where would be the right place to fix this problem? Currently I
    have no idea,
    > whether hplip-sane is open source and what the chances would be,
    to get a fix
    > in there, if this would be the right place for a fix. I don't
    even know,
    > whether it is part of the SANE API specification, that there
    must not be NULL
    > options.
    I suspect that the hpaio backend is doing something improper.
    However,
    we must deal with it somehow.
    I will do a fix.

    Cheers,
    Ralph

Reply via email to