https://github.com/zyn0217 closed
https://github.com/llvm/llvm-project/pull/90195
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/90195
>From f708694fc2686684589dca7b8f3738a117fc047e Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Fri, 26 Apr 2024 19:06:57 +0800
Subject: [PATCH 1/6] [Sema] Avoid an undesired pack expansion while
transforming
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 3ea9ed471c8dca8f703d7f3ce93d274a718b54bb
7a087f06240ce09a64fe679df14380e2fa538701 --
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/90195
>From f708694fc2686684589dca7b8f3738a117fc047e Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Fri, 26 Apr 2024 19:06:57 +0800
Subject: [PATCH 1/5] [Sema] Avoid an undesired pack expansion while
transforming
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/90195
>From f708694fc2686684589dca7b8f3738a117fc047e Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Fri, 26 Apr 2024 19:06:57 +0800
Subject: [PATCH 1/4] [Sema] Avoid an undesired pack expansion while
transforming
https://github.com/cor3ntin edited
https://github.com/llvm/llvm-project/pull/90195
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -216,8 +216,14 @@ static Cl::Kinds ClassifyInternal(ASTContext , const
Expr *E) {
return ClassifyInternal(Ctx,
cast(E)->getReplacement());
- case Expr::PackIndexingExprClass:
+ case Expr::PackIndexingExprClass: {
+// A dependent
https://github.com/cor3ntin approved this pull request.
LGTM, thanks!
https://github.com/llvm/llvm-project/pull/90195
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zyn0217 wrote:
@cor3ntin Mind looking at it again? Thanks so much!
https://github.com/llvm/llvm-project/pull/90195
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 edited
https://github.com/llvm/llvm-project/pull/90195
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/90195
>From f708694fc2686684589dca7b8f3738a117fc047e Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Fri, 26 Apr 2024 19:06:57 +0800
Subject: [PATCH 1/3] [Sema] Avoid an undesired pack expansion while
transforming
@@ -160,3 +160,22 @@ namespace GH88929 {
using E = P...[0]; // expected-error {{unknown type name 'P'}} \
// expected-error {{expected ';' after alias
declaration}}
}
+
+namespace GH88925 {
+template struct S {};
+
+template struct sequence {};
+
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/90195
>From f708694fc2686684589dca7b8f3738a117fc047e Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Fri, 26 Apr 2024 19:06:57 +0800
Subject: [PATCH 1/3] [Sema] Avoid an undesired pack expansion while
transforming
@@ -160,3 +160,22 @@ namespace GH88929 {
using E = P...[0]; // expected-error {{unknown type name 'P'}} \
// expected-error {{expected ';' after alias
declaration}}
}
+
+namespace GH88925 {
+template struct S {};
+
+template struct sequence {};
+
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/90195
>From f708694fc2686684589dca7b8f3738a117fc047e Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Fri, 26 Apr 2024 19:06:57 +0800
Subject: [PATCH 1/2] [Sema] Avoid an undesired pack expansion while
transforming
@@ -160,3 +160,22 @@ namespace GH88929 {
using E = P...[0]; // expected-error {{unknown type name 'P'}} \
// expected-error {{expected ';' after alias
declaration}}
}
+
+namespace GH88925 {
+template struct S {};
+
+template struct sequence {};
+
@@ -160,3 +160,22 @@ namespace GH88929 {
using E = P...[0]; // expected-error {{unknown type name 'P'}} \
// expected-error {{expected ';' after alias
declaration}}
}
+
+namespace GH88925 {
+template struct S {};
+
+template struct sequence {};
+
https://github.com/cor3ntin commented:
Thanks for working on that!
I suspect there is the same problem for pack indexing expressions, could you
try to add a test?
Thanks!
https://github.com/llvm/llvm-project/pull/90195
___
cfe-commits mailing list
@@ -160,3 +160,22 @@ namespace GH88929 {
using E = P...[0]; // expected-error {{unknown type name 'P'}} \
// expected-error {{expected ';' after alias
declaration}}
}
+
+namespace GH88925 {
+template struct S {};
+
+template struct sequence {};
+
https://github.com/cor3ntin edited
https://github.com/llvm/llvm-project/pull/90195
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -6649,6 +6649,9 @@
TreeTransform::TransformPackIndexingType(TypeLocBuilder ,
}
}
+ // We may be doing this in the context of expanding the Pattern. Forget that
+ // because it has been handled above.
+ Sema::ArgumentPackSubstitutionIndexRAII SubstIndex(getSema(),
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Younan Zhang (zyn0217)
Changes
Fixes https://github.com/llvm/llvm-project/issues/88925
---
Full diff: https://github.com/llvm/llvm-project/pull/90195.diff
2 Files Affected:
- (modified) clang/lib/Sema/TreeTransform.h (+3)
- (modified)
https://github.com/zyn0217 created
https://github.com/llvm/llvm-project/pull/90195
Fixes https://github.com/llvm/llvm-project/issues/88925
>From f708694fc2686684589dca7b8f3738a117fc047e Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Fri, 26 Apr 2024 19:06:57 +0800
Subject: [PATCH] [Sema]
23 matches
Mail list logo