Re: RFR: 8226990: GTK & Nimbus LAF: Tabbed pane's background color is not expected one when change the opaque checkbox. [v12]
On Thu, 2 May 2024 07:02:01 GMT, Prasanta Sadhukhan wrote: >> Abhishek Kumar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Nimbus property name update > > Marked as reviewed by psadhukhan (Reviewer). > @prsadhuk Updated the test instruction as per review comments and update > jtreg to execute the test only for windows and linux. > > Tested in mac machine where the issue is not resolved even the wrap tab > layout also didn't work in Aqua LAF. > > Would like to raise a separate bug to address Aqua issue. Created a new bug to handle contentOpaque and tabsOpaque properties for Aqua LAF [JDK-8331619](https://bugs.openjdk.org/browse/JDK-8331619). For wrap Layout issue in Aqua there exists a bug [JDK-8144124](https://bugs.openjdk.org/browse/JDK-8144124). @prsadhuk Please re-review this PR, there are few changes after you reviewed last. - PR Comment: https://git.openjdk.org/jdk/pull/17720#issuecomment-2092327902 PR Comment: https://git.openjdk.org/jdk/pull/17720#issuecomment-2092330137
Re: RFR: 8226990: GTK & Nimbus LAF: Tabbed pane's background color is not expected one when change the opaque checkbox. [v14]
On Fri, 3 May 2024 05:10:15 GMT, Abhishek Kumar wrote: >> JTabbedPane's content area, tab area and tab background color are not as >> expected when opaque is set to true or false. >> The proposed fix is to handle the TabbedPane's background color in installed >> LAFs. Manual test is added to support the fix and there is no regression >> caused by the fix. >> >> Proposed fix is tested in Ubuntu 22.04 and Oracle linux. >> >> CI link is posted in JBS. > > Abhishek Kumar has updated the pull request incrementally with one additional > commit since the last revision: > > Review comment update LGTM. - Marked as reviewed by tr (Committer). PR Review: https://git.openjdk.org/jdk/pull/17720#pullrequestreview-2037407816
Re: RFR: 8233177: Remove testcase for JDK-8001470 as fix has been reverted [v3]
On Sat, 13 Apr 2024 18:22:07 GMT, Phil Race wrote: > Where are we with this ? Is there a consensus yet ? I guess I have added my explanations in the PR as to why the test should be removed...You can take a call and provide your decision. We have several unresolved bugs in JDK and most, if not all, have reproducible testcase. We dont add those testcase in the repo and problemlist it till the issue is resolved, right? Similarly, I think this testcase should be removed till we have the fix ready and a new JBS can be created with this removed testcase as reproducible test.. - PR Comment: https://git.openjdk.org/jdk/pull/17528#issuecomment-2092266578
Integrated: 8329559: Test javax/swing/JFrame/bug4419914.java failed because The End and Start buttons are not placed correctly and Tab focus does not move as expected
On Thu, 4 Apr 2024 05:34:18 GMT, Prasanta Sadhukhan wrote: > Test issue shows the End and Start buttons are not placed as per instructions > due to ComponentOrientation RTL was not honoured, as with `getContentPane()` > being removed from `add` call of JFrame, it was also additionally removed > from other JFrame calls which resulted in the RTL not being propagated to its > child. Fix is to add `getContentPane()` to the non-add methods of JFrame as > was done in the applet version of the test.. This pull request has now been integrated. Changeset: 7c1fad4f Author:Prasanta Sadhukhan URL: https://git.openjdk.org/jdk/commit/7c1fad4fb6c387bbfb72b3f96b610e7cbc2ef312 Stats: 8 lines in 1 file changed: 2 ins; 1 del; 5 mod 8329559: Test javax/swing/JFrame/bug4419914.java failed because The End and Start buttons are not placed correctly and Tab focus does not move as expected Reviewed-by: abhiscxk, honkar, dnguyen - PR: https://git.openjdk.org/jdk/pull/18612
Re: RFR: 8226990: GTK & Nimbus LAF: Tabbed pane's background color is not expected one when change the opaque checkbox. [v13]
On Fri, 3 May 2024 04:38:07 GMT, Tejesh R wrote: >> Abhishek Kumar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> unselected tab background property added > > test/jdk/javax/swing/JTabbedPane/TestJTabbedPaneOpaqueColor.java line 56: > >> 54: private static JTabbedPane tabPane; >> 55: private static final String INSTRUCTIONS = """ >> 56: The background color of panel (which contains the tabbed >> pane is green). > > Can you reframe this sentence because it doesn't mention about the color, > except you have mentioned in braces. Updated. > test/jdk/javax/swing/JTabbedPane/TestJTabbedPaneOpaqueColor.java line 125: > >> 123: tabPane.setTabLayoutPolicy(JTabbedPane.SCROLL_TAB_LAYOUT); >> 124: tabPane.setTabPlacement(JTabbedPane.TOP); >> 125: PassFailJFrame.addTestWindow(frame); > > Is it required to add `frame` explicitly to PassFailJFrame here? Looks redundant to me, removed. - PR Review Comment: https://git.openjdk.org/jdk/pull/17720#discussion_r1588717738 PR Review Comment: https://git.openjdk.org/jdk/pull/17720#discussion_r1588717479
Re: RFR: 8226990: GTK & Nimbus LAF: Tabbed pane's background color is not expected one when change the opaque checkbox. [v14]
> JTabbedPane's content area, tab area and tab background color are not as > expected when opaque is set to true or false. > The proposed fix is to handle the TabbedPane's background color in installed > LAFs. Manual test is added to support the fix and there is no regression > caused by the fix. > > Proposed fix is tested in Ubuntu 22.04 and Oracle linux. > > CI link is posted in JBS. Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision: Review comment update - Changes: - all: https://git.openjdk.org/jdk/pull/17720/files - new: https://git.openjdk.org/jdk/pull/17720/files/54f2fde4..e4cc9de1 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=17720=13 - incr: https://webrevs.openjdk.org/?repo=jdk=17720=12-13 Stats: 3 lines in 2 files changed: 0 ins; 1 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/17720.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/17720/head:pull/17720 PR: https://git.openjdk.org/jdk/pull/17720
Re: RFR: 8226990: GTK & Nimbus LAF: Tabbed pane's background color is not expected one when change the opaque checkbox. [v13]
On Fri, 3 May 2024 03:31:22 GMT, Abhishek Kumar wrote:
>> JTabbedPane's content area, tab area and tab background color are not as
>> expected when opaque is set to true or false.
>> The proposed fix is to handle the TabbedPane's background color in installed
>> LAFs. Manual test is added to support the fix and there is no regression
>> caused by the fix.
>>
>> Proposed fix is tested in Ubuntu 22.04 and Oracle linux.
>>
>> CI link is posted in JBS.
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> unselected tab background property added
src/java.desktop/share/classes/javax/swing/plaf/synth/SynthTabbedPaneUI.java
line 653:
> 651:
> 652: if (isSelected) {
> 653: g.setColor( selectColor );
Suggestion:
g.setColor(selectColor);
test/jdk/javax/swing/JTabbedPane/TestJTabbedPaneOpaqueColor.java line 56:
> 54: private static JTabbedPane tabPane;
> 55: private static final String INSTRUCTIONS = """
> 56: The background color of panel (which contains the tabbed pane
> is green).
Can you reframe this sentence because it doesn't mention about the color,
except you have mentioned in braces.
test/jdk/javax/swing/JTabbedPane/TestJTabbedPaneOpaqueColor.java line 125:
> 123: tabPane.setTabLayoutPolicy(JTabbedPane.SCROLL_TAB_LAYOUT);
> 124: tabPane.setTabPlacement(JTabbedPane.TOP);
> 125: PassFailJFrame.addTestWindow(frame);
Is it required to add `frame` explicitly to PassFailJFrame here?
-
PR Review Comment: https://git.openjdk.org/jdk/pull/17720#discussion_r1588652353
PR Review Comment: https://git.openjdk.org/jdk/pull/17720#discussion_r1588659139
PR Review Comment: https://git.openjdk.org/jdk/pull/17720#discussion_r1588657505
Re: RFR: 8226990: GTK & Nimbus LAF: Tabbed pane's background color is not expected one when change the opaque checkbox. [v13]
> JTabbedPane's content area, tab area and tab background color are not as > expected when opaque is set to true or false. > The proposed fix is to handle the TabbedPane's background color in installed > LAFs. Manual test is added to support the fix and there is no regression > caused by the fix. > > Proposed fix is tested in Ubuntu 22.04 and Oracle linux. > > CI link is posted in JBS. Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision: unselected tab background property added - Changes: - all: https://git.openjdk.org/jdk/pull/17720/files - new: https://git.openjdk.org/jdk/pull/17720/files/eaee5651..54f2fde4 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=17720=12 - incr: https://webrevs.openjdk.org/?repo=jdk=17720=11-12 Stats: 3 lines in 2 files changed: 3 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/17720.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/17720/head:pull/17720 PR: https://git.openjdk.org/jdk/pull/17720
Re: RFR: 8226990: GTK & Nimbus LAF: Tabbed pane's background color is not expected one when change the opaque checkbox. [v12]
On Thu, 2 May 2024 15:07:30 GMT, Tejesh R wrote: >> `unselectedBackground` color is used to render the unselected tabs. What >> else you want me to check? > > I don't see the rendering code in `installDefaults()`, can you recheck that. `unselectedBackground` was not defined in GTKLookAndFeel class. Although the default graphics color for unselected tab was white but added the required property to make code consistent across LAFs. - PR Review Comment: https://git.openjdk.org/jdk/pull/17720#discussion_r1588630301
Re: RFR: 8331591: sun.font.CharSequenceCodePointIterator is buggy and unused [v2]
On Thu, 2 May 2024 21:53:34 GMT, Andy Goryachev wrote: >> Phil Race has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8331591 > > src/java.desktop/share/classes/sun/font/CodePointIterator.java line 65: > >> 63: } >> 64: >> 65: > > looks like a couple of unnecessary newlines were added inadvertently I had already noticed that and removed them - PR Review Comment: https://git.openjdk.org/jdk/pull/19072#discussion_r1588479413
Re: RFR: 8331591: sun.font.CharSequenceCodePointIterator is buggy and unused [v2]
On Thu, 2 May 2024 22:01:03 GMT, Phil Race wrote: >> Delete an internal class that has been around for 20 years but never been >> used. >> Verified that is true at least as far back as JDK7 >> All platforms build. Tests pass. > > Phil Race has updated the pull request incrementally with one additional > commit since the last revision: > > 8331591 Cleanup looks good. No other usages of CharSequenceCodePointIterator except in this file. Build works fine too. Minor: Copyright year needs to be updated. Marked as reviewed by honkar (Reviewer). - Marked as reviewed by honkar (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/19072#pullrequestreview-2037038423 PR Review: https://git.openjdk.org/jdk/pull/19072#pullrequestreview-2037040102
Re: RFR: 8331591: sun.font.CharSequenceCodePointIterator is buggy and unused [v2]
On Thu, 2 May 2024 21:58:21 GMT, Phil Race wrote: >> Delete an internal class that has been around for 20 years but never been >> used. >> Verified that is true at least as far back as JDK7 >> All platforms build. Tests pass. > > Phil Race has updated the pull request incrementally with one additional > commit since the last revision: > > 8331591 looks good! src/java.desktop/share/classes/sun/font/CodePointIterator.java line 65: > 63: } > 64: > 65: looks like a couple of unnecessary newlines were added inadvertently - Marked as reviewed by angorya (no project role). PR Review: https://git.openjdk.org/jdk/pull/19072#pullrequestreview-2037021342 PR Review Comment: https://git.openjdk.org/jdk/pull/19072#discussion_r1588462202
Re: RFR: 8331591: sun.font.CharSequenceCodePointIterator is buggy and unused [v2]
> Delete an internal class that has been around for 20 years but never been > used. > Verified that is true at least as far back as JDK7 > All platforms build. Tests pass. Phil Race has updated the pull request incrementally with one additional commit since the last revision: 8331591 - Changes: - all: https://git.openjdk.org/jdk/pull/19072/files - new: https://git.openjdk.org/jdk/pull/19072/files/f22d16f2..1ec19bd7 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=19072=01 - incr: https://webrevs.openjdk.org/?repo=jdk=19072=00-01 Stats: 2 lines in 1 file changed: 0 ins; 2 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/19072.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19072/head:pull/19072 PR: https://git.openjdk.org/jdk/pull/19072
RFR: 8331591: sun.font.CharSequenceCodePointIterator is buggy and unused
Delete an internal class that has been around for 20 years but never been used. Verified that is true at least as far back as JDK7 All platforms build. Tests pass. - Commit messages: - 8331591 Changes: https://git.openjdk.org/jdk/pull/19072/files Webrev: https://webrevs.openjdk.org/?repo=jdk=19072=00 Issue: https://bugs.openjdk.org/browse/JDK-8331591 Stats: 57 lines in 1 file changed: 2 ins; 55 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/19072.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19072/head:pull/19072 PR: https://git.openjdk.org/jdk/pull/19072
Integrated: 8280988: [XWayland] Click on title to request focus test failures
On Mon, 29 Apr 2024 10:44:37 GMT, Alexander Zvegintsev wrote: > Some tests try to get the focus of a window by clicking on its title bar. > > On XWayland, however, emulating mouse clicks with XTEST currently only > affects the XWayland server, not the window decorations, so trying to click > on the window title will have no effect. > > So the solution is to click inside the window or call `toFront()` to get the > window focused. > > Some tests have issues with AWT/Swing calls not being on EDT, it is not the > goal of this change to fix them as they require way too many code changes, > and make this PR hard to review. This pull request has now been integrated. Changeset: f6cdcc6f Author:Alexander Zvegintsev URL: https://git.openjdk.org/jdk/commit/f6cdcc6f65f2a436906541bb8266e69ded17e2e3 Stats: 259 lines in 5 files changed: 134 ins; 43 del; 82 mod 8280988: [XWayland] Click on title to request focus test failures Reviewed-by: honkar, serb - PR: https://git.openjdk.org/jdk/pull/18995
Integrated: 8331516: Tests should not use the "Classpath" exception form of the legal header
On Thu, 2 May 2024 18:45:54 GMT, Phil Race wrote: > Change GPL+CP -> GPL as required for all tests. This pull request has now been integrated. Changeset: 99654ec3 Author:Phil Race URL: https://git.openjdk.org/jdk/commit/99654ec3fb2c2e7c8d5bf5965aaf45aeb4b88c61 Stats: 4 lines in 1 file changed: 0 ins; 2 del; 2 mod 8331516: Tests should not use the "Classpath" exception form of the legal header Reviewed-by: iris, serb - PR: https://git.openjdk.org/jdk/pull/19068
Re: RFR: 8280988: [XWayland] Click on title to request focus test failures [v3]
On Thu, 2 May 2024 13:01:12 GMT, Alexander Zvegintsev wrote: >> Some tests try to get the focus of a window by clicking on its title bar. >> >> On XWayland, however, emulating mouse clicks with XTEST currently only >> affects the XWayland server, not the window decorations, so trying to click >> on the window title will have no effect. >> >> So the solution is to click inside the window or call `toFront()` to get the >> window focused. >> >> Some tests have issues with AWT/Swing calls not being on EDT, it is not the >> goal of this change to fix them as they require way too many code changes, >> and make this PR hard to review. > > Alexander Zvegintsev has updated the pull request incrementally with one > additional commit since the last revision: > > toFront + clickOnTitle(only for non wayland environment) Marked as reviewed by serb (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/18995#pullrequestreview-2036785634
Re: RFR: 8331516: Tests should not use the "Classpath" exception form of the legal header
On Thu, 2 May 2024 18:45:54 GMT, Phil Race wrote: > Change GPL+CP -> GPL as required for all tests. Marked as reviewed by serb (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/19068#pullrequestreview-2036784210
Re: RFR: 8331516: Tests should not use the "Classpath" exception form of the legal header
On Thu, 2 May 2024 18:45:54 GMT, Phil Race wrote: > Change GPL+CP -> GPL as required for all tests. Confirmed updated license matches the GPL template: https://github.com/openjdk/jdk/blob/master/make/data/license-templates/gpl-header - Marked as reviewed by iris (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/19068#pullrequestreview-2036665370
Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v7]
On Thu, 2 May 2024 18:30:23 GMT, Alexander Scherbatiy wrote: >> The fix adds new public `OutputBin` print attribute class which allow to set >> a printer output bin in a `PrinterJob` class. The corresponding internal >> `CustomOutputBin` class is added as well. >> >> - Constants used in `OutputBin` class are based on [Internet Printing >> Protocol (IPP): “output-bin” attribute >> extension](https://ftp.pwg.org/pub/pwg/candidates/cs-ippoutputbin10-20010207-5100.2.pdf) >> document. >> - `CUPSPrinter.getOutputBins(String printer)` method uses PPD >> `ppdFindOption(..., "OutputBin")` function to get supported output bins for >> the given printer on native level. >> - The fix propagates the `OutputBin` attribute from the printer job >> attributes to `NSPrintInfo` print settings with `OutputBin` key on macOS. >> >> The fix was tested on `Kyocera ECOSYS M8130cidn` printer where >> `ppdFindOption(..., "OutputBin")` call returns 4 output bins (text, choice): >> - Printer settings, None >> - Inner tray, INNERTRAY >> - Separator tray, SEPARATORTRAY >> - Finisher (face-down), Main >> >> if `Printer settings`, `Inner tray`, or `Finisher (face-down)` >> CustomOutputBins is set to `PrinterJob.print(...)` attributes a test page is >> printed to the Main tray of the `Kyocera ECOSYS M8130cidn` printer. If >> `Separator tray` is used a page is printed to the Separator tray. This is >> consistent with the printer behavior when a native print dialog is used from >> a native Preview app to print a document on macOS. > > Alexander Scherbatiy has updated the pull request incrementally with one > additional commit since the last revision: > > Change 'Page Setup' to 'Appearance' tab in the > OutputBinAttributePrintDialogTest I have created the CSR https://bugs.openjdk.org/browse/JDK-8331601 and assigned it to you to fill in. Once you've done that I can review it. - PR Comment: https://git.openjdk.org/jdk/pull/16166#issuecomment-2091293223
Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v7]
On Thu, 2 May 2024 18:30:23 GMT, Alexander Scherbatiy wrote: >> The fix adds new public `OutputBin` print attribute class which allow to set >> a printer output bin in a `PrinterJob` class. The corresponding internal >> `CustomOutputBin` class is added as well. >> >> - Constants used in `OutputBin` class are based on [Internet Printing >> Protocol (IPP): “output-bin” attribute >> extension](https://ftp.pwg.org/pub/pwg/candidates/cs-ippoutputbin10-20010207-5100.2.pdf) >> document. >> - `CUPSPrinter.getOutputBins(String printer)` method uses PPD >> `ppdFindOption(..., "OutputBin")` function to get supported output bins for >> the given printer on native level. >> - The fix propagates the `OutputBin` attribute from the printer job >> attributes to `NSPrintInfo` print settings with `OutputBin` key on macOS. >> >> The fix was tested on `Kyocera ECOSYS M8130cidn` printer where >> `ppdFindOption(..., "OutputBin")` call returns 4 output bins (text, choice): >> - Printer settings, None >> - Inner tray, INNERTRAY >> - Separator tray, SEPARATORTRAY >> - Finisher (face-down), Main >> >> if `Printer settings`, `Inner tray`, or `Finisher (face-down)` >> CustomOutputBins is set to `PrinterJob.print(...)` attributes a test page is >> printed to the Main tray of the `Kyocera ECOSYS M8130cidn` printer. If >> `Separator tray` is used a page is printed to the Separator tray. This is >> consistent with the printer behavior when a native print dialog is used from >> a native Preview app to print a document on macOS. > > Alexander Scherbatiy has updated the pull request incrementally with one > additional commit since the last revision: > > Change 'Page Setup' to 'Appearance' tab in the > OutputBinAttributePrintDialogTest This is getting close enough that it is time to start on the CSR, since I think the API part is settled now. /Reviewers 2 - PR Comment: https://git.openjdk.org/jdk/pull/16166#issuecomment-2091286085 PR Comment: https://git.openjdk.org/jdk/pull/16166#issuecomment-2091286506
RFR: 8331516: Tests should not use the "Classpath" exception form of the legal header
Change GPL+CP -> GPL as required for all tests. - Commit messages: - 8331516 Changes: https://git.openjdk.org/jdk/pull/19068/files Webrev: https://webrevs.openjdk.org/?repo=jdk=19068=00 Issue: https://bugs.openjdk.org/browse/JDK-8331516 Stats: 4 lines in 1 file changed: 0 ins; 2 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/19068.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19068/head:pull/19068 PR: https://git.openjdk.org/jdk/pull/19068
Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v7]
> The fix adds new public `OutputBin` print attribute class which allow to set > a printer output bin in a `PrinterJob` class. The corresponding internal > `CustomOutputBin` class is added as well. > > - Constants used in `OutputBin` class are based on [Internet Printing > Protocol (IPP): “output-bin” attribute > extension](https://ftp.pwg.org/pub/pwg/candidates/cs-ippoutputbin10-20010207-5100.2.pdf) > document. > - `CUPSPrinter.getOutputBins(String printer)` method uses PPD > `ppdFindOption(..., "OutputBin")` function to get supported output bins for > the given printer on native level. > - The fix propagates the `OutputBin` attribute from the printer job > attributes to `NSPrintInfo` print settings with `OutputBin` key on macOS. > > The fix was tested on `Kyocera ECOSYS M8130cidn` printer where > `ppdFindOption(..., "OutputBin")` call returns 4 output bins (text, choice): > - Printer settings, None > - Inner tray, INNERTRAY > - Separator tray, SEPARATORTRAY > - Finisher (face-down), Main > > if `Printer settings`, `Inner tray`, or `Finisher (face-down)` > CustomOutputBins is set to `PrinterJob.print(...)` attributes a test page is > printed to the Main tray of the `Kyocera ECOSYS M8130cidn` printer. If > `Separator tray` is used a page is printed to the Separator tray. This is > consistent with the printer behavior when a native print dialog is used from > a native Preview app to print a document on macOS. Alexander Scherbatiy has updated the pull request incrementally with one additional commit since the last revision: Change 'Page Setup' to 'Appearance' tab in the OutputBinAttributePrintDialogTest - Changes: - all: https://git.openjdk.org/jdk/pull/16166/files - new: https://git.openjdk.org/jdk/pull/16166/files/84f09802..7a0c6579 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=16166=06 - incr: https://webrevs.openjdk.org/?repo=jdk=16166=05-06 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/16166.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/16166/head:pull/16166 PR: https://git.openjdk.org/jdk/pull/16166
Integrated: JDK-8329692 : Add more details to FrameStateTest.java test instructions
On Mon, 29 Apr 2024 23:24:19 GMT, Harshitha Onkar wrote: > For the following manual test, more instructions are added as to what to > expect for "hide,iconify and show" vs "hide,iconify,show and restore" for > clarity. This pull request has now been integrated. Changeset: 6f98d8f5 Author:Harshitha Onkar URL: https://git.openjdk.org/jdk/commit/6f98d8f58f98827ae454c7ce4839de4071d95767 Stats: 50 lines in 1 file changed: 7 ins; 13 del; 30 mod 8329692: Add more details to FrameStateTest.java test instructions Reviewed-by: tr, azvegint - PR: https://git.openjdk.org/jdk/pull/19008
Integrated: 8328999: Update GIFlib to 5.2.2
On Fri, 26 Apr 2024 21:37:56 GMT, Alisen Chung wrote: > Updating giflib, clientlibs tests are green on all platforms This pull request has now been integrated. Changeset: 6969a9e0 Author:Alisen Chung URL: https://git.openjdk.org/jdk/commit/6969a9e0b2143eee5a7cfa02460a8ab6dfa08cda Stats: 846 lines in 8 files changed: 179 ins; 105 del; 562 mod 8328999: Update GIFlib to 5.2.2 Reviewed-by: tr, dnguyen, prr - PR: https://git.openjdk.org/jdk/pull/18985
Re: RFR: JDK-8329692 : Add more details to FrameStateTest.java test instructions [v7]
> For the following manual test, more instructions are added as to what to > expect for "hide,iconify and show" vs "hide,iconify,show and restore" for > clarity. Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision: row count change - Changes: - all: https://git.openjdk.org/jdk/pull/19008/files - new: https://git.openjdk.org/jdk/pull/19008/files/88f5d048..20ff464b Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=19008=06 - incr: https://webrevs.openjdk.org/?repo=jdk=19008=05-06 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/19008.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19008/head:pull/19008 PR: https://git.openjdk.org/jdk/pull/19008
Re: RFR: 8226990: GTK & Nimbus LAF: Tabbed pane's background color is not expected one when change the opaque checkbox. [v12]
On Thu, 2 May 2024 14:46:24 GMT, Abhishek Kumar wrote: >> src/java.desktop/share/classes/javax/swing/plaf/synth/SynthTabbedPaneUI.java >> line 128: >> >>> 126: private Color selectColor; >>> 127: // Background color for unselected tabs >>> 128: private Color unselectedBackground; >> >> Can u recheck `unselectedBackground` purpose once again? > > `unselectedBackground` color is used to render the unselected tabs. What else > you want me to check? I don't see the rendering code in `installDefaults()`, can you recheck that. - PR Review Comment: https://git.openjdk.org/jdk/pull/17720#discussion_r1587808509
Re: RFR: 8226990: GTK & Nimbus LAF: Tabbed pane's background color is not expected one when change the opaque checkbox. [v12]
On Thu, 2 May 2024 09:39:26 GMT, Tejesh R wrote: >> Abhishek Kumar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Nimbus property name update > > src/java.desktop/share/classes/javax/swing/plaf/synth/SynthTabbedPaneUI.java > line 128: > >> 126: private Color selectColor; >> 127: // Background color for unselected tabs >> 128: private Color unselectedBackground; > > Can u recheck `unselectedBackground` purpose once again? `unselectedBackground` color is used to render the unselected tabs. What else you want me to check? - PR Review Comment: https://git.openjdk.org/jdk/pull/17720#discussion_r1587771448
Re: RFR: JDK-8329692 : Add more details to FrameStateTest.java test instructions [v6]
On Tue, 30 Apr 2024 20:38:06 GMT, Harshitha Onkar wrote: >> For the following manual test, more instructions are added as to what to >> expect for "hide,iconify and show" vs "hide,iconify,show and restore" for >> clarity. > > Harshitha Onkar has updated the pull request incrementally with one > additional commit since the last revision: > > minor Marked as reviewed by azvegint (Reviewer). test/jdk/java/awt/Frame/FrameStateTest/FrameStateTest.java line 117: > 115: .instructions(INSTRUCTIONS) > 116: .testTimeOut(10) > 117: .rows(26) Suggestion: .rows(27) It doesn't fit on Linux without scrolling:  (the test is problem listed on Linux, but we can fix it now to avoid coming back to it later) - PR Review: https://git.openjdk.org/jdk/pull/19008#pullrequestreview-2035689784 PR Review Comment: https://git.openjdk.org/jdk/pull/19008#discussion_r1587602609
Re: RFR: 8280988: [XWayland] Click on title to request focus test failures [v3]
> Some tests try to get the focus of a window by clicking on its title bar. > > On XWayland, however, emulating mouse clicks with XTEST currently only > affects the XWayland server, not the window decorations, so trying to click > on the window title will have no effect. > > So the solution is to click inside the window or call `toFront()` to get the > window focused. > > Some tests have issues with AWT/Swing calls not being on EDT, it is not the > goal of this change to fix them as they require way too many code changes, > and make this PR hard to review. Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision: toFront + clickOnTitle(only for non wayland environment) - Changes: - all: https://git.openjdk.org/jdk/pull/18995/files - new: https://git.openjdk.org/jdk/pull/18995/files/ef4d7716..35bdff25 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=18995=02 - incr: https://webrevs.openjdk.org/?repo=jdk=18995=01-02 Stats: 25 lines in 3 files changed: 9 ins; 1 del; 15 mod Patch: https://git.openjdk.org/jdk/pull/18995.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/18995/head:pull/18995 PR: https://git.openjdk.org/jdk/pull/18995
Re: RFR: 8280988: [XWayland] Click on title to request focus test failures [v2]
On Wed, 1 May 2024 22:44:41 GMT, Sergey Bylokhov wrote: >> Do we really need an additional click on the title in this case? >> Just `toFront` should be enough on all platforms. > > `toFront()` is known to be broken on some versions of metacity/gnome, not > sure it was fixed or not, that was a reason why the "click" workaround was > introduced. If it works fine on Wayland we can just use it and leave the old > x11 workaround as is. Update to `"toFront + click on title" on X11 and just "toFront" on Wayland` > not sure it was fixed or not Looks like so, I also tested just `toFront()` without the `clickonTitle()`, it passes on all platforms(mac, win, X11, XWayland). But I kept the `clickOnTitle` just in case. - PR Review Comment: https://git.openjdk.org/jdk/pull/18995#discussion_r1587594046
Integrated: 8331011: [XWayland] TokenStorage fails under Security Manager
On Thu, 25 Apr 2024 11:52:35 GMT, Alexander Zvegintsev wrote: > This fix adds missing doPrivileged calls in TokenStorage, which is used to > help take screenshots in Wayland. This pull request has now been integrated. Changeset: 9912abf5 Author:Alexander Zvegintsev URL: https://git.openjdk.org/jdk/commit/9912abf586f4e0f76591639ae18d5c074edaa2c5 Stats: 46 lines in 1 file changed: 26 ins; 0 del; 20 mod 8331011: [XWayland] TokenStorage fails under Security Manager Reviewed-by: prr, honkar, serb - PR: https://git.openjdk.org/jdk/pull/18950
Re: RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on the Microsoft Visual C compiler [v70]
On Wed, 3 Apr 2024 02:38:21 GMT, Julian Waters wrote: >> Bumping > >> @TheShermanTanker I tried to help you get this done. I added fixes to a copy >> of your branch on my personal fork, but then it turned out I could not push >> them to your branch. :-( >> >> It ended up with me creating a new PR, #18584. As a bonus, I think it might >> be easier to review with a fresh start. This PR has grown quite heavy with >> lots of comments and commits. >> >> I hope you don't feel like I'm stealing this away from you. You have done a >> great job, and shown a lot of patience of carrying this all the way here. >> But I also got the impression that you would appreciate my assistance in >> getting the last pieces in place so we can integrate this. > > Not at all, I don't feel like you're stealing this from me. In fact, I should > be the one apologising for giving you extra work! Thanks for taking this up, > I once again apologise for making you do this instead, I've been very busy > since Thursday (working on OpenJDK while in lectures at times), and during my > breaks I've been too drained to continue, so i really appreciate your help :) > > I will keep this open until the other Pull Request has been integrated, in > case this might still be needed @TheShermanTanker You can close this PR. The bug was fixed with https://github.com/openjdk/jdk/pull/18584 instead. - PR Comment: https://git.openjdk.org/jdk/pull/15096#issuecomment-2090226777
Re: RFR: 8226990: GTK & Nimbus LAF: Tabbed pane's background color is not expected one when change the opaque checkbox. [v12]
On Thu, 2 May 2024 06:40:20 GMT, Abhishek Kumar wrote: >> JTabbedPane's content area, tab area and tab background color are not as >> expected when opaque is set to true or false. >> The proposed fix is to handle the TabbedPane's background color in installed >> LAFs. Manual test is added to support the fix and there is no regression >> caused by the fix. >> >> Proposed fix is tested in Ubuntu 22.04 and Oracle linux. >> >> CI link is posted in JBS. > > Abhishek Kumar has updated the pull request incrementally with one additional > commit since the last revision: > > Nimbus property name update src/java.desktop/share/classes/javax/swing/plaf/synth/SynthTabbedPaneUI.java line 128: > 126: private Color selectColor; > 127: // Background color for unselected tabs > 128: private Color unselectedBackground; Can u recheck `unselectedBackground` purpose once again? - PR Review Comment: https://git.openjdk.org/jdk/pull/17720#discussion_r1587348466
Re: RFR: 8327696: [TESTBUG] "javax/swing/JTable/KeyBoardNavigation/KeyBoardNavigation.java" test instruction needs to be corrected [v3]
> Instructions set has been updated as per OS specific. JTable keyboard > navigation is tested in each OS and according it's current implementation the > instructions has been updated (Few has been removed and few has been > updated). > PassFailJFrame.builder is used. Tejesh R has updated the pull request incrementally with one additional commit since the last revision: Review fix + Eanbled column selection mode - Changes: - all: https://git.openjdk.org/jdk/pull/18855/files - new: https://git.openjdk.org/jdk/pull/18855/files/17a87679..71f1156f Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=18855=02 - incr: https://webrevs.openjdk.org/?repo=jdk=18855=01-02 Stats: 40 lines in 1 file changed: 1 ins; 0 del; 39 mod Patch: https://git.openjdk.org/jdk/pull/18855.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/18855/head:pull/18855 PR: https://git.openjdk.org/jdk/pull/18855
Re: RFR: 8327696: [TESTBUG] "javax/swing/JTable/KeyBoardNavigation/KeyBoardNavigation.java" test instruction needs to be corrected [v2]
On Tue, 23 Apr 2024 07:51:59 GMT, Tejesh R wrote: >> Instructions set has been updated as per OS specific. JTable keyboard >> navigation is tested in each OS and according it's current implementation >> the instructions has been updated (Few has been removed and few has been >> updated). >> PassFailJFrame.builder is used. > > Tejesh R has updated the pull request incrementally with one additional > commit since the last revision: > > Review updates @DamonGuy @alisenchung any other feedback from your end? - PR Comment: https://git.openjdk.org/jdk/pull/18855#issuecomment-2090016612
Re: RFR: 8327696: [TESTBUG] "javax/swing/JTable/KeyBoardNavigation/KeyBoardNavigation.java" test instruction needs to be corrected [v2]
On Thu, 25 Apr 2024 10:21:57 GMT, Abhishek Kumar wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review updates > > Default time out may not be sufficient to test, can be increased. @kumarabhi006 I've updated the test with column selection too for testing purpose. > test/jdk/javax/swing/JTable/KeyBoardNavigation.java line 198: > >> 196: final String WINDOWS_SPECIFIC = """ >> 197: Tab, Shift-Tab - Navigate In. >> 198: Return/Shift-Return - move focus one cell down/up. > > Suggestion: > > Return/Shift-Return - Move focus one cell down/up. > > For consistency please ensure each command action to start with either lower > case or upper case. Same for F2, Esc commands etc. > > Check for Linux and Mac specific instructions also. Yes, I've updated all instructions to start with Upper Case. > test/jdk/javax/swing/JTable/KeyBoardNavigation.java line 217: > >> 215: F2 - Allows editing in a cell containing information >> without >> 216: overwriting the information >> 217: Esc - Resets the cell content back to the state it was >> in > > Suggestion: > > Esc - Reset the cell content back to the state it was in. > > > Minor suggestion, end with `.` for each statement else nothing. None of the statements are ending with `.`, I'll leave it that way. - PR Comment: https://git.openjdk.org/jdk/pull/18855#issuecomment-2090014751 PR Review Comment: https://git.openjdk.org/jdk/pull/18855#discussion_r1587337563 PR Review Comment: https://git.openjdk.org/jdk/pull/18855#discussion_r1587338476
Re: RFR: 8226990: GTK & Nimbus LAF: Tabbed pane's background color is not expected one when change the opaque checkbox. [v11]
On Thu, 2 May 2024 07:01:34 GMT, Prasanta Sadhukhan wrote: >> There are properties without nimbus prepended as well... e.g. >> textInactiveText, activeCaption etc. >> Anyways Updated with the suggested name. > > ok..In that case, this property should have been put after those and not in > between nimbus prepended properties... > It's upto you to keep this or revert and move to appropriate location.. Ok to keep this. - PR Review Comment: https://git.openjdk.org/jdk/pull/17720#discussion_r1587184664
Re: RFR: 8226990: GTK & Nimbus LAF: Tabbed pane's background color is not expected one when change the opaque checkbox. [v11]
On Thu, 2 May 2024 06:34:52 GMT, Abhishek Kumar wrote: >> src/java.desktop/share/classes/javax/swing/plaf/nimbus/skin.laf line 86: >> >>> 84: >> hueOffset="0.0" saturationOffset="0.0" brightnessOffset="0.0" >>> alphaOffset="0"/> >>> 85: >>> 86: >> >> One more thing >> All the above properties are prepended with nimbus except this so I guess it >> needs to be "nimbusTabbedPaneContentArea" > > There are properties without nimbus prepended as well... e.g. > textInactiveText, activeCaption etc. > Anyways Updated with the suggested name. ok..In that case, this property should have been put after those and not in between nimbus prepended properties... It's upto you to keep this or revert and move to appropriate location.. - PR Review Comment: https://git.openjdk.org/jdk/pull/17720#discussion_r1587158233
Re: RFR: 8226990: GTK & Nimbus LAF: Tabbed pane's background color is not expected one when change the opaque checkbox. [v12]
On Thu, 2 May 2024 06:40:20 GMT, Abhishek Kumar wrote: >> JTabbedPane's content area, tab area and tab background color are not as >> expected when opaque is set to true or false. >> The proposed fix is to handle the TabbedPane's background color in installed >> LAFs. Manual test is added to support the fix and there is no regression >> caused by the fix. >> >> Proposed fix is tested in Ubuntu 22.04 and Oracle linux. >> >> CI link is posted in JBS. > > Abhishek Kumar has updated the pull request incrementally with one additional > commit since the last revision: > > Nimbus property name update Marked as reviewed by psadhukhan (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/17720#pullrequestreview-2034976670
Re: RFR: 8226990: GTK & Nimbus LAF: Tabbed pane's background color is not expected one when change the opaque checkbox. [v11]
On Thu, 2 May 2024 06:20:28 GMT, Prasanta Sadhukhan wrote: >> Abhishek Kumar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Instruction and jtreg tag update > > src/java.desktop/share/classes/javax/swing/plaf/nimbus/skin.laf line 86: > >> 84: > hueOffset="0.0" saturationOffset="0.0" brightnessOffset="0.0" >> alphaOffset="0"/> >> 85: >> 86: > > One more thing > All the above properties are prepended with nimbus except this so I guess it > needs to be "nimbusTabbedPaneContentArea" There are properties without nimbus prepended as well... e.g. textInactiveText, activeCaption etc. Anyways Updated with the suggested name. - PR Review Comment: https://git.openjdk.org/jdk/pull/17720#discussion_r1587132220
Re: RFR: 8226990: GTK & Nimbus LAF: Tabbed pane's background color is not expected one when change the opaque checkbox. [v11]
On Thu, 2 May 2024 06:05:08 GMT, Abhishek Kumar wrote: >> JTabbedPane's content area, tab area and tab background color are not as >> expected when opaque is set to true or false. >> The proposed fix is to handle the TabbedPane's background color in installed >> LAFs. Manual test is added to support the fix and there is no regression >> caused by the fix. >> >> Proposed fix is tested in Ubuntu 22.04 and Oracle linux. >> >> CI link is posted in JBS. > > Abhishek Kumar has updated the pull request incrementally with one additional > commit since the last revision: > > Instruction and jtreg tag update [JDK-6462396](https://bugs.openjdk.org/browse/JDK-6462396) linked to [JDK-8226990](https://bugs.openjdk.org/browse/JDK-8226990) - PR Comment: https://git.openjdk.org/jdk/pull/17720#issuecomment-2089721636
Re: RFR: 8226990: GTK & Nimbus LAF: Tabbed pane's background color is not expected one when change the opaque checkbox. [v12]
> JTabbedPane's content area, tab area and tab background color are not as > expected when opaque is set to true or false. > The proposed fix is to handle the TabbedPane's background color in installed > LAFs. Manual test is added to support the fix and there is no regression > caused by the fix. > > Proposed fix is tested in Ubuntu 22.04 and Oracle linux. > > CI link is posted in JBS. Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision: Nimbus property name update - Changes: - all: https://git.openjdk.org/jdk/pull/17720/files - new: https://git.openjdk.org/jdk/pull/17720/files/611294ad..eaee5651 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=17720=11 - incr: https://webrevs.openjdk.org/?repo=jdk=17720=10-11 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/17720.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/17720/head:pull/17720 PR: https://git.openjdk.org/jdk/pull/17720
Re: RFR: 8226990: GTK & Nimbus LAF: Tabbed pane's background color is not expected one when change the opaque checkbox. [v11]
On Thu, 2 May 2024 06:05:08 GMT, Abhishek Kumar wrote: >> JTabbedPane's content area, tab area and tab background color are not as >> expected when opaque is set to true or false. >> The proposed fix is to handle the TabbedPane's background color in installed >> LAFs. Manual test is added to support the fix and there is no regression >> caused by the fix. >> >> Proposed fix is tested in Ubuntu 22.04 and Oracle linux. >> >> CI link is posted in JBS. > > Abhishek Kumar has updated the pull request incrementally with one additional > commit since the last revision: > > Instruction and jtreg tag update src/java.desktop/share/classes/javax/swing/plaf/nimbus/skin.laf line 86: > 84: hueOffset="0.0" saturationOffset="0.0" brightnessOffset="0.0" > alphaOffset="0"/> > 85: > 86: One more thing All the above properties are prepended with nimbus except this so I guess it needs to be "nimbusTabbedPaneContentArea" - PR Review Comment: https://git.openjdk.org/jdk/pull/17720#discussion_r1587117063
Re: RFR: 8226990: GTK & Nimbus LAF: Tabbed pane's background color is not expected one when change the opaque checkbox. [v11]
On Thu, 2 May 2024 06:05:08 GMT, Abhishek Kumar wrote: >> JTabbedPane's content area, tab area and tab background color are not as >> expected when opaque is set to true or false. >> The proposed fix is to handle the TabbedPane's background color in installed >> LAFs. Manual test is added to support the fix and there is no regression >> caused by the fix. >> >> Proposed fix is tested in Ubuntu 22.04 and Oracle linux. >> >> CI link is posted in JBS. > > Abhishek Kumar has updated the pull request incrementally with one additional > commit since the last revision: > > Instruction and jtreg tag update @prsadhuk Updated the test instruction as per review comments and update jtreg to execute the test only for windows and linux. Tested in mac machine where the issue is not resolved even the wrap tab layout also didn't work in Aqua LAF. Would like to raise a separate bug to address Aqua issue. - PR Comment: https://git.openjdk.org/jdk/pull/17720#issuecomment-2089654087
Re: RFR: 8226990: GTK & Nimbus LAF: Tabbed pane's background color is not expected one when change the opaque checkbox. [v11]
> JTabbedPane's content area, tab area and tab background color are not as > expected when opaque is set to true or false. > The proposed fix is to handle the TabbedPane's background color in installed > LAFs. Manual test is added to support the fix and there is no regression > caused by the fix. > > Proposed fix is tested in Ubuntu 22.04 and Oracle linux. > > CI link is posted in JBS. Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision: Instruction and jtreg tag update - Changes: - all: https://git.openjdk.org/jdk/pull/17720/files - new: https://git.openjdk.org/jdk/pull/17720/files/0973b9a4..611294ad Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=17720=10 - incr: https://webrevs.openjdk.org/?repo=jdk=17720=09-10 Stats: 12 lines in 1 file changed: 5 ins; 2 del; 5 mod Patch: https://git.openjdk.org/jdk/pull/17720.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/17720/head:pull/17720 PR: https://git.openjdk.org/jdk/pull/17720
