Bug#634738: remove wontfix tag
Control: tags -1 - wontfix Rainer Herrmann's python3.patch _did_ fix the original issue, the wontfix tag therefore no longer makes sense.
Bug#634738: [patch] issue no longer exists, remove reference to dead server
Control: tags -1 patch The issue described by this ticket no longer exists since ardentryst 1.71-7. Gonéri Le Bouder reported "ardentryst.py:24: DeprecationWarning: the sha/md5 module is deprecated; use hashlib instead", triggered by this line: import smtplib, email, math, sha, md5 Reiner Herrmann's Python 3 port (python3.patch) fixed the issue by replacing the offending line: import smtplib, email, math from hashlib import md5, sha1 There was also discussion how changing the code would affect uploading scores to the online score board, but the server has been offline since 2013 (as per game's author, Jordan Trudgett), so this is no longer of any interest, either. I attached a patch removing all menu options dealing with the long-dead online score board. For details see the text at the start of the patch. Then I'd suggest closing this ticket. Regards, Jens PS: I hope putting a Control command, text and patch attachment all in 1 email doesn't cause any issues. offline.patch.gz Description: application/gzip
Bug#1005849: [patch] fix 10 deprecation warnings
Attached the promised patch. deprecationfix.patch.gz Description: application/gzip
Bug#717885: [patch] fix issues with some in-game messages
Control: tags -1 patch Attached a patch finally (after 8+ years) fixing the shop message and, while I was at it, another minor issue with Nyx's tutorial messages. For details see text at top of patch. Regards, Jens messagefix.patch.gz Description: application/gzip
Bug#1005849: ardentryst: 10 deprecation messages at various points
Package: ardentryst Version: 1.71-8 Severity: normal Tags: patch I encountered a total of 10 deprecation messages at various points in the game. These are all of the same type (implicit floar->int conversion), all essentially harmless, but they might look alarming to an unsuspecting player. And the sheer number of these warnings makes the game look unprofessional. I'd have said Severity 'minor', but I upped it to 'normal', because there are so many of them. Present at least in 1.71-8 and -9. Haven't checked if they were introduced with Python 3 in 1.71-7 or if they were there even earlier. I made a patch fixing all of them, they're all fairly trivial. I'll attach it as soon as I got the ticket number (to reference it in the patch's description). Full list of warnings follows (line numbers are for 1.71-9): On Resume Quest screen if >14 saves present: /usr/share/games/ardentryst/ardentryst.py:1367: DeprecationWarning: an integer is required (got type float). Implicit conversion to integers using __int__ is deprecated, and may be removed in a future version of Python. gsr.midleft = (70, 100 + x * 25 - scroll_factor * 25) /usr/share/games/ardentryst/ardentryst.py:1373: DeprecationWarning: an integer is required (got type float). Implicit conversion to integers using __int__ is deprecated, and may be removed in a future version of Python. crect.midleft = (65, 100 + cursor * 25 - scroll_factor * 25) /usr/share/games/ardentryst/ardentryst.py:1378: DeprecationWarning: an integer is required (got type float). Implicit conversion to integers using __int__ is deprecated, and may be removed in a future version of Python. arrowrect.center = (130, 450 + math.sin(tick/10.0)*5) /usr/share/games/ardentryst/ardentryst.py:1384: DeprecationWarning: an integer is required (got type float). Implicit conversion to integers using __int__ is deprecated, and may be removed in a future version of Python. handr.midright = (int(60+abs(math.sin(tick/10.0))*10.0), 100 + cursor * 25 - scroll_factor * 25) At Eternal Boulder (save location): /usr/share/games/ardentryst/ardentryst.py:2339: DeprecationWarning: an integer is required (got type float). Implicit conversion to integers using __int__ is deprecated, and may be removed in a future version of Python. m_r.midleft = (320-Fonts[16].size(msg)[0]/2, 350) /usr/share/games/ardentryst/ardentryst.py:2347: DeprecationWarning: an integer is required (got type float). Implicit conversion to integers using __int__ is deprecated, and may be removed in a future version of Python. npi_r.center = (320, 400+abs(math.sin(tick/10.0)*15)) /usr/share/games/ardentryst/ardentryst.py:2383: DeprecationWarning: an integer is required (got type float). Implicit conversion to integers using __int__ is deprecated, and may be removed in a future version of Python. m_r.midleft = (320-Fonts[16].size(msg)[0]/2, 350+y) When Snodom reached on the map: /usr/share/games/ardentryst/ardentryst.py:2745: DeprecationWarning: an integer is required (got type float). Implicit conversion to integers using __int__ is deprecated, and may be removed in a future version of Python. screen.blit(Data.images["kiripan.png"][0], (290, 141 - Game.KIRI_HEIGHT*60 + math.sin(tick/30.0)*6)) /usr/share/games/ardentryst/ardentryst.py:2778: DeprecationWarning: an integer is required (got type float). Implicit conversion to integers using __int__ is deprecated, and may be removed in a future version of Python. screen.blit(Data.images["kiripan.png"][0], (290, 141 - Game.KIRI_HEIGHT*60 + math.sin(tick/30.0)*6)) When Kiripan floats down (endscene): /usr/share/games/ardentryst/ardentryst.py:2835: DeprecationWarning: an integer is required (got type float). Implicit conversion to integers using __int__ is deprecated, and may be removed in a future version of Python. screen.blit(Data.images["kiripan.png"][0], (290, 81 + Game.ENDSCENE)) Regards, Jens
Bug#733469: Can I add a "patch" tag like this?
Control: tags -1 patch
Bug#733469: Patch to fix both issues
Tags: patch I dug deeper, turns out I was wrong, the 2 crashes when renaming or deleting saves weren't related after all. Anyway, I made a patch fixing both of them. Note that it's meant to be applied _after_ my python3fix.patch for bug #1001823. savesfix.patch.gz Description: application/gzip
Bug#733469: Deleting save also exits
If you have 2 or more saves, deleting one of them (with Shift-Del in the "Resume
quest" menu) works fine. But deleting the _last_ save exits the program with two
exceptions:
Traceback (most recent call last):
File "/usr/share/games/ardentryst/ardentryst.py", line 4722, in
main()
File "/usr/share/games/ardentryst/ardentryst.py", line 4416, in main
Game = Game_SlotMenu()
File "/usr/share/games/ardentryst/ardentryst.py", line 1582, in Game_SlotMenu
gameobj = pickle.load(open(os.path.join(SAVEDIRECTORY, "Saves",
gamelist[cursor]),"rb"))
IndexError: list index out of range
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/share/games/ardentryst/ardentryst.py", line 4726, in
handleException(e)
File "/usr/share/games/ardentryst/ardentryst.py", line 685, in handleException
open("bugreport.txt", "w").write(open(os.path.join(SAVEDIRECTORY, "log.txt"),
"r").read())
PermissionError: [Errno 13] Permission denied: 'bugreport.txt'
I'm adding this info here, because I suspect the 2 issues with
renaming/deleting saves might have a common cause? (Note that both have been
present long before the Python3 port, but continue to exist afterwards.)
Bug#1001823: Ping?
Would you like me to provide additional info or reformat my patch?
Bug#718883: Both IndexErrors still occur in 1.71-8
Tested with 1.71-8: latest package still affected by _both_ IndexError instances.
Bug#718883: Another way to trigger IndexError on LEVEL.map[][], same file, different code line
A very similar bug, resulting in a crash, can be triggered by Nyx firing her crossbow. Even in the very first level, if unlucky, no additional equipment neccessary. Here it's line 5325, but in the same file and same mode of failure: I assume arrow.y becomes negative, which the code fails to check for => likewise IndexError trying to access LEVEL.map[][]. Fri Dec 17 19:25:21 2021| Playlevel called: Castle Centre Traceback (most recent call last): File "/usr/share/games/ardentryst/ardentryst.py", line 4722, in main() File "/usr/share/games/ardentryst/ardentryst.py", line 4423, in main handle_game(Game, True) File "/usr/share/games/ardentryst/ardentryst.py", line 3083, in handle_game Result = playlevel(player, level, [levelscript, npcscript], screen, Data, Fonts, soundbox, Game, File "/usr/share/games/ardentryst/play_level.py", line 2886, in playlevel PLAYER.arrow_tick() File "/usr/share/games/ardentryst/play_level.py", line 5325, in arrow_tick lm = LEVEL.map[int(arrow.x/40)][int(arrow.y/40)] IndexError: list index out of range
Bug#1001823: Re-send patch, bugtracker messed up spaces
Turns out bugtracker messes up whitespace in text/patch attachments. :( Re-attaching same patch, but gziped, hoping it's left intact now. python3fix.patch.gz Description: application/gzip
Bug#1001823: Improved patch
My fix removes the only occurrence of cmp() in magic.py, so we should drop the line importing past.builtins.cmp. Updated patch accordingly, also improved commit message. Attached patch v2, hoping bugtracker can handle attachments. Python 3 port introduced at least five severe bugs. * Customizing action keys via Options, Control prints 2 deprecation warnings and no longer works, changed keys aren't saved. Not being able to remap keys makes it hard for users of non-English keyboards. (controls.py) * Playing as Nyx and casting Ice ([D][S]) or Implosion ([D][W]) instantly crashes the game due to 3 exceptions. (magic.py) * Playing as Pyralis and using Spin-slash ([C][S]) hangs gameplay, you have to abort the current level to be able to move again. (play_level.py) Bug-Debian: https://bugs.debian.org/1001823 Signed-off-by: Jens Rottmann --- ardentryst/controls.py +++ python3fix/controls.py @@ -35,7 +35,7 @@ class SET2: def __init__(self, keycodes, x, y, set): self.set = set -self.keys = [Key(keycodes[c], x + ((8-c)%3) * 32, y + (c/3)*30, "B-" + str(((11-c)/3)*3 - (11-c)%3), set) for c in range(9)] +self.keys = [Key(keycodes[c], x + ((8-c)%3) * 32, y + (c//3)*30, "B-" + str(((11-c)//3)*3 - (11-c)%3), set) for c in range(9)] class Key: def __init__(self, keycode, x, y, binding, set): --- ardentryst/magic.py +++ python3fix/magic.py @@ -21,7 +21,6 @@ import pygame, math, random from pygame.locals import * -from past.builtins import cmp def ground_at(LEVEL, x, f=False): "Finds the y co-ordinate of the ground at position x." @@ -236,7 +235,7 @@ class Ice_1(Spell): def s_init(self): global DATA self.affected = [] -self.cant = self.caster.mp < 4 +self.cant = self.caster.mp[0] < 4 def s_blit(self, surf, ALT_X, ALT_Y): global DATA if not self.affected: @@ -441,7 +440,7 @@ class Implosion_1(Spell): def s_init(self): global DATA self.affected = [] -self.cant = self.caster.mp < 15 +self.cant = self.caster.mp[0] < 15 def s_blit(self, surf, ALT_X, ALT_Y): global DATA pic = DATA.mag_images["bubble.png"][0] @@ -472,7 +471,7 @@ class Implosion_1(Spell): if self.caster.mp[0] >= 15: self.affected.append(monster) -self.affected.sort(lambda x, y: cmp(y.maxhp, x.maxhp)) +self.affected.sort(key=lambda x: -x.maxhp) if len(self.affected): self.affected = self.affected[:1] --- ardentryst/play_level.py +++ python3fix/play_level.py @@ -4727,7 +4727,7 @@ class Character: self.mycombotime -= 1 if self.chainmove[1] and self.chainmove[1] > 0: self.chainmove[1] -= 1 -if self.chainmove[1] and self.chainmove[1] == 0: +if self.chainmove[1] == 0: cm = self.chainmove[:] self.chainmove = [None, None] getattr(self, cm[0])() --
Bug#1001823: Ardentryst near-unplayable after Python3 port
Package: ardentryst Version: 1.71-8 Severity: grave Tags: patch After Ardentryst was ported to Python 3 it appearently hasn't been play-tested well, several common actions don't work or crash the game, making it near-unplayable. Start a new game, playing as "Nyx". Enter the 1st level. Try to cast "Ice" by pressing [D], [S]. Game crashes, printing a backtrace. Ice is Nyx's starting spell, the tutorial even instructs the player to try it, so it's quite hard to get through the game without it. Especially as her higher level spell "Implosion" insta-crashes, too. For 2 more bugs, see below. Patch follows: --X8-X8 Python 3 port caused several severe bugs. * Customizing action keys via Control Options no longer works, changed keys aren't saved. Also a deprecation warning is printed. (controls.py) * Playing as Nyx and casting Ice ([D][S]) or Implosion ([D][W]) instantly crashes the game with an exception. (magic.py) * Playing as Pyralis and using Spin-slash ([C][S]) hangs gameplay, you have to abort the current level to be able to move again. (play_level.py) Signed-off-by: Jens Rottmann --- ardentryst/controls.py +++ py2-3fixes/controls.py @@ -35,7 +35,7 @@ class SET2: def __init__(self, keycodes, x, y, set): self.set = set -self.keys = [Key(keycodes[c], x + ((8-c)%3) * 32, y + (c/3)*30, "B-" + str(((11-c)/3)*3 - (11-c)%3), set) for c in range(9)] +self.keys = [Key(keycodes[c], x + ((8-c)%3) * 32, y + (c//3)*30, "B-" + str(((11-c)//3)*3 - (11-c)%3), set) for c in range(9)] class Key: def __init__(self, keycode, x, y, binding, set): --- ardentryst/magic.py +++ py2-3fixes/magic.py @@ -236,7 +236,7 @@ def s_init(self): global DATA self.affected = [] -self.cant = self.caster.mp < 4 +self.cant = self.caster.mp[0] < 4 def s_blit(self, surf, ALT_X, ALT_Y): global DATA if not self.affected: @@ -441,7 +441,7 @@ def s_init(self): global DATA self.affected = [] -self.cant = self.caster.mp < 15 +self.cant = self.caster.mp[0] < 15 def s_blit(self, surf, ALT_X, ALT_Y): global DATA pic = DATA.mag_images["bubble.png"][0] @@ -472,7 +472,7 @@ if self.caster.mp[0] >= 15: self.affected.append(monster) -self.affected.sort(lambda x, y: cmp(y.maxhp, x.maxhp)) +self.affected.sort(key=lambda x: -x.maxhp) if len(self.affected): self.affected = self.affected[:1] --- ardentryst/play_level.py +++ py2-3fixes/play_level.py @@ -4727,7 +4727,7 @@ self.mycombotime -= 1 if self.chainmove[1] and self.chainmove[1] > 0: self.chainmove[1] -= 1 -if self.chainmove[1] and self.chainmove[1] == 0: +if self.chainmove[1] == 0: cm = self.chainmove[:] self.chainmove = [None, None] getattr(self, cm[0])() --
Bug#821426: 'Show Global Variables' doesn't work
Package: nemiver
Version: 0.9.5-2
Debian 8.4 amd64, gdb 7.7.1+dfsg-5.
Compiled this with gcc -O0 -g:
int x = 5;
int main() { return x; }
In nemiver selecting "Show Global Variables" prints this error message:
|E|virtual void
nemiver::OnGlobalVariablesListedHandler::do_handle(nemiver::CommandAndOutput&):/tmp/buildd/nemiver-0.9.5/src/dbgengine/nmv-gdb-engine.cc:2299:failed
to extract global variable list
the "Global Variables" window remains empty, i.e. list header and close
button, but no variable data shown.
Maybe the GDB/MI API changed between versions i.e. between Debian's gdb
and whatever gdb the nemiver author coded against? Just guessing...
Thanks,
Jens
Bug#720599: libkmod2: modprobe -f doesn't work, fixed in kmod 12
Package: libkmod2 Version: 9-3 Severity: normal Tags: fixed-upstream In kmod before kmod 12 modprobe -f (force loading of module from a different version kernel) has no useful effect. It just changes the error message that the version info doesn't match to another error message that the version info is missing. As of writing, Debian Wheezy, Jessie and Sid all ship kmod 9, which is affected. A workaround is to downgrade to module-init-tools from Squeeze. The bug was fixed in kmod 12 upstream, please upgrade: http://article.gmane.org/gmane.linux.hotplug.devel/17644 Many thanks, Jens -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#495795: dropbear: please provide the scp binary
Seconded. Now Wheezy is frozen. :-( Could scp be added to Sid at least, please? Thanks, Jens -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
