Bug#1017026: ITP: gnome-kiosk -- mutter based compositor for kiosks
Control: tags -1 +pending On Thu, Jan 25, 2024 at 10:35 AM Mohammed Sadiq wrote: > On 2024-01-25 19:58, Jeremy Bícha wrote: > > Please add a Lintian override for this one. There was a LIntian > > override before you split the package: > > W: gnome-kiosk-search-appliance: desktop-command-not-in-package > > usr/bin/firefox > > [usr/share/applications/org.gnome.Kiosk.SearchApp.desktop] > I don't see this lintian warning. Can you check if it still shows up? Yes, it is still there. I am using lintian 2.116.3. Is it possible that you have not run git add debian/gnome-kiosk-search-appliance.lintian-overrides ? But this is minor. I pushed a minor commit and then uploaded your package to Experimental NEW now. What do you think about lowering the Recommends to Suggests? If we use Suggests, please add Enhances: gnome-kiosk to each package. Thank you very much for finishing this packaging! Jeremy Bícha
Bug#1017026: ITP: gnome-kiosk -- mutter based compositor for kiosks
On 2024-01-25 19:58, Jeremy Bícha wrote: Thank you! It can make review easier if you push new commits instead of force-pushing. Sorry. I was doing so since the repo was not used anywhere. Anyway new changes are pushed as new commits. Please forward your bin/sh patch upstream. You can then add a Forwarded: line to Debian's copy of the patch. This does not need to be done before I sponsor your upload. Shall do. Please fix the below list of LIntian errors and warnings. You can ignore other Lintian warnings here. You can get more explanation about the issue by running a command like lintian-explain-tags not-binnmuable-all-depends-any For the copyright warning, use a Comment field like https://salsa.debian.org/gnome-team/wike/-/blob/debian/latest/debian/copyright?ref_type=heads#L18-21 It is a long line so I would use two lines but indent the second line by a space like was done with the Copyright and License fields. done E: gnome-kiosk source: not-binnmuable-all-depends-any gnome-kiosk-script-session -> gnome-kiosk E: gnome-kiosk source: not-binnmuable-all-depends-any gnome-kiosk-search-appliance -> gnome-kiosk W: gnome-kiosk source: debhelper-but-no-misc-depends gnome-kiosk-script-session W: gnome-kiosk source: debhelper-but-no-misc-depends gnome-kiosk-search-appliance W: gnome-kiosk source: syntax-error-in-dep5-copyright Cannot parse line 5: Copyright info was added into README here: https://gitlab.gnome.org/GNOME/gnome-kiosk/-/commit/9cf264d [debian/copyright] Please add a Lintian override for this one. There was a LIntian override before you split the package: W: gnome-kiosk-search-appliance: desktop-command-not-in-package usr/bin/firefox [usr/share/applications/org.gnome.Kiosk.SearchApp.desktop] I don't see this lintian warning. Can you check if it still shows up? cheers, Mohammed Sadiq
Bug#1017026: ITP: gnome-kiosk -- mutter based compositor for kiosks
Thank you! It can make review easier if you push new commits instead of force-pushing. Please forward your bin/sh patch upstream. You can then add a Forwarded: line to Debian's copy of the patch. This does not need to be done before I sponsor your upload. Please fix the below list of LIntian errors and warnings. You can ignore other Lintian warnings here. You can get more explanation about the issue by running a command like lintian-explain-tags not-binnmuable-all-depends-any For the copyright warning, use a Comment field like https://salsa.debian.org/gnome-team/wike/-/blob/debian/latest/debian/copyright?ref_type=heads#L18-21 It is a long line so I would use two lines but indent the second line by a space like was done with the Copyright and License fields. E: gnome-kiosk source: not-binnmuable-all-depends-any gnome-kiosk-script-session -> gnome-kiosk E: gnome-kiosk source: not-binnmuable-all-depends-any gnome-kiosk-search-appliance -> gnome-kiosk W: gnome-kiosk source: debhelper-but-no-misc-depends gnome-kiosk-script-session W: gnome-kiosk source: debhelper-but-no-misc-depends gnome-kiosk-search-appliance W: gnome-kiosk source: syntax-error-in-dep5-copyright Cannot parse line 5: Copyright info was added into README here: https://gitlab.gnome.org/GNOME/gnome-kiosk/-/commit/9cf264d [debian/copyright] Please add a Lintian override for this one. There was a LIntian override before you split the package: W: gnome-kiosk-search-appliance: desktop-command-not-in-package usr/bin/firefox [usr/share/applications/org.gnome.Kiosk.SearchApp.desktop] Jeremy Bícha
Bug#1017026: ITP: gnome-kiosk -- mutter based compositor for kiosks
On 2024-01-25 00:44, Jeremy Bícha wrote:
control: owner -1 "Mohammed Sadiq "
control: affects -1 src:gnome-kiosk
Thank you Mohammed for working on packaging this. Here is your first
review.
Hi Jermy,
1. Please remove debian/control.in, the first few commented lines of
debian/control, and debian/control's Build-Depends: dh-sequence-gnome
The Debian GNOME team has deprecated debian/control.in and is in the
slow process of removing it across their team packages.
dh-sequence-gnome is now only needed for some packages.
done
2. This package will not build in Experimental (which is where we are
targeting it for now) because it is missing Build-Depends:
libgtk-4-dev
done
3. Please Build-Depend on dconf-cli instead of libdconf-dev.
meson.build has find_program('dconf') and dconf-cli ships
/usr/bin/dconf
done
4. I think the ftpmasters will not like that Red Hat is listed in your
debian/copyright but isn't mentioned in the source at all. There are a
few different ways to fix this. One way is to add a Comment field at
the end of the Red Hat paragraph pointing to
https://gitlab.gnome.org/GNOME/gnome-kiosk/-/commit/9cf264d
I have added a comment that links to this commit in debian/copyright
5. Let's split the package like Fedora did. You can see the file
structure for Fedora's split at
https://koji.fedoraproject.org/koji/buildinfo?buildID=2291875 . Click
info next to the rpm files for noarch (this is equivalent to Debian's
arch: all) and x86_64. Ignore the debuginfo and debugsource files.
For reference, here is Fedora's spec file:
https://src.fedoraproject.org/rpms/gnome-kiosk/blob/f39/f/gnome-kiosk.spec
done.
I have also added gnome-settings-daemon and gsettings-desktop-schemas as
dependencies - as it is in the fedora package.
And thanks for the review.
cheers,
Mohammed Sadiq
Bug#1017026: ITP: gnome-kiosk -- mutter based compositor for kiosks
control: owner -1 "Mohammed Sadiq "
control: affects -1 src:gnome-kiosk
Thank you Mohammed for working on packaging this. Here is your first review.
1. Please remove debian/control.in, the first few commented lines of
debian/control, and debian/control's Build-Depends: dh-sequence-gnome
The Debian GNOME team has deprecated debian/control.in and is in the
slow process of removing it across their team packages.
dh-sequence-gnome is now only needed for some packages.
2. This package will not build in Experimental (which is where we are
targeting it for now) because it is missing Build-Depends:
libgtk-4-dev
3. Please Build-Depend on dconf-cli instead of libdconf-dev.
meson.build has find_program('dconf') and dconf-cli ships
/usr/bin/dconf
4. I think the ftpmasters will not like that Red Hat is listed in your
debian/copyright but isn't mentioned in the source at all. There are a
few different ways to fix this. One way is to add a Comment field at
the end of the Red Hat paragraph pointing to
https://gitlab.gnome.org/GNOME/gnome-kiosk/-/commit/9cf264d
5. Let's split the package like Fedora did. You can see the file
structure for Fedora's split at
https://koji.fedoraproject.org/koji/buildinfo?buildID=2291875 . Click
info next to the rpm files for noarch (this is equivalent to Debian's
arch: all) and x86_64. Ignore the debuginfo and debugsource files.
For reference, here is Fedora's spec file:
https://src.fedoraproject.org/rpms/gnome-kiosk/blob/f39/f/gnome-kiosk.spec
Thank you,
Jeremy Bícha
Bug#1017026: ITP: gnome-kiosk -- mutter based compositor for kiosks
Package: wnpp Severity: wishlist X-Debbugs-CC: debian-de...@lists.debian.org, debian-gtk-gn...@lists.debian.org Owner: duckydre...@gmail.com Package Name: gnome-kiosk Version: 42.0 Upstream Author: Ray Strode License: GPL-2 Programming Lang: Description: mutter based compositor for kiosks gnome-kiosk provides a desktop environment suitable for fixed purpose, or single application deployments like wall displays and point-of-sale systems. Thanks, Shannon
