Bug#897449: django-allauth: Invalid character reference 138 in "Last Translator" field in some .po files (Bug#881727 reappeared when uploading 0.35 version)

2018-05-04 Thread Pierre-Elliott Bécue 
Le 4 mai 2018 20:05:52 GMT+02:00, Laura Arjona Reina  a 
écrit :
>Hello again
>I have sent a Pull Request (#2017) to the upstream project fixing the
>string of the translator name:
>https://github.com/pennersr/django-allauth/pull/2017
>
>Cheers

I referenced the issue I opened months ago in your MR.

You can close the bug as soon as you wish.

Sorry for all this.

Cheers ! 
-- 
PEB

Bug#897449: django-allauth: Invalid character reference 138 in "Last Translator" field in some .po files (Bug#881727 reappeared when uploading 0.35 version)

2018-05-04 Thread Laura Arjona Reina 
Hello again
I have sent a Pull Request (#2017) to the upstream project fixing the
string of the translator name:
https://github.com/pennersr/django-allauth/pull/2017

Cheers

-- 
Laura Arjona Reina
https://wiki.debian.org/LauraArjona

Bug#897449: django-allauth: Invalid character reference 138 in "Last Translator" field in some .po files (Bug#881727 reappeared when uploading 0.35 version)

2018-05-04 Thread Laura Arjona Reina 
Hello Pierre-Elliot

El 04/05/18 a las 13:52, Pierre-Elliott Bécue escribió:
> So, I wonder, maybe this error is triggered because the *source* actually
> still contains this wrongfully encoded character? But theoretically I'm not
> supposed to alter upstream's source.
>
Yes, that seems to be the case: I think our gen-material scripts don't
handle well the application of patches for packages with format 3.0 (quilt).
This is reported in bug #748716.

I'm excluding django-allauth from the l10n stats generation until
#748716 is solved, or upstream fixes the bad-encoded string.

Should I close this bug?

Thanks for your help

-- 
Laura Arjona Reina
https://wiki.debian.org/LauraArjona

Bug#897449: django-allauth: Invalid character reference 138 in "Last Translator" field in some .po files (Bug#881727 reappeared when uploading 0.35 version)

2018-05-04 Thread Pierre-Elliott Bécue 
Le mercredi 02 mai 2018 à 21:20:53+0200, Laura Arjona Reina a écrit :
> Package: django-allauth
> Severity: wishlist
> Tags: patch l10n upstream
> 
> Dear Maintainer,
> 
> When uploading the 0.35 version, the bug Bug#881727 reappeared again:
> 
> Some of the upstream .po files, in the "Last translator" field, include
> a name of translator with a bad encoded character (numeric character
> reference 138 instead of Š). This produces "Tidy Validation" warning
> messages when building the Debian website pages.
> The .PO files do not include mail address for the translator with the
> bad encoding, so I've requested to join the django-allauth translation
> team in Transifex, with the hope of contacting Jannis Š and request them
> to fix the encoding in their profile in Transifex.
> 
> Meanwhile, I'm attaching a patch that uses the correct UTF-8 character.

Hi,

This is very weird.

As you can see in the salsa repository, your patch is still there, and it
applied correctly (I rebased it on the new release).

As I did the upload myself, I took the .deb package I sent to the archive,
and extracted it, and placed myself in
usr/lib/python3/dist-packages/allauth/locale and ran this:

.-(.../dependencies/django-allauth/toto/usr/lib/python3/dist-packages/allauth/locale)-
`---> cat {es,pt_PT,sv,tr}/LC_MESSAGES/django.po|grep 'Jannis'
"Last-Translator: Jannis Š\n"
"Last-Translator: Jannis Š\n"
"Last-Translator: Jannis Š\n"
"Last-Translator: Jannis Š\n"

All seem fine.

As the package is also installed on my server, I also did this:

.-(13:50:00)-(~)-(peb@pimeys)-
`---> acp python-django-allauth
python-django-allauth:
  Installé : 0.35.0-1~bpo9+3
  Candidat : 0.35.0-1~bpo9+3
 Table de version :
 0.35.0-2 99
 99 http://ftp.fr.debian.org/debian sid/main amd64 Packages
 *** 0.35.0-1~bpo9+3 100
100 http://ftp.fr.debian.org/debian stretch-backports/main amd64 
Packages
100 /var/lib/dpkg/status
.-(13:50:04)-(~)-(peb@pimeys)-
`---> cd /usr/lib/python2.7/dist-packages/allauth/locale/
.-(13:50:26)-(/usr/lib/python2.7/dist-packages/allauth/locale)---(peb@pimeys)-
`---> cat {es,pt_PT,sv,tr}/LC_MESSAGES/django.po|grep 'Jannis'
"Last-Translator: Jannis Š\n"
"Last-Translator: Jannis Š\n"
"Last-Translator: Jannis Š\n"
"Last-Translator: Jannis Š\n"

Your patch really seems to work fine.

So, I wonder, maybe this error is triggered because the *source* actually
still contains this wrongfully encoded character? But theoretically I'm not
supposed to alter upstream's source.

Cheers,

-- 
Pierre-Elliott Bécue
GPG: 9AE0 4D98 6400 E3B6 7528  F493 0D44 2664 1949 74E2
It's far easier to fight for one's principles than to live up to them.


signature.asc
Description: PGP signature

Bug#897449: django-allauth: Invalid character reference 138 in "Last Translator" field in some .po files (Bug#881727 reappeared when uploading 0.35 version)

2018-05-02 Thread Laura Arjona Reina 
Package: django-allauth
Severity: wishlist
Tags: patch l10n upstream

Dear Maintainer,

When uploading the 0.35 version, the bug Bug#881727 reappeared again:

Some of the upstream .po files, in the "Last translator" field, include
a name of translator with a bad encoded character (numeric character
reference 138 instead of Š). This produces "Tidy Validation" warning
messages when building the Debian website pages.
The .PO files do not include mail address for the translator with the
bad encoding, so I've requested to join the django-allauth translation
team in Transifex, with the hope of contacting Jannis Š and request them
to fix the encoding in their profile in Transifex.

Meanwhile, I'm attaching a patch that uses the correct UTF-8 character.

Thanks!
-- 
Laura Arjona Reina
https://wiki.debian.org/LauraArjona
From 1f0529356e67c861f7f12870231da422edfbaeff Mon Sep 17 00:00:00 2001
From: Laura Arjona Reina 
Date: Wed, 2 May 2018 21:17:30 +0200
Subject: [PATCH] Fix wrongly encoded character in some .po files

---
 allauth/locale/es/LC_MESSAGES/django.po| 2 +-
 allauth/locale/pt_PT/LC_MESSAGES/django.po | 2 +-
 allauth/locale/sv/LC_MESSAGES/django.po| 2 +-
 allauth/locale/tr/LC_MESSAGES/django.po| 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/allauth/locale/es/LC_MESSAGES/django.po b/allauth/locale/es/LC_MESSAGES/django.po
index 9563433..265017e 100644
--- a/allauth/locale/es/LC_MESSAGES/django.po
+++ b/allauth/locale/es/LC_MESSAGES/django.po
@@ -9,7 +9,7 @@ msgstr ""
 "Report-Msgid-Bugs-To: \n"
 "POT-Creation-Date: 2018-02-02 12:55-0600\n"
 "PO-Revision-Date: 2014-08-12 00:30+0200\n"
-"Last-Translator: Jannis Š\n"
+"Last-Translator: Jannis Å \n"
 "Language-Team: Spanish (http://www.transifex.com/projects/p/django-allauth/;
 "language/es/)\n"
 "Language: es\n"
diff --git a/allauth/locale/pt_PT/LC_MESSAGES/django.po b/allauth/locale/pt_PT/LC_MESSAGES/django.po
index 183b23a..91ab179 100644
--- a/allauth/locale/pt_PT/LC_MESSAGES/django.po
+++ b/allauth/locale/pt_PT/LC_MESSAGES/django.po
@@ -9,7 +9,7 @@ msgstr ""
 "Report-Msgid-Bugs-To: \n"
 "POT-Creation-Date: 2018-02-02 12:55-0600\n"
 "PO-Revision-Date: 2014-08-12 00:33+0200\n"
-"Last-Translator: Jannis Š\n"
+"Last-Translator: Jannis Å \n"
 "Language-Team: Portuguese (Portugal) (http://www.transifex.com/projects/p/;
 "django-allauth/language/pt_PT/)\n"
 "Language: pt_PT\n"
diff --git a/allauth/locale/sv/LC_MESSAGES/django.po b/allauth/locale/sv/LC_MESSAGES/django.po
index fef25e9..c44c229 100644
--- a/allauth/locale/sv/LC_MESSAGES/django.po
+++ b/allauth/locale/sv/LC_MESSAGES/django.po
@@ -9,7 +9,7 @@ msgstr ""
 "Report-Msgid-Bugs-To: \n"
 "POT-Creation-Date: 2018-02-02 12:55-0600\n"
 "PO-Revision-Date: 2014-08-12 00:35+0200\n"
-"Last-Translator: Jannis Š\n"
+"Last-Translator: Jannis Å \n"
 "Language-Team: Swedish (http://www.transifex.com/projects/p/django-allauth/;
 "language/sv/)\n"
 "Language: sv\n"
diff --git a/allauth/locale/tr/LC_MESSAGES/django.po b/allauth/locale/tr/LC_MESSAGES/django.po
index 7acb817..2fc0c07 100644
--- a/allauth/locale/tr/LC_MESSAGES/django.po
+++ b/allauth/locale/tr/LC_MESSAGES/django.po
@@ -10,7 +10,7 @@ msgstr ""
 "Report-Msgid-Bugs-To: \n"
 "POT-Creation-Date: 2018-02-02 12:55-0600\n"
 "PO-Revision-Date: 2014-08-12 00:35+0200\n"
-"Last-Translator: Jannis Š\n"
+"Last-Translator: Jannis Å \n"
 "Language-Team: Turkish (http://www.transifex.com/projects/p/django-allauth/;
 "language/tr/)\n"
 "Language: tr\n"
-- 
2.11.0