Bug#1066355: spotlighter: FTBFS: spotlighter.c:105:3: error: implicit declaration of function ‘on_window_screen_changed’ [-Werror=implicit-function-declaration]

2024-04-14 Thread Vladimir Petko
Package: spotlighter
Followup-For: Bug #1066355
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu noble ubuntu-patch
Control: tags -1 patch

Dear Maintainer,

Would it be possible to consider the attached patch as the solution for the
issue?

In Ubuntu, the attached patch was applied to achieve the following:

  * d/p/2_ftbfs_implicit_declaration.patch: declare callback to
resolve -Werror=implicit-function-declaration ftbfs (LP: #2061331).


Thanks for considering the patch.


-- System Information:
Debian Release: trixie/sid
  APT prefers mantic-updates
  APT policy: (500, 'mantic-updates'), (500, 'mantic-security'), (500, 
'mantic'), (100, 'mantic-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 6.5.0-27-generic (SMP w/32 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
diff -Nru spotlighter-0.3/debian/patches/02_ftbfs_implicit_declaration.patch 
spotlighter-0.3/debian/patches/02_ftbfs_implicit_declaration.patch
--- spotlighter-0.3/debian/patches/02_ftbfs_implicit_declaration.patch  
1970-01-01 12:00:00.0 +1200
+++ spotlighter-0.3/debian/patches/02_ftbfs_implicit_declaration.patch  
2024-04-15 10:55:20.0 +1200
@@ -0,0 +1,18 @@
+Description: add callback declaration
+ Add callback declaration to resolve -Werror=implicit-function-declaration.
+Author: Vladimir Petko 
+Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1066355
+Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/spotlighter/+bug/2061331
+Forwarded: no
+Last-Update: 2024-04-15
+
+--- a/src/callbacks.h
 b/src/callbacks.h
+@@ -33,3 +33,7 @@
+  gpointerdata);
+
+
++G_MODULE_EXPORT void
++on_window_screen_changed   (GtkWidget  *widget,
++GdkScreen  *previous_screen,
++gpointeruser_data);
diff -Nru spotlighter-0.3/debian/patches/series 
spotlighter-0.3/debian/patches/series
--- spotlighter-0.3/debian/patches/series   2024-04-01 21:03:10.0 
+1300
+++ spotlighter-0.3/debian/patches/series   2024-04-15 10:55:20.0 
+1200
@@ -1,3 +1,4 @@
 00_desktop.patch
 01_ftbfs_mips.patch
 no_AM_PATH_GTK_3_0.diff
+02_ftbfs_implicit_declaration.patch


Bug#1066536: additional information

2024-04-14 Thread Vladimir Petko
Dear Maintainers,

This issue is resolved upstream[1]. Would it be possible to consider
releasing a new version, or applying the attached patch?

Best Regards,
 Vladimir.

[1] 
https://github.com/resurrecting-open-source-projects/sniffit/commit/df0221e95527e9f935b583da5d922c4d3e63d749
From: Sam James 
Date: Thu, 28 Jul 2022 12:14:44 +0100
Subject: [PATCH 2/2] Fix -Wimplicit-function-declaration (Clang 16)

Clang 16 will make -Wimplicit-function-declaration error by default.

For more information, see LWN.net [0] or LLVM's Discourse [1], gentoo-dev@ [2],
or the (new) c-std-porting mailing list [3].

[0] https://lwn.net/Articles/913505/
[1] https://discourse.llvm.org/t/configure-script-breakage-with-the-new-werror-implicit-function-declaration/65213
[2] https://archives.gentoo.org/gentoo-dev/message/dd9f2d3082b8b6f8dfbccb0639e6e240
[3] hosted at lists.linux.dev.

Signed-off-by: Sam James 
Origin: upstream, https://github.com/resurrecting-open-source-projects/sniffit/commit/df0221e95527e9f935b583da5d922c4d3e63d749
Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1066536
Bug-Ubuntu: https://bugs.launchpad.net/debian/+source/sniffit/+bug/2061033
Forwarded: not-needed

---
 src/sn_cfgfile.c| 1 +
 src/sn_generation.c | 2 ++
 src/sn_interface.c  | 1 +
 src/sniffit.c   | 1 +
 4 files changed, 5 insertions(+)

diff --git a/src/sn_cfgfile.c b/src/sn_cfgfile.c
index 4ea5d39..b27ac7d 100644
--- a/src/sn_cfgfile.c
+++ b/src/sn_cfgfile.c
@@ -2,6 +2,7 @@
 /*   - by  : Brecht Claerhout */
 /*   - improvements: Shudoh Kazuyuki  */

+#include 
 #include 
 #include 
 #include 
diff --git a/src/sn_generation.c b/src/sn_generation.c
index e08741e..030075a 100644
--- a/src/sn_generation.c
+++ b/src/sn_generation.c
@@ -13,7 +13,9 @@
 #include "sn_curses.h"
 #include "sn_defines.h"
 #include "sn_structs.h"
+#include "sn_packets.h"
 #include "sn_generation.h"
+#include "sn_interface.h"

 extern volatile int screen_busy;

diff --git a/src/sn_interface.c b/src/sn_interface.c
index 4842974..f8434d9 100644
--- a/src/sn_interface.c
+++ b/src/sn_interface.c
@@ -4,6 +4,7 @@
 #include "sn_config.h"

 #ifdef INCLUDE_INTERFACE
+#include 
 #include 
 #include 
 #include 
diff --git a/src/sniffit.c b/src/sniffit.c
index 7ab88a1..4adbe69 100644
--- a/src/sniffit.c
+++ b/src/sniffit.c
@@ -3,6 +3,7 @@

 #include "sn_config.h"		/* Config header file */

+#include 
 #include 
 #include 
 #include 
--
2.40.1


Bug#1065799: ncrack: FTBFS on arm{el,hf}: configure: error: *** compiler cannot create working executables, check config.log ***

2024-04-14 Thread Vladimir Petko
Dear Maintainers,

  Would it be possible to consider a merge request[1] that addresses this issue?

Best Regards,
 Vladimir.

 [1] https://salsa.debian.org/pkg-security-team/ncrack/-/merge_requests/2



Bug#1066239: gnome-system-tools: FTBFS: shares-tool.c:113:17: error: implicit declaration of function ‘table_add_share’ [-Werror=implicit-function-declaration]

2024-04-03 Thread Vladimir Petko
Package: gnome-system-tools
Followup-For: Bug #1066239
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu noble ubuntu-patch
Control: tags -1 patch

Dear Maintainer,

Would it be possible tot consider the attached patch as a solution to this
issue.

In Ubuntu, the attached patch was applied to achieve the following:

  * d/p/implicit_declaration.patch: add missing declarations to resolve
ftbfs (LP: #2060165).


Thanks for considering the patch.


-- System Information:
Debian Release: trixie/sid
  APT prefers mantic-updates
  APT policy: (500, 'mantic-updates'), (500, 'mantic-security'), (500, 
'mantic'), (100, 'mantic-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 6.5.0-26-generic (SMP w/32 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
diff -Nru gnome-system-tools-3.0.0/debian/patches/implicit_declaration.patch 
gnome-system-tools-3.0.0/debian/patches/implicit_declaration.patch
--- gnome-system-tools-3.0.0/debian/patches/implicit_declaration.patch  
1970-01-01 12:00:00.0 +1200
+++ gnome-system-tools-3.0.0/debian/patches/implicit_declaration.patch  
2024-04-04 11:38:40.0 +1300
@@ -0,0 +1,29 @@
+Description: add missing declarations
+ Add missing headers and declarations to resolve 
-Werror=implicit-function-declaration.
+Author: Vladimir Petko 
+Bug-Ubuntu: 
https://bugs.launchpad.net/debian/+source/gnome-system-tools/+bug/2060165
+Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1066239
+Forwarded: no
+Last-Update: 2024-04-04
+
+--- a/src/shares/shares-tool.h
 b/src/shares/shares-tool.h
+@@ -58,6 +58,7 @@
+ };
+
+ GstSharesTool *gst_shares_tool_new (void);
++GType gst_shares_tool_get_type();
+
+
+ G_END_DECLS
+--- a/src/shares/shares-tool.c
 b/src/shares/shares-tool.c
+@@ -23,6 +23,8 @@
+ #include "users-table.h"
+ #include 
+ #include "gst.h"
++#include "table.h"
++#include "share-settings.h"
+
+ static void gst_shares_tool_class_init (GstSharesToolClass *class);
+ static void gst_shares_tool_init   (GstSharesTool  *tool);
diff -Nru gnome-system-tools-3.0.0/debian/patches/series 
gnome-system-tools-3.0.0/debian/patches/series
--- gnome-system-tools-3.0.0/debian/patches/series  2024-03-31 
19:12:52.0 +1300
+++ gnome-system-tools-3.0.0/debian/patches/series  2024-04-04 
11:38:40.0 +1300
@@ -23,3 +23,4 @@
 max_group_name_32_chars.patch
 remove_g_thread_init.patch
 70_gst-yelp.patch
+implicit_declaration.patch


Bug#1066291: Additional information

2024-04-03 Thread Vladimir Petko
Dear Maintainers,

  Would it be possible to consider a merge request[1] that addresses this issue?

Best Regards,
 Vladimir.

 [1] https://salsa.debian.org/debian/gimp-plugin-registry/-/merge_requests/2



Bug#1067829: Additional information

2024-04-01 Thread Vladimir Petko
Hi,

I have submitted the bug upstream[1] here, and the patch contains
(long long int) cast as it would not be compiled otherwise.
The Ubuntu patch also contains a cast[2].
I apologise for not forwarding the patch correctly. I have attached
the patch forwarded upstream.

Best Regards,
 Vladimir.

[1] https://bugzilla.kernel.org/show_bug.cgi?id=218540
[2] 
https://launchpad.net/ubuntu/+archive/primary/+sourcefiles/nfs-utils/1:2.6.4-3ubuntu4/nfs-utils_2.6.4-3ubuntu4.debian.tar.xz
Description: cast to a type with a known size to ensure sprintf works
Author: Vladimir Petko 
Bug: https://bugzilla.kernel.org/show_bug.cgi?id=218540
Bug-Ubuntu:  https://bugs.launchpad.net/ubuntu/+source/nfs-utils/+bug/2055349
Last-Update: 2024-02-29
--- a/support/junction/export-cache.c
+++ b/support/junction/export-cache.c
@@ -107,7 +107,7 @@
 		xlog(D_GENERAL, "%s: time(3) failed", __func__);
 		return FEDFS_ERR_SVRFAULT;
 	}
-	snprintf(flushtime, sizeof(flushtime), "%ld\n", now);
+	snprintf(flushtime, sizeof(flushtime), "%lld\n", (long long int)now);
 
 	for (i = 0; junction_proc_files[i] != NULL; i++) {
 		retval = junction_write_time(junction_proc_files[i], flushtime);


Bug#1064724: yapet: FTBFS: dh_auto_test: error: make -j8 check "TESTSUITEFLAGS=-j8 --verbose" VERBOSE=1 returned exit code 2

2024-03-21 Thread Vladimir Petko
Package: yapet
Followup-For: Bug #1064724
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu noble ubuntu-patch
Control: tags -1 patch

Dear Maintainer,

The package fails to build due to the recent changes in openssl.
I have disabled the affected tests, but probably the issue should be fixed
upstream.

When investigating test failure I've also noticed that the tests fail on armhf
due to the usage of std::memset that was optimized away. I have replaced the
call with std::fill()

In Ubuntu, the attached patch was applied to achieve the following:

  * d/p/use-std-fill.patch: use std::fill to reset memory instead of
std::memset. This fixes armhf test failure (LP: 2058584).
  * d/p/disable-blowfish-tests.patch: disable failing blowfish tests.
See Debian bug 1064724.


Thanks for considering the patch.


-- System Information:
Debian Release: trixie/sid
  APT prefers mantic-updates
  APT policy: (500, 'mantic-updates'), (500, 'mantic-security'), (500, 
'mantic'), (100, 'mantic-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 6.5.0-25-generic (SMP w/32 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
diff -Nru yapet-2.6/debian/patches/disable-blowfish-tests.patch 
yapet-2.6/debian/patches/disable-blowfish-tests.patch
--- yapet-2.6/debian/patches/disable-blowfish-tests.patch   1970-01-01 
12:00:00.0 +1200
+++ yapet-2.6/debian/patches/disable-blowfish-tests.patch   2024-03-21 
15:56:18.0 +1300
@@ -0,0 +1,48 @@
+Description: disable blowfish tests
+ Blowfish tests fail with openssl 3.1.5-1. Disable failing tests.
+ The failure may be related to the fix for
+ https://www.openssl.org/news/vulnerabilities.html#CVE-2023-5363.
+Author: Vladimir Petko 
+Bug: https://github.com/RafaelOstertag/yapet/issues/26
+Bug-Debian: https://bugs.debian.org/1064724
+Last-Update: 2024-03-21
+
+--- a/tests/crypt/Makefile.am
 b/tests/crypt/Makefile.am
+@@ -47,10 +47,10 @@
+   $(cpy_verbose)cp $< $(builddir)/$@
+   $(chmod_verbose)chmod u=rw $(builddir)/$@
+
+-check_PROGRAMS  = key448 key256 blowfish aes256 blowfishfactory aes256factory 
file_blowfish file_aes256 foreign cryptofactoryhelper
++check_PROGRAMS  = key448 key256 aes256 blowfishfactory aes256factory 
file_aes256 cryptofactoryhelper
+ check_PROGRAMS += passwordchange_exerciser
+
+-TESTS = key448 key256 blowfish aes256 blowfishfactory aes256factory 
file_blowfish file_aes256 foreign cryptofactoryhelper
++TESTS = key448 key256 aes256 blowfishfactory aes256factory file_aes256 
cryptofactoryhelper
+
+ AM_CPPFLAGS = -I$(yapet_libs_srcdir)/consts \
+   -I$(yapet_libs_srcdir)/exceptions \
+--- a/tests/crypt/Makefile.in
 b/tests/crypt/Makefile.in
+@@ -87,15 +87,15 @@
+ POST_UNINSTALL = :
+ build_triplet = @build@
+ host_triplet = @host@
+-check_PROGRAMS = key448$(EXEEXT) key256$(EXEEXT) blowfish$(EXEEXT) \
++check_PROGRAMS = key448$(EXEEXT) key256$(EXEEXT)  \
+   aes256$(EXEEXT) blowfishfactory$(EXEEXT) \
+-  aes256factory$(EXEEXT) file_blowfish$(EXEEXT) \
+-  file_aes256$(EXEEXT) foreign$(EXEEXT) \
++  aes256factory$(EXEEXT)  \
++  file_aes256$(EXEEXT)  \
+   cryptofactoryhelper$(EXEEXT) passwordchange_exerciser$(EXEEXT)
+-TESTS = key448$(EXEEXT) key256$(EXEEXT) blowfish$(EXEEXT) \
++TESTS = key448$(EXEEXT) key256$(EXEEXT) \
+   aes256$(EXEEXT) blowfishfactory$(EXEEXT) \
+-  aes256factory$(EXEEXT) file_blowfish$(EXEEXT) \
+-  file_aes256$(EXEEXT) foreign$(EXEEXT) \
++  aes256factory$(EXEEXT)  \
++  file_aes256$(EXEEXT)  \
+   cryptofactoryhelper$(EXEEXT)
+ subdir = tests/crypt
+ ACLOCAL_M4 = $(top_srcdir)/aclocal.m4
diff -Nru yapet-2.6/debian/patches/series yapet-2.6/debian/patches/series
--- yapet-2.6/debian/patches/series 2024-03-05 15:19:25.0 +1300
+++ yapet-2.6/debian/patches/series 2024-03-21 15:56:18.0 +1300
@@ -1,2 +1,4 @@
 do-not-install-licenses-files.patch
 avoid-remote-font.patch
+use-std-fill.patch
+disable-blowfish-tests.patch
diff -Nru yapet-2.6/debian/patches/use-std-fill.patch 
yapet-2.6/debian/patches/use-std-fill.patch
--- yapet-2.6/debian/patches/use-std-fill.patch 1970-01-01 12:00:00.0 
+1200
+++ yapet-2.6/debian/patches/use-std-fill.patch 2024-03-21 15:56:18.0 
+1300
@@ -0,0 +1,38 @@
+From: Vladimir Petko 
+Date: Thu, 21 Mar 2024 15:47:02 +1300
+Bug: https://github.com/RafaelOstertag/yapet/issues/27
+Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/yapet/+bug/2058584
+Description: use std::fill with volatile pointers to reset memory
+ std::memset can be optimized away and can not be used to
+ securely reset memory.
+ Use std::fill with volatile pointers.
+
+---
+ src/libs/utils/securearray.cc | 5 +++--
+ 1 file changed, 3 insertions(+), 2 deletions(-)
+
+diff --

Bug#1064724: yapet: FTBFS: dh_auto_test: error: make -j8 check "TESTSUITEFLAGS=-j8 --verbose" VERBOSE=1 returned exit code 2

2024-03-20 Thread Vladimir Petko
Hi,

 This issue appears to be caused by the openssl fix[1].

Best Regards,
 Vladimir.

[1] https://www.openssl.org/news/vulnerabilities.html#CVE-2023-5363



Bug#1042042: android-platform-build: FTBFS: Vector.h:259:28: error: cannot convert ‘const android::Vector*’ to ‘android::VectorImpl*’

2024-03-07 Thread Vladimir Petko
Package: android-platform-build
Followup-For: Bug #1042042
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu noble ubuntu-patch
Control: tags -1 patch

Dear Maintainer,

The attached patch resolves the above ftbfs by adding patches for BouncyCastle
and libziparchive-dev API changes.

In Ubuntu, the attached patch was applied to achieve the following:

  * Resolve ftbfs due to the API changes (LP: #2056084):
- d/p/bouncycastle177-compat.patch: replace DerOutputStream with
  ASN1OutputStream.
- d/p/zip-archive-reader-signature: update ReadAtOffset method
  signature.


Thanks for considering the patch.


-- System Information:
Debian Release: trixie/sid
  APT prefers mantic-updates
  APT policy: (500, 'mantic-updates'), (500, 'mantic-security'), (500, 
'mantic'), (100, 'mantic-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 6.5.0-21-generic (SMP w/32 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
diff -Nru 
android-platform-build-10.0.0+r36/debian/patches/bouncycastle177-compat.patch 
android-platform-build-10.0.0+r36/debian/patches/bouncycastle177-compat.patch
--- 
android-platform-build-10.0.0+r36/debian/patches/bouncycastle177-compat.patch   
1970-01-01 12:00:00.0 +1200
+++ 
android-platform-build-10.0.0+r36/debian/patches/bouncycastle177-compat.patch   
2024-03-06 14:35:07.0 +1300
@@ -0,0 +1,30 @@
+Description: remove usage of DerOutputStream
+ BouncyCastle removed DerOutputStream and replaced it
+ with ASN1OutputStream.
+Author: Vladimir Petko 
+Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1042042
+Bug-Ubuntu: 
https://bugs.launchpad.net/ubuntu/+source/android-platform-build/+bug/2056084
+Forwarded: not-needed
+Last-Update: 2024-03-06
+
+--- a/tools/signapk/src/com/android/signapk/SignApk.java
 b/tools/signapk/src/com/android/signapk/SignApk.java
+@@ -18,7 +18,8 @@
+
+ import org.bouncycastle.asn1.ASN1InputStream;
+ import org.bouncycastle.asn1.ASN1ObjectIdentifier;
+-import org.bouncycastle.asn1.DEROutputStream;
++import org.bouncycastle.asn1.ASN1OutputStream;
++import org.bouncycastle.asn1.ASN1Encoding;
+ import org.bouncycastle.asn1.cms.CMSObjectIdentifiers;
+ import org.bouncycastle.asn1.pkcs.PrivateKeyInfo;
+ import org.bouncycastle.cert.jcajce.JcaCertStore;
+@@ -334,7 +335,7 @@
+ CMSSignedData sigData = gen.generate(data, false);
+
+ try (ASN1InputStream asn1 = new 
ASN1InputStream(sigData.getEncoded())) {
+-DEROutputStream dos = new DEROutputStream(out);
++ASN1OutputStream dos = ASN1OutputStream.create(out, 
ASN1Encoding.DER);
+ dos.writeObject(asn1.readObject());
+ }
+ }
diff -Nru android-platform-build-10.0.0+r36/debian/patches/series 
android-platform-build-10.0.0+r36/debian/patches/series
--- android-platform-build-10.0.0+r36/debian/patches/series 2021-01-03 
10:32:31.0 +1300
+++ android-platform-build-10.0.0+r36/debian/patches/series 2024-03-06 
14:35:07.0 +1300
@@ -3,3 +3,5 @@
 fix_zipalign_typo.diff
 python-2to3.patch
 Implement-range-based-pin-list.patch
+zip-archive-reader-signature.patch
+bouncycastle177-compat.patch
diff -Nru 
android-platform-build-10.0.0+r36/debian/patches/zip-archive-reader-signature.patch
 
android-platform-build-10.0.0+r36/debian/patches/zip-archive-reader-signature.patch
--- 
android-platform-build-10.0.0+r36/debian/patches/zip-archive-reader-signature.patch
 1970-01-01 12:00:00.0 +1200
+++ 
android-platform-build-10.0.0+r36/debian/patches/zip-archive-reader-signature.patch
 2024-03-06 14:35:07.0 +1300
@@ -0,0 +1,21 @@
+Description: update FileReader::ReadAtOffset signature
+ FileReader:ReadAtOffset() signature was changed in
+ android-libziparchive-dev. Update the method signature
+ to match.
+Author: Vladimir Petko 
+Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1042042
+Bug-Ubuntu: 
https://bugs.launchpad.net/ubuntu/+source/android-platform-build/+bug/2056084
+Forwarded: not-needed
+Last-Update: 2024-03-06
+
+--- a/tools/zipalign/ZipFile.cpp
 b/tools/zipalign/ZipFile.cpp
+@@ -1223,7 +1223,7 @@
+ FileReader(FILE* fp) : Reader(), fp_(fp), current_offset_(0) {
+ }
+
+-bool ReadAtOffset(uint8_t* buf, size_t len, uint32_t offset) const {
++bool ReadAtOffset(uint8_t* buf, size_t len, off64_t offset) const {
+ // Data is usually requested sequentially, so this helps avoid 
pointless
+ // fseeks every time we perform a read. There's an impedence mismatch
+ // here because the original API was designed around pread and pwrite.


Bug#1064676: additional information

2024-03-07 Thread Vladimir Petko
Dear Maintainers,

  Would it be possible to consider a merge request[1] that addresses this issue?

Best Regards,
 Vladimir.

 [1] 
https://salsa.debian.org/android-tools-team/android-platform-tools-apksig/-/merge_requests/6



Bug#1058331: android-platform-tools-base: additional information

2024-03-07 Thread Vladimir Petko
Package: android-platform-tools-base
Followup-For: Bug #1058331
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu noble ubuntu-patch
Control: tags -1 patch

Dear Maintainer,

I apologise for submitting it as a debdiff, salsa repository appears to be out
of date.

The attached patch resolves ftbfs due to the internal sun.security and
BouncyCastle API changes.

In Ubuntu, the attached patch was applied to achieve the following:

  * Resolve the failure to build from source (LP: #2056088):
- d/p/{der-output-stream.patch, add-exports.patch}: sun.security
  PKCS7 class now only supports encoding to DerOutputStream.
  Explicitly instantiate it.
- d/p/bouncycastle177-compat.patch: use ASN1OutputStream instead
  of remove DerOutputStream.


Thanks for considering the patch.


-- System Information:
Debian Release: trixie/sid
  APT prefers mantic-updates
  APT policy: (500, 'mantic-updates'), (500, 'mantic-security'), (500, 
'mantic'), (100, 'mantic-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 6.5.0-21-generic (SMP w/32 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
diff -Nru android-platform-tools-base-2.2.2/debian/patches/add-exports.patch 
android-platform-tools-base-2.2.2/debian/patches/add-exports.patch
--- android-platform-tools-base-2.2.2/debian/patches/add-exports.patch  
2023-02-03 03:01:58.0 +1300
+++ android-platform-tools-base-2.2.2/debian/patches/add-exports.patch  
2024-03-06 13:16:37.0 +1300
@@ -5,7 +5,7 @@
  }
  
 +compileJava {
-+options.compilerArgs << '--add-exports' << 
'java.base/sun.security.pkcs=ALL-UNNAMED' << '--add-exports' << 
'java.base/sun.security.x509=ALL-UNNAMED'
++options.compilerArgs << '--add-exports' << 
'java.base/sun.security.pkcs=ALL-UNNAMED' << '--add-exports' << 
'java.base/sun.security.x509=ALL-UNNAMED' << '--add-exports' << 
'java.base/sun.security.util=ALL-UNNAMED'
 +}
 +
  task initSdkForTests(type: JavaExec) {
diff -Nru 
android-platform-tools-base-2.2.2/debian/patches/bouncycastle177-compat.patch 
android-platform-tools-base-2.2.2/debian/patches/bouncycastle177-compat.patch
--- 
android-platform-tools-base-2.2.2/debian/patches/bouncycastle177-compat.patch   
1970-01-01 12:00:00.0 +1200
+++ 
android-platform-tools-base-2.2.2/debian/patches/bouncycastle177-compat.patch   
2024-03-06 13:16:37.0 +1300
@@ -0,0 +1,57 @@
+Description: bouncycastle 1.77 compatibility patch
+ Remove usages of DerOutputStream that is no longer public.
+Author: Vladimir Petko 
+Bug-Ubuntu: 
https://bugs.launchpad.net/debian/+source/android-platform-tools-base/+bug/2056088
+Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1058331
+Forwarded: not-needed
+Last-Update: 2024-03-06
+
+--- 
a/build-system/builder/src/main/java/com/android/builder/internal/packaging/sign/SignatureExtension.java
 
b/build-system/builder/src/main/java/com/android/builder/internal/packaging/sign/SignatureExtension.java
+@@ -29,7 +29,8 @@
+ 
+ import org.apache.commons.codec.binary.Base64;
+ import org.bouncycastle.asn1.ASN1InputStream;
+-import org.bouncycastle.asn1.DEROutputStream;
++import org.bouncycastle.asn1.ASN1OutputStream;
++import org.bouncycastle.asn1.ASN1Encoding;
+ import org.bouncycastle.cert.jcajce.JcaCertStore;
+ import org.bouncycastle.cms.CMSException;
+ import org.bouncycastle.cms.CMSProcessableByteArray;
+@@ -610,12 +611,12 @@
+ /*
+  * DEROutputStream is not closeable! OMG!
+  */
+-DEROutputStream dos = null;
++ASN1OutputStream dos = null;
+ try (ASN1InputStream asn1 = new 
ASN1InputStream(sigData.getEncoded())) {
+-dos = new DEROutputStream(outputBytes);
++dos = ASN1OutputStream.create(outputBytes, ASN1Encoding.DER);
+ dos.writeObject(asn1.readObject());
+ 
+-DEROutputStream toClose = dos;
++ASN1OutputStream toClose = dos;
+ dos = null;
+ toClose.close();
+ } catch (IOException e) {
+--- 
a/build-system/builder/src/main/java/com/android/builder/signing/SignedJarApkCreator.java
 
b/build-system/builder/src/main/java/com/android/builder/signing/SignedJarApkCreator.java
+@@ -33,7 +33,8 @@
+ import com.google.common.io.Files;
+ 
+ import org.bouncycastle.asn1.ASN1InputStream;
+-import org.bouncycastle.asn1.DEROutputStream;
++import org.bouncycastle.asn1.ASN1OutputStream;
++import org.bouncycastle.asn1.ASN1Encoding;
+ import org.bouncycastle.cert.jcajce.JcaCertStore;
+ import org.bouncycastle.cms.CMSException;
+ import org.bouncycastle.cms.CMSProcessableByteArray;
+@@ -400,7 +401,7 @@
+ CMSSignedData sigData = gen.generate(data, false);
+

Bug#1061025: Additional information

2024-03-06 Thread Vladimir Petko
Dear Maintainers,

 I am wondering if the acceptable fix for this failure would be
disabling slf4j backend in commons-logging? This will break circular
dependency and allow projects that use commons-logging and slf4j to
build. I have created a MR with the patch[1].

Best Regards,
 Vladimir.

[1] 
https://salsa.debian.org/java-team/libcommons-logging-java/-/merge_requests/7



Bug#1065460: uwsgi: the package fails to build from source due to missing 'plugins/rack_ruby32'

2024-03-04 Thread Vladimir Petko
Source: uwsgi
Version: 2.0.22-4
Severity: serious
Tags: ftbfs

Dear Maintainer,

The package fails to build in sid chroot with the following error:

--
*** uWSGI building and linking plugin plugins/rack_ruby32 ***
Error: unable to find directory 'plugins/rack_ruby32'
make: *** [debian/rules:429: debian/stamp-uwsgi-plugin-rack-ruby3.2] Error 1
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2

Build finished at 2024-03-04T23:36:17Z

Finished





-- System Information:
Debian Release: trixie/sid
  APT prefers mantic-updates
  APT policy: (500, 'mantic-updates'), (500, 'mantic-security'), (500, 
'mantic'), (100, 'mantic-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 6.5.0-21-generic (SMP w/32 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled



Bug#1061025: Additional information

2024-03-03 Thread Vladimir Petko
Dear Maintainers,

httpcomponents-client contains an implicit dependency on slf4j-java.

Last time it was build successfully against libcommons-log-java 1.2[1]

Support for slf4j was added after its release[2][3]

Debian and Ubuntu have slf4j 1.7.32-1 which calls
org.apache.commons.logging.LogFactory.getLog[4].

This causes exception in httpclient-cache tests[5]:

java.lang.IllegalStateException: Recursive update
 at 
java.base/java.util.concurrent.ConcurrentHashMap.computeIfAbsent(ConcurrentHashMap.java:1763)

Best Regards,
 Vladimir.

[1] 
https://buildd.debian.org/status/fetch.php?pkg=httpcomponents-client=all=4.5.14-1=1670330442=0
[2] https://github.com/apache/commons-logging/pull/177
[3] 
https://github.com/apache/commons-logging/commits/master/src/main/java/org/apache/commons/logging/impl/Slf4jLogFactory.java
[4] 
https://github.com/qos-ch/slf4j/blob/e9ee55cca93c2bf26f14482a9bdf961c750d2a56/slf4j-jcl/src/main/java/org/slf4j/impl/JCLLoggerFactory.java#L77
[5] 
https://launchpad.net/~vpa1977/+archive/ubuntu/october-21/+build/27798162/+files/buildlog_ubuntu-noble-amd64.httpcomponents-client_4.5.14-1_BUILDING.txt.gz



Bug#1065000: pgpool2: the package fails to build on armhf due to gcc-13 13.2.0-16.1 changes

2024-02-28 Thread Vladimir Petko
Dear Maintainers,

  Would it be possible to consider a merge request[1] that addresses this issue?

Best Regards,
 Vladimir.

 [1] https://salsa.debian.org/postgresql/pgpool2/-/merge_requests/5



Bug#1065000: pgpool2: the package fails to build on armhf due to gcc-13 13.2.0-16.1 changes

2024-02-28 Thread Vladimir Petko
Source: pgpool2
Version: 4.3.7-1
Severity: serious

Dear Maintainer,

armhf has -Werror=implicit-function-declaration enabled in default gcc flags of
gcc-13 13.2.0-16.1.

pgpool2 has a number of implicit function declarations causing the build
failure[1]

[1] https://launchpadlibrarian.net/716403848/buildlog_ubuntu-noble-
armhf.pgpool2_4.3.7-1ubuntu1_BUILDING.txt.gz


-- System Information:
Debian Release: trixie/sid
  APT prefers mantic-updates
  APT policy: (500, 'mantic-updates'), (500, 'mantic-security'), (500, 
'mantic'), (100, 'mantic-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 6.5.0-21-generic (SMP w/32 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled



Bug#1064554: jruby fails to build from source in unstable

2024-02-23 Thread Vladimir Petko
Source: jruby
Version: 9.4.5.0+ds-1
Severity: serious

Dear Maintainer,

When building jruby in unstable, the following error occurs:

[INFO] 
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-install-
plugin:3.1.1:install (default-install) on project jruby-parent: Failed to
install artifact org.jruby:jruby-parent:pom:9.4.5.0:
/<>/debian/maven-repo/org/jruby/jruby-parent/9.4.5.0/jruby-
parent-9.4.5.0.pom (Permission denied) -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please
read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
dh_auto_build: error: /usr/lib/jvm/default-java/bin/java -noverify -cp
/usr/share/maven/boot/plexus-classworlds-2.x.jar -Dmaven.home=/usr/share/maven
-Dmaven.multiModuleProjectDirectory=/<>/jruby-9.4.5.0\+ds
-Dclassworlds.conf=/etc/maven/m2-debian.conf
-Dproperties.file.manual=/<>/jruby-9.4.5.0\+ds/debian/maven.properties
org.codehaus.plexus.classworlds.launcher.Launcher -s/etc/maven/settings-
debian.xml -Ddebian.dir=/<>/jruby-9.4.5.0\+ds/debian
-Dmaven.repo.local=/<>/jruby-9.4.5.0\+ds/debian/maven-repo --batch-
mode -Djruby.revision=9.4.5.0\+ds-1build1\~ppa2 -Pmain,complete,dist
-DskipTests -Dnotimestamp=true -Dlocale=en_US returned exit code 1
make[1]: *** [debian/rules:43: override_dh_auto_build] Error 25
make[1]: Leaving directory '/<>'
make: *** [debian/rules:9: binary] Error 2
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2

Build finished at 2024-02-24T07:14:56Z

This is due to maven-repo-helper copying symlinks to jruby poms rather than
poms themselves.

One possible solution is to copy jruby poms manually in
execute_after_dh_auto_configure:
# copy jruby poms rather than links, because the build will try to
patch them
for p in jruby jruby-parent jruby-base jruby-core jruby-artifacts ; do
\
rm debian/maven-repo/org/jruby/$$p/* ;\
mkdir debian/maven-repo/org/jruby/$$p/debian ; \
cp /usr/share/maven-repo/org/jruby/$$p/debian/* debian/maven-
repo/org/jruby/$$p/debian/ ;\
done




-- System Information:
Debian Release: trixie/sid
  APT prefers mantic-updates
  APT policy: (500, 'mantic-updates'), (500, 'mantic-security'), (500, 
'mantic'), (100, 'mantic-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 6.5.0-17-generic (SMP w/32 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_WARN, TAINT_OOT_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled



Bug#1061736: aubio ftbfs with Python 3.12 as the default

2024-02-01 Thread Vladimir Petko
Dear Maintainers,

  Would it be possible to consider a merge request[1] that addresses this issue?

Best Regards,
 Vladimir.

 [1] https://salsa.debian.org/umlaeute/aubio/-/merge_requests/1



Bug#1042314: additional information

2024-01-31 Thread Vladimir Petko
Hi,

 The package builds with an experimental version of jruby
9.4.3.0+ds-1~exp2[1] after applying upstream patch[2].
 Applying Ubuntu diff[3] also fixes the issue.

Best regards,
 Vladimir.

[1] https://packages.debian.org/source/experimental/jruby
[2] 
https://github.com/puppetlabs/puppetserver/commit/d8b3a44a96f17214d434a3841887aa2e00e0546f
[3] 
https://launchpadlibrarian.net/702054854/jruby_9.3.9.0+ds-8_9.3.9.0+ds-8ubuntu1.diff.gz



Bug#1042049: lintian: FTBFS: 3 tests failed

2023-12-07 Thread Vladimir Petko
As of today there are more test failures:


Test Summary Report
---
debian/test-out/eval/checks/documentation/manual/manpage-errors-from-man/generic.t
 (Wstat: 256 (exited 1)
Tests: 1 Failed: 1)
  Failed test:  1
  Non-zero exit status: 1
debian/test-out/eval/checks/documentation/manual/surplus-manpage/generic.t
 (Wstat: 256
(exited 1) Tests: 1 Failed: 1)
  Failed test:  1
  Non-zero exit status: 1
debian/test-out/eval/checks/documentation/manual/manpages-general/generic.t
(Wstat: 256 (exited
1) Tests: 1 Failed: 1)
  Failed test:  1
  Non-zero exit status: 1
debian/test-out/eval/checks/systemd/kill-mode-none/generic.t
 (Wstat: 256
(exited 1) Tests: 1 Failed: 1)
  Failed test:  1
  Non-zero exit status: 1
debian/test-out/eval/checks/systemd/no-systemd-service-for-init-script/generic.t
   (Wstat: 256 (exited 1)
Tests: 1 Failed: 1)
  Failed test:  1
  Non-zero exit status: 1
debian/test-out/eval/checks/systemd/systemd-service-file-refers-to-var-run/generic.t
   (Wstat: 256 (exited 1)
Tests: 1 Failed: 1)
  Failed test:  1
  Non-zero exit status: 1
debian/test-out/eval/checks/systemd/systemd-service-file-shutdown-problems/generic.t
   (Wstat: 256 (exited 1)
Tests: 1 Failed: 1)
  Failed test:  1
  Non-zero exit status: 1
debian/test-out/eval/checks/systemd/systemd-service-file-uses-deprecated-syslog-facility/generic.t
 (Wstat: 256 (exited 1) Tests: 1 Failed: 1)
  Failed test:  1
  Non-zero exit status: 1
debian/test-out/eval/checks/systemd/systemd-service-file-uses-nobody-or-nogroup/generic.t
  (Wstat: 256 (exited 1) Tests: 1
Failed: 1)
  Failed test:  1
  Non-zero exit status: 1
debian/test-out/eval/checks/systemd/systemd-missing-services/generic.t
 (Wstat: 256
(exited 1) Tests: 1 Failed: 1)
  Failed test:  1
  Non-zero exit status: 1
Files=1486, Tests=63479, 158 wallclock secs ( 5.19 usr  4.86 sys + 3233.69
cusr 952.85 csys = 4196.59 CPU)
Result: FAIL

The test suite ran for 2 minutes and 38 seconds.


Bug#1011492: Additional information

2023-12-06 Thread Vladimir Petko
The relevant part of the build log
---
[INFO] -
[ERROR] COMPILATION ERROR :
[INFO] -
[ERROR]
/<>/tika-parsers/src/main/java/org/apache/tika/parser/microsoft/ooxml/MetadataExtractor.java:[37,72]
package org.openxmlformats.schemas.officeDocument.x2006.customProperties
does not exist
[ERROR]
/<>/tika-parsers/src/main/java/org/apache/tika/parser/microsoft/ooxml/MetadataExtractor.java:[38,74]
cannot find symbol
  symbol:   class CTProperties
  location: package
org.openxmlformats.schemas.officeDocument.x2006.extendedProperties
[ERROR]
/<>/tika-parsers/src/main/java/org/apache/tika/parser/microsoft/ooxml/XWPFListManager.java:[26,62]
cannot find symbol
  symbol:   class CTAbstractNum
  location: package org.openxmlformats.schemas.wordprocessingml.x2006.main
[ERROR]
/<>/tika-parsers/src/main/java/org/apache/tika/parser/microsoft/ooxml/XWPFListManager.java:[27,62]
cannot find symbol
  symbol:   class CTDecimalNumber
  location: package org.openxmlformats.schemas.wordprocessingml.x2006.main
[ERROR]
/<>/tika-parsers/src/main/java/org/apache/tika/parser/microsoft/ooxml/XWPFListManager.java:[28,62]
cannot find symbol
  symbol:   class CTLvl
  location: package org.openxmlformats.schemas.wordprocessingml.x2006.main
[ERROR]
/<>/tika-parsers/src/main/java/org/apache/tika/parser/microsoft/ooxml/XWPFListManager.java:[29,62]
cannot find symbol
  symbol:   class CTNum
  location: package org.openxmlformats.schemas.wordprocessingml.x2006.main
[ERROR]
/<>/tika-parsers/src/main/java/org/apache/tika/parser/microsoft/ooxml/XWPFListManager.java:[30,62]
cannot find symbol
  symbol:   class CTNumLvl
  location: package org.openxmlformats.schemas.wordprocessingml.x2006.main
[ERROR]
/<>/tika-parsers/src/main/java/org/apache/tika/parser/microsoft/ooxml/XWPFListManager.java:[105,45]
cannot find symbol
  symbol:   class CTNum
  location: class org.apache.tika.parser.microsoft.ooxml.XWPFListManager
[ERROR]
/<>/tika-parsers/src/main/java/org/apache/tika/parser/microsoft/ooxml/XWPFListManager.java:[129,51]
cannot find symbol
  symbol:   class CTDecimalNumber
  location: class org.apache.tika.parser.microsoft.ooxml.XWPFListManager
[ERROR]
/<>/tika-parsers/src/main/java/org/apache/tika/parser/microsoft/ooxml/XWPFListManager.java:[143,46]
cannot find symbol
  symbol:   class CTLvl
  location: class org.apache.tika.parser.microsoft.ooxml.XWPFListManager
[ERROR]
/<>/tika-parsers/src/main/java/org/apache/tika/parser/microsoft/ooxml/RunProperties.java:[21,62]
cannot find symbol
  symbol:   class CTUnderline
  location: package org.openxmlformats.schemas.wordprocessingml.x2006.main
[ERROR]
/<>/tika-parsers/src/main/java/org/apache/tika/parser/microsoft/ooxml/XSSFExcelExtractorDecorator.java:[68,55]
cannot find symbol
  symbol:   class CTHyperlink
  location: package org.openxmlformats.schemas.drawingml.x2006.main
[ERROR]
/<>/tika-parsers/src/main/java/org/apache/tika/parser/microsoft/ooxml/XSSFExcelExtractorDecorator.java:[69,55]
cannot find symbol
  symbol:   class CTNonVisualDrawingProps
  location: package org.openxmlformats.schemas.drawingml.x2006.main
[ERROR]
/<>/tika-parsers/src/main/java/org/apache/tika/parser/microsoft/ooxml/XSSFExcelExtractorDecorator.java:[70,69]
cannot find symbol
  symbol:   class CTShape
  location: package
org.openxmlformats.schemas.drawingml.x2006.spreadsheetDrawing
[ERROR]
/<>/tika-parsers/src/main/java/org/apache/tika/parser/microsoft/ooxml/XSSFExcelExtractorDecorator.java:[71,69]
cannot find symbol
  symbol:   class CTShapeNonVisual
  location: package
org.openxmlformats.schemas.drawingml.x2006.spreadsheetDrawing
[ERROR]
/<>/tika-parsers/src/main/java/org/apache/tika/parser/microsoft/ooxml/XSSFExcelExtractorDecorator.java:[303,45]
cannot find symbol
  symbol:   class CTShape
  location: class
org.apache.tika.parser.microsoft.ooxml.XSSFExcelExtractorDecorator
[ERROR]
/<>/tika-parsers/src/main/java/org/apache/tika/parser/microsoft/ooxml/XSLFPowerPointExtractorDecorator.java:[64,60]
cannot find symbol
  symbol:   class CTPicture
  location: package org.openxmlformats.schemas.presentationml.x2006.main
[ERROR]
/<>/tika-parsers/src/main/java/org/apache/tika/parser/microsoft/ooxml/XSLFPowerPointExtractorDecorator.java:[65,60]
cannot find symbol
  symbol:   class CTSlideIdList
  location: package org.openxmlformats.schemas.presentationml.x2006.main
[ERROR]
/<>/tika-parsers/src/main/java/org/apache/tika/parser/microsoft/ooxml/XSLFPowerPointExtractorDecorator.java:[66,60]
cannot find symbol
  symbol:   class CTSlideIdListEntry
  location: package org.openxmlformats.schemas.presentationml.x2006.main
[ERROR]
/<>/tika-parsers/src/main/java/org/apache/tika/parser/microsoft/ooxml/XWPFWordExtractorDecorator.java:[65,62]
cannot find symbol
  symbol:   class CTBookmark
  location: package org.openxmlformats.schemas.wordprocessingml.x2006.main
[ERROR]

Bug#1042044: Additional information

2023-08-03 Thread Vladimir Petko
Dear Maintainers,

I have tried to fix gtk warnings but due to changes in the FileDialog
API there are significant changes that are best fixed upstream[1].
I have attached debdiff patch to disable those warnings for now.

Best regards,
 Vladimir.

[1] https://github.com/strongswan/strongswan/issues/1829


disable-gtk-warnings.debdiff
Description: Binary data


Bug#1029283:

2023-08-01 Thread Vladimir Petko
Hi,

 I have used the attached patch to get the autopkgtests to pass.

Best Regards,
 Vladimir.


pywebdav_0.10.0-1ubuntu1.debdiff
Description: Binary data


Bug#1029283:

2023-07-31 Thread Vladimir Petko
After applying patch[1] I have ran the test suite with the following results:
---
 make URL=http://localhost:38028 CREDS="test test"  check
make[1]: Entering directory
'/home/vladimirp/git/make-pywebdav/pywebdav/test/litmus-0.13/lib/neon'
make[1]: Nothing to be done for 'all'.
make[1]: Leaving directory
'/home/vladimirp/git/make-pywebdav/pywebdav/test/litmus-0.13/lib/neon'
gcc  -o basic src/basic.o -L. -ltest -Llib/neon -lneon  -lexpat
gcc  -o copymove src/copymove.o -L. -ltest -Llib/neon -lneon  -lexpat
gcc  -o props src/props.o -L. -ltest -Llib/neon -lneon  -lexpat
gcc  -o locks src/locks.o -L. -ltest -Llib/neon -lneon  -lexpat
gcc  -o http src/http.o -L. -ltest -Llib/neon -lneon  -lexpat
-> running `basic':
 0. init.. pass
 1. begin. pass
 2. options... pass
 3. put_get... pass
 4. put_get_utf8_segment.. pass
 5. put_no_parent. pass
 6. mkcol_over_plain.. pass
 7. delete pass
 8. delete_null... pass
 9. delete_fragment... pass
10. mkcol. pass
11. mkcol_again... pass
12. delete_coll... pass
13. mkcol_no_parent... pass
14. mkcol_with_body... pass
15. finish pass
<- summary for `basic': of 16 tests run: 16 passed, 0 failed. 100.0%
-> running `copymove':
 0. init.. pass
 1. begin. pass
 2. copy_init. pass
 3. copy_simple... pass
 4. copy_overwrite pass
 5. copy_nodestcoll... pass
 6. copy_cleanup.. pass
 7. copy_coll. pass
 8. copy_shallow.. pass
 9. move.. pass
10. move_coll. pass
11. move_cleanup.. pass
12. finish pass
<- summary for `copymove': of 13 tests run: 13 passed, 0 failed. 100.0%
-> running `props':
 0. init.. pass
 1. begin. pass
 2. propfind_invalid.. pass
 3. propfind_invalid2. pass
 4. propfind_d0... pass
 5. propinit.. pass
 6. propset... FAIL (PROPPATCH on `/litmus/prop': 423 Locked)
 7. propget... SKIPPED
 8. propextended.. pass
 9. propmove.. SKIPPED
10. propget... SKIPPED
11. propdeletes... SKIPPED
12. propget... SKIPPED
13. propreplace... SKIPPED
14. propget... SKIPPED
15. propnullns SKIPPED
16. propget... SKIPPED
17. prophighunicode... SKIPPED
18. propget... SKIPPED
19. propremoveset. SKIPPED
20. propget... SKIPPED
21. propsetremove. SKIPPED
22. propget... SKIPPED
23. propvalnspace. SKIPPED
24. propwformed... pass
25. propinit.. pass
26. propmanyns FAIL (PROPPATCH on `/litmus/prop': 423 Locked)
27. propget... FAIL (No value given for property
{http://example.com/kappa}somename)
28. propcleanup... pass
29. finish pass
-> 16 tests were skipped.
<- summary for `props': of 14 tests run: 11 passed, 3 failed. 78.6%
See debug.log for network/debug traces.
make: *** [Makefile:65: check] Error 1
--
pywebdav/lib/WebDAVServer.py[2] does not implement ` def
do_PROPPATCH(self):` causing above test failures.


[1]  
https://salsa.debian.org/tryton-team/pywebdav/-/commit/e5d5acb5a18ca5e729c836c291350f239fccdcdb
[2] 
https://github.com/andrewleech/PyWebDAV3/blob/9c948c8861b7e0b01a2fe97b9f54c256d1ba458b/pywebdav/lib/WebDAVServer.py#L318



Bug#1040629: Additional information

2023-07-19 Thread Vladimir Petko
The original failure could be due to the network issue, as the tests
attempt to access the internet.



Bug#1040629: Additional information

2023-07-18 Thread Vladimir Petko
I have encountered the same error when running tests locally, but only
seen it once and could not reproduce it.

But when running a test against against pillow 10.0.0-1 the following
error occurs[1]

==
FAIL: test_process_apk (__main__.UpdateTest.test_process_apk)
--
Traceback (most recent call last):
  File "/tmp/autopkgtest.V6tBlg/build.2CL/real-tree/tests/update.TestCase",
line 949, in test_procesk
self.assertTrue(os.path.isfile(icon_path))
AssertionError: False is not true

It is already fixed upstream[2].

The attached patch contains the fix.

Thank you for considering the patch.

[1] 
https://autopkgtest.ubuntu.com/results/autopkgtest-mantic/mantic/amd64/f/fdroidserver/20230707_143232_ec734@/log.gz
[2] 
https://github.com/f-droid/fdroidserver/commit/132e953c8c9f7d709586442aee6ff474cfa8fa18
Description: do not use deprecated Image.ANTIALIAS attribute
 The ANTIALIAS alias was removed in Pillow 10.0.0:
 https://pillow.readthedocs.io/en/stable/deprecations.html
Author: Hans-Christoph Steiner 
Origin: upstream
Bug: https://github.com/f-droid/fdroidserver/commit/132e953c8c9f7d709586442aee6ff474cfa8fa18
Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1040629
Last-Update: 2023-07-19
--- a/fdroidserver/update.py
+++ b/fdroidserver/update.py
@@ -250,7 +250,7 @@
 
 if any(length > size for length in im.size):
 oldsize = im.size
-im.thumbnail((size, size), Image.ANTIALIAS)
+im.thumbnail((size, size), Image.Resampling.LANCZOS)
 logging.debug("%s was too large at %s - new size is %s" % (
 iconpath, oldsize, im.size))
 im.save(iconpath, "PNG", optimize=True,
@@ -1757,7 +1757,7 @@
 
 size = dpi_to_px(density)
 
-im.thumbnail((size, size), Image.ANTIALIAS)
+im.thumbnail((size, size), Image.Resampling.LANCZOS)
 im.save(icon_path, "PNG", optimize=True,
 pnginfo=BLANK_PNG_INFO, icc_profile=None)
 empty_densities.remove(density)


Bug#1030129: Additional information

2023-06-19 Thread Vladimir Petko
Would it be possible to consider a temporary fix[1] until all relevant
openjdk packages are updated?

[1] https://salsa.debian.org/java-team/ca-certificates-java/-/merge_requests/8