Re: Review Request 32740: Patch for KAFKA-1926
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32740/ --- (Updated April 6, 2015, 3:45 a.m.) Review request for kafka. Bugs: KAFKA-1926 https://issues.apache.org/jira/browse/KAFKA-1926 Repository: kafka Description --- Diffs (updated) - clients/src/main/java/org/apache/kafka/common/utils/Utils.java 39e8d7c95eddfe96253eca880789e904e017a96a clients/src/test/java/org/apache/kafka/common/utils/UtilsTest.java 4b706d7881769ade621032883da998a94332a568 core/src/main/scala/kafka/Kafka.scala 37de7df059829f40300aa5f920219b869f9c7f78 core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala 89fa29a882ae1f2be512e1ae469631c02adeeddb core/src/main/scala/kafka/admin/PreferredReplicaLeaderElectionCommand.scala 79b5e0aeb4af77d356f80107685cd9a7d508ef16 core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala 979992b68af3723cd229845faff81c641123bb88 core/src/main/scala/kafka/admin/TopicCommand.scala e36a9d17c9ca281deb7a40bb364c2d203a87473b core/src/main/scala/kafka/client/ClientUtils.scala ad4c9d20002135e1114a26f0696ffb0f349c8878 core/src/main/scala/kafka/cluster/Broker.scala 3933bb3d1e6b38f5ecda4548c7649f18f24772c4 core/src/main/scala/kafka/cluster/Partition.scala 6d142d645013d0f914e2c63aee7a4741986ada2f core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala 484a57f996e4d0a84bdaf1db3e87eb85fd6b503f core/src/main/scala/kafka/consumer/ConsumerIterator.scala b00a4dca0f3b618e8c6e6b9a1ec99139b3bd76e5 core/src/main/scala/kafka/consumer/PartitionAssignor.scala bc2e5b40e29659b8902b65a3234d6b53d8b1aa75 core/src/main/scala/kafka/consumer/TopicCount.scala 0954b3c3ff8b3b7a7a4095436bc9e6c494a38c37 core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala 3e8a75b6357b3432abc460adcf32db7172225ca8 core/src/main/scala/kafka/controller/ControllerChannelManager.scala fb596ba228d87c4d363d977738635b8f91c2df16 core/src/main/scala/kafka/controller/KafkaController.scala f2e62f5038c10178a09ed2c9f5a54f4d8212acdc core/src/main/scala/kafka/controller/PartitionStateMachine.scala 2f0694bc5cdfc763f4872d58bec925d0cf919da1 core/src/main/scala/kafka/controller/ReplicaStateMachine.scala 3e87e1d36f87b7dd539a474609b1c95487a4c337 core/src/main/scala/kafka/controller/TopicDeletionManager.scala e56f22d7399061a72aa67a9ee73ea4d91345c01f core/src/main/scala/kafka/log/FileMessageSet.scala b2652ddbe2f857028d5980e29a008b2c614694a3 core/src/main/scala/kafka/log/Log.scala a0745be9500e8f570184cd6909b09cec4cd9efbb core/src/main/scala/kafka/log/LogCleanerManager.scala 351824b3c9fabe0942528147bdde8cee13b63e20 core/src/main/scala/kafka/log/LogConfig.scala 8b67aee3a37765178b30d79e9e7bb882bdc89c29 core/src/main/scala/kafka/log/LogManager.scala 47d250af62c1aa53d11204a332d0684fb4217c8d core/src/main/scala/kafka/log/LogSegment.scala 02567649dd82309011ba2ac6dceda97683e4f5ed core/src/main/scala/kafka/log/OffsetIndex.scala ca82c043bb8413b1e010c40de9db1b6dae85e3ac core/src/main/scala/kafka/log/OffsetMap.scala 42cdfbb6100b5c89d86144f92f661ebd844b2132 core/src/main/scala/kafka/message/Message.scala 7ba280f955ed19685b298e1729fdf3a531d87007 core/src/main/scala/kafka/message/MessageAndMetadata.scala d693abc620aef7030f29f915604c5e172d60da0d core/src/main/scala/kafka/message/MessageWriter.scala 7eb72cbdc37de55875d8263aae5bb166d977a491 core/src/main/scala/kafka/metrics/KafkaCSVMetricsReporter.scala ea9559f822c1120e1997916190fcd597328e4965 core/src/main/scala/kafka/metrics/KafkaMetricsConfig.scala 84f6208610e09943e984b54c07b8d287945574f8 core/src/main/scala/kafka/metrics/KafkaMetricsReporter.scala 14e46244ee27c8c99f33852cf03bb907cebafa51 core/src/main/scala/kafka/network/BoundedByteBufferReceive.scala a44254564531a3fc6008da2be6c1df8bdb75ec75 core/src/main/scala/kafka/network/SocketServer.scala 0ad9057765815bcd07bb914ccc4462e65c441671 core/src/main/scala/kafka/producer/ByteArrayPartitioner.scala 6a3b02e414eb7d62cfaece3344245feac54cecda core/src/main/scala/kafka/producer/DefaultPartitioner.scala 3afb22eeb4e3b8ecf49e92bd167f2f67b8f6a961 core/src/main/scala/kafka/producer/Producer.scala e38d2fa7ec873677cc23b94092ddcd55baf1a3a2 core/src/main/scala/kafka/producer/ProducerConfig.scala 3cdf23dce3407f1770b9c6543e3a8ae8ab3ff255 core/src/main/scala/kafka/producer/async/DefaultEventHandler.scala 821901e4f434dfd9eec6eceabfc2e1e65507a57c core/src/main/scala/kafka/server/AbstractFetcherManager.scala 94aa952f6a7d3a815612e83aa804bb22c4560527 core/src/main/scala/kafka/server/AbstractFetcherThread.scala 93f67d5c4dc895274efdc891cf9d98f651cd7c0b core/src/main/scala/kafka/server/BrokerMetadataCheckpoint.scala 0e542ff0cc3eda1cbcef621e73e404c56f092862 core/src/main/scala/kafka/server/KafkaConfig.scala
Re: Review Request 32740: Patch for KAFKA-1926
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32740/#review78858 --- Thanks for the new patch. Just a couple of more minor comments. Also, we plan to commit KAFKA-1809 first. Could you rebase after that? clients/src/main/java/org/apache/kafka/common/utils/Utils.java https://reviews.apache.org/r/32740/#comment127932 It would be useful to add a wrapper method readFileAsString(String path) that uses the default Charset. Then, many callers don't have to pass in null for charset. clients/src/test/java/org/apache/kafka/common/utils/UtilsTest.java https://reviews.apache.org/r/32740/#comment127933 Do we still need to do the casting to byte[]? - Jun Rao On April 2, 2015, 2:16 a.m., Tong Li wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32740/ --- (Updated April 2, 2015, 2:16 a.m.) Review request for kafka. Bugs: KAFKA-1926 https://issues.apache.org/jira/browse/KAFKA-1926 Repository: kafka Description --- Diffs - clients/src/main/java/org/apache/kafka/common/utils/Utils.java 920b51a6c3c99639fbc9dc0656373c19fabd clients/src/test/java/org/apache/kafka/common/utils/UtilsTest.java c899813d55b9c4786adde3d840f040d6645d27c8 core/src/main/scala/kafka/Kafka.scala 37de7df059829f40300aa5f920219b869f9c7f78 core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala 89fa29a882ae1f2be512e1ae469631c02adeeddb core/src/main/scala/kafka/admin/PreferredReplicaLeaderElectionCommand.scala 79b5e0aeb4af77d356f80107685cd9a7d508ef16 core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala 979992b68af3723cd229845faff81c641123bb88 core/src/main/scala/kafka/admin/TopicCommand.scala f400b71f8444fffd3fc1d8398a283682390eba4e core/src/main/scala/kafka/client/ClientUtils.scala ebba87f0566684c796c26cb76c64b4640a5ccfde core/src/main/scala/kafka/cluster/Broker.scala 0060add008bb3bc4b0092f2173c469fce0120be6 core/src/main/scala/kafka/cluster/Partition.scala c4bf48a801007ebe7497077d2018d6dffe1677d4 core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala b9e2bea7b442a19bcebd1b350d39541a8c9dd068 core/src/main/scala/kafka/consumer/ConsumerIterator.scala b00a4dca0f3b618e8c6e6b9a1ec99139b3bd76e5 core/src/main/scala/kafka/consumer/PartitionAssignor.scala bc2e5b40e29659b8902b65a3234d6b53d8b1aa75 core/src/main/scala/kafka/consumer/TopicCount.scala 0954b3c3ff8b3b7a7a4095436bc9e6c494a38c37 core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala b1cf0db8741e384e4e4119751058ea87b2589e57 core/src/main/scala/kafka/controller/ControllerChannelManager.scala c582191636f6188c25d62a67ff0315b56f163133 core/src/main/scala/kafka/controller/KafkaController.scala 09fc46d759b74bcdad2d2a610d9c5a93ff02423f core/src/main/scala/kafka/controller/PartitionStateMachine.scala 2f0694bc5cdfc763f4872d58bec925d0cf919da1 core/src/main/scala/kafka/controller/ReplicaStateMachine.scala 3e87e1d36f87b7dd539a474609b1c95487a4c337 core/src/main/scala/kafka/controller/TopicDeletionManager.scala e56f22d7399061a72aa67a9ee73ea4d91345c01f core/src/main/scala/kafka/log/FileMessageSet.scala b2652ddbe2f857028d5980e29a008b2c614694a3 core/src/main/scala/kafka/log/Log.scala 06b8ecc5d11a1acfbaf3c693c42bf3ce5b2cd86d core/src/main/scala/kafka/log/LogCleanerManager.scala 351824b3c9fabe0942528147bdde8cee13b63e20 core/src/main/scala/kafka/log/LogConfig.scala 8b67aee3a37765178b30d79e9e7bb882bdc89c29 core/src/main/scala/kafka/log/LogManager.scala 47d250af62c1aa53d11204a332d0684fb4217c8d core/src/main/scala/kafka/log/LogSegment.scala 02567649dd82309011ba2ac6dceda97683e4f5ed core/src/main/scala/kafka/log/OffsetIndex.scala ca82c043bb8413b1e010c40de9db1b6dae85e3ac core/src/main/scala/kafka/log/OffsetMap.scala 42cdfbb6100b5c89d86144f92f661ebd844b2132 core/src/main/scala/kafka/message/Message.scala d3024807a84e104e6a28a29c957f4b964d8dd416 core/src/main/scala/kafka/message/MessageAndMetadata.scala d693abc620aef7030f29f915604c5e172d60da0d core/src/main/scala/kafka/message/MessageWriter.scala 7eb72cbdc37de55875d8263aae5bb166d977a491 core/src/main/scala/kafka/metrics/KafkaCSVMetricsReporter.scala ea9559f822c1120e1997916190fcd597328e4965 core/src/main/scala/kafka/metrics/KafkaMetricsConfig.scala 84f6208610e09943e984b54c07b8d287945574f8 core/src/main/scala/kafka/metrics/KafkaMetricsReporter.scala 14e46244ee27c8c99f33852cf03bb907cebafa51 core/src/main/scala/kafka/network/BoundedByteBufferReceive.scala a44254564531a3fc6008da2be6c1df8bdb75ec75 core/src/main/scala/kafka/network/SocketServer.scala
Re: Review Request 32740: Patch for KAFKA-1926
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32740/ --- (Updated April 2, 2015, 2:16 a.m.) Review request for kafka. Bugs: KAFKA-1926 https://issues.apache.org/jira/browse/KAFKA-1926 Repository: kafka Description --- Diffs (updated) - clients/src/main/java/org/apache/kafka/common/utils/Utils.java 920b51a6c3c99639fbc9dc0656373c19fabd clients/src/test/java/org/apache/kafka/common/utils/UtilsTest.java c899813d55b9c4786adde3d840f040d6645d27c8 core/src/main/scala/kafka/Kafka.scala 37de7df059829f40300aa5f920219b869f9c7f78 core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala 89fa29a882ae1f2be512e1ae469631c02adeeddb core/src/main/scala/kafka/admin/PreferredReplicaLeaderElectionCommand.scala 79b5e0aeb4af77d356f80107685cd9a7d508ef16 core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala 979992b68af3723cd229845faff81c641123bb88 core/src/main/scala/kafka/admin/TopicCommand.scala f400b71f8444fffd3fc1d8398a283682390eba4e core/src/main/scala/kafka/client/ClientUtils.scala ebba87f0566684c796c26cb76c64b4640a5ccfde core/src/main/scala/kafka/cluster/Broker.scala 0060add008bb3bc4b0092f2173c469fce0120be6 core/src/main/scala/kafka/cluster/Partition.scala c4bf48a801007ebe7497077d2018d6dffe1677d4 core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala b9e2bea7b442a19bcebd1b350d39541a8c9dd068 core/src/main/scala/kafka/consumer/ConsumerIterator.scala b00a4dca0f3b618e8c6e6b9a1ec99139b3bd76e5 core/src/main/scala/kafka/consumer/PartitionAssignor.scala bc2e5b40e29659b8902b65a3234d6b53d8b1aa75 core/src/main/scala/kafka/consumer/TopicCount.scala 0954b3c3ff8b3b7a7a4095436bc9e6c494a38c37 core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala b1cf0db8741e384e4e4119751058ea87b2589e57 core/src/main/scala/kafka/controller/ControllerChannelManager.scala c582191636f6188c25d62a67ff0315b56f163133 core/src/main/scala/kafka/controller/KafkaController.scala 09fc46d759b74bcdad2d2a610d9c5a93ff02423f core/src/main/scala/kafka/controller/PartitionStateMachine.scala 2f0694bc5cdfc763f4872d58bec925d0cf919da1 core/src/main/scala/kafka/controller/ReplicaStateMachine.scala 3e87e1d36f87b7dd539a474609b1c95487a4c337 core/src/main/scala/kafka/controller/TopicDeletionManager.scala e56f22d7399061a72aa67a9ee73ea4d91345c01f core/src/main/scala/kafka/log/FileMessageSet.scala b2652ddbe2f857028d5980e29a008b2c614694a3 core/src/main/scala/kafka/log/Log.scala 06b8ecc5d11a1acfbaf3c693c42bf3ce5b2cd86d core/src/main/scala/kafka/log/LogCleanerManager.scala 351824b3c9fabe0942528147bdde8cee13b63e20 core/src/main/scala/kafka/log/LogConfig.scala 8b67aee3a37765178b30d79e9e7bb882bdc89c29 core/src/main/scala/kafka/log/LogManager.scala 47d250af62c1aa53d11204a332d0684fb4217c8d core/src/main/scala/kafka/log/LogSegment.scala 02567649dd82309011ba2ac6dceda97683e4f5ed core/src/main/scala/kafka/log/OffsetIndex.scala ca82c043bb8413b1e010c40de9db1b6dae85e3ac core/src/main/scala/kafka/log/OffsetMap.scala 42cdfbb6100b5c89d86144f92f661ebd844b2132 core/src/main/scala/kafka/message/Message.scala d3024807a84e104e6a28a29c957f4b964d8dd416 core/src/main/scala/kafka/message/MessageAndMetadata.scala d693abc620aef7030f29f915604c5e172d60da0d core/src/main/scala/kafka/message/MessageWriter.scala 7eb72cbdc37de55875d8263aae5bb166d977a491 core/src/main/scala/kafka/metrics/KafkaCSVMetricsReporter.scala ea9559f822c1120e1997916190fcd597328e4965 core/src/main/scala/kafka/metrics/KafkaMetricsConfig.scala 84f6208610e09943e984b54c07b8d287945574f8 core/src/main/scala/kafka/metrics/KafkaMetricsReporter.scala 14e46244ee27c8c99f33852cf03bb907cebafa51 core/src/main/scala/kafka/network/BoundedByteBufferReceive.scala a44254564531a3fc6008da2be6c1df8bdb75ec75 core/src/main/scala/kafka/network/SocketServer.scala 76ce41aed6e04ac5ba88395c4d5008aca17f9a73 core/src/main/scala/kafka/producer/ByteArrayPartitioner.scala 6a3b02e414eb7d62cfaece3344245feac54cecda core/src/main/scala/kafka/producer/DefaultPartitioner.scala 3afb22eeb4e3b8ecf49e92bd167f2f67b8f6a961 core/src/main/scala/kafka/producer/Producer.scala e38d2fa7ec873677cc23b94092ddcd55baf1a3a2 core/src/main/scala/kafka/producer/ProducerConfig.scala 3cdf23dce3407f1770b9c6543e3a8ae8ab3ff255 core/src/main/scala/kafka/producer/async/DefaultEventHandler.scala 821901e4f434dfd9eec6eceabfc2e1e65507a57c core/src/main/scala/kafka/server/AbstractFetcherManager.scala 20c00cb8cc2351950edbc8cb1752905a0c26e79f core/src/main/scala/kafka/server/AbstractFetcherThread.scala 5d5cf5897cc37b3595f14bfe9d7cde43456bcc4b core/src/main/scala/kafka/server/BrokerMetadataCheckpoint.scala 0e542ff0cc3eda1cbcef621e73e404c56f092862 core/src/main/scala/kafka/server/KafkaConfig.scala
