Re: Fixing Wireguard spec file

2019-02-04 Thread Joe Doss

On 2/4/19 6:38 PM, Dominique Martinet wrote:

It's the second time I read wireguard would be coming in the 5.0 kernel
here - what makes you folk say that?
I certainly haven't seen anything to that extent lately and 5.0 is petty
well under way, something as big a zinc likely won't make the cut this
late.


The people that are working on WireGuard think things should be stable 
by this summer (June) so it most likely won't make 5.0 but something a 
bit after. My point is, I rather spend my efforts stabilizing the DKMS 
packages that have worked for years now, rather than change things 
totally over to using an akmod based approach. Especially with the 
possibility of having WireGuard upstream sometime this year.



(as for akmods, it's packaged as such as well in rpmfusion, and that
just works afaict)


Indeed. If those fit peoples needs, I urge them to use them.

Joe





--
Joe Doss
j...@solidadmin.com
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org


Re: Fixing Wireguard spec file

2019-02-04 Thread Dominique Martinet
Joe Doss wrote on Mon, Feb 04, 2019 at 03:43:59PM +:
> I know what akmods are and I don't have the bandwidth on my end to
> switch to them with WireGuard coming in the 5.0 kernel.


It's the second time I read wireguard would be coming in the 5.0 kernel
here - what makes you folk say that?
I certainly haven't seen anything to that extent lately and 5.0 is petty
well under way, something as big a zinc likely won't make the cut this
late.

(as for akmods, it's packaged as such as well in rpmfusion, and that
just works afaict)

-- 
Dominique
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org


Re: Fixing Wireguard spec file

2019-02-04 Thread Joe Doss
Was dkms working before you did the upgrade or was it already in a broken 
state? wireguard-dkms-0.0.20190123-2.fc29.noarch won't fix an already broken 
install, so you need to remove it and then install the new version. It should 
hopefully fix it moving forward.

I started a thread on the WireGuard mailing list to track this issue 
https://lists.zx2c4.com/pipermail/wireguard/2019-February/003851.html so please 
reply there with any feedback once the next snapshot is released. 

Thanks,
Joe
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org


Re: Fixing Wireguard spec file

2019-02-04 Thread Joe Doss
I know what akmods are and I don't have the bandwidth on my end to switch to 
them with WireGuard coming in the 5.0 kernel. 

Joe 
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org


Re: Fixing Wireguard spec file

2019-01-31 Thread Germano Massullo
Joe, I found a machine on which I can reproduce the problem. I installed
wireguard-dkms-0.0.20190123-2.fc29.noarch
on top of
wireguard-dkms-0.0.20190123-1.fc29.noarch
but the machine while running
# dkms autoinstall
still returns
Error! Could not locate dkms.conf file.
File: /var/lib/dkms/wireguard/0.0.20181218/source/dkms.conf does not exist.

Actually I am leaving this place, so I will have no longer access to
this machine for a certain amount of time
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org


Re: Fixing Wireguard spec file

2019-01-31 Thread Germano Massullo
Il giorno gio 31 gen 2019, 00:15 Joe Doss  ha scritto:

> Hey Germano,
>
> I have a working RPM that does not error out with Error! Could not locate
> dkms.conf file if you want to test it out before I push it to copr.
>


Hi Joe, I can test it on next Wireguard snapshot release, actually I cannot
reproduce an update action

>
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org


Re: Fixing Wireguard spec file

2019-01-31 Thread Fabio Valentini
On Thu, Jan 31, 2019, 00:15 Joe Doss  Hey Germano,
>
> I have a working RPM that does not error out with Error! Could not locate
> dkms.conf file if you want to test it out before I push it to copr.
>
>
> https://copr-be.cloud.fedoraproject.org/results/jdoss/wireguard-testing/fedora-29-x86_64/00852015-wireguard-dkms/wireguard-dkms-0.0.20190123-2.fc29.noarch.rpm
>
> It is an issue with DKMS as I suspected. `%post` runs before the new
> package's `%preun` and the --rpm_safe_upgrade isn't working as it should.
> https://github.com/dell/dkms/issues/25#issuecomment-360275619. I followed
> this post's suggestion and moved from %post to %posttrans and this issue no
> longer happens. It feels hacky and I might spend some more time this
> weekend trying to find a better solution. ZFS worked around it with a bunch
> of bash
> https://github.com/zfsonlinux/zfs/blob/master/rpm/generic/zfs-dkms.spec.in#L74-L102
> so that might be what we try down the road.
>

On a related note, have you looked into using akmods instead of dkms? In m
experience, it works much better, especially because it actually integrates
with the packaging system (kernel modules are built as rpm packages and
installed with dnf, whenever the kernel or the module itself is updated).

Fabio


> If anyone on the list has a better idea on how to work around this issue
> please let me know.
> ___
> devel mailing list -- devel@lists.fedoraproject.org
> To unsubscribe send an email to devel-le...@lists.fedoraproject.org
> Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives:
> https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
>
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org


Re: Fixing Wireguard spec file

2019-01-30 Thread Joe Doss
Hey Germano,

I have a working RPM that does not error out with Error! Could not locate 
dkms.conf file if you want to test it out before I push it to copr. 

https://copr-be.cloud.fedoraproject.org/results/jdoss/wireguard-testing/fedora-29-x86_64/00852015-wireguard-dkms/wireguard-dkms-0.0.20190123-2.fc29.noarch.rpm

It is an issue with DKMS as I suspected. `%post` runs before the new package's 
`%preun` and the --rpm_safe_upgrade isn't working as it should. 
https://github.com/dell/dkms/issues/25#issuecomment-360275619. I followed this 
post's suggestion and moved from %post to %posttrans and this issue no longer 
happens. It feels hacky and I might spend some more time this weekend trying to 
find a better solution. ZFS worked around it with a bunch of bash 
https://github.com/zfsonlinux/zfs/blob/master/rpm/generic/zfs-dkms.spec.in#L74-L102
  so that might be what we try down the road. 

If anyone on the list has a better idea on how to work around this issue please 
let me know. 
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org


Re: Fixing Wireguard spec file

2019-01-30 Thread Joe Doss
I am actively trying to track down why DKMS is not removing the old WireGuard 
version correctly. I suspect it is something to do with DKMS as other WireGuard 
users that use DKMS for things like ZFS 
(https://utcc.utoronto.ca/~cks/space/blog/linux/MyKernelUpdateSteps) are 
setting the same kinds of issues.

If anyone on this list has any insight on what might be the cause, please let 
me know.

Joe
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org


Re: Fixing Wireguard spec file

2019-01-29 Thread Germano Massullo
Il giorno mar 29 gen 2019 alle ore 17:39 Nicolas Chauvet
 ha scritto:
> There is a wireguard package maintained by Robert-André Mauchin on RPM
> Fusion that at least... works.

Ah I did not know that, thank you
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org


Re: Fixing Wireguard spec file

2019-01-29 Thread Nicolas Chauvet
Le mar. 29 janv. 2019 à 16:33, Germano Massullo
 a écrit :
>
> This [1] is the Wireguard spec file from upstream Copr repo [2].
> Wireguard will be included in kernel 5.0, but meanwhile we are using it as 
> dkms.
There is a wireguard package maintained by Robert-André Mauchin on RPM
Fusion that at least... works.

-- 
-

Nicolas (kwizart)
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org


Fixing Wireguard spec file

2019-01-29 Thread Germano Massullo
This [1] is the Wireguard spec file from upstream Copr repo [2].
Wireguard will be included in kernel 5.0, but meanwhile we are using it as dkms.

The only problem is that at every Wireguard upgrade, a manual action
is required.
For example now that I have installed 0.0.20190123, I have to remove the old
/var/lib/dkms/wireguard/0.0.20181218/
folder in order to let
# dkms autoinstall
work.
Otherwise I will get a
===
# dkms status
Error! Could not locate dkms.conf file.
File: /var/lib/dkms/wireguard/0.0.20181218/source/dkms.conf does not exist.
===
and wg-quick service unable to start.

Do you have any idea about how the Wireguard spec file could be fixed
in order to avoid this action having to be runned at every package
update?

Thank you

[1]: 
https://copr-be.cloud.fedoraproject.org/results/jdoss/wireguard/fedora-29-x86_64/00839061-wireguard-dkms/wireguard-dkms.spec
[2]: https://copr.fedorainfracloud.org/coprs/jdoss/wireguard/
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org