hi
صندوق النقد الدولي (I.M.F) شعبة إدارة الديون الدولية ، # 1900 ، شارع الرئيس مرحبًا بكم في عنوان البريد الإلكتروني الرسمي للمدير I.M.F. كريستالينا جورجيفا عزيزي المستفيد! لقد سمح لنا وزير الخزانة المعين حديثًا والهيئة الحاكمة للسلطة النقدية للأمم المتحدة بفحص الأموال التي لم تتم المطالبة بها والتي لطالما كانت مدينة لحكومة الأمم المتحدة ، لذلك تم اتهام مالكيها بالاحتيال. المحتالون الذين يستخدمون اسم الأمم المتحدة ، وفقًا لسجل تخزين البيانات مع عنوان البريد الإلكتروني لنظامنا أثناء التحقيق الذي أجريناه ، فإن دفعتك مدرجة في قائمة تضم 150 مستفيدًا في الفئات التالية: صندوق يانصيب غير مُسلَّم / صندوق يانصيب غير مدفوع / وراثة نقل غير مكتملة / أموال العقد. قام مسؤولو البنك الفاسد ، الذين ارتكبوا الفساد من أجل الاحتيال على أموالك ، بتأخير دفعك بشكل غير معقول ، مما أدى إلى تحملك الكثير من التكاليف وتأخير غير معقول في قبول مدفوعاتك. اختارت الأمم المتحدة وصندوق النقد الدولي (IMF) دفع جميع التعويضات لـ 150 مستفيدًا باستخدام بطاقات Visa ATM من أمريكا الشمالية وأمريكا الجنوبية والولايات المتحدة وأوروبا وآسيا وحول العالم ، حيث تتوفر تقنية الدفع العالمية هذه للمستهلكين والشركات والمؤسسات المالية. ويسمح للحكومات باستخدام العملات الرقمية بدلاً من النقد والشيكات. لقد قمنا بالترتيب لسداد مدفوعاتك باستخدام بطاقة Visa ATM وسيتم إصدارها لك وإرسالها مباشرةً إلى عنوانك عبر أي خدمات بريد سريع متاحة. بعد الاتصال بنا ، سيتم تحويل مبلغ 1،500،000.00 دولار أمريكي إلى بطاقة Visa ATM ، والتي ستسمح لك بسحب أموالك عن طريق سحب ما لا يقل عن 10،000 دولار أمريكي في اليوم من أي ماكينة صراف آلي في بلدك. بناءً على طلبك ، يمكنك زيادة الحد إلى 20،000.00 دولار في اليوم. في هذا الصدد ، يجب عليك الاتصال بإدارة المدفوعات والتحويلات الدولية وتقديم المعلومات المطلوبة من خلال: 1. اسمك الكامل .. 2. عنوانك الكامل ... 3. الجنسية 4. تاريخ الميلاد / الجنس . 5. التخصص ... 6. رقم الهاتف . 7. عنوان البريد الإلكتروني لشركتك .. 8. عنوان البريد الإلكتروني الشخصي .. لتحديد هذا الرمز (الرابط: CLIENT-966/16) ، استخدمه كموضوع للبريد الإلكتروني الخاص بك وحاول تقديم المعلومات المذكورة أعلاه إلى الموظفين التاليين لإصدار وتسليم بطاقة Visa ATM ؛ نوصيك بفتح عنوان بريد إلكتروني شخصي برقم جديد للسماح لوكيل البنك بتتبع هذه المدفوعات وتبادل الرسائل لمنع المزيد من التأخير أو التوجيه الخاطئ لأموالك. اتصل بوكيل البنك الإفريقي المتحد الآن باستخدام معلومات الاتصال أدناه: الشخص المسؤول: السيد توني إلوميلو إدارة تحويل أموال التعويضات ، جهة الاتصال بالبريد الإلكتروني لبنك إفريقيا المتحد: (mrtonyelumel...@gmail.com) نحتاج إلى رد سريع على هذا البريد الإلكتروني لتجنب المزيد من التأخير. صديقك المخلص السّيدة. كريستالينا جورجيفا ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
hi
国際通貨基金 (IMF) 国際債務管理課 ＃1900、AV.DU社長 I.M.F. ディレクターの公式電子メール アドレスへようこそ。クリスタリーナ・ゲオルギエワ 親愛なる受益者！ 新たに任命された財務長官と国連通貨当局の統治機関は、国連政府に長い間債務を負っていた未請求の資金を調査することを許可したため、所有者は詐欺で告発されました.国連の名前を使用した詐欺師。調査中のシステムの電子メール アドレスのデータ ストレージ記録によると、あなたの支払いは、次のカテゴリの 150 人の受益者のリストに含まれています。契約資金。 あなたの資金をだまし取るために汚職を犯した腐敗した銀行職員は、あなたの支払いを不当に遅らせ、あなたの側に多くの費用がかかり、あなたの支払いの受け入れが不当に遅れました.国連と国際通貨基金 (IMF) は、北米、南米、米国、ヨーロッパ、アジア、および世界中の ATM Visa カードを使用して 150 人の受益者にすべての補償を支払うことを選択しました。このグローバルな支払い技術が利用可能であるためです。消費者、企業、金融機関に。政府が現金や小切手の代わりにデジタル通貨を使用できるようにします。 ATM Visaカードを使用して支払いを行うように手配しました。カードは発行され、利用可能な宅配便サービスを介して直接住所に送られます。ご連絡後、1,500,000.00 米ドルの金額が ATM Visa カードに転送されます。これにより、お住まいの国の ATM から 1 日あたり少なくとも 10,000 米ドルを引き出すことで、お金を引き出すことができます。ご要望に応じて、1 日あたり 20,000.00 ドルまで上限を引き上げることができます。これに関して、国際支払および送金局に連絡し、要求された情報を次の方法で提供する必要があります。 1.あなたのフルネーム. 2.あなたの完全な住所 3. 国籍 . 4.生年月日・性別 5.専門性 6. 電話番号 .. 7. 御社のメールアドレス…… 8.個人のメールアドレス…… このコード (リンク: CLIENT-966/16) を識別するには、電子メールの件名として使用し、上記の情報を次の従業員に提供して ATM Visa カードの発行と配送を依頼してください。 銀行の担当者がこの支払いを追跡し、メッセージを交換して、資金のさらなる遅延や誤った方向付けを防ぐことができるように、新しい番号で個人の電子メール アドレスを開くことをお勧めします。以下の連絡先情報を使用して、ユナイテッド バンク オブ アフリカのエージェントに今すぐご連絡ください。 連絡窓口：トニー・エルメル氏 補償金送金部 United Bank of Africa 連絡先メールアドレス: ,(mrtonyelumel...@gmail.com) これ以上の遅れを避けるために、このメールへの迅速な対応が必要です。 敬具 クリスタリーナ・ゲオルギエバ夫人 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
hi
国際通貨基金 (IMF) 国際債務管理課 ＃1900、AV.DU社長 I.M.F. ディレクターの公式電子メール アドレスへようこそ。クリスタリーナ・ゲオルギエワ 親愛なる受益者！ 新たに任命された財務長官と国連通貨当局の統治機関は、国連政府に長い間債務を負っていた未請求の資金を調査することを許可したため、所有者は詐欺で告発されました.国連の名前を使用した詐欺師。調査中のシステムの電子メール アドレスのデータ ストレージ記録によると、あなたの支払いは、次のカテゴリの 150 人の受益者のリストに含まれています。契約資金。 あなたの資金をだまし取るために汚職を犯した腐敗した銀行職員は、あなたの支払いを不当に遅らせ、あなたの側に多くの費用がかかり、あなたの支払いの受け入れが不当に遅れました.国連と国際通貨基金 (IMF) は、北米、南米、米国、ヨーロッパ、アジア、および世界中の ATM Visa カードを使用して 150 人の受益者にすべての補償を支払うことを選択しました。このグローバルな支払い技術が利用可能であるためです。消費者、企業、金融機関に。政府が現金や小切手の代わりにデジタル通貨を使用できるようにします。 ATM Visaカードを使用して支払いを行うように手配しました。カードは発行され、利用可能な宅配便サービスを介して直接住所に送られます。ご連絡後、1,500,000.00 米ドルの金額が ATM Visa カードに転送されます。これにより、お住まいの国の ATM から 1 日あたり少なくとも 10,000 米ドルを引き出すことで、お金を引き出すことができます。ご要望に応じて、1 日あたり 20,000.00 ドルまで上限を引き上げることができます。これに関して、国際支払および送金局に連絡し、要求された情報を次の方法で提供する必要があります。 1.あなたのフルネーム. 2.あなたの完全な住所 3. 国籍 . 4.生年月日・性別 5.専門性 6. 電話番号 .. 7. 御社のメールアドレス…… 8.個人のメールアドレス…… このコード (リンク: CLIENT-966/16) を識別するには、電子メールの件名として使用し、上記の情報を次の従業員に提供して ATM Visa カードの発行と配送を依頼してください。 銀行の担当者がこの支払いを追跡し、メッセージを交換して、資金のさらなる遅延や誤った方向付けを防ぐことができるように、新しい番号で個人の電子メール アドレスを開くことをお勧めします。以下の連絡先情報を使用して、ユナイテッド バンク オブ アフリカのエージェントに今すぐご連絡ください。 連絡窓口：トニー・エルメル氏 補償金送金部 United Bank of Africa 連絡先メールアドレス: ,(mrtonyelumel...@gmail.com) これ以上の遅れを避けるために、このメールへの迅速な対応が必要です。 敬具 クリスタリーナ・ゲオルギエバ夫人 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Hi Dear,
Hi Dear, My name is Dr Lily William from the United States.I am a French and American nationality (dual) living in the U.S and sometimes in France for Work Purpose. I hope you consider my friend request. I will share some of my pics and more details about myself when I get your response. Thanks With love Lily ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Hi
-- Hello Dear.. How are you doing , I have been worried if you got my first message and I hope to hear from your positive response Thank You ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Hi
Greeting, I'm Anders Pedersen, from Norway. I want to know if this email is valid? Thanks. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
HI
I am Debora Kareem, I have somethings I need to share with you that have been bordering my heart, I hope you can give the permission to do that. so please am not online now so kindly contact e now with my private email addess at deborakare...@gmail.com so that i can tell you more about me ok Waiting to hear from you. Thanking you for your time. Debora ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
hi
My name is Dr Andrew Cardwell. I'm working as a Marketing Consultant/Supplier with an animal Farm Company here in England. I just glanced through your profile and decided to contact you. I wish to seek your consent for an urgent business dealing with my company. kindly get back to me for more info. Thank you! ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
hi
Hello My name is Alexander Morgan a Legal Practional and Am in need of reliable person to help me retrieve some funds belonging to my diseased client ($17.9M). The bank issue me in notice to present any of his business associate or friends to claim this funds. I had to find a foreigner who is reliable to present as his associate so that the fund will be released for our mutual benefits. Please let me know if you are interested kindly reply to: alexandermorganmorgan...@gmail.com for more specific details. Thank you. Alexander Morgan ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
hi
How are you doing today?Did you receive my message?Please let me know as soon as possible. Tony ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Hi,
Hi, How are you doing Did you receive the message i sent you.from Crystal Gloria thanks, ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Hi,
Hi, How are you doing Did you receive the message i sent you.from Crystal Gloria thanks, ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Hi
How are you doing today?Did you receive my message? Tony ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Hi
How are you doing today?Did you get my message?Please let me know. Tony ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Removing ununsed variable int lo, hi, int data and int i from comedi/drivers/dt2814.c.
On Tue, May 26, 2020 at 08:24:50PM +0530, GAURAV PATHAK wrote: > On Tue, May 26, 2020 at 05:13:46PM +0300, Dan Carpenter wrote: > > Your subject doesn't use the correct patch prefix please use. > > > > [PATCH] Staging: comedi: dt2814: remove unused assignments > > > > Please resend a v2. > > > > Correct the references to Sparse as well like Luc said. > > > > regards, > > dan carpenter > > > > Hello Dan, > Thank you for reviewing and suggesting changes. I have modified the > patch and attached it with the e-mail to keep this thread conversation. > I hope I have made the changes correctly. > No, this isn't how to send a v2 patch. https://www.google.com/search?client=firefox-b-d=how+to+send+a+v2+patch Put [PATCH v2] in the subject. Don't send patches as attachments. Put a comment after the --- cut off line: Signed-off... --- v2: Update subject and commit message. If you want to reply to the thread, that's good. Use --in-reply-to= But don't worry about it too much. Greg applies or deletes patches as soon as he sees them so either way he's not going to have the original thread in his inbox. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Removing ununsed variable int lo, hi, int data and int i from comedi/drivers/dt2814.c.
On Tue, May 26, 2020 at 05:13:46PM +0300, Dan Carpenter wrote:
> Your subject doesn't use the correct patch prefix please use.
>
> [PATCH] Staging: comedi: dt2814: remove unused assignments
>
> Please resend a v2.
>
> Correct the references to Sparse as well like Luc said.
>
> regards,
> dan carpenter
>
Hello Dan,
Thank you for reviewing and suggesting changes. I have modified the
patch and attached it with the e-mail to keep this thread conversation.
I hope I have made the changes correctly.
Thanks,
Gaurav
>From ef4a63e66fc09052c4cad808755d1142a9af7011 Mon Sep 17 00:00:00 2001
From: Gaurav Pathak
Date: Sun, 24 May 2020 17:06:16 +0530
Subject: [PATCH v2] Staging: comedi: dt2814: remove unused assignments
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Silence following compiler warning:
drivers/staging/comedi/drivers/dt2814.c: In function ‘dt2814_interrupt’:
drivers/staging/comedi/drivers/dt2814.c:193:6: warning: variable ‘data’ set but not used [-Wunused-but-set-variable]
int data;
^~~~
drivers/staging/comedi/drivers/dt2814.c: In function ‘dt2814_attach’:
drivers/staging/comedi/drivers/dt2814.c:232:6: warning: variable ‘i’ set but not used [-Wunused-but-set-variable]
int i;
^
Signed-off-by: Gaurav Pathak
---
drivers/staging/comedi/drivers/dt2814.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/drivers/staging/comedi/drivers/dt2814.c b/drivers/staging/comedi/drivers/dt2814.c
index d2c715737361..eea587d63e18 100644
--- a/drivers/staging/comedi/drivers/dt2814.c
+++ b/drivers/staging/comedi/drivers/dt2814.c
@@ -186,22 +186,15 @@ static int dt2814_ai_cmd(struct comedi_device *dev, struct comedi_subdevice *s)
static irqreturn_t dt2814_interrupt(int irq, void *d)
{
- int lo, hi;
struct comedi_device *dev = d;
struct dt2814_private *devpriv = dev->private;
struct comedi_subdevice *s = dev->read_subdev;
- int data;
if (!dev->attached) {
dev_err(dev->class_dev, "spurious interrupt\n");
return IRQ_HANDLED;
}
- hi = inb(dev->iobase + DT2814_DATA);
- lo = inb(dev->iobase + DT2814_DATA);
-
- data = (hi << 4) | (lo >> 4);
-
if (!(--devpriv->ntrig)) {
int i;
@@ -229,7 +222,6 @@ static int dt2814_attach(struct comedi_device *dev, struct comedi_devconfig *it)
struct dt2814_private *devpriv;
struct comedi_subdevice *s;
int ret;
- int i;
ret = comedi_request_region(dev, it->options[0], 0x2);
if (ret)
@@ -241,8 +233,6 @@ static int dt2814_attach(struct comedi_device *dev, struct comedi_devconfig *it)
dev_err(dev->class_dev, "reset error (fatal)\n");
return -EIO;
}
- i = inb(dev->iobase + DT2814_DATA);
- i = inb(dev->iobase + DT2814_DATA);
if (it->options[1]) {
ret = request_irq(it->options[1], dt2814_interrupt, 0,
--
2.17.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Removing ununsed variable int lo, hi, int data and int i from comedi/drivers/dt2814.c.
Your subject doesn't use the correct patch prefix please use. [PATCH] Staging: comedi: dt2814: remove unused assignments Please resend a v2. Correct the references to Sparse as well like Luc said. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Removing ununsed variable int lo, hi, int data and int i from comedi/drivers/dt2814.c.
On Sun, May 24, 2020 at 07:02:20PM +0530, GAURAV PATHAK wrote: > > For few drivers, I am getting: > > CC [M] drivers/staging/vt6656/key.o > CHECK drivers/staging/vt6656/rf.c > /usr/lib/gcc/x86_64-linux-gnu/7/include/stddef.h:417:9: warning: preprocessor > token offsetof redefined > ./include/linux/stddef.h:17:9: this was the original definition > > but I guess these are false positive, as #undef offsetof is already present > in ./include/linux/stddef.h. But there is no #undef in /usr/lib/gcc/x86_64-linux-gnu/7/include/stddef.h which seems to be sometimes included after Linux's include/linux/stddef.h -- Luc ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Removing ununsed variable int lo, hi, int data and int i from comedi/drivers/dt2814.c.
On Sun, May 24, 2020 at 06:19:22PM +0530, GAURAV PATHAK wrote: > Thanks a lot for your reply. > I am trying to run sparse on drivers/staging directory, > but I am not getting any useful warnings. > Steps that I did: > > - Referred https://www.kernel.org/doc/man-pages/linux-next.html to get > linux-next latest tag next-20200522. > - After that executed following commands: > - make mrproper; make clean; make distclean > - make defconfig > - make menuconfig (Enabled all Staging Drivers with M) > - make modules_prepare > - make C=1 M=drivers/staging (Also tried individual directories > inside staging directory e.g. make C=1 > M=drivers/staging/comedi/drivers) > > I am not getting any warning, I have attached the output in text format. > > Any pointers for finding warning using sparse in drivers/staging > directory will be helpful. I really appretiate your guidance in this > regard. Well it seems that most staging drivers have no sparse warnings at all. I only see somes in the following staging drivers: drivers/staging/isdn/ drivers/staging/kpc2000/ drivers/staging/uwb/ drivers/staging/vc04_services/ drivers/staging/wfx/ drivers/staging/wusbcore/ Your commands seems to be good but I would advice you to use 'C=2' instead of 'C=1' in order for sparse to effectively run on each input file even when the corresponding .o file already exists. The simplest to use is: - make allmodconfig - make -j8 drivers/staging/ This will just compile all the files without running sparse. So all warnings will be from the compiler. The you can run: - make C=2 drivers/staging/ which will only run sparse (and will thus be much faster). Best regards, -- Luc ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Removing ununsed variable int lo, hi, int data and int i from comedi/drivers/dt2814.c.
Nevermind, my sparse version was broken. Installed sparse 0.6.1, but
still no warnings from sparse in any of the directories in drivers staging.
E.g.:
make C=2 M=drivers/staging/sm750fb
CHECK drivers/staging/sm750fb/sm750.c
CHECK drivers/staging/sm750fb/sm750_hw.c
CHECK drivers/staging/sm750fb/sm750_accel.c
CHECK drivers/staging/sm750fb/sm750_cursor.c
CHECK drivers/staging/sm750fb/ddk750_chip.c
CHECK drivers/staging/sm750fb/ddk750_power.c
CHECK drivers/staging/sm750fb/ddk750_mode.c
CHECK drivers/staging/sm750fb/ddk750_display.c
CHECK drivers/staging/sm750fb/ddk750_swi2c.c
CHECK drivers/staging/sm750fb/ddk750_sii164.c
CHECK drivers/staging/sm750fb/ddk750_dvi.c
CHECK drivers/staging/sm750fb/ddk750_hwi2c.c
MODPOST 1 modules
For few drivers, I am getting:
CC [M] drivers/staging/vt6656/key.o
CHECK drivers/staging/vt6656/rf.c
/usr/lib/gcc/x86_64-linux-gnu/7/include/stddef.h:417:9: warning: preprocessor
token offsetof redefined
./include/linux/stddef.h:17:9: this was the original definition
but I guess these are false positive, as #undef offsetof is already present in
./include/linux/stddef.h.
On Sun, May 24, 2020 at 02:10:44PM +0200, Luc Van Oostenryck wrote:
> Hi,
>
> On Sun, May 24, 2020 at 05:06:18PM +0530, Gaurav Pathak wrote:
> > Silence following sparse warning:
> > drivers/staging/comedi/drivers/dt2814.c: In function ‘dt2814_interrupt’:
> > drivers/staging/comedi/drivers/dt2814.c:193:6: warning: variable ‘data’ set
> > but not used [-Wunused-but-set-variable]
> > int data;
> > ^~~~
> > drivers/staging/comedi/drivers/dt2814.c: In function ‘dt2814_attach’:
> > drivers/staging/comedi/drivers/dt2814.c:232:6: warning: variable ‘i’ set
> > but not used [-Wunused-but-set-variable]
> > int i;
> > ^
>
> These warnings are not from sparse but simply from the compiler.
>
> > static irqreturn_t dt2814_interrupt(int irq, void *d)
> > {
> > - int lo, hi;
> > struct comedi_device *dev = d;
> > struct dt2814_private *devpriv = dev->private;
> > struct comedi_subdevice *s = dev->read_subdev;
> > - int data;
> >
> > if (!dev->attached) {
> > dev_err(dev->class_dev, "spurious interrupt\n");
> > return IRQ_HANDLED;
> > }
> >
> > - hi = inb(dev->iobase + DT2814_DATA);
> > - lo = inb(dev->iobase + DT2814_DATA);
> > -
> > - data = (hi << 4) | (lo >> 4);
>
> OK, 'data' is unused but are these 2 'inb(dev->iobase + DT2814_DATA)'
> needed or not? I would guess that they're needed but I don't know
> this hardware.
>
> > @@ -241,8 +233,6 @@ static int dt2814_attach(struct comedi_device *dev,
> > struct comedi_devconfig *it)
> > dev_err(dev->class_dev, "reset error (fatal)\n");
> > return -EIO;
> > }
> > - i = inb(dev->iobase + DT2814_DATA);
> > - i = inb(dev->iobase + DT2814_DATA);
>
> Same here.
>
> -- Luc
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Removing ununsed variable int lo, hi, int data and int i from comedi/drivers/dt2814.c.
Hi,
On Sun, May 24, 2020 at 05:06:18PM +0530, Gaurav Pathak wrote:
> Silence following sparse warning:
> drivers/staging/comedi/drivers/dt2814.c: In function ‘dt2814_interrupt’:
> drivers/staging/comedi/drivers/dt2814.c:193:6: warning: variable ‘data’ set
> but not used [-Wunused-but-set-variable]
> int data;
> ^~~~
> drivers/staging/comedi/drivers/dt2814.c: In function ‘dt2814_attach’:
> drivers/staging/comedi/drivers/dt2814.c:232:6: warning: variable ‘i’ set but
> not used [-Wunused-but-set-variable]
> int i;
> ^
These warnings are not from sparse but simply from the compiler.
> static irqreturn_t dt2814_interrupt(int irq, void *d)
> {
> - int lo, hi;
> struct comedi_device *dev = d;
> struct dt2814_private *devpriv = dev->private;
> struct comedi_subdevice *s = dev->read_subdev;
> - int data;
>
> if (!dev->attached) {
> dev_err(dev->class_dev, "spurious interrupt\n");
> return IRQ_HANDLED;
> }
>
> - hi = inb(dev->iobase + DT2814_DATA);
> - lo = inb(dev->iobase + DT2814_DATA);
> -
> - data = (hi << 4) | (lo >> 4);
OK, 'data' is unused but are these 2 'inb(dev->iobase + DT2814_DATA)'
needed or not? I would guess that they're needed but I don't know
this hardware.
> @@ -241,8 +233,6 @@ static int dt2814_attach(struct comedi_device *dev,
> struct comedi_devconfig *it)
> dev_err(dev->class_dev, "reset error (fatal)\n");
> return -EIO;
> }
> - i = inb(dev->iobase + DT2814_DATA);
> - i = inb(dev->iobase + DT2814_DATA);
Same here.
-- Luc
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] Removing ununsed variable int lo, hi, int data and int i from comedi/drivers/dt2814.c.
Silence following sparse warning:
drivers/staging/comedi/drivers/dt2814.c: In function ‘dt2814_interrupt’:
drivers/staging/comedi/drivers/dt2814.c:193:6: warning: variable ‘data’ set but
not used [-Wunused-but-set-variable]
int data;
^~~~
drivers/staging/comedi/drivers/dt2814.c: In function ‘dt2814_attach’:
drivers/staging/comedi/drivers/dt2814.c:232:6: warning: variable ‘i’ set but
not used [-Wunused-but-set-variable]
int i;
^
Signed-off-by: Gaurav Pathak
---
drivers/staging/comedi/drivers/dt2814.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/drivers/staging/comedi/drivers/dt2814.c
b/drivers/staging/comedi/drivers/dt2814.c
index d2c715737361..eea587d63e18 100644
--- a/drivers/staging/comedi/drivers/dt2814.c
+++ b/drivers/staging/comedi/drivers/dt2814.c
@@ -186,22 +186,15 @@ static int dt2814_ai_cmd(struct comedi_device *dev,
struct comedi_subdevice *s)
static irqreturn_t dt2814_interrupt(int irq, void *d)
{
- int lo, hi;
struct comedi_device *dev = d;
struct dt2814_private *devpriv = dev->private;
struct comedi_subdevice *s = dev->read_subdev;
- int data;
if (!dev->attached) {
dev_err(dev->class_dev, "spurious interrupt\n");
return IRQ_HANDLED;
}
- hi = inb(dev->iobase + DT2814_DATA);
- lo = inb(dev->iobase + DT2814_DATA);
-
- data = (hi << 4) | (lo >> 4);
-
if (!(--devpriv->ntrig)) {
int i;
@@ -229,7 +222,6 @@ static int dt2814_attach(struct comedi_device *dev, struct
comedi_devconfig *it)
struct dt2814_private *devpriv;
struct comedi_subdevice *s;
int ret;
- int i;
ret = comedi_request_region(dev, it->options[0], 0x2);
if (ret)
@@ -241,8 +233,6 @@ static int dt2814_attach(struct comedi_device *dev, struct
comedi_devconfig *it)
dev_err(dev->class_dev, "reset error (fatal)\n");
return -EIO;
}
- i = inb(dev->iobase + DT2814_DATA);
- i = inb(dev->iobase + DT2814_DATA);
if (it->options[1]) {
ret = request_irq(it->options[1], dt2814_interrupt, 0,
--
2.17.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: comedi: dt2815: fix writing hi byte of analog output
The DT2815 analog output command is 16 bits wide, consisting of the
12-bit sample value in bits 15 to 4, the channel number in bits 3 to 1,
and a voltage or current selector in bit 0. Both bytes of the 16-bit
command need to be written in turn to a single 8-bit data register.
However, the driver currently only writes the low 8-bits. It is broken
and appears to have always been broken.
Electronic copies of the DT2815 User's Manual seem impossible to find
online, but looking at the source code, a best guess for the sequence
the driver intended to use to write the analog output command is as
follows:
1. Wait for the status register to read 0x00.
2. Write the low byte of the command to the data register.
3. Wait for the status register to read 0x80.
4. Write the high byte of the command to the data register.
Step 4 is missing from the driver. Add step 4 to (hopefully) fix the
driver.
Also add a "FIXME" comment about setting bit 0 of the low byte of the
command. Supposedly, it is used to choose between voltage output and
current output, but the current driver always sets it to 1.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/dt2815.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/comedi/drivers/dt2815.c
b/drivers/staging/comedi/drivers/dt2815.c
index 83026ba63d1c..78a7c1b3448a 100644
--- a/drivers/staging/comedi/drivers/dt2815.c
+++ b/drivers/staging/comedi/drivers/dt2815.c
@@ -92,6 +92,7 @@ static int dt2815_ao_insn(struct comedi_device *dev, struct
comedi_subdevice *s,
int ret;
for (i = 0; i < insn->n; i++) {
+ /* FIXME: lo bit 0 chooses voltage output or current output */
lo = ((data[i] & 0x0f) << 4) | (chan << 1) | 0x01;
hi = (data[i] & 0xff0) >> 4;
@@ -105,6 +106,8 @@ static int dt2815_ao_insn(struct comedi_device *dev, struct
comedi_subdevice *s,
if (ret)
return ret;
+ outb(hi, dev->iobase + DT2815_DATA);
+
devpriv->ao_readback[chan] = data[i];
}
return i;
--
2.25.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Staging: comedi: dt2815: remove set but not used variable 'hi'
On 07/04/2020 13:59, Wang Hai wrote:
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/staging/comedi/drivers/dt2815.c: In function dt2815_ao_insn:
drivers/staging/comedi/drivers/dt2815.c:91:19: warning: variable 'hi' set but
not used [-Wunused-but-set-variable]
commit d6a929b7608a ("Staging: comedi: add dt2815 driver")
involved this, remove it.
Reported-by: Hulk Robot
Signed-off-by: Wang Hai
---
drivers/staging/comedi/drivers/dt2815.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/dt2815.c
b/drivers/staging/comedi/drivers/dt2815.c
index 83026ba..bcf85ec 100644
--- a/drivers/staging/comedi/drivers/dt2815.c
+++ b/drivers/staging/comedi/drivers/dt2815.c
@@ -88,12 +88,11 @@ static int dt2815_ao_insn(struct comedi_device *dev, struct
comedi_subdevice *s,
struct dt2815_private *devpriv = dev->private;
int i;
int chan = CR_CHAN(insn->chanspec);
- unsigned int lo, hi;
+ unsigned int lo;
int ret;
for (i = 0; i < insn->n; i++) {
lo = ((data[i] & 0x0f) << 4) | (chan << 1) | 0x01;
- hi = (data[i] & 0xff0) >> 4;
ret = comedi_timeout(dev, s, insn, dt2815_ao_status, 0x00);
if (ret)
That 'hi' value should be written to the hardware, but the driver is
broken. I don't think this driver has ever been tested as working
because it has never written the 'hi' value to the hardware!
I think I know how to fix it. I'll send a patch.
--
-=( Ian Abbott || Web: www.mev.co.uk )=-
-=( MEV Ltd. is a company registered in England & Wales. )=-
-=( Registered number: 02862268. Registered address:)=-
-=( 15 West Park Road, Bramhall, STOCKPORT, SK7 3JZ, UK. )=-
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] Staging: comedi: dt2815: remove set but not used variable 'hi'
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/staging/comedi/drivers/dt2815.c: In function dt2815_ao_insn:
drivers/staging/comedi/drivers/dt2815.c:91:19: warning: variable 'hi' set but
not used [-Wunused-but-set-variable]
commit d6a929b7608a ("Staging: comedi: add dt2815 driver")
involved this, remove it.
Reported-by: Hulk Robot
Signed-off-by: Wang Hai
---
drivers/staging/comedi/drivers/dt2815.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/dt2815.c
b/drivers/staging/comedi/drivers/dt2815.c
index 83026ba..bcf85ec 100644
--- a/drivers/staging/comedi/drivers/dt2815.c
+++ b/drivers/staging/comedi/drivers/dt2815.c
@@ -88,12 +88,11 @@ static int dt2815_ao_insn(struct comedi_device *dev, struct
comedi_subdevice *s,
struct dt2815_private *devpriv = dev->private;
int i;
int chan = CR_CHAN(insn->chanspec);
- unsigned int lo, hi;
+ unsigned int lo;
int ret;
for (i = 0; i < insn->n; i++) {
lo = ((data[i] & 0x0f) << 4) | (chan << 1) | 0x01;
- hi = (data[i] & 0xff0) >> 4;
ret = comedi_timeout(dev, s, insn, dt2815_ao_status, 0x00);
if (ret)
--
1.8.3.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2 5/6] staging: comedi: Remove set but not used variable 'hi'
On Tue, Oct 08, 2019 at 01:56:49PM +0100, Ian Abbott wrote:
> On 08/10/2019 08:41, zhengbin wrote:
> > Fixes gcc '-Wunused-but-set-variable' warning:
> >
> > drivers/staging/comedi/drivers/dt2815.c: In function dt2815_ao_insn:
> > drivers/staging/comedi/drivers/dt2815.c:91:19: warning: variable hi set but
> > not used [-Wunused-but-set-variable]
> >
> > It is not used since commit d6a929b7608a ("Staging:
> > comedi: add dt2815 driver")
> >
> > Reported-by: Hulk Robot
> > Signed-off-by: zhengbin
> > ---
> > drivers/staging/comedi/drivers/dt2815.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/comedi/drivers/dt2815.c
> > b/drivers/staging/comedi/drivers/dt2815.c
> > index 83026ba..bcf85ec 100644
> > --- a/drivers/staging/comedi/drivers/dt2815.c
> > +++ b/drivers/staging/comedi/drivers/dt2815.c
> > @@ -88,12 +88,11 @@ static int dt2815_ao_insn(struct comedi_device *dev,
> > struct comedi_subdevice *s,
> > struct dt2815_private *devpriv = dev->private;
> > int i;
> > int chan = CR_CHAN(insn->chanspec);
> > - unsigned int lo, hi;
> > + unsigned int lo;
> > int ret;
> >
> > for (i = 0; i < insn->n; i++) {
> > lo = ((data[i] & 0x0f) << 4) | (chan << 1) | 0x01;
> > - hi = (data[i] & 0xff0) >> 4;
> >
> > ret = comedi_timeout(dev, s, insn, dt2815_ao_status, 0x00);
> > if (ret)
> > --
> > 2.7.4
> >
>
> There is something fishy going on in this one too. It should be writing the
> 'hi' value to the card registers.
>
> Please could you omit this patch from the series so I can investigate?
Now dropped, thanks.
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2 5/6] staging: comedi: Remove set but not used variable 'hi'
On 08/10/2019 08:41, zhengbin wrote:
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/staging/comedi/drivers/dt2815.c: In function dt2815_ao_insn:
drivers/staging/comedi/drivers/dt2815.c:91:19: warning: variable hi set but not
used [-Wunused-but-set-variable]
It is not used since commit d6a929b7608a ("Staging:
comedi: add dt2815 driver")
Reported-by: Hulk Robot
Signed-off-by: zhengbin
---
drivers/staging/comedi/drivers/dt2815.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/dt2815.c
b/drivers/staging/comedi/drivers/dt2815.c
index 83026ba..bcf85ec 100644
--- a/drivers/staging/comedi/drivers/dt2815.c
+++ b/drivers/staging/comedi/drivers/dt2815.c
@@ -88,12 +88,11 @@ static int dt2815_ao_insn(struct comedi_device *dev, struct
comedi_subdevice *s,
struct dt2815_private *devpriv = dev->private;
int i;
int chan = CR_CHAN(insn->chanspec);
- unsigned int lo, hi;
+ unsigned int lo;
int ret;
for (i = 0; i < insn->n; i++) {
lo = ((data[i] & 0x0f) << 4) | (chan << 1) | 0x01;
- hi = (data[i] & 0xff0) >> 4;
ret = comedi_timeout(dev, s, insn, dt2815_ao_status, 0x00);
if (ret)
--
2.7.4
There is something fishy going on in this one too. It should be writing
the 'hi' value to the card registers.
Please could you omit this patch from the series so I can investigate?
--
-=( Ian Abbott || Web: www.mev.co.uk )=-
-=( MEV Ltd. is a company registered in England & Wales. )=-
-=( Registered number: 02862268. Registered address:)=-
-=( 15 West Park Road, Bramhall, STOCKPORT, SK7 3JZ, UK. )=-
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2 5/6] staging: comedi: Remove set but not used variable 'hi'
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/staging/comedi/drivers/dt2815.c: In function dt2815_ao_insn:
drivers/staging/comedi/drivers/dt2815.c:91:19: warning: variable hi set but not
used [-Wunused-but-set-variable]
It is not used since commit d6a929b7608a ("Staging:
comedi: add dt2815 driver")
Reported-by: Hulk Robot
Signed-off-by: zhengbin
---
drivers/staging/comedi/drivers/dt2815.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/dt2815.c
b/drivers/staging/comedi/drivers/dt2815.c
index 83026ba..bcf85ec 100644
--- a/drivers/staging/comedi/drivers/dt2815.c
+++ b/drivers/staging/comedi/drivers/dt2815.c
@@ -88,12 +88,11 @@ static int dt2815_ao_insn(struct comedi_device *dev, struct
comedi_subdevice *s,
struct dt2815_private *devpriv = dev->private;
int i;
int chan = CR_CHAN(insn->chanspec);
- unsigned int lo, hi;
+ unsigned int lo;
int ret;
for (i = 0; i < insn->n; i++) {
lo = ((data[i] & 0x0f) << 4) | (chan << 1) | 0x01;
- hi = (data[i] & 0xff0) >> 4;
ret = comedi_timeout(dev, s, insn, dt2815_ao_status, 0x00);
if (ret)
--
2.7.4
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 5/6] staging: comedi: Remove set but not used variable 'hi'
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/staging/comedi/drivers/dt2815.c: In function dt2815_ao_insn:
drivers/staging/comedi/drivers/dt2815.c:91:19: warning: variable hi set but not
used [-Wunused-but-set-variable]
It is not used since commit d6a929b7608a ("Staging:
comedi: add dt2815 driver")
Reported-by: Hulk Robot
Signed-off-by: zhengbin
---
drivers/staging/comedi/drivers/dt2815.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/dt2815.c
b/drivers/staging/comedi/drivers/dt2815.c
index 83026ba..bcf85ec 100644
--- a/drivers/staging/comedi/drivers/dt2815.c
+++ b/drivers/staging/comedi/drivers/dt2815.c
@@ -88,12 +88,11 @@ static int dt2815_ao_insn(struct comedi_device *dev, struct
comedi_subdevice *s,
struct dt2815_private *devpriv = dev->private;
int i;
int chan = CR_CHAN(insn->chanspec);
- unsigned int lo, hi;
+ unsigned int lo;
int ret;
for (i = 0; i < insn->n; i++) {
lo = ((data[i] & 0x0f) << 4) | (chan << 1) | 0x01;
- hi = (data[i] & 0xff0) >> 4;
ret = comedi_timeout(dev, s, insn, dt2815_ao_status, 0x00);
if (ret)
--
2.7.4
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Hi dear,
Hi dear, I am still waiting for your Email response, you did receive my first email to you Respectfully Yours, Mrs Katie Huggins ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Hi dear,
Hi dear, I am still waiting for your Email response, you did receive my first email to you Respectfully Yours, Mrs Katie Huggins ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Hi
Hello, My name is Miss Eden,i saw your profile and i love it,i think we can make it together,please i will like you to email me back through my email thus;so that i will send you my picture.so that we will discuss more about my interest,I will be waiting to receive your lovely reply soon Miss Eden ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
HI
-- Greeting, once again is me Lucy Boston this is twice am contacting you please is very urgent respond to me for more details through my. Email: dr.lucybos...@gmail.com ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
HI
-- Greeting, once again is me Lucy Boston this is twice am contacting you please is very urgent respond to me for more details through my. Email: dr.lucybos...@gmail.com ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: Hi
- Original Message - Sent: Fri, 27 Jan 2017 04:59:49 -0500 (EST) Subject: Hi Attention is needed ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Hi
My dear, It's my pleasure writing to you today, I am Collins Adams by name, I am working in a bank here in Accra Ghana. I have a proposition involving the sum of $16 million USD in our bank invested by one Iraq oil dealer who died years back, the money is still in his account here, I was his account officer when he was alive, this deal will be of mutual benefit for both of us. Should you be interested kindly get back to me for us to proceed. Kind Regards Collins Adams. -- Este mensaje ha sido analizado por MailScanner en busca de virus y otros contenidos peligrosos, y se considera que está limpio. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: hi
Good day to you, Please, I'm not internet server and I don't know if it is quite safe to share this information with you on this portal without anyone else knowing about it. For this reason, I'll not disclose all for now. My Name is Marcus Cooper ,Please i have no intentions of causing you any pains, I'm seeking your assistance only on humanitarian basis.I want you to assist me ensure that my estate and money is been used for Orphanage Home Project because I decided to give alms to charity organizations, as I want this to be one of the last good deeds I do on earth and I don't care about your religion,if you are interested and you need more details,Please send your reply to this E-mail: marcus.cooper...@gmail.com Best Regards, Mr.Marcus Cooper, Please send your reply to this E-mail: marcus.cooper...@gmail.com ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 5/6] staging: comedi: addi_common.h: remove {LO, HI}WORD macros
These macros don't add any additional clarity to the addi_data drivers. Just remove them. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/addi-data/addi_common.h | 3 --- .../staging/comedi/drivers/addi-data/hwdrv_apci3120.c| 16 2 files changed, 8 insertions(+), 11 deletions(-) diff --git a/drivers/staging/comedi/drivers/addi-data/addi_common.h b/drivers/staging/comedi/drivers/addi-data/addi_common.h index 1a0bafc..0138e00 100644 --- a/drivers/staging/comedi/drivers/addi-data/addi_common.h +++ b/drivers/staging/comedi/drivers/addi-data/addi_common.h @@ -18,9 +18,6 @@ #include linux/sched.h #include linux/interrupt.h -#define LOWORD(W) (unsigned short)((W) 0x) -#define HIWORD(W) (unsigned short)(((W) 16) 0x) - #define ADDIDATA_EEPROM1 #define ADDIDATA_NO_EEPROM 0 #define ADDIDATA_93C76 93C76 diff --git a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3120.c b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3120.c index 764c8f1..bfa154d 100644 --- a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3120.c +++ b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3120.c @@ -1051,7 +1051,7 @@ static int apci3120_cyclic_ai(int mode, b_DigitalOutputRegister) 0xF0) | APCI3120_SELECT_TIMER_2_LOW_WORD; outb(b_Tmp, dev-iobase + APCI3120_TIMER_CRT0); - outw(LOWORD(ui_TimerValue2), + outw(ui_TimerValue2 0x, dev-iobase + APCI3120_TIMER_VALUE); /* Writing HIGH unsigned short */ @@ -1059,7 +1059,7 @@ static int apci3120_cyclic_ai(int mode, b_DigitalOutputRegister) 0xF0) | APCI3120_SELECT_TIMER_2_HIGH_WORD; outb(b_Tmp, dev-iobase + APCI3120_TIMER_CRT0); - outw(HIWORD(ui_TimerValue2), + outw((ui_TimerValue2 16) 0x, dev-iobase + APCI3120_TIMER_VALUE); /* (2) Reset FC_TIMER BIT Clearing timer status register */ @@ -1805,7 +1805,7 @@ static int apci3120_config_insn_timer(struct comedi_device *dev, b_DigitalOutputRegister) 0xF0) | APCI3120_SELECT_TIMER_2_LOW_WORD; outb(b_Tmp, devpriv-iobase + APCI3120_TIMER_CRT0); - outw(LOWORD(ui_Timervalue2), + outw(ui_Timervalue2 0x, devpriv-iobase + APCI3120_TIMER_VALUE); /* Writing HIGH unsigned short */ @@ -1813,7 +1813,7 @@ static int apci3120_config_insn_timer(struct comedi_device *dev, b_DigitalOutputRegister) 0xF0) | APCI3120_SELECT_TIMER_2_HIGH_WORD; outb(b_Tmp, devpriv-iobase + APCI3120_TIMER_CRT0); - outw(HIWORD(ui_Timervalue2), + outw((ui_Timervalue2 16) 0x, devpriv-iobase + APCI3120_TIMER_VALUE); /* timer2 in Timer mode enabled */ devpriv-b_Timer2Mode = APCI3120_TIMER; @@ -1841,7 +1841,7 @@ static int apci3120_config_insn_timer(struct comedi_device *dev, b_DigitalOutputRegister) 0xF0) | APCI3120_SELECT_TIMER_2_LOW_WORD; outb(b_Tmp, devpriv-iobase + APCI3120_TIMER_CRT0); - outw(LOWORD(ui_Timervalue2), + outw(ui_Timervalue2 0x, devpriv-iobase + APCI3120_TIMER_VALUE); /* Writing HIGH unsigned short */ @@ -1850,7 +1850,7 @@ static int apci3120_config_insn_timer(struct comedi_device *dev, APCI3120_SELECT_TIMER_2_HIGH_WORD; outb(b_Tmp, devpriv-iobase + APCI3120_TIMER_CRT0); - outw(HIWORD(ui_Timervalue2), + outw((ui_Timervalue2 16) 0x, devpriv-iobase + APCI3120_TIMER_VALUE); /* watchdog enabled */ devpriv-b_Timer2Mode = APCI3120_WATCHDOG; @@ -2017,7 +2017,7 @@ static int apci3120_write_insn_timer(struct comedi_device *dev, APCI3120_SELECT_TIMER_2_LOW_WORD; outb(b_Tmp, devpriv-iobase + APCI3120_TIMER_CRT0); - outw(LOWORD(ui_Timervalue2), + outw(ui_Timervalue2 0x, devpriv-iobase + APCI3120_TIMER_VALUE); /* Writing HIGH unsigned short */ @@ -2026,7 +2026,7 @@ static int apci3120_write_insn_timer(struct comedi_device *dev, APCI3120_SELECT_TIMER_2_HIGH_WORD; outb(b_Tmp, devpriv-iobase + APCI3120_TIMER_CRT0); -
