[Gluster-devel] Fwd: New Defects reported by Coverity Scan for GlusterFS
FYI,
To fix these Coverity issues , please check the below link for how to
and guidelines:
http://www.gluster.org/community/documentation/index.php/Fixing_Issues_Reported_By_Tools_For_Static_Code_Analysis#Coverity
Thanks,
Lala
Original Message
Subject:New Defects reported by Coverity Scan for GlusterFS
Date: Sun, 15 Jun 2014 23:52:47 -0700
From: scan-ad...@coverity.com
Hi,
Please find the latest report on new defect(s) introduced to GlusterFS found
with Coverity Scan.
Defect(s) Reported-by: Coverity Scan
Showing 8 of 8 defect(s)
** CID 1223039: Dereference after null check (FORWARD_NULL)
/xlators/features/changelog/src/changelog.c: 2057 in init()
** CID 1223041: Data race condition (MISSING_LOCK)
/xlators/features/snapview-server/src/snapview-server.c: 2768 in init()
** CID 1223040: Data race condition (MISSING_LOCK)
/xlators/features/snapview-server/src/snapview-server.c: 2770 in init()
** CID 1223046: Resource leak (RESOURCE_LEAK)
/xlators/features/snapview-server/src/snapview-server.c: 378 in
mgmt_get_snapinfo_cbk()
** CID 1223045: Resource leak (RESOURCE_LEAK)
/xlators/mgmt/glusterd/src/glusterd-snapshot.c: 3826 in glusterd_update_fstype()
** CID 1223044: Resource leak (RESOURCE_LEAK)
/xlators/mgmt/glusterd/src/glusterd-snapshot.c: 5503 in
glusterd_snapshot_config_commit()
** CID 1223043: Resource leak (RESOURCE_LEAK)
/xlators/mgmt/glusterd/src/glusterd-geo-rep.c: 1497 in _get_slave_status()
** CID 1223042: Resource leak (RESOURCE_LEAK)
/xlators/mgmt/glusterd/src/glusterd-geo-rep.c: 1035 in _get_status_mst_slv()
*** CID 1223039: Dereference after null check (FORWARD_NULL)
/xlators/features/changelog/src/changelog.c: 2057 in init()
2051 GF_FREE (priv-changelog_brick);
2052 GF_FREE (priv-changelog_dir);
2053 if (cond_lock_init)
2054 changelog_pthread_destroy (priv);
2055 GF_FREE (priv);
2056 }
CID 1223039: Dereference after null check (FORWARD_NULL)
Dereferencing null pointer this.
2057 this-private = NULL;
2058 } else
2059 this-private = priv;
2060
2061 return ret;
2062 }
*** CID 1223041: Data race condition (MISSING_LOCK)
/xlators/features/snapview-server/src/snapview-server.c: 2768 in init()
2762 goto out;
2763
2764 this-private = priv;
2765
2766 GF_OPTION_INIT (volname, priv-volname, str, out);
2767 pthread_mutex_init ((priv-snaplist_lock), NULL);
CID 1223041: Data race condition (MISSING_LOCK)
Accessing priv-is_snaplist_done without holding lock svs_private.snaplist_lock. Elsewhere,
priv-is_snaplist_done is accessed with svs_private.snaplist_lock held 2 out of 2 times.
2768 priv-is_snaplist_done = 0;
2769 priv-num_snaps = 0;
2770 snap_worker_resume = _gf_false;
2771
2772 /* get the list of snaps first to return to client xlator */
2773 ret = svs_get_snapshot_list (this);
*** CID 1223040: Data race condition (MISSING_LOCK)
/xlators/features/snapview-server/src/snapview-server.c: 2770 in init()
2764 this-private = priv;
2765
2766 GF_OPTION_INIT (volname, priv-volname, str, out);
2767 pthread_mutex_init ((priv-snaplist_lock), NULL);
2768 priv-is_snaplist_done = 0;
2769 priv-num_snaps = 0;
CID 1223040: Data race condition (MISSING_LOCK)
Accessing snap_worker_resume without holding lock mutex. Elsewhere,
snap_worker_resume is accessed with mutex held 3 out of 3 times.
2770 snap_worker_resume = _gf_false;
2771
2772 /* get the list of snaps first to return to client xlator */
2773 ret = svs_get_snapshot_list (this);
2774 if (ret) {
2775 gf_log (this-name, GF_LOG_ERROR,
*** CID 1223046: Resource leak (RESOURCE_LEAK)
/xlators/features/snapview-server/src/snapview-server.c: 378 in
mgmt_get_snapinfo_cbk()
372 free (rsp.op_errstr);
373
374 if (myframe)
375 SVS_STACK_DESTROY (myframe);
376
377 error_out:
CID 1223046: Resource leak (RESOURCE_LEAK)
Variable dirents going out of scope leaks the storage it points to.
378 return ret;
379 }
380
381 int
382 svs_get_snapshot_list (xlator_t *this)
383 {
Re: [Gluster-devel] [Gluster-users] GlusterFS-3.4.4 RPMs on download.gluster.org
How well does Gluster work on Pidora? Does the Raspberry Pi's limited RAM hinder it any? Thanks, Gene Liverman Systems Administrator Information Technology Services University of West Georgia ITS: Making Technology Work for You! This e-mail and any attachments may contain confidential and privileged information. If you are not the intended recipient, please notify the sender immediately by return mail, delete this message, and destroy any copies. Any dissemination or use of this information by a person other than the intended recipient is unauthorized and may be illegal or actionable by law. On Jun 16, 2014 9:25 AM, Kaleb S. KEITHLEY kkeit...@redhat.com wrote: RPMs for el5-7 (RHEL, CentOS, etc.) and Fedora (19, 20, 21/rawhide), are now available in YUM repos at http://download.gluster.org/pub/gluster/glusterfs/3.4/LATEST There are also RPMs available for Pidora 20, SLES 11sp3 and OpenSuSE 13.1. Debian and Ubuntu DPKGs should also be appearing soon. -- Kaleb ___ Gluster-users mailing list gluster-us...@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-users ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel
Re: [Gluster-devel] [Gluster-users] GlusterFS-3.4.4 RPMs on download.gluster.org
Makes sense. Thanks! -- *Gene Liverman* Systems Administrator Information Technology Services University of West Georgia glive...@westga.edu 678.839.5492 ITS: Making Technology Work for You! This e-mail and any attachments may contain confidential and privileged information. If you are not the intended recipient, please notify the sender immediately by return mail, delete this message, and destroy any copies. Any dissemination or use of this information by a person other than the intended recipient is unauthorized and may be illegal or actionable by law. On Mon, Jun 16, 2014 at 9:34 AM, Kaleb S. KEITHLEY kkeit...@redhat.com wrote: On 06/16/2014 09:31 AM, Gene Liverman wrote: How well does Gluster work on Pidora? Does the Raspberry Pi's limited RAM hinder it any? It seems to work well enough. I've heard of several people who have built clusters of pis running GlusterFS. It's certainly not going to set any speed records though. -- Kaleb ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel
[Gluster-devel] tests and umount
hi, I see that most of the tests are doing umount and these may fail sometimes because of EBUSY etc. I am wondering if we should change all of them to umount -l. Let me know if you foresee any problems. Pranith ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel
Re: [Gluster-devel] [Gluster-users] GlusterFS-3.4.4 RPMs on download.gluster.org
And, I found it myself: https://github.com/gluster/glusterfs/blob/release-3.4/doc/release-notes/3.4.4.md On Mon, Jun 16, 2014 at 11:13 PM, Alexey Zilber alexeyzil...@gmail.com wrote: Changelog? On Mon, Jun 16, 2014 at 9:24 PM, Kaleb S. KEITHLEY kkeit...@redhat.com wrote: RPMs for el5-7 (RHEL, CentOS, etc.) and Fedora (19, 20, 21/rawhide), are now available in YUM repos at http://download.gluster.org/pub/gluster/glusterfs/3.4/LATEST There are also RPMs available for Pidora 20, SLES 11sp3 and OpenSuSE 13.1. Debian and Ubuntu DPKGs should also be appearing soon. -- Kaleb ___ Gluster-users mailing list gluster-us...@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-users ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel
Re: [Gluster-devel] [Gluster-users] GlusterFS-3.4.4 RPMs on download.gluster.org
Changelog? On Mon, Jun 16, 2014 at 9:24 PM, Kaleb S. KEITHLEY kkeit...@redhat.com wrote: RPMs for el5-7 (RHEL, CentOS, etc.) and Fedora (19, 20, 21/rawhide), are now available in YUM repos at http://download.gluster.org/pub/gluster/glusterfs/3.4/LATEST There are also RPMs available for Pidora 20, SLES 11sp3 and OpenSuSE 13.1. Debian and Ubuntu DPKGs should also be appearing soon. -- Kaleb ___ Gluster-users mailing list gluster-us...@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-users ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel
Re: [Gluster-devel] tests and umount
I see that most of the tests are doing umount and these may fail sometimes because of EBUSY etc. I am wondering if we should change all of them to umount -l. Let me know if you foresee any problems. I think I'd try umount -f first. Using -l too much can cause an accumulation of zombie mounts. When I'm hacking around on my own, I sometimes have to do umount -f twice but that's always sufficient. ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel
Re: [Gluster-devel] Regression testing status report
On 14/06/2014, at 12:02 AM, Justin Clift wrote: Small update. The new rackspace-regression-2GB queue on build.gluster.org has been running all day doing regression tests: http://build.gluster.org/job/rackspace-regression-2GB/ This is going well. It's doing it's 200th regression test at the moment. :) This regression test queue has 7 slave VMs for doing the tests in parallel. These slave VM's go offline (on purpose) when they're inactive. After you submit a Gerrit CR to the queue, give it a minute and a new slave will come online and start testing your CR. Hope that helps. :) Regards and best wishes, Justin Clift -- GlusterFS - http://www.gluster.org An open source, distributed file system scaling to several petabytes, and handling thousands of clients. My personal twitter: twitter.com/realjustinclift ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel
Re: [Gluster-devel] Regression testing status report
Can't thank you enough for this :-) +100 Justin has done a lot of hard, tedious work whipping this infrastructure into better shape, and has significantly improved the project as a result. Such efforts deserve to be recognized. Justin, I owe you a beer. ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel
Re: [Gluster-devel] Regression testing status report
On 16/06/2014, at 4:50 PM, Jeff Darcy wrote: Can't thank you enough for this :-) +100 Justin has done a lot of hard, tedious work whipping this infrastructure into better shape, and has significantly improved the project as a result. Such efforts deserve to be recognized. Justin, I owe you a beer. Written thanks to my manager are definitely welcome: :D Daniel Veillard veill...@redhat.com Just saying. ;) + Justin -- GlusterFS - http://www.gluster.org An open source, distributed file system scaling to several petabytes, and handling thousands of clients. My personal twitter: twitter.com/realjustinclift ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel
Re: [Gluster-devel] Regression testing status report
On 06/16/2014 09:24 PM, Justin Clift wrote: On 16/06/2014, at 4:50 PM, Jeff Darcy wrote: Can't thank you enough for this :-) +100 Justin has done a lot of hard, tedious work whipping this infrastructure into better shape, and has significantly improved the project as a result. Such efforts deserve to be recognized. Justin, I owe you a beer. Written thanks to my manager are definitely welcome: :D Daniel Veillard veill...@redhat.com Just saying. ;) Done. + Justin -- GlusterFS - http://www.gluster.org An open source, distributed file system scaling to several petabytes, and handling thousands of clients. My personal twitter: twitter.com/realjustinclift ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel
