Re: [Gluster-devel] Patches to be merged before 3.6 branching
I need reviews here to get these changes in for 3.6 , La FreeBSD - http://review.gluster.com/#/c/8246/ On Tue, Jul 15, 2014 at 1:32 AM, Soumya Koduri skod...@redhat.com wrote: Hi Vijay, I suggest below patch to be merged - http://review.gluster.org/#/c/7976/ Its not a critical one but fixes an issue with gfid-healing in the libgfapi path. Thanks, Soumya On 07/14/2014 07:33 PM, Vijay Bellur wrote: Hi All, I intend creating the 3.6 branch tomorrow. After that, the branch will be restricted to bug fixes only. If you have any major patches to be reviewed and merged for release-3.6, please update this thread. Thanks, Vijay ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel -- Religious confuse piety with mere ritual, the virtuous confuse regulation with outcomes ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel
Re: [Gluster-devel] Patches to be merged before 3.6 branching
Also for fuse_readlink bug from MacOSX testing - http://review.gluster.com/#/c/8300/ On Tue, Jul 15, 2014 at 1:46 AM, Harshavardhana har...@harshavardhana.net wrote: I need reviews here to get these changes in for 3.6 , La FreeBSD - http://review.gluster.com/#/c/8246/ On Tue, Jul 15, 2014 at 1:32 AM, Soumya Koduri skod...@redhat.com wrote: Hi Vijay, I suggest below patch to be merged - http://review.gluster.org/#/c/7976/ Its not a critical one but fixes an issue with gfid-healing in the libgfapi path. Thanks, Soumya On 07/14/2014 07:33 PM, Vijay Bellur wrote: Hi All, I intend creating the 3.6 branch tomorrow. After that, the branch will be restricted to bug fixes only. If you have any major patches to be reviewed and merged for release-3.6, please update this thread. Thanks, Vijay ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel -- Religious confuse piety with mere ritual, the virtuous confuse regulation with outcomes -- Religious confuse piety with mere ritual, the virtuous confuse regulation with outcomes ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel
Re: [Gluster-devel] Patches to be merged before 3.6 branching
On Mon, Jul 14, 2014 at 06:05:25PM +0100, Justin Clift wrote: On 14/07/2014, at 4:20 PM, Anders Blomdell wrote: On 2014-07-14 16:03, Vijay Bellur wrote: Hi All, I intend creating the 3.6 branch tomorrow. After that, the branch will be restricted to bug fixes only. If you have any major patches to be reviewed and merged for release-3.6, please update this thread. Does this mean that https://bugzilla.redhat.com/show_bug.cgi?id=1113050 has no chance to get in (no patch for that yet, still trying to figure out how things work inside gluster)? Sounds like that would be a bug fix, so it'd get applied to everything that it makes sense too. eg likely 3.6, 3.5, 3.7dev, etc. Indeed, if there is no patch available when release-3.6 gets branched, bug fixes and (serious) usability improvements can get backported to the 3.6 version. The process to do so has been documented here: - http://www.gluster.org/community/documentation/index.php/Backport_Guidelines When the branching happened, the 3.6 release will be closed for new feature enhancements. The goal is to stabilize the branch and not introduce any complex/major changes anymore. Vijay will likely mention this in his announcement of the release-3.6 branch too. There can be a thin line between 'usability bug' and 'feature'. If an acceptable case is made for an improvement, I doubt it will have difficulties getting included in any of the stable branches. snip And I would really like to get http://review.gluster.org/8292, IPv6 support. Niels, have you had a change to look at this? Should we get this merged, and fix any bugs that turn up later? No, and unfortunately I will unlikely be able to look into that within the next few weeks. I'd really like to see good IPv6 support in Gluster, but for me it really is a long-term goal. Maybe the 'better peer identification' feature improves IPv6 support as well. Some details and further pointers to discussions about it can be found here: - http://www.gluster.org/community/documentation/index.php/Features/Better_peer_identification Niels ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel
[Gluster-devel] libgfapi + qemu compatibility job
Hi All, The libgfapi qemu compatibility check is active on review.gluster.org via GlusterBuildSystem2 ,(rhs-client34.lab.eng.blr.redhat.com . The review votes are skipped for 'success' and -1 has set for failure. Please let us know if you have any questions. --Humble ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel
[Gluster-devel] Is gerrit/jenkins integration sick?
I'm getting http://review.gluster.org/#/c/8291/: Patch Set 5: Build Successful http://rhs-client34.lab.eng.blr.redhat.com:8080/job/libgfapi-qemu/322/ : SUCCESS (skipped) http://review.gluster.org/#/c/8299/: Patch Set 6: Verified-1 Build Failed http://rhs-client34.lab.eng.blr.redhat.com:8080/job/libgfapi-qemu/323/ : FAILURE How do I debug these? /Anders -- Anders Blomdell Email: anders.blomd...@control.lth.se Department of Automatic Control Lund University Phone:+46 46 222 4625 P.O. Box 118 Fax: +46 46 138118 SE-221 00 Lund, Sweden ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel
Re: [Gluster-devel] Is gerrit/jenkins integration sick?
Hi Anders, Looks to be an issue generated when GlusterBuildSystem2 tries to connect review.gluster.org , I am trying to sort this out. --Humble On Tue, Jul 15, 2014 at 4:14 PM, Anders Blomdell anders.blomd...@control.lth.se wrote: I'm getting http://review.gluster.org/#/c/8291/: Patch Set 5: Build Successful http://rhs-client34.lab.eng.blr.redhat.com:8080/job/libgfapi-qemu/322/ : SUCCESS (skipped) http://review.gluster.org/#/c/8299/: Patch Set 6: Verified-1 Build Failed http://rhs-client34.lab.eng.blr.redhat.com:8080/job/libgfapi-qemu/323/ : FAILURE How do I debug these? /Anders -- Anders Blomdell Email: anders.blomd...@control.lth.se Department of Automatic Control Lund University Phone:+46 46 222 4625 P.O. Box 118 Fax: +46 46 138118 SE-221 00 Lund, Sweden ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel
[Gluster-devel] Developer Documentation for datastructures in gluster
hi, Please respond if you guys volunteer to add documentation for any of the following things that are not already taken. client_t - pranith integration with statedump - pranith mempool - Pranith event-hostory + circ-buff - Raghavendra Bhat inode - Raghavendra Bhat call-stub fd iobuf graph xlator option-framework rbthash runner-framework stack/frame strfd timer store gid-cache(source is heavily documented) dict event-poll Pranith ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel
Re: [Gluster-devel] Developer Documentation for datastructures in gluster
What do you mean by 'option-framework'? Is it the xlator options table that we have in each xlator? Or the glusterd volume set framework (which requires the xlator options tables to function anyway)? On Tue, Jul 15, 2014 at 4:39 PM, Pranith Kumar Karampuri pkara...@redhat.com wrote: hi, Please respond if you guys volunteer to add documentation for any of the following things that are not already taken. client_t - pranith integration with statedump - pranith mempool - Pranith event-hostory + circ-buff - Raghavendra Bhat inode - Raghavendra Bhat call-stub fd iobuf graph xlator option-framework rbthash runner-framework stack/frame strfd timer store gid-cache(source is heavily documented) dict event-poll Pranith ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel
Re: [Gluster-devel] Developer Documentation for datastructures in gluster
On 07/15/2014 04:47 PM, Kaushal M wrote: What do you mean by 'option-framework'? Is it the xlator options table that we have in each xlator? Or the glusterd volume set framework (which requires the xlator options tables to function anyway)? options.c in libglusterfs Pranith On Tue, Jul 15, 2014 at 4:39 PM, Pranith Kumar Karampuri pkara...@redhat.com wrote: hi, Please respond if you guys volunteer to add documentation for any of the following things that are not already taken. client_t - pranith integration with statedump - pranith mempool - Pranith event-hostory + circ-buff - Raghavendra Bhat inode - Raghavendra Bhat call-stub fd iobuf graph xlator option-framework rbthash runner-framework stack/frame strfd timer store gid-cache(source is heavily documented) dict event-poll Pranith ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel
Re: [Gluster-devel] libgfapi + qemu compatibility job
Yes, its not possible to monitor from outside RH network. We are planning to move this to one of the public servers. Till then please report the issues , if any . I will take care of it.. --Humble On Tue, Jul 15, 2014 at 4:11 PM, Kaushal M kshlms...@gmail.com wrote: That machine is not accessible from the outside the Red Hat internal network. How would users who are not on the internal network be able to look at the jobs? ~kaushal On Tue, Jul 15, 2014 at 3:54 PM, Humble Devassy Chirammal humble.deva...@gmail.com wrote: Hi All, The libgfapi qemu compatibility check is active on review.gluster.org via GlusterBuildSystem2 ,(rhs-client34.lab.eng.blr.redhat.com . The review votes are skipped for 'success' and -1 has set for failure. Please let us know if you have any questions. --Humble ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel
Re: [Gluster-devel] Developer Documentation for datastructures in gluster
On 15/07/2014, at 1:45 PM, Jeff Darcy wrote: Please respond if you guys volunteer to add documentation for any of the following things that are not already taken. I think the most important thing to describe for each of these is the life cycle rules. When I've tried to teach people about translators, one of the biggest stumbling blocks has been the question of what gets freed after the fop, what gets freed after the callback, and what lives on even longer. There are different rules for dict_t, loc_t, inode_t, etc. Dict_set_*str is one of the worst offenders; even after all this time, I have to go back and re-check which variants do what when the dict itself is freed. If the only thing that comes out of this effort is greater clarity regarding what should be freed when, it will be worth it. +1 :) -- GlusterFS - http://www.gluster.org An open source, distributed file system scaling to several petabytes, and handling thousands of clients. My personal twitter: twitter.com/realjustinclift ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel
[Gluster-devel] Verfification failure on GlusterBuildSystem2
What can I do about this one http://review.gluster.org/#/c/8299/? -- Anders Blomdell Email: anders.blomd...@control.lth.se Department of Automatic Control Lund University Phone:+46 46 222 4625 P.O. Box 118 Fax: +46 46 138118 SE-221 00 Lund, Sweden ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel
Re: [Gluster-devel] Developer Documentation for datastructures in gluster
On Tue, Jul 15, 2014 at 08:45:45AM -0400, Jeff Darcy wrote: Please respond if you guys volunteer to add documentation for any of the following things that are not already taken. I think the most important thing to describe for each of these is the life cycle rules. When I've tried to teach people about translators, one of the biggest stumbling blocks has been the question of what gets freed after the fop, what gets freed after the callback, and what lives on even longer. There are different rules for dict_t, loc_t, inode_t, etc. Dict_set_*str is one of the worst offenders; even after all this time, I have to go back and re-check which variants do what when the dict itself is freed. If the only thing that comes out of this effort is greater clarity regarding what should be freed when, it will be worth it. client_t - pranith integration with statedump - pranith mempool - Pranith event-hostory + circ-buff - Raghavendra Bhat inode - Raghavendra Bhat call-stub fd iobuf graph xlator option-framework rbthash runner-framework stack/frame strfd timer store gid-cache(source is heavily documented) dict event-poll My Translator 101 series already covers xlators and call frames, so I might as well continue with those. Can you make these available in MarkDown format somewhere under the docs/ directory? Thanks, Niels ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel
Re: [Gluster-devel] Patches to be merged before 3.6 branching
On 2014-07-15 11:30, Niels de Vos wrote: On Mon, Jul 14, 2014 at 06:05:25PM +0100, Justin Clift wrote: On 14/07/2014, at 4:20 PM, Anders Blomdell wrote: On 2014-07-14 16:03, Vijay Bellur wrote: Hi All, I intend creating the 3.6 branch tomorrow. After that, the branch will be restricted to bug fixes only. If you have any major patches to be reviewed and merged for release-3.6, please update this thread. Does this mean that https://bugzilla.redhat.com/show_bug.cgi?id=1113050 has no chance to get in (no patch for that yet, still trying to figure out how things work inside gluster)? Sounds like that would be a bug fix, so it'd get applied to everything that it makes sense too. eg likely 3.6, 3.5, 3.7dev, etc. Indeed, if there is no patch available when release-3.6 gets branched, bug fixes and (serious) usability improvements can get backported to the 3.6 version. The process to do so has been documented here: - http://www.gluster.org/community/documentation/index.php/Backport_Guidelines When the branching happened, the 3.6 release will be closed for new feature enhancements. The goal is to stabilize the branch and not introduce any complex/major changes anymore. Vijay will likely mention this in his announcement of the release-3.6 branch too. There can be a thin line between 'usability bug' and 'feature'. If an acceptable case is made for an improvement, I doubt it will have difficulties getting included in any of the stable branches. snip And I would really like to get http://review.gluster.org/8292, IPv6 support. Niels, have you had a change to look at this? Should we get this merged, and fix any bugs that turn up later? No, and unfortunately I will unlikely be able to look into that within the next few weeks. I'd really like to see good IPv6 support in Gluster, but for me it really is a long-term goal. OK, will have to keep my own version here then (some of my hosts are IPv6 only) since the current state of affairs, where you have to edit a lot of volfiles, etc in order to get it working is far too cumbersome. Maybe the 'better peer identification' feature improves IPv6 support as well. Some details and further pointers to discussions about it can be found here: - http://www.gluster.org/community/documentation/index.php/Features/Better_peer_identification Very little IPv6 there, but very useful for multi-homed machines (which I also want, but not as badly). /Anders -- Anders Blomdell Email: anders.blomd...@control.lth.se Department of Automatic Control Lund University Phone:+46 46 222 4625 P.O. Box 118 Fax: +46 46 138118 SE-221 00 Lund, Sweden ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel
Re: [Gluster-devel] Developer Documentation for datastructures in gluster
On 07/15/2014 07:22 PM, Niels de Vos wrote: On Tue, Jul 15, 2014 at 08:45:45AM -0400, Jeff Darcy wrote: Please respond if you guys volunteer to add documentation for any of the following things that are not already taken. I think the most important thing to describe for each of these is the life cycle rules. When I've tried to teach people about translators, one of the biggest stumbling blocks has been the question of what gets freed after the fop, what gets freed after the callback, and what lives on even longer. There are different rules for dict_t, loc_t, inode_t, etc. Dict_set_*str is one of the worst offenders; even after all this time, I have to go back and re-check which variants do what when the dict itself is freed. If the only thing that comes out of this effort is greater clarity regarding what should be freed when, it will be worth it. client_t - pranith integration with statedump - pranith mempool - Pranith event-hostory + circ-buff - Raghavendra Bhat inode - Raghavendra Bhat call-stub fd iobuf graph xlator option-framework rbthash runner-framework stack/frame strfd timer store gid-cache(source is heavily documented) dict event-poll My Translator 101 series already covers xlators and call frames, so I might as well continue with those. Can you make these available in MarkDown format somewhere under the docs/ directory? Oops sorry. That is what we are going to do. Send patches :-). Pranith. Thanks, Niels ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel
[Gluster-devel] spurious regression failures again!
hi, We have 4 tests failing once in a while causing problems: 1) tests/bugs/bug-1087198.t - Author: Varun 2) tests/basic/mgmt_v3-locks.t - Author: Avra 3) tests/basic/fops-sanity.t - Author: Pranith Please take a look at them and post updates. Pranith ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel
Re: [Gluster-devel] spurious regression failures again!
Hi Pranith, Could you please share the link of the console output of the failures. Regards, Joe - Original Message - From: Pranith Kumar Karampuri pkara...@redhat.com To: Gluster Devel gluster-devel@gluster.org, Varun Shastry vshas...@redhat.com Sent: Tuesday, July 15, 2014 8:52:44 PM Subject: [Gluster-devel] spurious regression failures again! hi, We have 4 tests failing once in a while causing problems: 1) tests/bugs/bug-1087198.t - Author: Varun 2) tests/basic/mgmt_v3-locks.t - Author: Avra 3) tests/basic/fops-sanity.t - Author: Pranith Please take a look at them and post updates. Pranith ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel
[Gluster-devel] Fwd: New Defects reported by Coverity Scan for GlusterFS
To fix these Coverity issues , please check the below link for guidelines:
http://www.gluster.org/community/documentation/index.php/Fixing_Issues_Reported_By_Tools_For_Static_Code_Analysis#Coverity
Thanks,
Lala
Original Message
Subject:New Defects reported by Coverity Scan for GlusterFS
Date: Mon, 14 Jul 2014 23:47:00 -0700
From: scan-ad...@coverity.com
Hi,
Please find the latest report on new defect(s) introduced to GlusterFS found
with Coverity Scan.
Defect(s) Reported-by: Coverity Scan
Showing 20 of 23 defect(s)
** CID 1226162: Logically dead code (DEADCODE)
/xlators/cluster/ec/src/ec-method.c: 119 in ec_method_decode()
** CID 1226164: Division or modulo by zero (DIVIDE_BY_ZERO)
/xlators/cluster/dht/src/dht-selfheal.c: 1068 in
dht_selfheal_layout_new_directory()
** CID 1226163: Division or modulo by zero (DIVIDE_BY_ZERO)
/xlators/cluster/dht/src/dht-selfheal.c: 1062 in
dht_selfheal_layout_new_directory()
** CID 1226165: Null pointer dereference (FORWARD_NULL)
/libglusterfs/src/client_t.c: 294 in gf_client_get()
/libglusterfs/src/client_t.c: 294 in gf_client_get()
** CID 1226177: Missing break in switch (MISSING_BREAK)
/xlators/cluster/ec/src/ec-dir-write.c: 181 in ec_manager_create()
** CID 1226176: Missing break in switch (MISSING_BREAK)
/xlators/cluster/ec/src/ec-generic.c: 911 in ec_manager_lookup()
** CID 1226175: Missing break in switch (MISSING_BREAK)
/xlators/cluster/ec/src/ec-inode-read.c: 671 in ec_manager_open()
** CID 1226174: Missing break in switch (MISSING_BREAK)
/xlators/cluster/ec/src/ec-inode-write.c: 1366 in ec_manager_truncate()
** CID 1226173: Missing break in switch (MISSING_BREAK)
/xlators/cluster/ec/src/ec-inode-write.c: 2022 in ec_manager_writev()
** CID 1226172: Missing break in switch (MISSING_BREAK)
/xlators/cluster/ec/src/ec-locks.c: 218 in ec_manager_entrylk()
** CID 1226171: Missing break in switch (MISSING_BREAK)
/xlators/cluster/ec/src/ec-locks.c: 649 in ec_manager_inodelk()
** CID 1226170: Missing break in switch (MISSING_BREAK)
/xlators/cluster/ec/src/ec-locks.c: 1134 in ec_manager_lk()
** CID 1226169: Missing break in switch (MISSING_BREAK)
/xlators/cluster/ec/src/ec-inode-read.c: 1239 in ec_manager_readv()
** CID 1226168: Missing break in switch (MISSING_BREAK)
/xlators/cluster/ec/src/ec-dir-read.c: 366 in ec_manager_readdir()
** CID 1226167: Missing break in switch (MISSING_BREAK)
/xlators/cluster/ec/src/ec-heal.c: 1164 in ec_manager_heal()
** CID 1226166: Missing break in switch (MISSING_BREAK)
/xlators/cluster/ec/src/ec-heal.c: 1224 in ec_manager_heal()
** CID 1226180: Data race condition (MISSING_LOCK)
/xlators/cluster/ec/src/ec-heal.c: 945 in ec_heal_needs_data_rebuild()
** CID 1226179: Data race condition (MISSING_LOCK)
/xlators/cluster/ec/src/ec-heal.c: 94 in ec_heal_lookup_resume()
** CID 1226178: Data race condition (MISSING_LOCK)
/xlators/cluster/ec/src/ec-heal.c: 93 in ec_heal_lookup_resume()
** CID 1226181: Thread deadlock (ORDER_REVERSAL)
/xlators/cluster/ec/src/ec-heal.c: 458 in ec_heal_init()
*** CID 1226162: Logically dead code (DEADCODE)
/xlators/cluster/ec/src/ec-method.c: 119 in ec_method_decode()
113 }
114 k = 0;
115 for (i = 0; i columns; i++)
116 {
117 while ((mask 1) != 0)
118 {
CID 1226162: Logically dead code (DEADCODE)
Execution cannot reach this statement k++;.
119 k++;
120 mask = 1;
121 }
122 mtx[k][columns - 1] = 1;
123 for (j = columns - 1; j 0; j--)
124 {
*** CID 1226164: Division or modulo by zero (DIVIDE_BY_ZERO)
/xlators/cluster/dht/src/dht-selfheal.c: 1068 in
dht_selfheal_layout_new_directory()
1062 chunk = ((unsigned long) 0x) / total_size;
1063 gf_log (this-name, GF_LOG_INFO,
1064 chunk size = 0x / %u = 0x%x,
1065 total_size, chunk);
1066 }
1067 else {
CID 1226164: Division or modulo by zero (DIVIDE_BY_ZERO)
In expression 4294967295UL / bricks_used, division by expression
bricks_used which may be zero has undefined behavior.
1068 chunk = ((unsigned long) 0x) / bricks_used;
1069 }
1070
1071 start_subvol = dht_selfheal_layout_alloc_start (this, loc,
layout);
1072
1073 /* clear out the range, as we are re-computing here */
*** CID 1226163: Division or modulo by zero (DIVIDE_BY_ZERO)
/xlators/cluster/dht/src/dht-selfheal.c: 1062 in
