Re: freeze break request enable koji-gc on fedora 23 and 24 keys and install git-email on batcave

[Pierre-Yves Chibon]

On Wed, Oct 21, 2015 at 09:01:29PM -0500, Dennis Gilmore wrote:
> I wanted to run git send-email to send the koji-gc patch for review and found 
> it was not installed so here is two patches 

The ansible repo being public, you can clone it on your machine and send the
emails from there.

That being said +1 for both patches


Pierre


> From 4297c458ff7a3ea673f2835cf73d2da78d61feca Mon Sep 17 00:00:00 2001
> From: Dennis Gilmore 
> Date: Thu, 22 Oct 2015 01:54:21 +
> Subject: [PATCH 1/2] koji-gc: enable kojigc on fedora 23 and 24 keys
> 
> Signed-off-by: Dennis Gilmore 
> ---
>  roles/koji_hub/files/koji-gc.conf | 6 ++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/roles/koji_hub/files/koji-gc.conf b/roles/koji_hub/files/koji-
> gc.conf
> index 7680be9..525c9b7 100644
> --- a/roles/koji_hub/files/koji-gc.conf
> +++ b/roles/koji_hub/files/koji-gc.conf
> @@ -23,6 +23,8 @@ key_aliases =
>  246110C1fedora-20
>  95A43F54fedora-21
>  8E1431D5fedora-22
> +34EC9CBAfedora-23
> +81B46521fedora-24
>  217521F6fedora-epel
>  0608B895fedora-epel-6
>  352C64E5fedora-epel-7
> @@ -36,6 +38,8 @@ unprotected_keys =
>  fedora-20
>  fedora-21
>  fedora-22
> +fedora-23
> +fedora-24
>  fedora-extras
>  redhat-beta
>  fedora-epel
> @@ -68,6 +72,8 @@ policy =
>  sig fedora-20 && age < 12 weeks :: keep
>  sig fedora-21 && age < 12 weeks :: keep
>  sig fedora-22 && age < 12 weeks :: keep
> +sig fedora-23 && age < 12 weeks :: keep
> +sig fedora-24 && age < 12 weeks :: keep
>  sig fedora-epel && age < 12 weeks :: keep
>  sig fedora-epel-6 && age < 12 weeks :: keep
>  sig fedora-epel-7 && age < 12 weeks :: keep
> -- 
> 1.8.3.1
> 
> From 1945487a35859176d360e7ce937cd14d21f2260e Mon Sep 17 00:00:00 2001
> From: Dennis Gilmore 
> Date: Thu, 22 Oct 2015 01:58:09 +
> Subject: [PATCH 2/2] add git-email on batcave in order to send out patches for
>  review
> 
> Signed-off-by: Dennis Gilmore 
> ---
>  roles/batcave/tasks/main.yml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/roles/batcave/tasks/main.yml b/roles/batcave/tasks/main.yml
> index f83ebd7..0dccad8 100644
> --- a/roles/batcave/tasks/main.yml
> +++ b/roles/batcave/tasks/main.yml
> @@ -33,6 +33,7 @@
>- unzip # general useful util
>- fpaste# general useful util
>- lftp  # needed to easily pull in builds from koji 
> for 
> internal repos
> +  - git-email # needed to send patches for review to the 
> mailing list
>tags:
>- batcave
>- config


pgpkiCm0CA9_P.pgp
Description: PGP signature
___
infrastructure mailing list
infrastructure@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/infrastructure@lists.fedoraproject.org

Re: freeze break request enable koji-gc on fedora 23 and 24 keys and install git-email on batcave

[Patrick Uiterwijk]

> I wanted to run git send-email to send the koji-gc patch for review and found
> it was not installed so here is two patches
> 
> Dennnis
> 
> From 4297c458ff7a3ea673f2835cf73d2da78d61feca Mon Sep 17 00:00:00 2001
> From: Dennis Gilmore 
> Date: Thu, 22 Oct 2015 01:54:21 +
> Subject: [PATCH 1/2] koji-gc: enable kojigc on fedora 23 and 24 keys
> 
> Signed-off-by: Dennis Gilmore 
> ---
>  roles/koji_hub/files/koji-gc.conf | 6 ++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/roles/koji_hub/files/koji-gc.conf b/roles/koji_hub/files/koji-
> gc.conf
> index 7680be9..525c9b7 100644
> --- a/roles/koji_hub/files/koji-gc.conf
> +++ b/roles/koji_hub/files/koji-gc.conf
> @@ -23,6 +23,8 @@ key_aliases =
>  246110C1fedora-20
>  95A43F54fedora-21
>  8E1431D5fedora-22
> +34EC9CBAfedora-23
> +81B46521fedora-24
>  217521F6fedora-epel
>  0608B895fedora-epel-6
>  352C64E5fedora-epel-7
> @@ -36,6 +38,8 @@ unprotected_keys =
>  fedora-20
>  fedora-21
>  fedora-22
> +fedora-23
> +fedora-24
>  fedora-extras
>  redhat-beta
>  fedora-epel
> @@ -68,6 +72,8 @@ policy =
>  sig fedora-20 && age < 12 weeks :: keep
>  sig fedora-21 && age < 12 weeks :: keep
>  sig fedora-22 && age < 12 weeks :: keep
> +sig fedora-23 && age < 12 weeks :: keep
> +sig fedora-24 && age < 12 weeks :: keep
>  sig fedora-epel && age < 12 weeks :: keep
>  sig fedora-epel-6 && age < 12 weeks :: keep
>  sig fedora-epel-7 && age < 12 weeks :: keep
> --
> 1.8.3.1
> 
> From 1945487a35859176d360e7ce937cd14d21f2260e Mon Sep 17 00:00:00 2001
> From: Dennis Gilmore 
> Date: Thu, 22 Oct 2015 01:58:09 +
> Subject: [PATCH 2/2] add git-email on batcave in order to send out patches
> for
>  review
> 
> Signed-off-by: Dennis Gilmore 
> ---
>  roles/batcave/tasks/main.yml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/roles/batcave/tasks/main.yml b/roles/batcave/tasks/main.yml
> index f83ebd7..0dccad8 100644
> --- a/roles/batcave/tasks/main.yml
> +++ b/roles/batcave/tasks/main.yml
> @@ -33,6 +33,7 @@
>- unzip # general useful util
>- fpaste# general useful util
>- lftp  # needed to easily pull in builds from koji
>for
> internal repos
> +  - git-email # needed to send patches for review to the
> mailing list
>tags:
>- batcave
>- config
> --
> 1.8.3.1
> 
> 

+1 on both.
___
infrastructure mailing list
infrastructure@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/infrastructure@lists.fedoraproject.org

Re: Freeze Break Request - enable F23 updates/testing atomic composes in bodhi

[Patrick Uiterwijk]

> +1. Roll back should be just comment the lines out again, correct?
> 
> On 22 October 2015 at 15:04, Luke Macken  wrote:
> > There is a rel-eng request to enable F23 updates-testing atomic ostrees.
> > https://fedorahosted.org/rel-eng/ticket/6279
> >
> > I attached a patch that uncomments the existing configuration in ansible to
> > enable this.
> > https://fedorahosted.org/rel-eng/attachment/ticket/6279/0001-bodhi-Enable-F23-updates-updates-testing-atomic-comp.patch
> >
> > This change affects bodhi-backend01 and can easily be reverted if the
> > composes fail.
> >
> > Thanks,
> >
> > luke
> >
> > ___
> > infrastructure mailing list
> > infrastructure@lists.fedoraproject.org
> > http://lists.fedoraproject.org/admin/infrastructure@lists.fedoraproject.org
> >
> 
> 
> 
> --
> Stephen J Smoogen.
> ___

+1
___
infrastructure mailing list
infrastructure@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/infrastructure@lists.fedoraproject.org

Re: Freeze break requeest: add script to make OpenVPN always fix its routes

[Stephen John Smoogen]

+1 thanks.

On 22 October 2015 at 15:11, Patrick Uiterwijk  wrote:
> Can I get any +1s?
> This will guarantee that the routes will have been created when the OpenVPN 
> link is up.
>
>
> commit e8f63323b4e236629f438a082422d61a37cc95af
> Author: Patrick Uiterwijk 
> Date:   Thu Oct 22 21:06:38 2015 +
>
> Add script to OpenVPN for VPN route fixing
>
> This will make sure that always after a start/restart the
> VPN routes are created
>
> Signed-off-by: Patrick Uiterwijk 
>
> diff --git a/roles/openvpn/client/files/client.conf 
> b/roles/openvpn/client/files/client.conf
> index abb5d03..704becb 100644
> --- a/roles/openvpn/client/files/client.conf
> +++ b/roles/openvpn/client/files/client.conf
> @@ -14,6 +14,9 @@ nobind
>
>  persist-key
>
> +up /etc/openvpn/fix-routes.sh
> +up-restart
> +
>  ca ca.crt
>  cert client.crt
>  key client.key
> diff --git a/roles/openvpn/client/files/fix-routes.sh 
> b/roles/openvpn/client/files/fix-routes.sh
> new file mode 100644
> index 000..a08e519
> --- /dev/null
> +++ b/roles/openvpn/client/files/fix-routes.sh
> @@ -0,0 +1,12 @@
> +#!/bin/sh
> +# First check if this server is actually an OpenVPN client
> +if [ -f /etc/openvpn/client.crt ];
> +then
> +   # Now the magic line
> +   # This first checks whether there is a route, and if there isn't it 
> will:
> +   # 1. Get the local machine's VPN IP (up to and including awk)
> +   # 2. Add a new route to 192.168.0.0/16 via that IP addres (from xargs 
> on)
> +   # 3. Print "Fixed VPN" and exit with code 2 to indicate that it 
> changed
> +   # Note: I've been told that the grep and awk can be in one command, 
> and I believe that, but I find this clearer.
> +   (ip route show | grep '192.168.0.0/16') || ((ip route show | grep 
> '192.168.0.' | awk '{print $1}' | xargs ip route add 192.168.0.0/16 via) && 
> echo "Fixed VPN" && exit 2);
> +fi
> diff --git a/roles/openvpn/client/tasks/main.yml 
> b/roles/openvpn/client/tasks/main.yml
> index 76817a2..67e44b1 100644
> --- a/roles/openvpn/client/tasks/main.yml
> +++ b/roles/openvpn/client/tasks/main.yml
> @@ -17,6 +17,9 @@
>- { file: client.conf,
>dest: /etc/openvpn/openvpn.conf,
>mode: '0644' }
> +  - { file: fix-routes.sh,
> +  dest: /etc/openvpn/fix-routes.sh,
> +  mode: '0755' }
>- { file: "{{ private }}/files/vpn/openvpn/keys/{{ inventory_hostname 
> }}.crt",
>dest: "/etc/openvpn/client.crt",
>mode: '0600' }
>
>
>
> With kind regards,
> Patrick Uiterwijk
> Fedora Infra
> ___
> infrastructure mailing list
> infrastructure@lists.fedoraproject.org
> http://lists.fedoraproject.org/admin/infrastructure@lists.fedoraproject.org



-- 
Stephen J Smoogen.
___
infrastructure mailing list
infrastructure@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/infrastructure@lists.fedoraproject.org

Re: Freeze break requeest: add script to make OpenVPN always fix its routes

[Tim Flink]

On Thu, 22 Oct 2015 17:11:51 -0400 (EDT)
Patrick Uiterwijk  wrote:

> Can I get any +1s?
> This will guarantee that the routes will have been created when the
> OpenVPN link is up.

+1 - must protect the virtual kittens traveling over openvpn wires in
order to avoid the lava on the floor

Tim

> commit e8f63323b4e236629f438a082422d61a37cc95af
> Author: Patrick Uiterwijk 
> Date:   Thu Oct 22 21:06:38 2015 +
> 
> Add script to OpenVPN for VPN route fixing
> 
> This will make sure that always after a start/restart the
> VPN routes are created
> 
> Signed-off-by: Patrick Uiterwijk 
> 
> diff --git a/roles/openvpn/client/files/client.conf
> b/roles/openvpn/client/files/client.conf index abb5d03..704becb 100644
> --- a/roles/openvpn/client/files/client.conf
> +++ b/roles/openvpn/client/files/client.conf
> @@ -14,6 +14,9 @@ nobind
>  
>  persist-key
>  
> +up /etc/openvpn/fix-routes.sh
> +up-restart
> +
>  ca ca.crt
>  cert client.crt
>  key client.key
> diff --git a/roles/openvpn/client/files/fix-routes.sh
> b/roles/openvpn/client/files/fix-routes.sh new file mode 100644
> index 000..a08e519
> --- /dev/null
> +++ b/roles/openvpn/client/files/fix-routes.sh
> @@ -0,0 +1,12 @@
> +#!/bin/sh
> +# First check if this server is actually an OpenVPN client
> +if [ -f /etc/openvpn/client.crt ];
> +then
> +   # Now the magic line
> +   # This first checks whether there is a route, and if there
> isn't it will:
> +   # 1. Get the local machine's VPN IP (up to and including awk)
> +   # 2. Add a new route to 192.168.0.0/16 via that IP addres
> (from xargs on)
> +   # 3. Print "Fixed VPN" and exit with code 2 to indicate that
> it changed
> +   # Note: I've been told that the grep and awk can be in one
> command, and I believe that, but I find this clearer.
> +   (ip route show | grep '192.168.0.0/16') || ((ip route show |
> grep '192.168.0.' | awk '{print $1}' | xargs ip route add
> 192.168.0.0/16 via) && echo "Fixed VPN" && exit 2); +fi diff --git
> a/roles/openvpn/client/tasks/main.yml
> b/roles/openvpn/client/tasks/main.yml index 76817a2..67e44b1 100644
> --- a/roles/openvpn/client/tasks/main.yml +++
> b/roles/openvpn/client/tasks/main.yml @@ -17,6 +17,9 @@
>- { file: client.conf,
>dest: /etc/openvpn/openvpn.conf,
>mode: '0644' }
> +  - { file: fix-routes.sh,
> +  dest: /etc/openvpn/fix-routes.sh,
> +  mode: '0755' }
>- { file:
> "{{ private }}/files/vpn/openvpn/keys/{{ inventory_hostname }}.crt",
> dest: "/etc/openvpn/client.crt", mode: '0600' }
> 
> 
> 
> With kind regards,
> Patrick Uiterwijk
> Fedora Infra
> ___
> infrastructure mailing list
> infrastructure@lists.fedoraproject.org
> http://lists.fedoraproject.org/admin/infrastructure@lists.fedoraproject.org



pgpjo9cDa6dPE.pgp
Description: OpenPGP digital signature
___
infrastructure mailing list
infrastructure@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/infrastructure@lists.fedoraproject.org

Re: Freeze Break Request - enable F23 updates/testing atomic composes in bodhi

[Luke Macken]

On Thu, Oct 22, 2015 at 03:14:47PM -0600, Stephen John Smoogen wrote:
> +1. Roll back should be just comment the lines out again, correct?

Correct.

luke
___
infrastructure mailing list
infrastructure@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/infrastructure@lists.fedoraproject.org

Re: freeze break request enable koji-gc on fedora 23 and 24 keys and install git-email on batcave

[Dennis Gilmore]

On Thursday, October 22, 2015 07:27:33 AM Patrick Uiterwijk wrote:
> +1 on both.

applied thanks

Dennis

signature.asc
Description: This is a digitally signed message part.
___
infrastructure mailing list
infrastructure@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/infrastructure@lists.fedoraproject.org

Re: Freeze break requeest: add script to make OpenVPN always fix its routes

[Patrick Uiterwijk]

And I just realized I need to remove the exit 2, because this will make openvpn 
exit.

Can I get +1s to this change to the script?



commit 50511a65e7dbdf0a60ad1cc43a6fa2fddec66ed3
Author: Patrick Uiterwijk 
Date:   Fri Oct 23 02:41:01 2015 +

Make fix-routes not terminate with status 2 if it fixed it

This will make openvpn think something went wrong and terminate the 
connection.
I did this to make it easily visible when running with ansible, but in this 
case
it messes things up.

Signed-off-by: Patrick Uiterwijk 

diff --git a/roles/openvpn/client/files/fix-routes.sh 
b/roles/openvpn/client/files/fix-routes.sh
index a08e519..44a9450 100644
--- a/roles/openvpn/client/files/fix-routes.sh
+++ b/roles/openvpn/client/files/fix-routes.sh
@@ -8,5 +8,5 @@ then
# 2. Add a new route to 192.168.0.0/16 via that IP addres (from xargs 
on)
# 3. Print "Fixed VPN" and exit with code 2 to indicate that it changed
# Note: I've been told that the grep and awk can be in one command, and 
I believe that, but I find this clearer.
-   (ip route show | grep '192.168.0.0/16') || ((ip route show | grep 
'192.168.0.' | awk '{print $1}' | xargs ip route add 192.168.0.0/16 via) && 
echo "Fixed VPN" && exit 2);
+   (ip route show | grep '192.168.0.0/16') || ((ip route show | grep 
'192.168.0.' | awk '{print $1}' | xargs ip route add 192.168.0.0/16 via) && 
echo "Fixed VPN");
 fi
___
infrastructure mailing list
infrastructure@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/infrastructure@lists.fedoraproject.org

Re: Freeze break requeest: add script to make OpenVPN always fix its routes

[Stephen John Smoogen]

Count this as a +2 and get a retroactive 1 later. Dropping vpn because
of this would be worse than waiting for it.

On 22 October 2015 at 20:45, Patrick Uiterwijk  wrote:
> And I just realized I need to remove the exit 2, because this will make 
> openvpn exit.
>
> Can I get +1s to this change to the script?
>
>
>
> commit 50511a65e7dbdf0a60ad1cc43a6fa2fddec66ed3
> Author: Patrick Uiterwijk 
> Date:   Fri Oct 23 02:41:01 2015 +
>
> Make fix-routes not terminate with status 2 if it fixed it
>
> This will make openvpn think something went wrong and terminate the 
> connection.
> I did this to make it easily visible when running with ansible, but in 
> this case
> it messes things up.
>
> Signed-off-by: Patrick Uiterwijk 
>
> diff --git a/roles/openvpn/client/files/fix-routes.sh 
> b/roles/openvpn/client/files/fix-routes.sh
> index a08e519..44a9450 100644
> --- a/roles/openvpn/client/files/fix-routes.sh
> +++ b/roles/openvpn/client/files/fix-routes.sh
> @@ -8,5 +8,5 @@ then
> # 2. Add a new route to 192.168.0.0/16 via that IP addres (from xargs 
> on)
> # 3. Print "Fixed VPN" and exit with code 2 to indicate that it 
> changed
> # Note: I've been told that the grep and awk can be in one command, 
> and I believe that, but I find this clearer.
> -   (ip route show | grep '192.168.0.0/16') || ((ip route show | grep 
> '192.168.0.' | awk '{print $1}' | xargs ip route add 192.168.0.0/16 via) && 
> echo "Fixed VPN" && exit 2);
> +   (ip route show | grep '192.168.0.0/16') || ((ip route show | grep 
> '192.168.0.' | awk '{print $1}' | xargs ip route add 192.168.0.0/16 via) && 
> echo "Fixed VPN");
>  fi
> ___
> infrastructure mailing list
> infrastructure@lists.fedoraproject.org
> http://lists.fedoraproject.org/admin/infrastructure@lists.fedoraproject.org



-- 
Stephen J Smoogen.
___
infrastructure mailing list
infrastructure@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/infrastructure@lists.fedoraproject.org

freeze break request: deploy a new fedora-tagger release with a bugfix for the JSON API.

[Ralph Bean]

On Thu, Oct 22, 2015 at 11:11:51AM -0400, Ralph Bean wrote:
> Hey all
> 
> Here's a small bugfix release for fedora-tagger which is meant to get the JSON
> API working again.  See this pull request specifically:
> https://github.com/fedora-infra/fedora-tagger/pull/195
> 
> The tagger nodes are currently frozen because the bodhi masher pulls down a
> sqlite dump of all the tags and uses them to mash the repo metadata.  This
> change shouldn't affect that behavior at all, though.
> 
> 2.3.2
> -
> 
> Pull Requests
> 
> - (@pypingou)   #192, Adjust the faitout url to the new address
>   https://github.com/fedora-infra/fedora-tagger/pull/192
> - (@ralphbean)  #195, Fix icon in json.
>   https://github.com/fedora-infra/fedora-tagger/pull/195
> 
> Commits
> 
> - 50e3981fc Adjust the faitout url to the new address
>   https://github.com/fedora-infra/fedora-tagger/commit/50e3981fc
> - 4341810e7 Fix icon in json.
>   https://github.com/fedora-infra/fedora-tagger/commit/4341810e7

As mentioned above, there's a new fedora-tagger release that I'd like
to push to production.  It contains a one-line fix that should get the
JSON API working again.

If it breaks the world, we can back it out.

Can I get two +1s?


signature.asc
Description: PGP signature
___
infrastructure mailing list
infrastructure@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/infrastructure@lists.fedoraproject.org

Re: freeze break request: deploy a new fedora-tagger release with a bugfix for the JSON API.

[Pierre-Yves Chibon]

On Thu, Oct 22, 2015 at 11:19:04AM -0400, Ralph Bean wrote:
> On Thu, Oct 22, 2015 at 11:11:51AM -0400, Ralph Bean wrote:
> > Hey all
> > 
> > Here's a small bugfix release for fedora-tagger which is meant to get the 
> > JSON
> > API working again.  See this pull request specifically:
> > https://github.com/fedora-infra/fedora-tagger/pull/195
> > 
> > The tagger nodes are currently frozen because the bodhi masher pulls down a
> > sqlite dump of all the tags and uses them to mash the repo metadata.  This
> > change shouldn't affect that behavior at all, though.
> > 
> > 2.3.2
> > -
> > 
> > Pull Requests
> > 
> > - (@pypingou)   #192, Adjust the faitout url to the new address
> >   https://github.com/fedora-infra/fedora-tagger/pull/192
> > - (@ralphbean)  #195, Fix icon in json.
> >   https://github.com/fedora-infra/fedora-tagger/pull/195
> > 
> > Commits
> > 
> > - 50e3981fc Adjust the faitout url to the new address
> >   https://github.com/fedora-infra/fedora-tagger/commit/50e3981fc
> > - 4341810e7 Fix icon in json.
> >   https://github.com/fedora-infra/fedora-tagger/commit/4341810e7
> 
> As mentioned above, there's a new fedora-tagger release that I'd like
> to push to production.  It contains a one-line fix that should get the
> JSON API working again.
> 
> If it breaks the world, we can back it out.
> 
> Can I get two +1s?

Here is mine: +1

Thanks,
Pierre


pgpj9MO2aLpij.pgp
Description: PGP signature
___
infrastructure mailing list
infrastructure@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/infrastructure@lists.fedoraproject.org

Re: freeze break request: deploy a new fedora-tagger release with a bugfix for the JSON API.

[Kevin Fenzi]

+1 here. do it! :) 


pgpj8Bt6r1vV1.pgp
Description: OpenPGP digital signature
___
infrastructure mailing list
infrastructure@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/infrastructure@lists.fedoraproject.org