[krunner] [Bug 385693] krunner text input broken with wayland

[Aleix Pol]

https://bugs.kde.org/show_bug.cgi?id=385693

Aleix Pol  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/pla
   ||sma-workspace/fc5a454030252
   ||86fed063273f958ef0aa04f7f30

--- Comment #19 from Aleix Pol  ---
Git commit fc5a45403025286fed063273f958ef0aa04f7f30 by Aleix Pol.
Committed on 31/01/2018 at 11:20.
Pushed by apol into branch 'Plasma/5.12'.

Fix krunner's alt+f2 on wayland

Summary:
Don't go through the workaround introduced for X11 that makes it go mental.

Test Plan: Have been a happy krunner user since

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: ngraham, davidedmundson, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D10197

M  +1-60   krunner/view.cpp
M  +0-4krunner/view.h

https://commits.kde.org/plasma-workspace/fc5a45403025286fed063273f958ef0aa04f7f30

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 385693] krunner text input broken with wayland

[Aleix Pol]

https://bugs.kde.org/show_bug.cgi?id=385693

--- Comment #18 from Aleix Pol  ---
This works for me, on Plasma/5.12 branch. Inspired on Märt's approach.
https://phabricator.kde.org/D10197

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 385693] krunner text input broken with wayland

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=385693

Nate Graham  changed:

   What|Removed |Added

 CC||aleix...@kde.org

--- Comment #17 from Nate Graham  ---
*** Bug 389557 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 385693] krunner text input broken with wayland

[Märt Bakhoff]

https://bugs.kde.org/show_bug.cgi?id=385693

--- Comment #16 from Märt Bakhoff  ---
Thanks for your insight Fabian. I'm wondering if there are two separate issues
here. 

In my case, krunner never receives keyboard focus at all. Pressing alt+f2 makes
krunner visible, but all key events still go to plasmashell. This happens
whether there is a delay between alt+f2 and typing the command or not. 

I tried to remove the code in plasmashell that activates krunner over dbus.
Then alt+f2 still opens krunner, but nothing can be written to the query box at
all. Clicking on the query box focuses it and it starts working normally.

If the race condition was about which window receives the key events, then
should't waiting for krunner to open completely affect the result? It doesn't
in my case.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 385693] krunner text input broken with wayland

[Fabian Vogt]

https://bugs.kde.org/show_bug.cgi?id=385693

--- Comment #14 from Fabian Vogt  ---
This is a more general issue with krunner.
It acquires actual focus too late, even when it's already shown completely, the
keyboard focus is missing.

Here you can see openQA typing "xterm" after matching the fully opened krunner
on the screen. The result is "erm" in the input line.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 385693] krunner text input broken with wayland

[Fabian Vogt]

https://bugs.kde.org/show_bug.cgi?id=385693

--- Comment #15 from Fabian Vogt  ---
(In reply to Fabian Vogt from comment #14)
> Here you can see openQA typing "xterm" after matching the fully opened
> krunner on the screen. The result is "erm" in the input line.

Apparently I forgot the URL:

https://openqa.opensuse.org/tests/570421#step/kate/1 (the "erm" result is
visible in the next step)

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 385693] krunner text input broken with wayland

[Fabian Vogt]

https://bugs.kde.org/show_bug.cgi?id=385693

--- Comment #13 from Fabian Vogt  ---
(In reply to Märt Bakhoff from comment #12)
> Created attachment 109547 [details]
> remove-krunner-event-override-5.11.4.patch
> 
> Removing the method `bool event(QEvent* event) override` from the krunner
> view fixes the issue for me (see
> remove-krunner-event-override-5.11.4.patch). The method seems to be a
> workaround for some old bug, so removing it may cause other issues.

I tried this, it does not help here.

It seems to be a race condition. The first press gets sent by plasmashell to
the krunner dbus service, which then starts opening the view.
Then the subsequent presses arrive, but as krunner is not completely opened yet
it doesn't have focus and plasmashell still sends the single keypresses to
krunner over dbus.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 385693] krunner text input broken with wayland

[Märt Bakhoff]

https://bugs.kde.org/show_bug.cgi?id=385693

--- Comment #12 from Märt Bakhoff  ---
Created attachment 109547
  --> https://bugs.kde.org/attachment.cgi?id=109547=edit
remove-krunner-event-override-5.11.4.patch

Removing the method `bool event(QEvent* event) override` from the krunner view
fixes the issue for me (see remove-krunner-event-override-5.11.4.patch). The
method seems to be a workaround for some old bug, so removing it may cause
other issues.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 385693] krunner text input broken with wayland

[Fabian Vogt]

https://bugs.kde.org/show_bug.cgi?id=385693

--- Comment #11 from Fabian Vogt  ---
(In reply to Märt Bakhoff from comment #10)
> The query in the text field is overwritten here:
> 
> plasma-workspace-5.11.4/krunner/view.cpp:380
> 375 void View::query(const QString )
> 376 {
> 377 setVisible(true);
> 378
> 379 m_qmlObj->rootObject()->setProperty("runner", QString());
> 380 m_qmlObj->rootObject()->setProperty("query", term);
> 381 }
> 
> The query method is triggered by a QDBusActivateObjectEvent, which does a
> QDBusActivateObjectEvent::placeMetaCall
> 
> The metacall seems to be sent from
> plasma-workspace-5.11.4/shell/desktopview.cpp:241:
> 240 org::kde::krunner::App krunner(interface, QStringLiteral("/App"),
> QDBusConnection::sessionBus());
> 241 krunner.query(text);

Ok, so it looks like krunner doesn't get focus early enough and plasmashell
still gets all the key events.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 385693] krunner text input broken with wayland

[Märt Bakhoff]

https://bugs.kde.org/show_bug.cgi?id=385693

--- Comment #10 from Märt Bakhoff  ---
I interrogated krunner with gdb and found some potentially useful information:

The query in the text field is overwritten here:

plasma-workspace-5.11.4/krunner/view.cpp:380
375 void View::query(const QString )
376 {
377 setVisible(true);
378
379 m_qmlObj->rootObject()->setProperty("runner", QString());
380 m_qmlObj->rootObject()->setProperty("query", term);
381 }

The query method is triggered by a QDBusActivateObjectEvent, which does a
QDBusActivateObjectEvent::placeMetaCall

The metacall seems to be sent from
plasma-workspace-5.11.4/shell/desktopview.cpp:241:
240 org::kde::krunner::App krunner(interface, QStringLiteral("/App"),
QDBusConnection::sessionBus());
241 krunner.query(text);

Debugging plasmashell shows that this snippet runs every time when krunner text
is overwritten and the argument text has size() == 1.

Another observation:
1) open konsole, focus it
2) type alt+f2, "d"
3) click on krunner text field to focus it
4) click on konsole to focus it (krunner doesn't close)
5) click on krunner text field to focus it
6) type "olphin" -> text field now contains "dolphin" as expected

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 385693] krunner text input broken with wayland

[Fabian Vogt]

https://bugs.kde.org/show_bug.cgi?id=385693

--- Comment #9 from Fabian Vogt  ---
(In reply to David Edmundson from comment #5)
> Was a Qt bug that is since fixed.
> Try with Qt5.10 and reopen if you still have an issue.

Still exists. What's the commit which was supposed to fix it?

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 385693] krunner text input broken with wayland

[Dr . Chapatin]

https://bugs.kde.org/show_bug.cgi?id=385693

Dr. Chapatin  changed:

   What|Removed |Added

 CC||fab...@ritter-vogt.de

--- Comment #8 from Dr. Chapatin  ---
*** Bug 388179 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 385693] krunner text input broken with wayland

[Märt Bakhoff]

https://bugs.kde.org/show_bug.cgi?id=385693

--- Comment #7 from Märt Bakhoff  ---
Problem persists: qt 5.10, frameworks 5.41, plasma 5.11.4

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 385693] krunner text input broken with wayland

[Dr . Chapatin]

https://bugs.kde.org/show_bug.cgi?id=385693

Dr. Chapatin  changed:

   What|Removed |Added

 Resolution|UPSTREAM|---
 Status|RESOLVED|REOPENED
 Ever confirmed|0   |1

--- Comment #6 from Dr. Chapatin  ---
I'm testing qt 5.10 rc2 on Arch Linux.
The problem persists.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 385693] krunner text input broken with wayland

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=385693

David Edmundson  changed:

   What|Removed |Added

 Resolution|--- |UPSTREAM
 Status|UNCONFIRMED |RESOLVED

--- Comment #5 from David Edmundson  ---
Was a Qt bug that is since fixed.
Try with Qt5.10 and reopen if you still have an issue.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 385693] krunner text input broken with wayland

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=385693

Nate Graham  changed:

   What|Removed |Added

   Keywords||usability

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 385693] krunner text input broken with wayland

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=385693

Nate Graham  changed:

   What|Removed |Added

   Severity|normal  |major

--- Comment #4 from Nate Graham  ---
Marking as Major, since this makes KRunner more or less unusable in a Wayland
session.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 385693] krunner text input broken with wayland

[Arthur Țițeică]

https://bugs.kde.org/show_bug.cgi?id=385693

Arthur Țițeică  changed:

   What|Removed |Added

 CC||arthur+...@cloud.titeica.ro

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 385693] krunner text input broken with wayland

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=385693

David Edmundson  changed:

   What|Removed |Added

   Keywords||wayland
 CC||k...@davidedmundson.co.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 385693] krunner text input broken with wayland

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=385693

--- Comment #3 from yellowha...@gmail.com ---
Same problem with 5.11.3 and 5.39.0 kde framework.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 385693] krunner text input broken with wayland

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=385693

--- Comment #2 from yellowha...@gmail.com ---
Exactly same behavior for me.
Plasma 5.11.2, Qt 5.9.2, Gentoo/systemd ~amd64

Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 385693] krunner text input broken with wayland

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=385693

yellowha...@gmail.com changed:

   What|Removed |Added

 CC||yellowha...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 385693] krunner text input broken with wayland

[Dr . Chapatin]

https://bugs.kde.org/show_bug.cgi?id=385693

Dr. Chapatin  changed:

   What|Removed |Added

 CC||bugsefor...@gmx.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 385693] krunner text input broken with wayland

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=385693

Nate Graham  changed:

   What|Removed |Added

 CC||k...@privat.broulik.de,
   ||pointedst...@zoho.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 385693] krunner text input broken with wayland

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=385693

Nate Graham  changed:

   What|Removed |Added

 CC||toneym...@gmail.com

--- Comment #1 from Nate Graham  ---
*** Bug 385773 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.