Re: [Libreoffice] [LibreOffice] [PATCH] Minor libs-core comment clean up.
On Tue, 19 Oct 2010 20:40:32 -0400, Trevor Murphy trevor.m.mur...@gmail.com wrote: Incidentally, I'm running Ubuntu 10.04 with git-email installed via aptitude install, but I don't have the git-send-email command. Is there something obvious that I'm missing? I don't have git-send-email either but git send-email works just fine. Ubuntu here too. Try it out. Sebastian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Building on gentoo ...
On Tue, 19 Oct 2010 23:45:11 +0200, René Kjellerup rk.katana.st...@gmail.com wrote: On the other matter unless you're still running kde 3 then you need --disable-kde else the config will fail when it can't find Qt 3.x On that matter can, we please --disable-kde by default. I don't know of recent distros that ship kde3 but not KDE4, and those who do can turn it on in their distro-specific defaults. Even better, our make should detect the lack of qt3 headers and disable it automatically rather than bailing out. Sebastian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] removed a lot of dead code and bogus comments
On 18/10/10 14:06, Povilas Kanapickas wrote: Hello, I've done some work on entry level tasks. Specifically, I've removed all #if 0 blocks in the LibreOffice source tree. Also, a lot of bogus comments like /*N*/, /*?*/ and so on were removed. As more than thousand of files have been changed I didn't try to make a separate patch for each one. Some of the resulting patches were really large (10MB+) thus I uploaded them to external storage. Here's the link: https://docs.google.com/leaf?id=0B17lV1Y1fK9UMTM3ZDRlOWUtMjFlNi00YTE0LTg2NjgtYjdlOGVkNTljZDZjhl=enauthkey=CNjS9v0C https://docs.google.com/leaf?id=0B17lV1Y1fK9UMTM3ZDRlOWUtMjFlNi00YTE0LTg2NjgtYjdlOGVkNTljZDZjhl=enauthkey=CNjS9v0C I contribute under LGPLv3+. Hope you can merge my contributions :) Regards, Povilas I've looked at the basic part, looks good to me, currently I am in the middle of a build, I will apply it later, check again and push it ( will post here about that ). Thanks again!!! much apprecialted Noel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] removed a lot of dead code and bogus comments
sending again :/ On 18/10/10 14:06, Povilas Kanapickas wrote: Hello, I've done some work on entry level tasks. Specifically, I've removed all #if 0 blocks in the LibreOffice source tree. Also, a lot of bogus comments like /*N*/, /*?*/ and so on were removed. As more than thousand of files have been changed I didn't try to make a separate patch for each one. Some of the resulting patches were really large (10MB+) thus I uploaded them to external storage. Here's the link: https://docs.google.com/leaf?id=0B17lV1Y1fK9UMTM3ZDRlOWUtMjFlNi00YTE0LTg2NjgtYjdlOGVkNTljZDZjhl=enauthkey=CNjS9v0C https://docs.google.com/leaf?id=0B17lV1Y1fK9UMTM3ZDRlOWUtMjFlNi00YTE0LTg2NjgtYjdlOGVkNTljZDZjhl=enauthkey=CNjS9v0C I contribute under LGPLv3+. Hope you can merge my contributions :) Regards, Povilas I've looked at the basic part, looks good to me, currently I am in the middle of a build, I will apply it later, check again and push it ( will post here about that ). Thanks again!!! much apprecialted Noel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] shutdownicon.cxx: rename getDotAutostart() - getAutostartDir()
I was puzzled by the name and the new one is much clearer. Also add
proper documentation to that function as to what it does and what the
params mean. All callers have been adapted to the new name.
Signed-off-by: Sebastian Spaeth sebast...@sspaeth.de
---
sfx2/source/appl/shutdownicon.cxx | 16
1 files changed, 12 insertions(+), 4 deletions(-)
diff --git a/sfx2/source/appl/shutdownicon.cxx
b/sfx2/source/appl/shutdownicon.cxx
index 1ff2164..3d8e4b6 100644
--- a/sfx2/source/appl/shutdownicon.cxx
+++ b/sfx2/source/appl/shutdownicon.cxx
@@ -771,12 +771,20 @@ bool ShutdownIcon::IsQuickstarterInstalled()
// ---
#if defined (ENABLE_QUICKSTART_APPLET) defined (UNX)
-static OUString getDotAutostart( bool bCreate = false )
+/**
+* Return the XDG autostart directory.
+* http://standards.freedesktop.org/autostart-spec/autostart-spec-latest.html
+* Available in Unix and with Quickstart enabled.
+* @param bCreate Create the directory if it does not exist yet.
+* @return OUString containing the autostart directory path.
+*/
+static OUString getAutostartDir( bool bCreate = false )
{
OUString aShortcut;
const char *pConfigHome;
if( (pConfigHome = getenv(XDG_CONFIG_HOME) ) )
-aShortcut = OStringToOUString( OString( pConfigHome ),
RTL_TEXTENCODING_UTF8 );
+aShortcut = OStringToOUString( OString( pConfigHome ),
+ RTL_TEXTENCODING_UTF8 );
else
{
OUString aHomeURL;
@@ -816,7 +824,7 @@ rtl::OUString ShutdownIcon::getShortcutName()
aShortcut += OUString( RTL_CONSTASCII_USTRINGPARAM( \\ ) );
aShortcut += aShortcutName;
#else // UNX
-OUString aShortcut = getDotAutostart();
+OUString aShortcut = getAutostartDir();
aShortcut += OUString( RTL_CONSTASCII_USTRINGPARAM( /qstart.desktop ) );
#endif // UNX
return aShortcut;
@@ -857,7 +865,7 @@ void ShutdownIcon::SetAutostart( bool bActivate )
#ifdef WNT
EnableAutostartW32( aShortcut );
#else // UNX
-getDotAutostart( true );
+getAutostartDir( true );
OUString aPath(
RTL_CONSTASCII_USTRINGPARAM(${BRAND_BASE_DIR}/share/xdg/qstart.desktop ) );
Bootstrap::expandMacros( aPath );
--
1.7.1
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] shutdownicon.cxx: rename getDotAutostart() - getAutostartDir()
On Wed, 2010-10-20 at 13:11 +0200, Sebastian Spaeth wrote: I was puzzled by the name and the new one is much clearer. Also add proper documentation to that function as to what it does and what the params mean. All callers have been adapted to the new name. Look ok to me, committed + pushed. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Building on windows 7-64bit with Visual Studio 2010 Express
On Tue, 2010-10-19 at 22:46 +0100, Martin Gallwey wrote: Okay! Most of the battle so far was figuring out what cygwin packages to install and how to get the correct cygdrive paths - can someone add a windows section to http://www.freedesktop.org/wiki/Software/LibreOffice/HowToBuild with the info in this email? You should be able to add it yourself I believe, that's probably the best thing to do if possible. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Fix for #i93300#: Crash when inserting 32 bit TIFF image
On Tue, 2010-10-19 at 20:25 +0300, Harri Pitkänen wrote: This patch has been tested on a 64 bit Linux system using the samples in the bug and some images from libtiff sample collection at ftp://ftp.remotesensing.org/pub/libtiff/pics-3.8.0.tar.gz I ran through this one, and yeah fixes a pile of crashes, so test-suite doesn't crash LO after applying, and simpler tiffs continue to work (including recently added tiff alpha channel support). So committed and pushed, thanks. What would be awesome of course is to work on supporting those current unknown formats :-) C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Address Books
It looks like someone already connected Base to Apple's Address Book (no bonus points for me) On my mac, I can't get the Mozilla Address Book driver to work. 1. Preferences - LibreOffice Base - Connections shows that com.sun.star.comp.sdbc.MozabDriver is installed. 2. Trying to open the abook.mab file as an existing database fails (it doesn't recognize the file as being a database). 3. The connect to an existing database drop down doesn't include the Moz Driver. I'm working on trying to isolate all the Moz Driver code out of the seamonkey source so it can be build with seamonkey disabled. I'd also like to update the code something a little more modern like v2ish of seamonkey (I'm going to look into Thunderbird's code and see if it uses seamonkey's address book code). Also, does anyone know of any documentation on how the connectors work? (libs-core - connectivity - source - drivers) Any pointers on any of the above would be nice. Joe P. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Problem w:/BASIC
Hello I'm testing libo beta2 + langpack fr under linux(slax) without jre get Erreur d'exécution BASIC message : the external file picker does not run works fine under windows happy if you can help ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] bootstrap/soenv: remove tcsh version of LinuxX86-64Env.Set
Previously we would have been writing out LinuxX86-64Env.Set and
LinuxX86-64Env.Set.sh which made my autocompletion useless. As we
require bash anyway, it has been agreed on to just provide the bash
version. Simplify the set_soenv.in to actually only produce 1 version.
Signed-off-by: Sebastian Spaeth sebast...@sspaeth.de
---
I have tested the correct function of this patch on x86_64 Linux and I don't
see any reason why it should break on other platforms. I don't know how fragile
Windows is in that regard though.
set_soenv.in | 117 +-
1 files changed, 42 insertions(+), 75 deletions(-)
diff --git a/set_soenv.in b/set_soenv.in
index 5a3313c..7f55e47 100644
--- a/set_soenv.in
+++ b/set_soenv.in
@@ -38,12 +38,12 @@ use File::Basename;
# IIa. Declaring variables for the system commands, etc.
#
#
-my ( $outfile, $outfile_sh, $bootfile, $newline, $comment,
+my ( $outfile, $bootfile, $newline, $comment,
$compiler, $unsetenv, $setenv, $unset, $set, $ds, $ps,
$wps, $cur_dir, $par_dir, $I, $L, $D, $buildenv, $answer, $tmp, $MINGW,
$USE_MINGW, $platform,
$cygwinver, $empty, $no_ant, $no_stl, $no_gcc_include,
- $no_gxx_include, $warnfile, $Warning, $result, $unsetvars, $unsetvarssh,
$unsetvarsbat, $exportvars, $win_format_var, $perl_os,
@mingw_lib_include_paths, $mingw_lib_include_path);
+ $no_gxx_include, $warnfile, $Warning, $result, $unsetvars, $exportvars,
$win_format_var, $perl_os, @mingw_lib_include_paths, $mingw_lib_include_path);
#
#-
# IIb. Declaring environment values (constants).
@@ -205,10 +205,10 @@ if ( $platform =~ m/solaris/ )
if ($platform =~ m/^i[3456]86/)
{
if ( $CC =~ gcc) {
- $outfile= SolarisX86GccEnv.Set;
+ $outfile= SolarisX86GccEnv.Set.sh;
$OUTPATH= unxsogi;
} else {
- $outfile= SolarisX86Env.Set;
+ $outfile= SolarisX86Env.Set.sh;
$OUTPATH= unxsoli4;
}
$CPU= I;
@@ -221,10 +221,10 @@ if ( $platform =~ m/solaris/ )
else
{
if ( $CC =~ gcc) {
- $outfile= SolarisSparcGccEnv.Set;
+ $outfile= SolarisSparcGccEnv.Set.sh;
$OUTPATH= unxsogs;
} else {
- $outfile= SolarisSparcEnv.Set;
+ $outfile= SolarisSparcEnv.Set.sh;
$OUTPATH= unxsols4;
}
$CPU= S;
@@ -256,7 +256,7 @@ elsif ( $platform =~ m/netbsd/ )
#Set platform specific values:
if ($platform =~ m/^i[3456]86/)
{ print Setting NetBSD x86 specific values... ;
- $outfile= NetBSDX86Env.Set;
+ $outfile= NetBSDX86Env.Set.sh;
$CPU= I;
$CPUNAME= INTEL;
$OUTPATH= unxbsdi;
@@ -266,7 +266,7 @@ elsif ( $platform =~ m/netbsd/ )
}
elsif ($platform =~ m/^sparc/)
{ print Setting NetBSD Sparc specific values... ;
- $outfile= NetBSDSparcEnv.Set;
+ $outfile= NetBSDSparcEnv.Set.sh;
$CPU= S;
$CPUNAME= SPARC;
$OUTPATH= unxbsds;
@@ -276,7 +276,7 @@ elsif ( $platform =~ m/netbsd/ )
}
elsif ($platform =~ m/powerpc/)
{ print Setting NetBSD PPC specific values... ;
- $outfile= NetBSDPPCEnv.Set;
+ $outfile= NetBSDPPCEnv.Set.sh;
$CPU= P;
$CPUNAME= POWERPC;
$OUTPATH= unxbsdppc;
@@ -319,7 +319,7 @@ elsif ( $platform =~ m/kfreebsd/ )
#Set platform specific values:
if ($platform =~ m/^i[3456]86/)
{ print Setting GNU/kFreeBSD x86 specific values... ;
- $outfile= GNUkFreeBSDX86Env.Set;
+ $outfile= GNUkFreeBSDX86Env.Set.sh;
$CPU= I;
$CPUNAME= INTEL;
$OUTPATH= unxkfgi6;
@@ -331,7 +331,7 @@ elsif ( $platform =~ m/kfreebsd/ )
}
elsif ($platform =~ m/^x86_64/)
{ print Setting GNU/kFreeBSD x86-64 specific values... ;
- $outfile= GNUkFreeBSDX86-64Env.Set;
+ $outfile= GNUkFreeBSDX86-64Env.Set.sh;
$CPU= X;
$CPUNAME= X86_64;
$OUTPATH= unxkfgx6;
@@ -357,7 +357,7 @@ elsif ( $platform =~ m/freebsd/ )
if ($platform =~ m/^amd64/)
{ my ( $JAVA_OS );
print Setting FreeBSD AMD64 specific values... ;
- $outfile= FreeBSDAMDEnv.Set;
+ $outfile= FreeBSDAMDEnv.Set.sh;
$CPU= X;
$CPUNAME= X86_64;
$OUTPATH= unxfbsdx;
@@ -376,7 +376,7 @@ elsif ( $platform =~ m/freebsd/ )
}
elsif ($platform =~ m/^i386/)
{ print Setting FreeBSD x86 specific values... ;
- $outfile= FreeBSDX86Env.Set;
+ $outfile= FreeBSDX86Env.Set.sh;
$CPU= I;
$CPUNAME=
Re: [Libreoffice] Problem w:/BASIC
On 20/10/10 14:39, Jean-Etienne SIX wrote: Hello I'm testing libo beta2 + langpack fr under linux(slax) without jre get Erreur d'exécution BASIC message : the external file picker does not run works fine under windows happy if you can help what exact steps do you do? can you give some more detail please Noel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Patch] SAL_N_ELEMENTS Easy Hack
From dff6ef1a53dd5f76ce9f33819106e860dd63a3e2 Mon Sep 17 00:00:00 2001 Date: Tue, 19 Oct 2010 16:10:36 -0700 Subject: [PATCH] Easy Hack for SAL_N_ELEMENTS This patch is public domain. --- reportdesign/source/ui/inspection/metadata.cxx |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/reportdesign/source/ui/inspection/metadata.cxx b/reportdesign/source/ui/inspection/metadata.cxx index db219c8..e3610c4 100644 --- a/reportdesign/source/ui/inspection/metadata.cxx +++ b/reportdesign/source/ui/inspection/metadata.cxx @@ -173,9 +173,8 @@ namespace rptui }; s_pPropertyInfos = aPropertyInfos; -s_nCount = sizeof(aPropertyInfos) / sizeof(OPropertyInfoImpl); -::std::sort( aPropertyInfos, aPropertyInfos + s_nCount, PropertyInfoLessByName() ); +::std::sort( aPropertyInfos, aPropertyInfos + SAL_N_ELEMENTS(aPropertyInfos), PropertyInfoLessByName() ); return s_pPropertyInfos; } -- 1.6.2.5 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Is there tag/property in the following example that LO not support yet?
Hello I have docx document that LO failed load is images. The image can added to document, altough the XML code is defer. this is the part of the document.xml of the image. Do you know if it's because LO can't parse this part? (for any tag/property for example) I still investigate the wordfilter code area, but I still don't know how to check it thanks Nadav w:r − w:object w:dxaOrig=13698 w:dyaOrig=7546 − v:shape id=_x_i1035 type=#_x_t75 style=width:472.5pt;height:260.25pt o:ole= v:imagedata r:id=rId26 o:title=/ /v:shape o:OLEObject Type=Embed ProgID=Visio.Drawing.11 ShapeID=_x_i1035 DrawAspect=Content ObjectID=_1343106124 r:id=rId27/ /w:object /w:r -- הבלוג שלי: http://nadavvin.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Is there tag/property in the following example that LO not support yet?
On Wed, Oct 20, 2010 at 9:47 PM, Nadav Vinik em...@nadavvin.com wrote: Hello I have docx document that LO failed load is images. The image can added to document, altough the XML code is defer. this is the part of the document.xml of the image. Do you know if it's because LO can't parse this part? (for any tag/property for example) I still investigate the wordfilter code area, but I still don't know how to check it When I add the image to new document I got the following error in console: $ ERROR: meta.c (179): wmf_header_read: this isn't a wmf file ERROR: meta.c (179): wmf_header_read: this isn't a wmf file ERROR: meta.c (179): wmf_header_read: this isn't a wmf file (this time I add it in OO 3.2) thanks Nadav w:r − w:object w:dxaOrig=13698 w:dyaOrig=7546 − v:shape id=_x_i1035 type=#_x_t75 style=width:472.5pt;height:260.25pt o:ole= v:imagedata r:id=rId26 o:title=/ /v:shape o:OLEObject Type=Embed ProgID=Visio.Drawing.11 ShapeID=_x_i1035 DrawAspect=Content ObjectID=_1343106124 r:id=rId27/ /w:object /w:r -- הבלוג שלי: http://nadavvin.com -- הבלוג שלי: http://nadavvin.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Building on gentoo ...
As for disable it per default, look at another enable clause. But the quick glance at it tells me the then and else blocks needs to be reversed if test z$enable_kde != zyes; then orig else block else orig then block fi Hope it makes sense René On Oct 20, 2010 8:00 PM, Wols Lists antli...@youngman.org.uk wrote: On 20/10/10 14:39, Wols Lists wrote: On 20/10/10 08:28, Sebastian Spaeth wrote: On Tue, 19 Oct 2010 23:45:11 +0200, René Kjellerup rk.katana.st...@gmail.com wrote: On the other matter unless you're still running kde 3 then you need --disable-kde else the config will fail when it can't find Qt 3.x On that matter can, we please --disable-kde by default. I don't know of recent distros that ship kde3 but not KDE4, and those who do can turn it on in their distro-specific defaults. Forgive the newbie question, but while I've got a lot of programming experience large chunks of detail here (gnu tools, frinstance) are new to me. I've dug a bit, found configure.in, and found AC_ARG_ENABLE(kde, [ --disable-kde Disables KDE native widgets.], ,) Does this switch it on? Will deleting it disable kde by default? If it will, I'll put a patch in. Even better, our make should detect the lack of qt3 headers and disable it automatically rather than bailing out. That's a bit deeper ... won't stop me having a go if someone would care to give me a few guidelines :-) Sebastian Cheers, Wol ___ Just found a bit more ... if test $enable_kde != no; then if test z$with_win32 = z -a z`uname -s` != zDarwin -a z$with_distro != zCrossWin32; then OOO_WIDGET_FLAGS=--enable-kde widget_sets=kde fi else OOO_WIDGET_FLAGS=--disable-kde fi I'm going to try changing != no to = yes - is that a sensible thing to do? I'm sure it'll work for me, but will it make it blow up when people want kde3 - does enable default to a value of yes? Cheers, Wol ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] how can we import/export .cbz/.cbr files on LibreOffice Impress?
One feature in here (that I really liked about the newest powerpoint) is the ease to fill slides with just photo's. 2010/10/20 Thorsten Behrens t...@documentfoundation.org: Paulo Silva wrote: A missing awesome feature on LibreOffice Impress would be the possibility on importing/exporting .cbz and .cbr files on LibreOffice Impress. Hi Paulo, hm, that almost sound like a useful thing to have outside LibO - you can reasonably easily synthesize odf files - there are interfaces to handle odf packages xml details e.g. for java, python and perl. Would you be interested in having a go with that? Cheers, -- Thorsten ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice -- Linux-user #496644 (http://counter.li.org) - first touch of linux in 2004 Demandoj en aŭ pri Esperanto? Questions about Esperanto? Vragen over Esperanto? Perguntas sobre o Esperanto? - http://demandoj.tk ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] howto for getting non-trivial cppunit tests up and running
Caolan McNamara wrote: sc/qa/unit had an existing cppunit test to ensure that calc can do =SUM(A1:A2) correctly but it was currently disabled seeing as it didn't work, mostly due to miserable bootstrapping problems. I've fixed that test (I think), so I hope it can now provide a basis for adding more. [...] Hi Caolan - interesting, cool that this is actually possible - I kinda evaded the full-scale bootstrapping problem somehow, mostly doing scaffolding for testing parts of app functionality. There are three patches where I ended up with useful unit tests: lobuild/patches/unittesting/unittesting-more-sw.diff lobuild/patches/dev300/impress-autolayout.diff lobuild/patches/dev300/sd_effects_styles.diff The impress autolayout actually gets away w/o any uno setup; the writer test fakes a uno.ini (see the makefile there) - I guess, there's a fine line between trying to fake a ~whole office setup, vs. testing exactly one class (and doing some scaffolding and/or refactoring to really only test that one class) - for the former, maybe the complextest framework is a closer fit? So, one suggestion I have it to look at stripmining testtool and try and start to *move* the calc tests out of the unreliable and painful testtool and into hopefully reliable cppunit tests which are run at buildtime That would be a *very* useful end result. Cheers, -- Thorsten pgpCUdBcRciNq.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Filters - Clean up comments in sw_unosett.cxx
A patch to clean up comments.
Graeme
From c16ca6be0594106268dc94646b1fc0724e924461 Mon Sep 17 00:00:00 2001
From: J. Graeme Lingard jgraeme+...@gmail.com
Date: Thu, 21 Oct 2010 00:27:09 +0100
Subject: [PATCH] Clean up comments in sw_unosett.cxx
---
binfilter/bf_sw/source/core/unocore/sw_unosett.cxx | 217 +--
1 files changed, 12 insertions(+), 205 deletions(-)
diff --git a/binfilter/bf_sw/source/core/unocore/sw_unosett.cxx b/binfilter/bf_sw/source/core/unocore/sw_unosett.cxx
index eb1e439..9a03998 100644
--- a/binfilter/bf_sw/source/core/unocore/sw_unosett.cxx
+++ b/binfilter/bf_sw/source/core/unocore/sw_unosett.cxx
@@ -26,7 +26,6 @@
*
/
-
#ifdef _MSC_VER
#pragma hdrstop
#endif
@@ -113,7 +112,7 @@ struct PropValData
};
typedef PropValData* PropValDataPtr;
-SV_DECL_PTRARR(PropValDataArr, PropValDataPtr, 5, 5 )//STRIP008 ;
+SV_DECL_PTRARR(PropValDataArr, PropValDataPtr, 5, 5 )
SV_IMPL_PTRARR(PropValDataArr, PropValDataPtr)
@@ -210,9 +209,6 @@ const SfxItemPropertyMap* GetLineNumberingMap()
return aLineNumberingMap_Impl;
}
-/* -05.05.98 08:30---
- *
- * --*/
SwCharFmt* lcl_getCharFmt(SwDoc* pDoc, const uno::Any aValue)
{
SwCharFmt* pRet = 0;
@@ -233,9 +229,7 @@ SwCharFmt* lcl_getCharFmt(SwDoc* pDoc, const uno::Any aValue)
}
return pRet;
}
-/* -05.05.98 08:30---
- *
- * --*/
+
SwTxtFmtColl* lcl_GetParaStyle(SwDoc* pDoc, const uno::Any aValue)
{
OUString uTmp;
@@ -251,9 +245,7 @@ SwTxtFmtColl* lcl_GetParaStyle(SwDoc* pDoc, const uno::Any aValue)
}
return pRet;
}
-/* -05.05.98 08:30---
- *
- * --*/
+
SwPageDesc* lcl_GetPageDesc(SwDoc* pDoc, const uno::Any aValue)
{
SwPageDesc* pRet = 0;
@@ -279,9 +271,7 @@ SwPageDesc* lcl_GetPageDesc(SwDoc* pDoc, const uno::Any aValue)
}
return pRet;
}
-/**
- *
- **/
+
// Numerierung
const unsigned short aSvxToUnoAdjust[] =
{
@@ -306,23 +296,16 @@ const unsigned short aUnoToSvxAdjust[] =
/**
* SwXFootnoteProperties
**/
-/* -06.04.00 11:43
-
- ---*/
OUString SwXFootnoteProperties::getImplementationName(void) throw( RuntimeException )
{
return C2U(SwXFootnoteProperties);
}
-/* -06.04.00 11:43
- ---*/
BOOL SwXFootnoteProperties::supportsService(const OUString rServiceName) throw( RuntimeException )
{
return C2U(com.sun.star.text.FootnoteSettings) == rServiceName;
}
-/* -06.04.00 11:43
- ---*/
Sequence OUString SwXFootnoteProperties::getSupportedServiceNames(void) throw( RuntimeException )
{
Sequence OUString aRet(1);
@@ -330,33 +313,24 @@ Sequence OUString SwXFootnoteProperties::getSupportedServiceNames(void) throw
pArray[0] = C2U(com.sun.star.text.FootnoteSettings);
return aRet;
}
-/*-- 14.12.98 14:03:20---
- ---*/
SwXFootnoteProperties::SwXFootnoteProperties(SwDoc* pDc) :
pDoc(pDc),
_pMap(GetFootnoteMap())
{
}
-/*-- 14.12.98 14:03:20---
- ---*/
SwXFootnoteProperties::~SwXFootnoteProperties()
{
-
}
-/*-- 14.12.98 14:03:20---
- ---*/
uno::Reference beans::XPropertySetInfo SwXFootnoteProperties::getPropertySetInfo(void)
throw( uno::RuntimeException )
{
static uno::Reference beans::XPropertySetInfo aRef = new SfxItemPropertySetInfo( _pMap );
return aRef;
}
-/*-- 14.12.98 14:03:20---
- ---*/
void SwXFootnoteProperties::setPropertyValue(const OUString rPropertyName, const uno::Any aValue)
throw( beans::UnknownPropertyException, beans::PropertyVetoException, lang::IllegalArgumentException,
Re: [Libreoffice] Address Books
On Oct 20, 2010, at 8:05 AM, Caolán McNamara wrote: On Wed, 2010-10-20 at 06:09 -0700, Joseph Powers wrote: It looks like someone already connected Base to Apple's Address Book (no bonus points for me) On my mac, I can't get the Mozilla Address Book driver to work. Hmm, see connectivity/source/drivers/mozab/makefile.mk Apparently on the mac its not built if I'm reading that right Which explains why the connection couldn't find the libraries. Preferences - LibreOffice Base - Connections shows that com.sun.star.comp.sdbc.MozabDriver is installed. probably should find out where that's coming from then This could be caused by the fact that the Connection was compiled into the program. C. So the short answer is: If the connection is compiled, you'll see the driver listed; however, if the external driver isn't found you can't using the connection and no error is given. Thanks for the help... now to see if I can force it to compile so I can play with it :) I think on Mac they disabled MozAB and use AppleAB instead. Which is ok, but we should leave both enabled. Mail.app is very limited so it's quite likely that someone may use Thunderbird instead. In which case we should allow the users to select the preferred address book. (side note: thunderbird also has an option to use the AppleAB by default) Joe P. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] remove pam in writer sw
remove pam in writer sw diff --git a/sw/source/filter/writer/writer.cxx b/sw/source/filter/writer/writer.cxx index db72a3c..708ab29 100644 --- a/sw/source/filter/writer/writer.cxx +++ b/sw/source/filter/writer/writer.cxx @@ -40,7 +40,6 @@ #include editeng/fontitem.hxx #include editeng/eeitem.hxx #include shellio.hxx -#include pam.hxx #include doc.hxx #include docary.hxx #include IMark.hxx diff --git a/sw/source/filter/writer/wrt_fn.cxx b/sw/source/filter/writer/wrt_fn.cxx index bab8f82..8a6273c 100644 --- a/sw/source/filter/writer/wrt_fn.cxx +++ b/sw/source/filter/writer/wrt_fn.cxx @@ -34,7 +34,6 @@ #include shellio.hxx #include wrt_fn.hxx -#include pam.hxx #include node.hxx #include format.hxx -- הבלוג שלי: http://nadavvin.com diff --git a/sw/source/filter/writer/writer.cxx b/sw/source/filter/writer/writer.cxx index db72a3c..708ab29 100644 --- a/sw/source/filter/writer/writer.cxx +++ b/sw/source/filter/writer/writer.cxx @@ -40,7 +40,6 @@ #include editeng/fontitem.hxx #include editeng/eeitem.hxx #include shellio.hxx -#include pam.hxx #include doc.hxx #include docary.hxx #include IMark.hxx diff --git a/sw/source/filter/writer/wrt_fn.cxx b/sw/source/filter/writer/wrt_fn.cxx index bab8f82..8a6273c 100644 --- a/sw/source/filter/writer/wrt_fn.cxx +++ b/sw/source/filter/writer/wrt_fn.cxx @@ -34,7 +34,6 @@ #include shellio.hxx #include wrt_fn.hxx -#include pam.hxx #include node.hxx #include format.hxx ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] ucb/source/ucb compilation error
At 1:11am -0400 Thu, 21 Oct 2010, Kevin Hunter wrote: 3. Misinterpretation of __PRETTY_FUNCTION__? What is __PRETTY_FUNCTION__? It changed in GCC 3.4, I believe. Now, contrary to the implicit understanding from its all caps nature, it is *not* a macro; it's a language identifier: http://gcc.gnu.org/onlinedocs/gcc/Function-Names.html I need to learn to read more thoroughly. For C only, it was changed in GCC 3.4. It's apparently always been treated as a variable in C++: In C++, __FUNCTION__ and __PRETTY_FUNCTION__ have always been variables. Cheers, Kevin ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
