Re: [Libreoffice] Templates path, move language independent stuffs to common folder

2011-05-29 Thread KAMI911 KAMI911
Hi Andras, Michael, Caolan!


I would like to share my findings.

1)

https://bugs.freedesktop.org/show_bug.cgi?id=37597 is not related to
my problem. It seems templates are checked only only one level not
recursively in the subdirs.
Maybe a fix need for it.

2) Michael, en-US forlder in added by report designer:

extensions/report-builder/registry/data/org/openoffice/Office/Paths.xcu
node oor:name=%origin%/../../../../../template oor:op=fuse/
To fix it we should change this path to
%origin%/../../../../../template/en-US/wizard

3) Related to templates path that I would like to change

The current settings are in
officecfg/registry/schema/org/openoffice/Office/Common.xcs:

prop oor:name=Template oor:type=oor:string-list
  info
 authorMBA/author
 descSpecifies the templates originate from these folders and
sub-folders./desc
   /info
  value 
oor:separator=:$(insturl)/share/template/$(vlang):$(insturl)/share/template:$(userurl)/template/value


prop oor:name=Template oor:type=oor:string-list
   info
 descSpecifies the default directory where all provided
templates are located in folders and sub-folders./desc
   /info
   value 
oor:separator=:$(insturl)/share/template/$(vlang):$(insturl)/share/template:$(userurl)/template/value

(also I did small changes in scp2 module too.

When I set 
$(insturl)/share/template/$(vlang):$(insturl)/share/template/common:$(userurl)/template
in Common.xcs I expected to Settings/Path UI comes up with all three
paths like this:
/opt/libreoffice3.4/basis3.4/share/template/hu (hu is my current UI language)
/opt/libreoffice3.4/basis3.4//share/template/common
/home/kami/.oxygenoffice/3/user/template

but I only get /home/kami/.oxygenoffice/3/user/template

Then I added as
$(insturl)/share/template/$(vlang)/:$(insturl)/share/template/common/:$(userurl)/template/,
so I  closed I path with /. then I get this
/opt/libreoffice3.4/basis3.4/share/template/hu (hu is my current UI language)
/opt/libreoffice3.4/basis3.4//share/template/common
/home/kami/.oxygenoffice/3/user/template
/home/kami/.oxygenoffice/3/user/template

So are we confident about leaving closing /is the good practice?

So finally I tested with:

  value 
oor:separator=:$(insturl)/share/template/$(vlang)/:$(insturl)/share/template/common/value

And I got the desired path settings:
/opt/libreoffice3.4/basis3.4/share/template/hu (hu is my current UI language)
/opt/libreoffice3.4/basis3.4//share/template/common
/home/kami/.oxygenoffice/3/user/template

What is your opinion? Why closing / matters? Can I commit patch for
it in master? Then I would like to get it to 3-4 if this is the good
behavior.

Regards,
KAMI




2011/5/26 Andras Timar tima...@gmail.com:
 Hi KAMI,

 2011/5/26 KAMI911 KAMI911 kami...@gmail.com:
 Hi Andras!

 Thank you for your answer. I will test on master (currently I have
 Linux only) Is it possible to use build services for other platforms?
 Using share/template folder in path creates a problem: you all subdirs
 appear as empty subdir in the templates selector of File - New - From
 template.
 I would like to fix this issue by moving language independent fulder
 to a subfolder (common) and set the path to this share/template/common
 folder instead of share/template.


 Have you seen this bug?
 https://bugs.freedesktop.org/show_bug.cgi?id=37597
 It may be related.

 Regards,
 Andras

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] Templates path, move language independent stuffs to common folder

2011-05-26 Thread Michael Meeks
Hi Kami,

On Wed, 2011-05-25 at 09:49 +0200, KAMI911 KAMI911 wrote:
 Currently all templates installed by LibreOffice (3.4) are in:
 /opt/libreoffice3.4/basis3.4/share/template

Right.

 If someone adds here subfolders it is appear as empty subfolder while
 create a new document from template.

So in the File-Templates-Organize - we see the bogus 'en_US'
directory that we don't want ? :-) or is this another issue ?

  By the go-oo time we used common
 subfolder for such language independent files. Can we move
 /opt/libreoffice3.4/basis3.4/share/template/layout to
 /opt/libreoffice3.4/basis3.4/share/template/common/layout.

Sounds fine to me - but it'd be great to explain the concrete impact
more clearly. Also, as Andras says, lets get this into master quickly,
and then 

 In master i would like to delete $(insturl)/share/template reference
 and change the scp2 module to follow this change.

It'd be great to better understand the rational ( not everyone is as
expert with templates and their problems as you :-) but in principle it
sounds fine to me !

Thanks,

Michael.

-- 
 michael.me...@novell.com  , Pseudo Engineer, itinerant idiot


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] Templates path, move language independent stuffs to common folder

2011-05-25 Thread Andras Timar
Hi Kami,

2011/5/25 KAMI911 KAMI911 kami...@gmail.com:
 Hi LibreOffice Developers,

 Currently all templates installed by LibreOffice (3.4) are in:
 /opt/libreoffice3.4/basis3.4/share/template

 If someone adds here subfolders it is appear as empty subfolder while
 create a new document from template. By the go-oo time we used common
 subfolder for such language independent files. Can we move
 /opt/libreoffice3.4/basis3.4/share/template/layout to
 /opt/libreoffice3.4/basis3.4/share/template/common/layout.

 It has scp2 related and officecfg related changes.

I did not understand 100% what you wrote but it may be a good idea. I
suggest that you make your changes locally (in master), then test if
it builds in all platforms, then test if it causes upgrade problems
from previous versions (e.g with existing user profile). Then you can
push it to master. When we see your commit in master, we can tell if
it is good for 3-4 ot not.

Thanks,
Andras
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] Templates path, move language independent stuffs to common folder

2011-05-25 Thread Caolán McNamara
On Wed, 2011-05-25 at 09:49 +0200, KAMI911 KAMI911 wrote:
 Hi LibreOffice Developers,
 
 Currently all templates installed by LibreOffice (3.4) are in:
 /opt/libreoffice3.4/basis3.4/share/template
 
 If someone adds here subfolders it is appear as empty subfolder while
 create a new document from template.

Not sure what you're describing, but perhaps its a caching bug of
somekind, i.e. are you saying that the newly added dir isn't being read
correctly by the template dialog ? If so, why not debug into and fix the
root cause.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice