[LAD] Re: Update of zita-at1

2024-04-20 Thread Fons Adriaensen
On Sat, Apr 20, 2024 at 03:47:20PM +0200, Robin Gareus wrote:
 
> Either I have to backport your bug-fixes, or add the missing features to
> your new version.

With the new logic deciding on forward / backward jumps, the 
low latency mode just came for free - all it takes is just
changing the value of one variable. BTW, the 'correct' latency,
the one that would perfectly align the pitch detection with the
signal, would be 5/8, not 1/2 of the input size. But I kept
1/2 in order to match the latency of the original version.
For low latency, I use 1/4, around 10 ms.

The standard 'bugs' were not in the Retuner class, so they
won't affect the plugin code.

Re. microtuning individual notes: I don't think the retuning
is ever accurate enough for this to be of any use. Or maybe
I misunderstand what you refer to.

What would be great (in particular for zita-at2) would be
a mode were you can e.g. select a region in Ardour, have it
analysed, present the result graphically so it can be edited,
and finally apply the edited version to the region...

It would require separating the pitch detection, the logic
that decides on the amound of correction, and the actual
processing of the signal as separately usable components.
I'll keep this in mind when designing zita-at2.

Ciao,

-- 
FA

___
Linux-audio-dev mailing list -- linux-audio-dev@lists.linuxaudio.org
To unsubscribe send an email to linux-audio-dev-le...@lists.linuxaudio.org


[LAD] Re: Update of zita-at1

2024-04-20 Thread Robin Gareus

Hi Fons,

it's great to see you have not lot your edge! :)

On 2024-04-20 11:50, Fons Adriaensen wrote:

> The new Retuner class can probably be used without changes
> in the x42-autotuner plugin.
I had a quick look and and sadly it's not that simple. The plugin 
already has a low latency mode, and supports for per note microtuning.


Either I have to backport your bug-fixes, or add the missing features to 
your new version. Then I will have to check that the behavior of 0.8.2 
does not alter the sound of existing sessions using the plugin.


Can you elaborate on the bug fixes that you made?

I'm already looking forward to zita-at2! That will have to be a new 
plugin. So perhaps there is also an option to wait for that to drop.


Thanks for your hard work on this.

--
robin


OpenPGP_signature.asc
Description: OpenPGP digital signature
___
Linux-audio-dev mailing list -- linux-audio-dev@lists.linuxaudio.org
To unsubscribe send an email to linux-audio-dev-le...@lists.linuxaudio.org


[LAD] Update of zita-at1

2024-04-20 Thread Fons Adriaensen
Hello all,

Zita-at1-0.8.1 is now available at the usual place:



Note: this is not (yet) the new zita-at2 that will have formant
correction. 

Changes:

- Bug fixes.
- Improved pitch estimation algorithm.
- Low latency mode, reduces latency to around 10 ms.


Note to Robin Gareus:

The new Retuner class can probably be used without changes
in the x42-autotuner plugin.

The logic that controls jumping forward/back while resampling
has been changed. Instead of just trying to avoid reading 
outside the available input range, it now tries to keep the
read index as close as possible to the ideal position, i.e.
'latency' samples behind the write index. That also means
that for unvoiced input it will be within +/- 1.3 ms of the
ideal position, so nothing special is required for this case.

Ciao,

-- 
FA

___
Linux-audio-dev mailing list -- linux-audio-dev@lists.linuxaudio.org
To unsubscribe send an email to linux-audio-dev-le...@lists.linuxaudio.org