Re: [protobuf] Location of proto files in protobuf-kotlin JAR changed to src directory in version 3.25

[Wesley Hartford]

I've just created https://github.com/protocolbuffers/protobuf/issues/15407

Thanks,

Wesley

On Thu, Jan 11, 2024 at 10:35 AM Adam Cozzette  wrote:

> Thank you for the heads-up. That sounds like a real bug we should make
> sure to fix in the upcoming release. Would you mind filing a GitHub issue
> for this so that we can track it?
>
> On Mon, Jan 8, 2024 at 2:17 PM Wesley Hartford 
> wrote:
>
>> Starting with version 3.25.0 the protobuf-kotlin jar includes some common
>> .proto files in the JARs src/google/protobuf directory. Previous version
>> included these files in the google/protobuf directory (without the
>> parent src directory). I haven't been able to find any announcement or
>> explanation of this change. Current and past versions of the protobuf-java
>> JAR include the same .proto files in the google/protobuf directory.
>>
>> Was this change intentional? It caused one of my builds to break because
>> because the contents of the protobuf-kotlin and protobuf-java JAR were both
>> present causing protoc to detect conflicting declarations of the Any type.
>> My build was misconfiguration and has been fixed, but the change in
>> location still seems wrong to me, especially considering the protobuf-java
>> JAR still includes the same files in the original location.
>>
>> Thanks,
>>
>> Wesley Hartford
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "Protocol Buffers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to protobuf+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/protobuf/e5c4258b-a233-459b-b33e-af058d56d3c8n%40googlegroups.com
>> 
>> .
>>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Protocol Buffers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/protobuf/CA%2B%2B-c5z8jUrYpWUFQZ8vCWjQgOcxWVQ4OefderQWkZ30%3Dfc5xg%40mail.gmail.com.

Re: [protobuf] Location of proto files in protobuf-kotlin JAR changed to src directory in version 3.25

['Adam Cozzette' via Protocol Buffers]

Thank you for the heads-up. That sounds like a real bug we should make sure
to fix in the upcoming release. Would you mind filing a GitHub issue for
this so that we can track it?

On Mon, Jan 8, 2024 at 2:17 PM Wesley Hartford 
wrote:

> Starting with version 3.25.0 the protobuf-kotlin jar includes some common
> .proto files in the JARs src/google/protobuf directory. Previous version
> included these files in the google/protobuf directory (without the parent
> src directory). I haven't been able to find any announcement or
> explanation of this change. Current and past versions of the protobuf-java
> JAR include the same .proto files in the google/protobuf directory.
>
> Was this change intentional? It caused one of my builds to break because
> because the contents of the protobuf-kotlin and protobuf-java JAR were both
> present causing protoc to detect conflicting declarations of the Any type.
> My build was misconfiguration and has been fixed, but the change in
> location still seems wrong to me, especially considering the protobuf-java
> JAR still includes the same files in the original location.
>
> Thanks,
>
> Wesley Hartford
>
> --
> You received this message because you are subscribed to the Google Groups
> "Protocol Buffers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to protobuf+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/protobuf/e5c4258b-a233-459b-b33e-af058d56d3c8n%40googlegroups.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"Protocol Buffers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/protobuf/CADqAXr5Q-0N6z1x3k96ESEvKYN1%3DviN5inykVXzoXQ%2B1WihCfg%40mail.gmail.com.

[protobuf] Location of proto files in protobuf-kotlin JAR changed to src directory in version 3.25

[Wesley Hartford]

Starting with version 3.25.0 the protobuf-kotlin jar includes some common 
.proto files in the JARs src/google/protobuf directory. Previous version 
included these files in the google/protobuf directory (without the parent 
src directory). I haven't been able to find any announcement or explanation 
of this change. Current and past versions of the protobuf-java JAR include 
the same .proto files in the google/protobuf directory.

Was this change intentional? It caused one of my builds to break because 
because the contents of the protobuf-kotlin and protobuf-java JAR were both 
present causing protoc to detect conflicting declarations of the Any type. 
My build was misconfiguration and has been fixed, but the change in 
location still seems wrong to me, especially considering the protobuf-java 
JAR still includes the same files in the original location.

Thanks,

Wesley Hartford

-- 
You received this message because you are subscribed to the Google Groups 
"Protocol Buffers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/protobuf/e5c4258b-a233-459b-b33e-af058d56d3c8n%40googlegroups.com.