[issue35769] IDLE: change new file name from ''Untitled" to "untitled"

2019-01-17 Thread miss-islington


miss-islington  added the comment:


New changeset 5f9a168a313485791d85250e5bf673b66bd51244 by Miss Islington (bot) 
in branch '3.7':
bpo-35769: Change IDLE's name for new files from 'Untitled' to 'untitled' 
(GH-11602)
https://github.com/python/cpython/commit/5f9a168a313485791d85250e5bf673b66bd51244


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35769] IDLE: change new file name from ''Untitled" to "untitled"

2019-01-17 Thread miss-islington


Change by miss-islington :


--
pull_requests: +11325

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35769] IDLE: change new file name from ''Untitled" to "untitled"

2019-01-17 Thread Terry J. Reedy


Terry J. Reedy  added the comment:


New changeset a902239f22c322d8988c514dd1c724aade3e4ef3 by Terry Jan Reedy in 
branch 'master':
bpo-35769: Change IDLE's name for new files from 'Untitled' to 'untitled' 
(GH-11602)
https://github.com/python/cpython/commit/a902239f22c322d8988c514dd1c724aade3e4ef3


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35730] IDLE: Fix squeezer test_reload.

2019-01-17 Thread Terry J. Reedy


Terry J. Reedy  added the comment:

I looked at the non-green results on the buildbot grid and found one IDLE 
failure, which passed on retest.  I opened #35771 for this.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35771] IDLE: Fix tooltip Hovertiptest failure

2019-01-17 Thread Terry J. Reedy


New submission from Terry J. Reedy :

In the buildbot testing for #35730, this test failed on X86 Windows 3.7 and 
passed on retest.  I did not check the green bots, so there could be other fail 
and pass results.

==
FAIL: test_showtip_on_mouse_enter_hover_delay 
(idlelib.idle_test.test_tooltip.HovertipTest)
--
Traceback (most recent call last):
  File 
"D:\cygwin\home\db3l\buildarea\3.7.bolen-windows7\build\lib\idlelib\idle_test\test_tooltip.py",
 line 112, in test_showtip_on_mouse_enter_hover_delay
self.assertFalse(tooltip.tipwindow and tooltip.tipwindow.winfo_viewable())
AssertionError: 1 is not false

We should at least look at this since it might someday fail twice in a row on 1 
machine.

--
messages: 333946
nosy: taleinat, terry.reedy
priority: normal
severity: normal
stage: needs patch
status: open
title: IDLE: Fix tooltip Hovertiptest failure
type: behavior
versions: Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35769] IDLE: change new file name from ''Untitled" to "untitled"

2019-01-17 Thread Terry J. Reedy


Change by Terry J. Reedy :


--
pull_requests:  -11324

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35769] IDLE: change new file name from ''Untitled" to "untitled"

2019-01-17 Thread Terry J. Reedy


Change by Terry J. Reedy :


--
keywords: +patch, patch
pull_requests: +11323, 11324
stage: commit review -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35769] IDLE: change new file name from ''Untitled" to "untitled"

2019-01-17 Thread Terry J. Reedy


Change by Terry J. Reedy :


--
keywords: +patch
pull_requests: +11323
stage: commit review -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35770] IDLE: python -m idlelib fails on master on Mac OS 10.10.4

2019-01-17 Thread Karthikeyan Singaravelan

New submission from Karthikeyan Singaravelan :

I used to launch IDLE using from master using ./python.exe -m idlelib . It used 
to work but fails on master on Mac OS now. There seems to be some discussion 
about this on msg332672 after the commit 
c1b4b0f6160e1919394586f44b12538505fed300. Feel free to close this if it's a 
known issue. I haven't tested it on latest 3.7 but it seems the commit was also 
merged to 3.7 so I am just adding 3.8 as version.

Mac OS version : 10.10.4

➜  cpython git:(master) ✗ git checkout c1b4b0f6160e1919394586f44b12538505fed300 
Lib/idlelib && ./python.exe -m idlelib
Traceback (most recent call last):
  File "/Users/karthikeyansingaravelan/stuff/python/cpython/Lib/runpy.py", line 
192, in _run_module_as_main
return _run_code(code, main_globals, None,
  File "/Users/karthikeyansingaravelan/stuff/python/cpython/Lib/runpy.py", line 
85, in _run_code
exec(code, run_globals)
  File 
"/Users/karthikeyansingaravelan/stuff/python/cpython/Lib/idlelib/__main__.py", 
line 7, in 
idlelib.pyshell.main()
  File 
"/Users/karthikeyansingaravelan/stuff/python/cpython/Lib/idlelib/pyshell.py", 
line 1507, in main
macosx.setupApp(root, flist)
  File 
"/Users/karthikeyansingaravelan/stuff/python/cpython/Lib/idlelib/macosx.py", 
line 280, in setupApp
overrideRootMenu(root, flist)
  File 
"/Users/karthikeyansingaravelan/stuff/python/cpython/Lib/idlelib/macosx.py", 
line 181, in overrideRootMenu
del mainmenu.menudefs[-2][1][0]
IndexError: list assignment index out of range

➜  cpython git:(master) ✗ git checkout 
c1b4b0f6160e1919394586f44b12538505fed300~1 Lib/idlelib && ./python.exe -m 
idlelib # Works


$ git show c1b4b0f6160e1919394586f44b12538505fed300
commit c1b4b0f6160e1919394586f44b12538505fed300 (bpo35557, 35559)
Author: Cheryl Sabella 
Date:   Sat Dec 22 01:25:45 2018 -0500

 bpo-22703: IDLE: Improve Code Context and Zoom Height menu labels 
(GH-11214)



The Code Context menu label now toggles between Show/Hide Code Context.
 The Zoom Height menu now toggles between Zoom/Restore Height.
 Zoom Height has moved from the Window menu to the Options menu.


https://bugs.python.org/issue22703

--
assignee: terry.reedy
components: IDLE
messages: 333945
nosy: cheryl.sabella, taleinat, terry.reedy, xtreak
priority: normal
severity: normal
status: open
title: IDLE: python -m idlelib fails on master on Mac OS 10.10.4
versions: Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35730] IDLE: Fix squeezer test_reload.

2019-01-17 Thread Terry J. Reedy


Change by Terry J. Reedy :


--
pull_requests:  -11322

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35730] IDLE: Fix squeezer test_reload.

2019-01-17 Thread Terry J. Reedy


Change by Terry J. Reedy :


--
pull_requests:  -11321

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue25522] IDLE: warn if save-as name matches stdlib name

2019-01-17 Thread Terry J. Reedy


Terry J. Reedy  added the comment:

Also check if the name is not an identifier and therefore could not be 
imported.  Example:

>>> exec('import abc--bb')
import abc--bb
  ^
SyntaxError: invalid syntax

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35769] IDLE: change new file name from ''Untitled" to "untitled"

2019-01-17 Thread Terry J. Reedy


New submission from Terry J. Reedy :

Conform to PEP 8.

--
assignee: terry.reedy
components: IDLE
messages: 333943
nosy: terry.reedy
priority: normal
severity: normal
stage: commit review
status: open
title: IDLE: change new file name from  ''Untitled" to "untitled"
type: enhancement
versions: Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34850] Emit a syntax warning for "is" with a literal

2019-01-17 Thread Serhiy Storchaka


Serhiy Storchaka  added the comment:

Thanks.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34850] Emit a syntax warning for "is" with a literal

2019-01-17 Thread Serhiy Storchaka


Serhiy Storchaka  added the comment:


New changeset 3bcbedc9f1471d957a30a90f9d1251516b422416 by Serhiy Storchaka in 
branch 'master':
bpo-34850: Emit a warning for "is" and "is not" with a literal. (GH-9642)
https://github.com/python/cpython/commit/3bcbedc9f1471d957a30a90f9d1251516b422416


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35757] slow subprocess.Popen(..., close_fds=True)

2019-01-17 Thread Benjamin Peterson


Benjamin Peterson  added the comment:

Yeah, this is WONTFIX particularly since you can have the Python3 
implementation in Python 2 easily with https://pypi.org/project/subprocess32/.

--
nosy: +benjamin.peterson
resolution:  -> wont fix
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35768] IDLE: Auto measure font fixed pitch characteristics

2019-01-17 Thread Terry J. Reedy


New submission from Terry J. Reedy :

The greatly expanded configdialog Font tab multi-alphabet sample reveals to 
some degree how well tk fills in BMP Unicode characters on a particular 
machine.  It also lets users extend the sample.

The sample has 2 lines of 20 ascii characters each and lines of 20 non-Latin1, 
IPA, Greek, Cyrillic, Hebrew, and Arabic characters.  The intention is to let 
one see if a font (as extended) is fixed-pitch for Ascii and if that property 
extends to any of those other European and Near East alphabets. On my machine, 
the number of fixed alphabets varies from 0, 1 (ascii), 2 (rest of Latin1) up 
to 7 (for Courier) (and some in between).

On #35196, Raymond Hettinger asked whether fixed-pitch fonts could be detected. 
 With the caveat that this property is not binary unless we restrict attention 
to Ascii, yes.  Without measuring each character, we could check the ascii 
lines and then the others. We could then highlight the lines in the sample that 
pass.

Before coding, we need to experiment a bit with the Font measuring method.  
Should we cache results in .idlerc?

For all the fonts on my machine, the East Asian CJK characters are filled in 
with a fixed-pitch that is about 1.6 to 1.8 (not 2.0) times the Ascii fixed or 
average pitch.

Raymond also suggested limiting the font list to those with fixed ascii.  I 
think at least segregating fixed Ascii pitch fonts to make them easy to find is 
a great idea.  Some detail need to be thought about.

--
assignee: terry.reedy
components: IDLE
messages: 333939
nosy: terry.reedy
priority: normal
severity: normal
stage: test needed
status: open
title: IDLE: Auto measure font fixed pitch characteristics
type: enhancement
versions: Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35767] unittest loader doesn't work with partial test functions

2019-01-17 Thread Karthikeyan Singaravelan


Karthikeyan Singaravelan  added the comment:

Seems this was introduced with issue32071

--
nosy: +jonash, pitrou, xtreak

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35734] Remove unused _BaseV4._is_valid_netmask in ipaddress

2019-01-17 Thread ulin


ulin  added the comment:

OK, message copied, I'll mark it closed. :)

--
resolution:  -> not a bug
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue31860] IDLE: Make font sample editable

2019-01-17 Thread Terry J. Reedy


Terry J. Reedy  added the comment:

Closing #31777 as duplicate of this.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue31777] IDLE: Let users add to font selection

2019-01-17 Thread Terry J. Reedy


Terry J. Reedy  added the comment:

Serhiy opened #31860 with a patch.  So close this as duplicate.

--
resolution:  -> duplicate
stage: test needed -> resolved
status: open -> closed
superseder:  -> IDLE: Make font sample editable

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35730] IDLE: Fix squeezer test_reload.

2019-01-17 Thread miss-islington


miss-islington  added the comment:


New changeset 237f864c905531b2da211bebc5f6109b0b797bac by Miss Islington (bot) 
in branch '3.7':
bpo-35730: IDLE - test squeezer reload() by checking load_font() (GH-11585)
https://github.com/python/cpython/commit/237f864c905531b2da211bebc5f6109b0b797bac


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35730] IDLE: Fix squeezer test_reload.

2019-01-17 Thread miss-islington


Change by miss-islington :


--
pull_requests: +11320

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35730] IDLE: Fix squeezer test_reload.

2019-01-17 Thread miss-islington


Change by miss-islington :


--
pull_requests: +11320, 11321, 11322

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35730] IDLE: Fix squeezer test_reload.

2019-01-17 Thread Terry J. Reedy


Terry J. Reedy  added the comment:


New changeset e55cf024cae203f63b4f78f1b21c1375fe424441 by Terry Jan Reedy (Tal 
Einat) in branch 'master':
bpo-35730: IDLE - test squeezer reload() by checking load_font() (GH-11585)
https://github.com/python/cpython/commit/e55cf024cae203f63b4f78f1b21c1375fe424441


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35730] IDLE: Fix squeezer test_reload.

2019-01-17 Thread miss-islington


Change by miss-islington :


--
pull_requests: +11320, 11321

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35757] slow subprocess.Popen(..., close_fds=True)

2019-01-17 Thread Josh Rosenberg


Josh Rosenberg  added the comment:

Others can correct me if I'm wrong, but I'm fairly sure 2.7 isn't making 
changes unless they fix critical or security-related bugs.

The code here is suboptimal, but it's already been fixed in Python 3 (in 
#8052), as part of a C accelerator module (that reduces the risk of race 
conditions and other conflicts your Python level fix entails). Unless someone 
corrects me, I'll close this as "Won't Fix".

--
nosy: +josh.r

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35765] Document references object x but doesn't show it in the example

2019-01-17 Thread Karthikeyan Singaravelan


Karthikeyan Singaravelan  added the comment:

Thanks for the report. I think x here is implied as [1, 'simple', 'list']. Do 
you want to make it explicit with x = [1, 'simple', 'list'] in the code block?

Removing 3.5 since it's in security fixes only mode.

--
nosy: +xtreak
versions: +Python 3.7, Python 3.8 -Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35730] IDLE: Fix squeezer test_reload.

2019-01-17 Thread Terry J. Reedy


Change by Terry J. Reedy :


--
pull_requests:  -11273

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35730] IDLE: Fix squeezer test_reload.

2019-01-17 Thread Terry J. Reedy


Change by Terry J. Reedy :


--
pull_requests:  -11274

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35283] "threading._DummyThread" redefines "is_alive" but forgets "isAlive"

2019-01-17 Thread Dong-hee Na


Dong-hee Na  added the comment:

Great!
Should we notify this deprecation also on Doc/whatsnew/3.7.rst?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35767] unittest loader doesn't work with partial test functions

2019-01-17 Thread Jason Fried


Change by Jason Fried :


--
keywords: +patch, patch, patch
pull_requests: +11316, 11317, 11318
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35767] unittest loader doesn't work with partial test functions

2019-01-17 Thread Jason Fried


Change by Jason Fried :


--
keywords: +patch
pull_requests: +11316
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35767] unittest loader doesn't work with partial test functions

2019-01-17 Thread Jason Fried


Change by Jason Fried :


--
keywords: +patch, patch
pull_requests: +11316, 11317
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35701] [uuid] 3.8 breaks weak references for UUIDs

2019-01-17 Thread Josh Rosenberg


Josh Rosenberg  added the comment:

The UUID module documentation (and docstring) begin with:

"This module provides immutable UUID objects"

Immutable is a stronger guarantee than __slots__ enforces already, so the 
documentation already ruled out adding arbitrary attributes to UUID (and the 
__setattr__ that unconditionally raised TypeError('UUID objects are immutable') 
supported that.

Given the behavior hasn't changed in any way that contradicts the docs, nor 
would it affect anyone who wasn't intentionally working around the __setattr__ 
block, I don't feel a need to mention the arbitrary attribute limitation.

It's fine to leave in the What's New note (it is a meaningful memory savings 
for applications using lots of UUIDs), but the note can simplify to just:

"""uuid.UUID now uses __slots__ to reduce its memory footprint."""

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35767] unittest loader doesn't work with partial test functions

2019-01-17 Thread Jason Fried


Jason Fried  added the comment:

working on a pull request

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35767] unittest loader doesn't work with partial test functions

2019-01-17 Thread Jason Fried


Jason Fried  added the comment:

Oh this is broken in 3.7 trunk

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35767] unittest loader doesn't work with partial test functions

2019-01-17 Thread Jason Fried


New submission from Jason Fried :

https://github.com/python/cpython/blob/3.7/Lib/unittest/loader.py#L232

fullName = '%s.%s' % (testCaseClass.__module__, testFunc.__qualname__)

Instead we should probably replace testFunc.__qualname__ with attrname

I ran into this while running a test suite that built up test functions using 
partials and added them to the TestCase class with setattr. 

This works in 3.6.3

--
messages: 333926
nosy: fried, lisroach, lukasz.langa
priority: normal
severity: normal
status: open
title: unittest loader doesn't work with partial test functions
versions: Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35486] subprocess module import hooks breaks back compatibility

2019-01-17 Thread Ned Deily


Ned Deily  added the comment:

I've merged the doc changes for 3.6, thanks.  Can we close this now?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35486] subprocess module import hooks breaks back compatibility

2019-01-17 Thread Ned Deily


Ned Deily  added the comment:


New changeset 1edb3dc6ff70db88a7e89586578e58a86ee0e75e by Ned Deily (Miss 
Islington (bot)) in branch '3.6':
bpo-35486: Note Py3.6 import system API requirement change (GH-11540) (GH-11588)
https://github.com/python/cpython/commit/1edb3dc6ff70db88a7e89586578e58a86ee0e75e


--
nosy: +ned.deily

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34850] Emit a syntax warning for "is" with a literal

2019-01-17 Thread Gregory P. Smith


Gregory P. Smith  added the comment:

Lets move forward with this as a SyntaxWarning in 3.8 and see if anyone 
complains during the betas.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35525] Incorrect keyword name in NNTP.starttls() documentation

2019-01-17 Thread Ned Deily


Ned Deily  added the comment:


New changeset 7887c02d3372ebe3b39379588364134521a36c4e by Ned Deily (Miss 
Islington (bot)) in branch '3.6':
bpo-35525: Correct the argument name for NNTP.starttls() (GH-11310) (GH-11417)
https://github.com/python/cpython/commit/7887c02d3372ebe3b39379588364134521a36c4e


--
nosy: +ned.deily

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35601] Race condition in test_signal_handling_args x86-64 High Sierra 3.75

2019-01-17 Thread Ned Deily


Ned Deily  added the comment:


New changeset 7eef540ab89e426b622373f43713521876447f2f by Ned Deily (Miss 
Islington (bot)) in branch '3.6':
bpo-35601: Alleviate race condition when waiting for SIGALRM in test_asyncio 
(GH-11337) (GH-11348)
https://github.com/python/cpython/commit/7eef540ab89e426b622373f43713521876447f2f


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34162] idlelib/NEWS.txt for 3.8.0 (and backports)

2019-01-17 Thread Terry J. Reedy


Terry J. Reedy  added the comment:


New changeset 59d7bdb3386ab78ccf6edbbeba9669124515c707 by Terry Jan Reedy (Miss 
Islington (bot)) in branch '3.7':
bpo-34162: Update idlelib/NEWS.txt to 2019 Jan 17 (GH-11597) (GH-11598)
https://github.com/python/cpython/commit/59d7bdb3386ab78ccf6edbbeba9669124515c707


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23156] Remove tix install information in tkinter tix chapter of doc

2019-01-17 Thread Terry J. Reedy


Change by Terry J. Reedy :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
title: Update tix install information in tkinter tix chapter of doc -> Remove 
tix install information in tkinter tix chapter of doc
versions: +Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35766] Merge typed_ast back into CPython

2019-01-17 Thread Guido van Rossum

New submission from Guido van Rossum :

(This started at 
https://discuss.python.org/t/merge-typed-ast-back-into-cpython/377. It's 
somewhat related to https://bugs.python.org/issue7.) 

I now have a thorough understanding of what typed_ast does, and I think it 
would be straightforward to port it upstream. We’d need to define two new 
tokens to represent `# type: ignore` and `# type: `, and tokenizer 
code to recognize these. Then we need a new flag to be passed to the tokenizer 
(via the parser) that enables this behavior. We make a small number of changes 
to `Grammar` (inserting optional `TYPE_COMMENT` tokens and to `Python.asdl` 
(adding fields to a few node types to hold the optional type comment), and a 
fair number of changes to `ast.c` to extract the type comments. We have similar 
patches for 3.6 and 3.7, so it's a simple matter of porting those patches to 
3.8.

By default, `ast.parse()` should not return type comments, since this would 
reject some perfectly good Python code (with sonething looking like a type 
comment in a place where the grammar doesn’t allow it). But passing an new flag 
will cause the tokenizer to process type comments and the returned tree will 
contain them.

I could produce a PR with this in a few days (having just gone over most of the 
process for porting typed_ast from 3.6 to 3.7).

There’s one more feature I’d like to lobby for – a feature_version flag that 
modifies the grammar slightly so it resembles an older version of Python (going 
back to 3.4). This is used in mypy to decouple the Python version you’re 
running from the Python version for which you’re checking compatibility (useful 
when checking code that will be deployed on a system with a different Python 
version installed). I imagine this would be useful to other linters as well, 
and the implementation is mostly manipulating whether `async` and `await` are 
keywords. But if there’s pushback to this part I can live without it – the rest 
of the work is still useful.

In the next few days I will produce a PR so people can see for themselves.

In https://discuss.python.org/t/merge-typed-ast-back-into-cpython/377/17, 
Łukasz offered to merge my PR.

--
components: Library (Lib)
messages: 333919
nosy: gvanrossum
priority: normal
severity: normal
stage: needs patch
status: open
title: Merge typed_ast back into CPython
type: enhancement
versions: Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35756] Using `return value` in a generator function skips the returned value on for-loop iteration

2019-01-17 Thread bryan.koch


bryan.koch  added the comment:

Thank you both for the clarifications.  I agree these's no bug in `yield from` 
however is there a way to reference the return value when a generator with a 
return is invoked using `for val in gen` i.e. when the generator is invoked 
without delegation?

I could write my own wrapper around using `next` to work around this but it 
might be an oversight of the new grammar (new being relative) that the return 
value is only available when invoked from the `yield from` syntax.

Essentially I have code that looks like
`
for value in generator:
  do thing with value
  yield value
`
where I need to do something before yielding the value.  It would be awesome if 
invoking a generator above would throw a SyntaxError iff it contained a return 
and it wasn't invoked through `yield from`.

The below isn't valid Python and I'm not sure that it should be but it's what I 
need to do.

`
return_value = for value in generator:
  do thing with value
  yield value

if return_value:
  do something with return_value
`

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35765] Document references object x but doesn't show it in the example

2019-01-17 Thread Patrick Rice


New submission from Patrick Rice :

https://docs.python.org/3.5/tutorial/inputoutput.html

If you have an object x, you can view its JSON string representation with a 
simple line of code:

>>>
>>> import json
>>> json.dumps([1, 'simple', 'list'])
'[1, "simple", "list"]'

--
assignee: docs@python
components: Documentation
messages: 333917
nosy: Patrick Rice, docs@python
priority: normal
severity: normal
status: open
title: Document references object x but doesn't show it in the example
versions: Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23156] Update tix install information in tkinter tix chapter of doc

2019-01-17 Thread miss-islington


miss-islington  added the comment:


New changeset ebb08beb08461eb5f147aaca6f86cafa4ea15bff by Miss Islington (bot) 
in branch '3.7':
bpo-23156: Remove obsolete tix install directions (GH-11595)
https://github.com/python/cpython/commit/ebb08beb08461eb5f147aaca6f86cafa4ea15bff


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34161] (good first issue) Tutorial 7.1 str.format() code example syntax error

2019-01-17 Thread miss-islington


Change by miss-islington :


--
pull_requests: +11315

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23156] Update tix install information in tkinter tix chapter of doc

2019-01-17 Thread Terry J. Reedy


Terry J. Reedy  added the comment:


New changeset cf27c06229eb4b8280bb5f2b93a57e33163411f4 by Terry Jan Reedy in 
branch 'master':
bpo-23156: Remove obsolete tix install directions (GH-11595)
https://github.com/python/cpython/commit/cf27c06229eb4b8280bb5f2b93a57e33163411f4


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34161] (good first issue) Tutorial 7.1 str.format() code example syntax error

2019-01-17 Thread Terry J. Reedy


Terry J. Reedy  added the comment:

Sorry for the noise.  It seems like a bug to me that GitHub keeps a secret link 
to the original title and uses it in the merge box.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34161] (good first issue) Tutorial 7.1 str.format() code example syntax error

2019-01-17 Thread Terry J. Reedy


Change by Terry J. Reedy :


--
Removed message: https://bugs.python.org/msg333912

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34162] idlelib/NEWS.txt for 3.8.0 (and backports)

2019-01-17 Thread Terry J. Reedy


Terry J. Reedy  added the comment:

New changeset 56c16057c639acc2fb89c6b783425320f23a5f6c by Terry Jan Reedy in 
branch 'master':
bpo-34161: Update idlelib/NEWS.txt to 2019 Jan 17 (GH-11597)
https://github.com/python/cpython/commit/56c16057c639acc2fb89c6b783425320f23a5f6c

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34161] (good first issue) Tutorial 7.1 str.format() code example syntax error

2019-01-17 Thread Terry J. Reedy


Change by Terry J. Reedy :


--
pull_requests:  -11308

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34161] (good first issue) Tutorial 7.1 str.format() code example syntax error

2019-01-17 Thread Terry J. Reedy


Change by Terry J. Reedy :


--
pull_requests:  -11309

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34161] (good first issue) Tutorial 7.1 str.format() code example syntax error

2019-01-17 Thread Terry J. Reedy


Change by Terry J. Reedy :


--
pull_requests:  -11310

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34162] idlelib/NEWS.txt for 3.8.0 (and backports)

2019-01-17 Thread miss-islington


Change by miss-islington :


--
pull_requests: +11311

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34161] (good first issue) Tutorial 7.1 str.format() code example syntax error

2019-01-17 Thread miss-islington


Change by miss-islington :


--
pull_requests: +11308, 11309, 11310

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34161] (good first issue) Tutorial 7.1 str.format() code example syntax error

2019-01-17 Thread miss-islington


Change by miss-islington :


--
pull_requests: +11308, 11309

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34161] (good first issue) Tutorial 7.1 str.format() code example syntax error

2019-01-17 Thread miss-islington


Change by miss-islington :


--
pull_requests: +11308

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34161] (good first issue) Tutorial 7.1 str.format() code example syntax error

2019-01-17 Thread Terry J. Reedy


Terry J. Reedy  added the comment:


New changeset 56c16057c639acc2fb89c6b783425320f23a5f6c by Terry Jan Reedy in 
branch 'master':
bpo-34161: Update idlelib/NEWS.txt to 2019 Jan 17 (GH-11597)
https://github.com/python/cpython/commit/56c16057c639acc2fb89c6b783425320f23a5f6c


--
nosy: +terry.reedy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35283] "threading._DummyThread" redefines "is_alive" but forgets "isAlive"

2019-01-17 Thread Andrew Svetlov


Andrew Svetlov  added the comment:

I think yes.
People will be notified about depreciation earlier, even after 3.8 release not 
everybody switches to a new version fast.
For example, I still use 3.6 for my job now (but we are planning to switch to 
3.7 in a month or two).
Adding PendingDeprecationWarning to 3.7 is safe, I expect a very few code uses 
`.isAlive()` on Python 3.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35761] Allow dataclasses to be updated in place

2019-01-17 Thread Eric V. Smith


Eric V. Smith  added the comment:

I agree that I don't see the point, unless there's something I'm missing with 
other_instance. Or maybe the proposal is for it to also work with frozen 
dataclasses? I'm definitely -1 on that.

So unless there's something I'm missing where normal attribute assignment 
wouldn't work, I'm leaning toward rejecting this. What is it about dataclasses 
that would need this feature, where regular classes don't? Just do what you'd 
do with regular classes.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34161] (good first issue) Tutorial 7.1 str.format() code example syntax error

2019-01-17 Thread Terry J. Reedy


Change by Terry J. Reedy :


--
pull_requests:  -11304

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35283] "threading._DummyThread" redefines "is_alive" but forgets "isAlive"

2019-01-17 Thread Dong-hee Na


Change by Dong-hee Na :


--
pull_requests: +11301, 11302, 11303

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34161] (good first issue) Tutorial 7.1 str.format() code example syntax error

2019-01-17 Thread Terry J. Reedy


Change by Terry J. Reedy :


--
pull_requests: +11304, 11305, 11306

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34161] (good first issue) Tutorial 7.1 str.format() code example syntax error

2019-01-17 Thread Terry J. Reedy


Change by Terry J. Reedy :


--
pull_requests:  -11305

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34161] (good first issue) Tutorial 7.1 str.format() code example syntax error

2019-01-17 Thread Terry J. Reedy


Change by Terry J. Reedy :


--
pull_requests:  -11306

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34161] (good first issue) Tutorial 7.1 str.format() code example syntax error

2019-01-17 Thread Terry J. Reedy


Change by Terry J. Reedy :


--
pull_requests: +11304, 11305

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34162] idlelib/NEWS.txt for 3.8.0 (and backports)

2019-01-17 Thread Terry J. Reedy


Change by Terry J. Reedy :


--
pull_requests: +11307

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35283] "threading._DummyThread" redefines "is_alive" but forgets "isAlive"

2019-01-17 Thread Dong-hee Na


Change by Dong-hee Na :


--
pull_requests: +11301, 11302

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34161] (good first issue) Tutorial 7.1 str.format() code example syntax error

2019-01-17 Thread Terry J. Reedy


Change by Terry J. Reedy :


--
pull_requests: +11304

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35283] "threading._DummyThread" redefines "is_alive" but forgets "isAlive"

2019-01-17 Thread Dong-hee Na


Change by Dong-hee Na :


--
pull_requests: +11301

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35761] Allow dataclasses to be updated in place

2019-01-17 Thread Raymond Hettinger


Raymond Hettinger  added the comment:

I'm don't see the point of this proposal.  The fields of dataclasses are 
already mutable, so they can be updated just like any other object (no need for 
a special mechanism):

a = InventoryItem(name='Widget', unit_price=37.25, quantity_on_hand=10)

a.quantity_on_hand -= 1   # Sold one
a.unit_price *= 0.90  # Ten percent off sale

Also, it's not hard to directly take data from one instance to another:

a.name = master_catalog.name
a.unit_price = master_catalog.unit_price

--
nosy: +rhettinger

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue26414] os.defpath too permissive

2019-01-17 Thread Eryk Sun


Change by Eryk Sun :


--
resolution:  -> duplicate
stage:  -> resolved
status: open -> closed
superseder:  -> Remove current directory from posixpath.defpath to enhance 
security

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23156] Update tix install information in tkinter tix chapter of doc

2019-01-17 Thread Terry J. Reedy


Terry J. Reedy  added the comment:

/go/so

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23156] Update tix install information in tkinter tix chapter of doc

2019-01-17 Thread Terry J. Reedy


Terry J. Reedy  added the comment:

If the obsolete text is not to revised, it should be removed, as Ned suggested. 
 I don't now think a replacement list is needed.

Serhiy, if you have any opinion either way, please say go.

--
stage: patch review -> needs patch
versions: +Python 3.8 -Python 2.7, Python 3.4, Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23156] Update tix install information in tkinter tix chapter of doc

2019-01-17 Thread Terry J. Reedy


Change by Terry J. Reedy :


--
keywords: +patch, patch, patch
pull_requests: +11298, 11299, 11300
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23156] Update tix install information in tkinter tix chapter of doc

2019-01-17 Thread Terry J. Reedy


Change by Terry J. Reedy :


--
keywords: +patch, patch
pull_requests: +11298, 11299
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23156] Update tix install information in tkinter tix chapter of doc

2019-01-17 Thread Terry J. Reedy


Change by Terry J. Reedy :


--
keywords: +patch
pull_requests: +11298
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35761] Allow dataclasses to be updated in place

2019-01-17 Thread Eric V. Smith


Eric V. Smith  added the comment:

What would the interaction be between other_instance and changes? Why is this 
API different from .replace()?

--
assignee:  -> eric.smith
nosy: +eric.smith

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35755] Remove current directory from posixpath.defpath to enhance security

2019-01-17 Thread Alexey Izbyshev


Alexey Izbyshev  added the comment:

Thanks for the info on CS_PATH, Victor. IMHO it'd make sense to use the 
libc-provided default PATH at least in shutil.which() since its intent is to 
emulate "which" from the default shell.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35683] Enable manylinux1 builds on Pipelines for CI testing

2019-01-17 Thread Terry J. Reedy


Terry J. Reedy  added the comment:

I believe it was Louie Lu's idea, #30290, to check more than one line.
I am glad it helped.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30290] IDLE: add tests for help_about.py

2019-01-17 Thread Terry J. Reedy


Terry J. Reedy  added the comment:

Postscript: this test that the retrieved text has at least two lines caught a 
bug in the new Windows Store python distribution.

self.assertEqual(printer._Printer__lines[1],
 dialog._current_textview.textView.get('2.0', '2.end'))

The license file was missing and the backup default had only one line.
#35683, msg333891

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35537] use os.posix_spawn in subprocess

2019-01-17 Thread Alexey Izbyshev


Alexey Izbyshev  added the comment:

> It should be compared to the current code. Currently, _posixsubprocess uses a 
> loop calling execv(). I don't think that calling posix_spawn() in a loop 
> until one doesn't fail is more inefficient.

> The worst case would be when applying process attributes and run file actions 
> would dominate performances... I don't think that such case exists. Syscalls 
> like dup2() and close() should be way faster than the final successful 
> execv() in the overall posix_spawn() call. I'm talking about the case when 
> the program exists.

I had vfork() used internally by posix_spawn() in mind when I considered 
repeatedly calling it "prohibitively expensive". While vfork() is much cheaper 
than fork(), it doesn't mean that its performance is comparable to dup2() and 
close(). But on systems where posix_spawn is a syscall the overhead could 
indeed be lesser. Anyway, it should be measured.

>> Iterate over PATH entries and perform a quick check for common exec errors 
>> (ENOENT, ENOTDIR, EACCES) manually (e.g. by stat()).

> I dislike this option. There is a high risk of race condition if the program 
> is created, deleted or modified between the check and exec. It can cause 
> subtle bugs, or worse: security vulnerabilities. IMHO the only valid check, 
> to test if a program exists, is to call exec().

While exec() is of course cleaner, IMHO races don't matter in this case. If our 
stat()-like check fails, we could as well imagine that it is exec() that failed 
(while doing the same checks as our stat()), so it doesn't matter what happens 
with the tested entry afterwards. If the check succeeds, we simply call 
posix_spawn() that will perform the same checks again. If any race condition 
occurs, the problem will be detected by posix_spawn(). 

> Alexey: Do you want to work on a PR to reimplement the "executable_list" and 
> loop used by subprocess with _posixsubproces?

I'm currently focused on researching whether it's possible to use vfork()-like 
approach instead of fork() on Linux, so if anyone wants to implement the PR you 
suggested, feel free to do it.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23156] Update tix install information in tkinter tix chapter of doc

2019-01-17 Thread Cheryl Sabella


Cheryl Sabella  added the comment:

Since tix has been deprecated since 3.6 (according to the docs with commit 
bd63353b7433ea8aa831ffb158ac29fb646a6fc9), should this ticket be closed as out 
of date?

--
nosy: +cheryl.sabella

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue16638] support multi-line docstring signatures in IDLE calltips

2019-01-17 Thread Terry J. Reedy


Terry J. Reedy  added the comment:

The standard calltip box is two lines: signature and docstring header.  In most 
cases, such as int, iter, and min, the effect of this patch is to get both 
lines of a docstring signature, so the result is not abnormally big.  And I 
agree with Serhiy that getting even more lines, when needed, is a bug fix.  (My 
change to 'enhancement' was in respect to Raymond's proposal, hence the 
reversion.)

Bytes is one of the very few functions with more than two header lines, and 
exceptional at 5.  It could be reduced to 4 if the first and last were combined 
as done for other functions.  I don't want to add an option or special code for 
this special case.

#19903 expands the calltip by 2 lines when the signature includes '/'.  This is 
increasingly common as more builtins get processed by Argument Clinic. I opened 
#35763 to revisit and revise this behavior.

--
status: open -> closed
type: enhancement -> behavior

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35763] IDLE calltips: make positional note less obtrusive

2019-01-17 Thread Terry J. Reedy


Terry J. Reedy  added the comment:

#35764 is about revising the calltip doc, including adding something about '/' 
in signatures.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35764] IDLE: revise calltip doc

2019-01-17 Thread Terry J. Reedy


New submission from Terry J. Reedy :

Add cross-reference from Menu section entry.  Document '/' for builtins.  Check 
other details.  (Also remove 'extension' from end of previous entry.)

--
assignee: terry.reedy
components: IDLE
messages: 333898
nosy: terry.reedy
priority: normal
severity: normal
stage: needs patch
status: open
title: IDLE: revise calltip doc
type: enhancement
versions: Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35763] IDLE calltips: make positional note less obtrusive

2019-01-17 Thread Terry J. Reedy


New submission from Terry J. Reedy :

#19903 made calltip.getargspec use inspect.signature.  The latter may include 
'/' following positional-only arguments.  Slashes are possible for the growing 
number of C-coded functions processed with Argument Clinic.  They appear in 
both help output and IDLE calltips, but not yet in the regular docs, let alone 
Python code.  The result, for instance, is 'float([x])' in the docs and 
'float(x=0, /)' in help() and calltips.

Since '/' is effectively undocumented, especially in anything beginners would 
see, and since there have been questions from beginners as to its meaning, the 
following note is added to calltips on a new line followed by a blank line:

  ['/' marks preceding arguments as positional-only]

The negative effect is somewhat obtrusively expanding what would typically be 2 
lines to 4 in order to say something that hopefully becomes useless.  Raymond's 
#16638 comment about big tips being distracting prompted me to consider some 
possible (non-exclusive) changes to reduce the impact.

0. Omit the blank line.  We added the blank line to make it clearer that the 
comment is not part of the docstring.  This can be done otherwise.

1. Change the font to something like smaller, red, italic characters.  Issue: 
the tip string is computed as a whole in the user execution process and 
inserted in the tip window in the IDLE process.  

2. Shorten and move the comment and mark it with '#'. Most builtins have short 
signatures, so a short enough comment could be appended to the signature line 
as a comment.  In combination with 0. (and 1., but not visible here), the float 
tip would shrink from the current

  float(x=0, /)
  ['/' marks preceding arguments as positional-only]

  Convert a string or number to a floating point number, if possible.

back down to

  float(x=0, /)  # / means positional-only
  Convert a string or number to a floating point number, if possible.

3. Limit the number of appearances in a particular session.  The following 
should work.

slash_comments = 3
...  
if '/' in sig:
if slash_comments:
slash_comments -= 1


I think 3 would be about enough.  I don't want to make it configurable.

Issue: restarting the user execution process would restart the count in that 
process, where the addition is currently made.


If the proposal to use '/' in the regular docs were ever accepted, I would 
remove the special calltip comment.

--
assignee: terry.reedy
components: IDLE
messages: 333897
nosy: rhettinger, terry.reedy
priority: normal
severity: normal
stage: test needed
status: open
title: IDLE calltips: make positional note less obtrusive
type: enhancement
versions: Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34766] BaseProxy cache should be cleaned when Manager client is reconnected

2019-01-17 Thread Yongnan Wu


Yongnan Wu  added the comment:

ping

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue22393] multiprocessing.Pool shouldn't hang forever if a worker process dies unexpectedly

2019-01-17 Thread Chris Markiewicz


Chris Markiewicz  added the comment:

Just a bump to note that the PR (10441) is ready for another round of review.

--
nosy: +cjmarkie

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32866] zipimport loader.get_data() requires absolute zip file path

2019-01-17 Thread Nina Zakharenko


Change by Nina Zakharenko :


--
nosy: +nnja

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32866] zipimport loader.get_data() requires absolute zip file path

2019-01-17 Thread Barry A. Warsaw


Barry A. Warsaw  added the comment:

I believe this bug does not affect Python 3.8:

(Using a Python 3.8 virtualenv):

% python demo.pyz 
Reading: resource.txt
Length: 19
% python `pwd`/demo.pyz 
Reading: resource.txt
Length: 19

I think it's too risky (and too much work, given it would have to be ported to 
the C implementation of zipimport) to change this in earlier Pythons.  So, 
closing.

--
resolution:  -> works for me
stage:  -> resolved
status: open -> closed
versions:  -Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23078] unittest.mock patch autospec doesn't work on staticmethods

2019-01-17 Thread Felipe


Felipe  added the comment:

Please go ahead with the PR. I can't push this one through, but would be
great to have this finally land!

On Thu, 17 Jan 2019 at 03:42, Karthikeyan Singaravelan <
rep...@bugs.python.org> wrote:

>
> Karthikeyan Singaravelan  added the comment:
>
> @berker.peksag I have converted the patch at
> https://bugs.python.org/file40470/issue23078.patch and pushed it to a
> GitHub branch
> https://github.com/python/cpython/compare/master...tirkarthi:bpo23078 . I
> am willing to open a PR attributing to @fov in case you haven't had the
> time to look into this.
>
> I am removing 3.6 since it's security fixes only mode.
>
> Thanks
>
> --
> nosy: +cjw296, mariocj89, xtreak
> versions:  -Python 3.6
>
> ___
> Python tracker 
> 
> ___
>

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35683] Enable manylinux1 builds on Pipelines for CI testing

2019-01-17 Thread Steve Dower


Steve Dower  added the comment:

I have made the changes I suggested (though correctly...), but ultimately we 
need to create our own Docker image suitable for running these tests.

So for now, I'm proposing in my PR to make most of the change, as well as a few 
other Pipelines/test-related improvements, but to leave this open in case 
someone wants to come in later with a suitable image. At that point, the only 
change necessary to enable the tests will be to add a "posix_deps_yum.sh" 
script, update the image name/tag and change the manylinux variable to 'true'.

PR 11493 also fixes a missing LICENSE.txt file in the app store package, which 
was causing an idlelib test to fail as the fallback text only has one line. 
*Way* too obscure a failure for my liking, but at least we had a test there, so 
thanks, Terry :)

--
nosy: +terry.reedy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24928] mock.patch.dict spoils order of items in collections.OrderedDict

2019-01-17 Thread Berker Peksag


Change by Berker Peksag :


--
pull_requests:  -10872

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24928] mock.patch.dict spoils order of items in collections.OrderedDict

2019-01-17 Thread Berker Peksag


Berker Peksag  added the comment:

While I agree having more tests are a good thing, I'm not sure if the test in 
PR 11437 should be merged as it's not specifically testing a feature of the 
mock module.

patch.dict() basically does the following operation (ignoring possible 
AttributeErrors):

   # Keep the original one to use later.
   d = original_dict.copy()

   original_dict.update(new_dict)

I think the relationship between dict and OrderedDict (including any other dict 
subclasses and dict-like objects) and anything related to insertion order 
should be tested either in test_dict or in test_ordered_dict.

Also, the test can be simplified, but I will let other core developers chime in 
with their thoughts before reviewing PR 11437 on GitHub.

--
nosy: +berker.peksag

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35537] use os.posix_spawn in subprocess

2019-01-17 Thread Alexey Izbyshev


Alexey Izbyshev  added the comment:

Thank you for the answers, Kyle!

> I'll be preparing a patch for our posix_spawn's signal handling.

Great!

> My mistake in my setuid assessment was pointed out to me- it doesn't seem 
> like a highly likely attack vector, but it is indeed possible.

The specific scenario with non-synchronized posix_spawn/setuid is certainly not 
a good practice and could probably be considered an application bug (such 
application effectively spawns a child with "random" privileges -- depending on 
whether setuid() completed before or after vfork()).

That said, in Linux C libraries protection from that scenario is usually 
achieved automatically if all signals are blocked before vfork(). This is the 
result of a Linux-specific detail: at syscall level, setuid() affects a single 
thread only, but setuid() library function must affect the process as a whole. 
This forces C libraries to signal all threads when setuid() is called and wait 
until all threads perform setuid() syscall. This waiting can't complete until 
vfork() returns (because signals are blocked), so setuid() is effectively 
postponed. I don't know how setuid() behaves on FreeBSD (so the above may be 
not applicable at all).

> If the child errored out, they will indeed be properly reapable at that point 
> due to how vfork is implemented -- any observation to the contrary is to be 
> considered a bug.

Ah, that's good, thanks for the confirmation!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



  1   2   >