Re: [Replicant] default app list included into each replicant version

2019-10-18 Thread dllud
> wondering how to export clock alarm settings, I did not found the name
> of the app on replicant. In this case, it seems the app is Lockclock.
I use oandbackups or adb backup for that.
If you opt for oandbackups install version 0.2.13. Later versions, on
the 0.3 series, do not work properly on Replicant 6.
___
Replicant mailing list
Replicant@osuosl.org
https://lists.osuosl.org/mailman/listinfo/replicant


[Replicant] silence and MMS

2019-10-18 Thread Fil Lupin
Hello,
I just checked my silence import and I do not find any attached files (image or 
sound) into the MMS I imported into silence. Is there some special procedure to 
access them?

- Fil Lupin.___
Replicant mailing list
Replicant@osuosl.org
https://lists.osuosl.org/mailman/listinfo/replicant


[Replicant] default app list included into each replicant version

2019-10-18 Thread Fil Lupin
Hello,
wondering how to export clock alarm settings, I did not found the name of the 
app on replicant. In this case, it seems the app is Lockclock.
I think it would be interested to get the list of replicant default app, to 
help people to get this information without needing to use some CLI commands.
Is there already some information somewhere, and if not, do you think it could 
be interesting?

- Fil Lupin.___
Replicant mailing list
Replicant@osuosl.org
https://lists.osuosl.org/mailman/listinfo/replicant


Re: [Replicant] Security fix causing crash that blocks Replicant 6.0 0004 release

2019-10-18 Thread Kurtis Hanna
Hello all,

CVE-2017-13154 was announced in Google's security bulletin here:
https://source.android.com/security/bulletin/pixel/2017-12-01

Their patch to fix this is here:
https://android.googlesource.com/platform/frameworks/av/+/271defe729a10db25b45759c8ccfb5abed24c647

The patch that fixes CVE-2017-13154 was backported to LineageOS 13 on
Jan 12, 2018 here:
https://github.com/LineageOS/android_frameworks_av/commit/19d12edc1aad955ecd2e2b1bc786f1e7acb5fe0c#diff-26fac486080a94be3c3dd15b0775665a

When testing and reviewing the patch on LOS 13, multiple people observed
that it breaks the camera functionality and causes system crashes.
https://review.lineageos.org/c/LineageOS/android_frameworks_av/+/198403

This patch also seemed to break video playback / YouTube on LOS 11:
https://review.lineageos.org/c/LineageOS/android_frameworks_av/+/211067/11

Due to this, instead of properly backporting the patch to prevent the
camera from breaking and system from crashing, a workaround to the patch
was made. The commit message describes it this way:

Backport: Wrap into #ifndef/#endif statement to allow skipping this
patch for specific devices by adding the following directive into the
BoardConfig.mk or BoardConfigCommon.mk file of the device repo:
TARGET_RELEASE_CPPFLAGS += -DSKIP_CVE_2017_13154

On May 7, 2018 it was determined that the method used in the backported
patch, where a C/C++ flag was used in BoardConfig.mk /
BoardConfigCommon.mk, was a bad idea and that a Boardflag should be used
instead, so this patch was applied:
https://review.lineageos.org/c/LineageOS/android_frameworks_av/+/212842

Since LineageOS upstream doesn't have a fix for this, I suggest that we
either revert both of these two patches or add the
'BOARD_SKIP_CVE_2017_13154' boardflag for any 6.0 devices that are
currently experiencing system crashes on our alpha 0004 builds.

The two patches are on our cgit here:
https://git.replicant.us/replicant/frameworks_av/commit/?id=19d12edc1aad955ecd2e2b1bc786f1e7acb5fe0c
https://git.replicant.us/replicant/frameworks_av/commit/?id=a794b89fe00d214c8c1ced6a9519dd48b1ceb4af

Sure, it'd be great to figure out how to properly backport the upstream
patch, but we already are missing a number of other upstream patches
because they never were fixed in LOS 13. When we release this new Rom,
we can emphasize to everyone that Replicant 6.0 0004 is supposed to just
be a stop gap between 6.0 0003 and Replicant 9 and that it doesn't have
all of Google's security patches applied.

As a side note, it seems as though LineageOS only lets you sign into
their gerrit instance if you have a Google account. I don't have a
google account though and don't particularly want one. It might be worth
asking them to provide a different login option so that we can
collaborate with them closer.

Cordially,
Kurtis

Joonas Kylmälä:
> Hi,
> 
> yeah, this was just linked to #replicant IRC channel:
> .
> So the patch was ifdef'd because it broke on one device. I think we
> might be using software audio/video decoding/encoding and in lineageos
> it might be hardware so they might use different libraries and not have
> come across this on other than that 1 device which was then not fixed.
> 
> Joonas
> 
> Marcos Marado:
>> That ifdef is in there because this will happen to some devices but
>> not others (and we should investigate each replicant device to see
>> which of them are affected, it might be all as you assume, but it
>> might be none). Unfortunately, for the devices you see this happen, it
>> probably means that one of the propriatery files you are copying from
>> the device was depending on the old behavior.
>>
>> On Mon, Oct 14, 2019 at 9:38 PM Joonas Kylmälä  wrote:
>>>
>>> Hi,
>>>
>>> we investigated today a system server crash:
>>> . It was bisected to commit
>>> .
>>> If anybody has suggestions how to fix this please let us know!
>>>
>>> This is causing most likely the audio issues people have reported
>>> happening on the dev branch and it causes the boot time to be much much
>>> longer and most likely other issues. It is blocking the 0004 we were
>>> planning to do this Sunday.
>>>
>>> Joonas
>>> ___
>>> Replicant mailing list
>>> Replicant@osuosl.org
>>> https://lists.osuosl.org/mailman/listinfo/replicant
>>
> ___
> Replicant mailing list
> Replicant@osuosl.org
> https://lists.osuosl.org/mailman/listinfo/replicant
> 
___
Replicant mailing list
Replicant@osuosl.org
https://lists.osuosl.org/mailman/listinfo/replicant


[Replicant] [PATCH v2] Add native Android support for external WiFi dongles

2019-10-18 Thread Belgin ?tirbu
With this patch, if the nonfree firmware is found, the internal WiFi
is used, otherwise the WiFi state machine tries to use the external
WiFi adapter.
---
 .../com/android/server/wifi/WifiStateMachine.java  | 103 ++---
 1 file changed, 67 insertions(+), 36 deletions(-)

diff --git a/service/java/com/android/server/wifi/WifiStateMachine.java 
b/service/java/com/android/server/wifi/WifiStateMachine.java
index 38d0ac8..6d9c0d0 100644
--- a/service/java/com/android/server/wifi/WifiStateMachine.java
+++ b/service/java/com/android/server/wifi/WifiStateMachine.java
@@ -198,7 +198,8 @@ public class WifiStateMachine extends StateMachine 
implements WifiNative.WifiPno
 private ConnectivityManager mCm;
 private DummyWifiLogger mWifiLogger;
 private WifiApConfigStore mWifiApConfigStore;
-private final boolean mP2pSupported;
+private boolean mP2pSupported;
+private boolean mDongleConnected;
 private boolean mIbssSupported;
 private final AtomicBoolean mP2pConnected = new AtomicBoolean(false);
 private boolean mTemporarilyDisconnectWifi = false;
@@ -1155,6 +1156,8 @@ public class WifiStateMachine extends StateMachine 
implements WifiNative.WifiPno
 mP2pSupported = mContext.getPackageManager().hasSystemFeature(
 PackageManager.FEATURE_WIFI_DIRECT);
 
+mDongleConnected = false;
+
 mWifiNative = new WifiNative(mInterfaceName);
 mWifiConfigStore = new WifiConfigStore(context,this,  mWifiNative);
 mWifiAutoJoinController = new WifiAutoJoinController(context, this,
@@ -5274,16 +5277,19 @@ public class WifiStateMachine extends StateMachine 
implements WifiNative.WifiPno
 
 void handlePreDhcpSetup() {
 mDhcpActive = true;
-// Disable the coexistence mode
-mWifiNative.setBluetoothCoexistenceMode(
-mWifiNative.BLUETOOTH_COEXISTENCE_MODE_DISABLED);
 
-// Disable power save and suspend optimizations during DHCP
-// Note: The order here is important for now. Brcm driver changes
-// power settings when we control suspend mode optimizations.
-// TODO: Remove this comment when the driver is fixed.
-setSuspendOptimizationsNative(SUSPEND_DUE_TO_DHCP, false);
-mWifiNative.setPowerSave(false);
+if (mDongleConnected == false) {
+// Disable the coexistence mode
+mWifiNative.setBluetoothCoexistenceMode(
+mWifiNative.BLUETOOTH_COEXISTENCE_MODE_DISABLED);
+
+// Disable power save and suspend optimizations during DHCP
+// Note: The order here is important for now. Brcm driver changes
+// power settings when we control suspend mode optimizations.
+// TODO: Remove this comment when the driver is fixed.
+setSuspendOptimizationsNative(SUSPEND_DUE_TO_DHCP, false);
+mWifiNative.setPowerSave(false);
+}
 
 // Update link layer stats
 getWifiLinkLayerStats(false);
@@ -5337,15 +5343,17 @@ public class WifiStateMachine extends StateMachine 
implements WifiNative.WifiPno
 }
 
 void handlePostDhcpSetup() {
-/* Restore power save and suspend optimizations */
-setSuspendOptimizationsNative(SUSPEND_DUE_TO_DHCP, true);
-mWifiNative.setPowerSave(true);
+if (mDongleConnected == false) {
+/* Restore power save and suspend optimizations */
+setSuspendOptimizationsNative(SUSPEND_DUE_TO_DHCP, true);
+mWifiNative.setPowerSave(true);
 
-mWifiP2pChannel.sendMessage(WifiP2pServiceImpl.BLOCK_DISCOVERY, 
WifiP2pServiceImpl.DISABLED);
+mWifiP2pChannel.sendMessage(WifiP2pServiceImpl.BLOCK_DISCOVERY, 
WifiP2pServiceImpl.DISABLED);
 
-// Set the coexistence mode back to its default value
-mWifiNative.setBluetoothCoexistenceMode(
-mWifiNative.BLUETOOTH_COEXISTENCE_MODE_SENSE);
+// Set the coexistence mode back to its default value
+mWifiNative.setBluetoothCoexistenceMode(
+mWifiNative.BLUETOOTH_COEXISTENCE_MODE_SENSE);
+}
 
 mDhcpActive = false;
 }
@@ -6047,8 +6055,12 @@ public class WifiStateMachine extends StateMachine 
implements WifiNative.WifiPno
 * Avoids issues with drivers that do not handle interface 
down
 * on a running supplicant properly.
 */
+mDongleConnected = false;
 mWifiMonitor.killSupplicant(mP2pSupported);
 
+mP2pSupported = 
mContext.getPackageManager().hasSystemFeature(
+PackageManager.FEATURE_WIFI_DIRECT);
+
 if (mWifiNative.loadDriver()) {
 try {
 mNwService.wifiFirmwareReload(mInterfaceName, 
"STA");
@@ -6096,7 +6108,21 @@ public class WifiStateMachine extends StateMachine 
implements WifiNative.WifiPno
 

Re: [Replicant] signal app

2019-10-18 Thread Aaron Whitehouse
Hi

On 16 October 2019 00:19:24 BST, dllud  wrote:
>Hi Fil,
>
>If I remember correctly Signal uses Google Cloud Messaging or other
>similar Google service for push messages. Thus it depends on the
>non-free Google Play services. That's the reason why it isn't available
>on F-Droid.

I'm not sure that is right. I think that it has been possible to use Signal 
without Google Play Services for the last couple of years:
https://github.com/signalapp/Signal-Android/commit/1669731329bcc32c84e33035a67a2fc22444c24b

An old comment from moxie about why he doesn't distribute on fdroid is here:
https://github.com/signalapp/Signal-Android/issues/281#issuecomment-21762482

That is now a bit out of date, AIUI, and the non-Google APK is available on the 
site (might be here: https://signal.org/android/apk/ ) though I've always used 
the Play version. Not sure if updates are solved in that version.

Kind regards,

Aaron
___
Replicant mailing list
Replicant@osuosl.org
https://lists.osuosl.org/mailman/listinfo/replicant


Re: [Replicant] Security fix causing crash that blocks Replicant 6.0 0004 release

2019-10-18 Thread Marcos Marado
That ifdef is in there because this will happen to some devices but
not others (and we should investigate each replicant device to see
which of them are affected, it might be all as you assume, but it
might be none). Unfortunately, for the devices you see this happen, it
probably means that one of the propriatery files you are copying from
the device was depending on the old behavior.

On Mon, Oct 14, 2019 at 9:38 PM Joonas Kylmälä  wrote:
>
> Hi,
>
> we investigated today a system server crash:
> . It was bisected to commit
> .
> If anybody has suggestions how to fix this please let us know!
>
> This is causing most likely the audio issues people have reported
> happening on the dev branch and it causes the boot time to be much much
> longer and most likely other issues. It is blocking the 0004 we were
> planning to do this Sunday.
>
> Joonas
> ___
> Replicant mailing list
> Replicant@osuosl.org
> https://lists.osuosl.org/mailman/listinfo/replicant
___
Replicant mailing list
Replicant@osuosl.org
https://lists.osuosl.org/mailman/listinfo/replicant


Re: [Replicant] signal app

2019-10-18 Thread Denis 'GNUtoo' Carikli
On Wed, 16 Oct 2019 13:36:56 +0100
dllud  wrote:

> Good to know it no longer uses GCM. Sorry for the outdated info.
> 
> Still, if you are starting from scratch, like Fil apparently is,
> better opt for a federated network like XMPP or Matrix.
This is also more robust as there are many different implementations of
XMPP for instance, whereas with signal if the client hardware/software
requirements change at some point, you may be unable to use it.

Denis.


pgptyUw7wXKUV.pgp
Description: OpenPGP digital signature
___
Replicant mailing list
Replicant@osuosl.org
https://lists.osuosl.org/mailman/listinfo/replicant