[GitHub] [spark] dongjoon-hyun commented on issue #25550: [SPARK-28847][TEST] Annotate HiveExternalCatalogVersionsSuite with ExtendedHiveTest
dongjoon-hyun commented on issue #25550: [SPARK-28847][TEST] Annotate HiveExternalCatalogVersionsSuite with ExtendedHiveTest URL: https://github.com/apache/spark/pull/25550#issuecomment-523760031 Thank you so much for review and approval! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network
AmplabJenkins removed a comment on issue #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network URL: https://github.com/apache/spark/pull/25500#issuecomment-523759770 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network
AmplabJenkins removed a comment on issue #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network URL: https://github.com/apache/spark/pull/25500#issuecomment-523759777 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/109548/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #25549: [SPARK-28828][DOC] Document REFRESH TABLE command
HyukjinKwon commented on issue #25549: [SPARK-28828][DOC] Document REFRESH TABLE command URL: https://github.com/apache/spark/pull/25549#issuecomment-523759859 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25549: [SPARK-28828][DOC] Document REFRESH TABLE command
AmplabJenkins removed a comment on issue #25549: [SPARK-28828][DOC] Document REFRESH TABLE command URL: https://github.com/apache/spark/pull/25549#issuecomment-523759203 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network
AmplabJenkins commented on issue #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network URL: https://github.com/apache/spark/pull/25500#issuecomment-523759777 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/109548/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network
AmplabJenkins commented on issue #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network URL: https://github.com/apache/spark/pull/25500#issuecomment-523759770 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #25550: [SPARK-28847][TEST] Annotate HiveExternalCatalogVersionsSuite with ExtendedHiveTest
SparkQA commented on issue #25550: [SPARK-28847][TEST] Annotate HiveExternalCatalogVersionsSuite with ExtendedHiveTest URL: https://github.com/apache/spark/pull/25550#issuecomment-523759771 **[Test build #109555 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109555/testReport)** for PR 25550 at commit [`39e7ece`](https://github.com/apache/spark/commit/39e7ecec7c03b2cae97b3564952a2dfde4b6a712). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] kevinyu98 commented on a change in pull request #25528: [SPARK-28802][DOC][SQL]Document DESCRIBE DATABASE statement in SQL Reference
kevinyu98 commented on a change in pull request #25528: [SPARK-28802][DOC][SQL]Document DESCRIBE DATABASE statement in SQL Reference URL: https://github.com/apache/spark/pull/25528#discussion_r316506249 ## File path: docs/sql-ref-syntax-aux-describe-database.md ## @@ -18,5 +18,23 @@ license: | See the License for the specific language governing permissions and limitations under the License. --- +### Description + +Return the metadata of an existing database(name, comment and location). If the database does not exist, +an exception is thrown. + +When `extended` is specified, it also shows the database's properties. Review comment: sure This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network
SparkQA removed a comment on issue #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network URL: https://github.com/apache/spark/pull/25500#issuecomment-523731949 **[Test build #109548 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109548/testReport)** for PR 25500 at commit [`3990fec`](https://github.com/apache/spark/commit/3990fec4bfe91f757872e3d79d059591c9ed1748). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network
SparkQA commented on issue #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network URL: https://github.com/apache/spark/pull/25500#issuecomment-523759339 **[Test build #109548 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109548/testReport)** for PR 25500 at commit [`3990fec`](https://github.com/apache/spark/commit/3990fec4bfe91f757872e3d79d059591c9ed1748). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] kevinyu98 commented on a change in pull request #25528: [SPARK-28802][DOC][SQL]Document DESCRIBE DATABASE statement in SQL Reference
kevinyu98 commented on a change in pull request #25528: [SPARK-28802][DOC][SQL]Document DESCRIBE DATABASE statement in SQL Reference URL: https://github.com/apache/spark/pull/25528#discussion_r316506170 ## File path: docs/sql-ref-syntax-aux-describe-database.md ## @@ -18,5 +18,23 @@ license: | See the License for the specific language governing permissions and limitations under the License. --- +### Description + +Return the metadata of an existing database(name, comment and location). If the database does not exist, Review comment: ok. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun opened a new pull request #25550: [SPARK-28847][TEST] Annotate HiveExternalCatalogVersionsSuite with ExtendedHiveTest
dongjoon-hyun opened a new pull request #25550: [SPARK-28847][TEST] Annotate HiveExternalCatalogVersionsSuite with ExtendedHiveTest URL: https://github.com/apache/spark/pull/25550 ### What changes were proposed in this pull request? This PR aims to annotate `HiveExternalCatalogVersionsSuite` with `ExtendedHiveTest`. ### Why are the changes needed? `HiveExternalCatalogVersionsSuite` is an outstanding test in terms of testing time. This PR aims to allow skipping this test suite when we use `ExtendedHiveTest`.  ### Does this PR introduce any user-facing change? No ### How was this patch tested? Since Jenkins doesn't exclude `ExtendedHiveTest`, there is no difference in Jenkins testing. This PR should be tested by manually by the following. **BEFORE** ``` $ cd sql/hive $ mvn package -Dtest=none -DwildcardSuites=org.apache.spark.sql.hive.HiveExternalCatalogVersionsSuite -Dtest.exclude.tags=org.apache.spark.tags.ExtendedHiveTest ... Run starting. Expected test count is: 1 HiveExternalCatalogVersionsSuite: 22:32:16.218 WARN org.apache.hadoop.util.NativeCodeLoader: Unable to load ... ``` **AFTER** ``` $ cd sql/hive $ mvn package -Dtest=none -DwildcardSuites=org.apache.spark.sql.hive.HiveExternalCatalogVersionsSuite -Dtest.exclude.tags=org.apache.spark.tags.ExtendedHiveTest ... Run starting. Expected test count is: 0 HiveExternalCatalogVersionsSuite: Run completed in 772 milliseconds. Total number of tests run: 0 Suites: completed 2, aborted 0 Tests: succeeded 0, failed 0, canceled 0, ignored 0, pending 0 No tests were executed. ... ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25549: [SPARK-28828][DOC] Document REFRESH TABLE command
AmplabJenkins removed a comment on issue #25549: [SPARK-28828][DOC] Document REFRESH TABLE command URL: https://github.com/apache/spark/pull/25549#issuecomment-523759090 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #25541: [SPARK-28831][DOC][SQL]Document CLEAR CACHE statement in SQL Reference
SparkQA removed a comment on issue #25541: [SPARK-28831][DOC][SQL]Document CLEAR CACHE statement in SQL Reference URL: https://github.com/apache/spark/pull/25541#issuecomment-523756445 **[Test build #109553 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109553/testReport)** for PR 25541 at commit [`1f820a4`](https://github.com/apache/spark/commit/1f820a45cae238b67cef65ac7769172ce33d9137). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25541: [SPARK-28831][DOC][SQL]Document CLEAR CACHE statement in SQL Reference
AmplabJenkins removed a comment on issue #25541: [SPARK-28831][DOC][SQL]Document CLEAR CACHE statement in SQL Reference URL: https://github.com/apache/spark/pull/25541#issuecomment-523758860 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/109553/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25549: [SPARK-28828][DOC] Document REFRESH TABLE command
AmplabJenkins removed a comment on issue #25549: [SPARK-28828][DOC] Document REFRESH TABLE command URL: https://github.com/apache/spark/pull/25549#issuecomment-523758024 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25541: [SPARK-28831][DOC][SQL]Document CLEAR CACHE statement in SQL Reference
AmplabJenkins removed a comment on issue #25541: [SPARK-28831][DOC][SQL]Document CLEAR CACHE statement in SQL Reference URL: https://github.com/apache/spark/pull/25541#issuecomment-523758854 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25549: [SPARK-28828][DOC] Document REFRESH TABLE command
AmplabJenkins commented on issue #25549: [SPARK-28828][DOC] Document REFRESH TABLE command URL: https://github.com/apache/spark/pull/25549#issuecomment-523759203 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25549: [SPARK-28828][DOC] Document REFRESH TABLE command
AmplabJenkins commented on issue #25549: [SPARK-28828][DOC] Document REFRESH TABLE command URL: https://github.com/apache/spark/pull/25549#issuecomment-523759090 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25541: [SPARK-28831][DOC][SQL]Document CLEAR CACHE statement in SQL Reference
AmplabJenkins commented on issue #25541: [SPARK-28831][DOC][SQL]Document CLEAR CACHE statement in SQL Reference URL: https://github.com/apache/spark/pull/25541#issuecomment-523758860 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/109553/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25541: [SPARK-28831][DOC][SQL]Document CLEAR CACHE statement in SQL Reference
AmplabJenkins commented on issue #25541: [SPARK-28831][DOC][SQL]Document CLEAR CACHE statement in SQL Reference URL: https://github.com/apache/spark/pull/25541#issuecomment-523758854 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #25541: [SPARK-28831][DOC][SQL]Document CLEAR CACHE statement in SQL Reference
SparkQA commented on issue #25541: [SPARK-28831][DOC][SQL]Document CLEAR CACHE statement in SQL Reference URL: https://github.com/apache/spark/pull/25541#issuecomment-523758783 **[Test build #109553 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109553/testReport)** for PR 25541 at commit [`1f820a4`](https://github.com/apache/spark/commit/1f820a45cae238b67cef65ac7769172ce33d9137). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #24759: [SPARK-27395][SQL] Improve EXPLAIN command
SparkQA commented on issue #24759: [SPARK-27395][SQL] Improve EXPLAIN command URL: https://github.com/apache/spark/pull/24759#issuecomment-523758116 **[Test build #109554 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109554/testReport)** for PR 24759 at commit [`b846922`](https://github.com/apache/spark/commit/b846922bcd4172d554f688bd8f713c6837d9c2d0). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25549: [SPARK-28828][DOC] Document REFRESH TABLE command
AmplabJenkins commented on issue #25549: [SPARK-28828][DOC] Document REFRESH TABLE command URL: https://github.com/apache/spark/pull/25549#issuecomment-523758024 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] kevinyu98 opened a new pull request #25549: [SPARK-28828][DOC] Document REFRESH TABLE command
kevinyu98 opened a new pull request #25549: [SPARK-28828][DOC] Document REFRESH
TABLE command
URL: https://github.com/apache/spark/pull/25549
### What changes were proposed in this pull request?
Document REFRESH TABLE statement in the SQL Reference Guide.
### Why are the changes needed?
Currently there is no documentation in the SPARK SQL to describe how to use
this command, it is to address this issue.
### Does this PR introduce any user-facing change?
Yes.
Before:
There is no documentation for this.
After:
### How was this patch tested?
Using jykll build --serve
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25541: [SPARK-28831][DOC][SQL]Document CLEAR CACHE statement in SQL Reference
AmplabJenkins removed a comment on issue #25541: [SPARK-28831][DOC][SQL]Document CLEAR CACHE statement in SQL Reference URL: https://github.com/apache/spark/pull/25541#issuecomment-523757614 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #24759: [SPARK-27395][SQL] Improve EXPLAIN command
AmplabJenkins removed a comment on issue #24759: [SPARK-27395][SQL] Improve EXPLAIN command URL: https://github.com/apache/spark/pull/24759#issuecomment-523757604 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/14611/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #24759: [SPARK-27395][SQL] Improve EXPLAIN command
AmplabJenkins removed a comment on issue #24759: [SPARK-27395][SQL] Improve EXPLAIN command URL: https://github.com/apache/spark/pull/24759#issuecomment-523757600 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25541: [SPARK-28831][DOC][SQL]Document CLEAR CACHE statement in SQL Reference
AmplabJenkins commented on issue #25541: [SPARK-28831][DOC][SQL]Document CLEAR CACHE statement in SQL Reference URL: https://github.com/apache/spark/pull/25541#issuecomment-523757623 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/14610/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #24759: [SPARK-27395][SQL] Improve EXPLAIN command
AmplabJenkins commented on issue #24759: [SPARK-27395][SQL] Improve EXPLAIN command URL: https://github.com/apache/spark/pull/24759#issuecomment-523757600 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #24759: [SPARK-27395][SQL] Improve EXPLAIN command
AmplabJenkins commented on issue #24759: [SPARK-27395][SQL] Improve EXPLAIN command URL: https://github.com/apache/spark/pull/24759#issuecomment-523757604 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/14611/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25541: [SPARK-28831][DOC][SQL]Document CLEAR CACHE statement in SQL Reference
AmplabJenkins commented on issue #25541: [SPARK-28831][DOC][SQL]Document CLEAR CACHE statement in SQL Reference URL: https://github.com/apache/spark/pull/25541#issuecomment-523757614 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25541: [SPARK-28831][DOC][SQL]Document CLEAR CACHE statement in SQL Reference
AmplabJenkins removed a comment on issue #25541: [SPARK-28831][DOC][SQL]Document CLEAR CACHE statement in SQL Reference URL: https://github.com/apache/spark/pull/25541#issuecomment-523757623 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/14610/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] huaxingao edited a comment on issue #25525: [SPARK-28786][DOC][SQL]Document INSERT statement in SQL Reference
huaxingao edited a comment on issue #25525: [SPARK-28786][DOC][SQL]Document INSERT statement in SQL Reference URL: https://github.com/apache/spark/pull/25525#issuecomment-523557375  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #25541: [SPARK-28831][DOC][SQL]Document CLEAR CACHE statement in SQL Reference
SparkQA commented on issue #25541: [SPARK-28831][DOC][SQL]Document CLEAR CACHE statement in SQL Reference URL: https://github.com/apache/spark/pull/25541#issuecomment-523756445 **[Test build #109553 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109553/testReport)** for PR 25541 at commit [`1f820a4`](https://github.com/apache/spark/commit/1f820a45cae238b67cef65ac7769172ce33d9137). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] rednaxelafx commented on a change in pull request #20965: [SPARK-21870][SQL] Split aggregation code into small functions
rednaxelafx commented on a change in pull request #20965: [SPARK-21870][SQL]
Split aggregation code into small functions
URL: https://github.com/apache/spark/pull/20965#discussion_r316501527
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
##
@@ -267,29 +302,81 @@ case class HashAggregateExec(
e.aggregateFunction.asInstanceOf[DeclarativeAggregate].mergeExpressions
}
}
-ctx.currentVars = bufVars ++ input
-val boundUpdateExpr = bindReferences(updateExpr, inputAttrs)
-val subExprs =
ctx.subexpressionEliminationForWholeStageCodegen(boundUpdateExpr)
-val effectiveCodes = subExprs.codes.mkString("\n")
-val aggVals = ctx.withSubExprEliminationExprs(subExprs.states) {
- boundUpdateExpr.map(_.genCode(ctx))
-}
-// aggregate buffer should be updated atomic
-val updates = aggVals.zipWithIndex.map { case (ev, i) =>
+
+if (!conf.codegenSplitAggregateFunc) {
+ ctx.currentVars = bufVars ++ input
+ val boundUpdateExpr = updateExpr.map(BindReferences.bindReference(_,
inputAttrs))
+ val subExprs =
ctx.subexpressionEliminationForWholeStageCodegen(boundUpdateExpr)
+ val effectiveCodes = subExprs.codes.mkString("\n")
+ val aggVals = ctx.withSubExprEliminationExprs(subExprs.states) {
+boundUpdateExpr.map(_.genCode(ctx))
+ }
+ // aggregate buffer should be updated atomic
+ val updates = aggVals.zipWithIndex.map { case (ev, i) =>
+s"""
+ | ${bufVars(i).isNull} = ${ev.isNull};
+ | ${bufVars(i).value} = ${ev.value};
+ """.stripMargin
+ }
+ s"""
+ | // do aggregate
Review comment:
Thanks! I'm totally fine with either cleaning it up here or in a follow-up.
This is purely cosmetic and wouldn't change the core feature.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25507: [SPARK-28667][SQL] Support InsertInto through the V2SessionCatalog
AmplabJenkins removed a comment on issue #25507: [SPARK-28667][SQL] Support InsertInto through the V2SessionCatalog URL: https://github.com/apache/spark/pull/25507#issuecomment-523753145 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25507: [SPARK-28667][SQL] Support InsertInto through the V2SessionCatalog
AmplabJenkins removed a comment on issue #25507: [SPARK-28667][SQL] Support InsertInto through the V2SessionCatalog URL: https://github.com/apache/spark/pull/25507#issuecomment-523753157 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/109538/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25507: [SPARK-28667][SQL] Support InsertInto through the V2SessionCatalog
AmplabJenkins commented on issue #25507: [SPARK-28667][SQL] Support InsertInto through the V2SessionCatalog URL: https://github.com/apache/spark/pull/25507#issuecomment-523753157 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/109538/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25507: [SPARK-28667][SQL] Support InsertInto through the V2SessionCatalog
AmplabJenkins commented on issue #25507: [SPARK-28667][SQL] Support InsertInto through the V2SessionCatalog URL: https://github.com/apache/spark/pull/25507#issuecomment-523753145 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #25507: [SPARK-28667][SQL] Support InsertInto through the V2SessionCatalog
SparkQA removed a comment on issue #25507: [SPARK-28667][SQL] Support InsertInto through the V2SessionCatalog URL: https://github.com/apache/spark/pull/25507#issuecomment-523711333 **[Test build #109538 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109538/testReport)** for PR 25507 at commit [`30e2b0f`](https://github.com/apache/spark/commit/30e2b0f3941cbdb0983f724881edd57cf209). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #25507: [SPARK-28667][SQL] Support InsertInto through the V2SessionCatalog
SparkQA commented on issue #25507: [SPARK-28667][SQL] Support InsertInto through the V2SessionCatalog URL: https://github.com/apache/spark/pull/25507#issuecomment-523752764 **[Test build #109538 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109538/testReport)** for PR 25507 at commit [`30e2b0f`](https://github.com/apache/spark/commit/30e2b0f3941cbdb0983f724881edd57cf209). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25520: [SPARK-28621][SQL] Make spark.sql.crossJoin.enabled default value true
AmplabJenkins removed a comment on issue #25520: [SPARK-28621][SQL] Make spark.sql.crossJoin.enabled default value true URL: https://github.com/apache/spark/pull/25520#issuecomment-523751785 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/109541/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25520: [SPARK-28621][SQL] Make spark.sql.crossJoin.enabled default value true
AmplabJenkins commented on issue #25520: [SPARK-28621][SQL] Make spark.sql.crossJoin.enabled default value true URL: https://github.com/apache/spark/pull/25520#issuecomment-523751785 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/109541/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25520: [SPARK-28621][SQL] Make spark.sql.crossJoin.enabled default value true
AmplabJenkins removed a comment on issue #25520: [SPARK-28621][SQL] Make spark.sql.crossJoin.enabled default value true URL: https://github.com/apache/spark/pull/25520#issuecomment-523751780 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25520: [SPARK-28621][SQL] Make spark.sql.crossJoin.enabled default value true
AmplabJenkins commented on issue #25520: [SPARK-28621][SQL] Make spark.sql.crossJoin.enabled default value true URL: https://github.com/apache/spark/pull/25520#issuecomment-523751780 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #25520: [SPARK-28621][SQL] Make spark.sql.crossJoin.enabled default value true
SparkQA removed a comment on issue #25520: [SPARK-28621][SQL] Make spark.sql.crossJoin.enabled default value true URL: https://github.com/apache/spark/pull/25520#issuecomment-523720404 **[Test build #109541 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109541/testReport)** for PR 25520 at commit [`3a0447f`](https://github.com/apache/spark/commit/3a0447ff052fb1df96155677ef291d2f8608d368). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #25520: [SPARK-28621][SQL] Make spark.sql.crossJoin.enabled default value true
SparkQA commented on issue #25520: [SPARK-28621][SQL] Make spark.sql.crossJoin.enabled default value true URL: https://github.com/apache/spark/pull/25520#issuecomment-523751583 **[Test build #109541 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109541/testReport)** for PR 25520 at commit [`3a0447f`](https://github.com/apache/spark/commit/3a0447ff052fb1df96155677ef291d2f8608d368). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #25538: [SPARK-28844][SQL] Fix typo in SQLConf FILE_COMRESSION_FACTOR
SparkQA commented on issue #25538: [SPARK-28844][SQL] Fix typo in SQLConf FILE_COMRESSION_FACTOR URL: https://github.com/apache/spark/pull/25538#issuecomment-523751544 **[Test build #109552 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109552/testReport)** for PR 25538 at commit [`558ff04`](https://github.com/apache/spark/commit/558ff043ba204014d1fc03258a67d33bcd256bc1). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25538: [SPARK-28844][SQL] Fix typo in SQLConf FILE_COMRESSION_FACTOR
AmplabJenkins removed a comment on issue #25538: [SPARK-28844][SQL] Fix typo in SQLConf FILE_COMRESSION_FACTOR URL: https://github.com/apache/spark/pull/25538#issuecomment-523751109 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #25538: [SPARK-28844][SQL] Fix typo in SQLConf FILE_COMRESSION_FACTOR
dongjoon-hyun commented on issue #25538: [SPARK-28844][SQL] Fix typo in SQLConf FILE_COMRESSION_FACTOR URL: https://github.com/apache/spark/pull/25538#issuecomment-523751357 Since this typo was introduced since 2.3, cc @kiszk , too. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25538: [SPARK-28844][SQL] Fix typo in SQLConf FILE_COMRESSION_FACTOR
AmplabJenkins removed a comment on issue #25538: [SPARK-28844][SQL] Fix typo in SQLConf FILE_COMRESSION_FACTOR URL: https://github.com/apache/spark/pull/25538#issuecomment-523751114 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/14609/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25538: [SPARK-28844][SQL] Fix typo in SQLConf FILE_COMRESSION_FACTOR
AmplabJenkins commented on issue #25538: [SPARK-28844][SQL] Fix typo in SQLConf FILE_COMRESSION_FACTOR URL: https://github.com/apache/spark/pull/25538#issuecomment-523751109 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25538: [SPARK-28844][SQL] Fix typo in SQLConf FILE_COMRESSION_FACTOR
AmplabJenkins commented on issue #25538: [SPARK-28844][SQL] Fix typo in SQLConf FILE_COMRESSION_FACTOR URL: https://github.com/apache/spark/pull/25538#issuecomment-523751114 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/14609/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference
AmplabJenkins removed a comment on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference URL: https://github.com/apache/spark/pull/25532#issuecomment-523750642 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/109551/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference
AmplabJenkins removed a comment on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference URL: https://github.com/apache/spark/pull/25532#issuecomment-523750633 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference
SparkQA removed a comment on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference URL: https://github.com/apache/spark/pull/25532#issuecomment-523748530 **[Test build #109551 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109551/testReport)** for PR 25532 at commit [`f7ca92a`](https://github.com/apache/spark/commit/f7ca92a6c12705c3132143b375d3d622cb333edf). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference
AmplabJenkins commented on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference URL: https://github.com/apache/spark/pull/25532#issuecomment-523750633 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference
AmplabJenkins commented on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference URL: https://github.com/apache/spark/pull/25532#issuecomment-523750642 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/109551/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference
SparkQA commented on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference URL: https://github.com/apache/spark/pull/25532#issuecomment-523750570 **[Test build #109551 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109551/testReport)** for PR 25532 at commit [`f7ca92a`](https://github.com/apache/spark/commit/f7ca92a6c12705c3132143b375d3d622cb333edf). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #25538: [SPARK-28844][SQL][MINOR] Fix typo in SQLConf FILE_COMRESSION_FACTOR
dongjoon-hyun commented on issue #25538: [SPARK-28844][SQL][MINOR] Fix typo in SQLConf FILE_COMRESSION_FACTOR URL: https://github.com/apache/spark/pull/25538#issuecomment-523750071 Sorry for being late, @triplesheep . This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25538: [SPARK-28844][SQL][MINOR] Fix typo in SQLConf FILE_COMRESSION_FACTOR
AmplabJenkins removed a comment on issue #25538: [SPARK-28844][SQL][MINOR] Fix typo in SQLConf FILE_COMRESSION_FACTOR URL: https://github.com/apache/spark/pull/25538#issuecomment-523448327 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #25538: [SPARK-28844][SQL][MINOR] Fix typo in SQLConf FILE_COMRESSION_FACTOR
dongjoon-hyun commented on issue #25538: [SPARK-28844][SQL][MINOR] Fix typo in SQLConf FILE_COMRESSION_FACTOR URL: https://github.com/apache/spark/pull/25538#issuecomment-523750004 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] sharangk closed pull request #25548: [SPARK-28844] [SQL] Fix typo in SQLConf FILE_COMRESSION_FACTOR
sharangk closed pull request #25548: [SPARK-28844] [SQL] Fix typo in SQLConf FILE_COMRESSION_FACTOR URL: https://github.com/apache/spark/pull/25548 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference
AmplabJenkins removed a comment on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference URL: https://github.com/apache/spark/pull/25532#issuecomment-523748148 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/14608/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] sharangk commented on issue #25548: [SPARK-28844] [SQL] Fix typo in SQLConf FILE_COMRESSION_FACTOR
sharangk commented on issue #25548: [SPARK-28844] [SQL] Fix typo in SQLConf FILE_COMRESSION_FACTOR URL: https://github.com/apache/spark/pull/25548#issuecomment-523748731 Already PR exist This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference
SparkQA commented on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference URL: https://github.com/apache/spark/pull/25532#issuecomment-523748530 **[Test build #109551 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109551/testReport)** for PR 25532 at commit [`f7ca92a`](https://github.com/apache/spark/commit/f7ca92a6c12705c3132143b375d3d622cb333edf). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25548: [SPARK-28844] [SQL] Fix typo in SQLConf FILE_COMRESSION_FACTOR
AmplabJenkins commented on issue #25548: [SPARK-28844] [SQL] Fix typo in SQLConf FILE_COMRESSION_FACTOR URL: https://github.com/apache/spark/pull/25548#issuecomment-523748460 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference
AmplabJenkins commented on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference URL: https://github.com/apache/spark/pull/25532#issuecomment-523748148 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/14608/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference
AmplabJenkins removed a comment on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference URL: https://github.com/apache/spark/pull/25532#issuecomment-523748141 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference
AmplabJenkins commented on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference URL: https://github.com/apache/spark/pull/25532#issuecomment-523748141 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] sharangk opened a new pull request #25548: [SPARK-28844] [SQL] Fix typo in SQLConf FILE_COMRESSION_FACTOR
sharangk opened a new pull request #25548: [SPARK-28844] [SQL] Fix typo in SQLConf FILE_COMRESSION_FACTOR URL: https://github.com/apache/spark/pull/25548 ### What changes were proposed in this pull request? Corrected Configuration parameter from FILE_COMRESSION_FACTOR to FILE_COMPRESSION_FACTOR ### Why are the changes needed? Spelling mistake of Configuration Parameter FILE_COMRESSION_FACTOR ### Does this PR introduce any user-facing change? No ### How was this patch tested? Existing UT and manual verification This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] huaxingao edited a comment on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference
huaxingao edited a comment on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference URL: https://github.com/apache/spark/pull/25532#issuecomment-523690824  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25547: [SPARK-28780][ML][2.4] deprecate LinearSVCModel.setWeightCol
AmplabJenkins removed a comment on issue #25547: [SPARK-28780][ML][2.4] deprecate LinearSVCModel.setWeightCol URL: https://github.com/apache/spark/pull/25547#issuecomment-523747615 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/109549/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25547: [SPARK-28780][ML][2.4] deprecate LinearSVCModel.setWeightCol
AmplabJenkins removed a comment on issue #25547: [SPARK-28780][ML][2.4] deprecate LinearSVCModel.setWeightCol URL: https://github.com/apache/spark/pull/25547#issuecomment-523747610 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25547: [SPARK-28780][ML][2.4] deprecate LinearSVCModel.setWeightCol
AmplabJenkins commented on issue #25547: [SPARK-28780][ML][2.4] deprecate LinearSVCModel.setWeightCol URL: https://github.com/apache/spark/pull/25547#issuecomment-523747615 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/109549/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #25547: [SPARK-28780][ML][2.4] deprecate LinearSVCModel.setWeightCol
SparkQA removed a comment on issue #25547: [SPARK-28780][ML][2.4] deprecate LinearSVCModel.setWeightCol URL: https://github.com/apache/spark/pull/25547#issuecomment-523734616 **[Test build #109549 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109549/testReport)** for PR 25547 at commit [`20b544a`](https://github.com/apache/spark/commit/20b544a11532ae0298f5435959b25e40cd0589ed). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25547: [SPARK-28780][ML][2.4] deprecate LinearSVCModel.setWeightCol
AmplabJenkins commented on issue #25547: [SPARK-28780][ML][2.4] deprecate LinearSVCModel.setWeightCol URL: https://github.com/apache/spark/pull/25547#issuecomment-523747610 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #25547: [SPARK-28780][ML][2.4] deprecate LinearSVCModel.setWeightCol
SparkQA commented on issue #25547: [SPARK-28780][ML][2.4] deprecate LinearSVCModel.setWeightCol URL: https://github.com/apache/spark/pull/25547#issuecomment-523747513 **[Test build #109549 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109549/testReport)** for PR 25547 at commit [`20b544a`](https://github.com/apache/spark/commit/20b544a11532ae0298f5435959b25e40cd0589ed). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25535: [SPARK-28835][SQL] Introduce TPCDSSchema
dongjoon-hyun commented on a change in pull request #25535: [SPARK-28835][SQL]
Introduce TPCDSSchema
URL: https://github.com/apache/spark/pull/25535#discussion_r316495604
##
File path: sql/core/src/test/scala/org/apache/spark/sql/TPCDSSchema.scala
##
@@ -0,0 +1,259 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql
+
+trait TPCDSSchema {
+
+ private val tableColumns = Map(
+"call_center" ->
+ """
+|`cc_call_center_sk` INT, `cc_call_center_id` STRING,
`cc_rec_start_date` DATE,
+|`cc_rec_end_date` DATE, `cc_closed_date_sk` INT, `cc_open_date_sk`
INT, `cc_name` STRING,
+|`cc_class` STRING, `cc_employees` INT, `cc_sq_ft` INT, `cc_hours`
STRING,
+|`cc_manager` STRING, `cc_mkt_id` INT, `cc_mkt_class` STRING,
`cc_mkt_desc` STRING,
+|`cc_market_manager` STRING, `cc_division` INT, `cc_division_name`
STRING,
+|`cc_company` INT, `cc_company_name` STRING, `cc_street_number` STRING,
+|`cc_street_name` STRING, `cc_street_type` STRING, `cc_suite_number`
STRING,
+|`cc_city` STRING, `cc_county` STRING, `cc_state` STRING, `cc_zip`
STRING,
+|`cc_country` STRING, `cc_gmt_offset` DECIMAL(5,2),
`cc_tax_percentage` DECIMAL(5,2)
+|""".stripMargin,
Review comment:
Please match the starting and ending indentation of `"""`. That is the most
recommended and dominant style in Apache Spark codebase. You can see it from
[the deleted
code](https://github.com/apache/spark/pull/25535/files#diff-38fa80d1dc9860f07e135dd02d259269L39).
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25535: [SPARK-28835][SQL] Introduce TPCDSSchema
dongjoon-hyun commented on a change in pull request #25535: [SPARK-28835][SQL]
Introduce TPCDSSchema
URL: https://github.com/apache/spark/pull/25535#discussion_r316495604
##
File path: sql/core/src/test/scala/org/apache/spark/sql/TPCDSSchema.scala
##
@@ -0,0 +1,259 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql
+
+trait TPCDSSchema {
+
+ private val tableColumns = Map(
+"call_center" ->
+ """
+|`cc_call_center_sk` INT, `cc_call_center_id` STRING,
`cc_rec_start_date` DATE,
+|`cc_rec_end_date` DATE, `cc_closed_date_sk` INT, `cc_open_date_sk`
INT, `cc_name` STRING,
+|`cc_class` STRING, `cc_employees` INT, `cc_sq_ft` INT, `cc_hours`
STRING,
+|`cc_manager` STRING, `cc_mkt_id` INT, `cc_mkt_class` STRING,
`cc_mkt_desc` STRING,
+|`cc_market_manager` STRING, `cc_division` INT, `cc_division_name`
STRING,
+|`cc_company` INT, `cc_company_name` STRING, `cc_street_number` STRING,
+|`cc_street_name` STRING, `cc_street_type` STRING, `cc_suite_number`
STRING,
+|`cc_city` STRING, `cc_county` STRING, `cc_state` STRING, `cc_zip`
STRING,
+|`cc_country` STRING, `cc_gmt_offset` DECIMAL(5,2),
`cc_tax_percentage` DECIMAL(5,2)
+|""".stripMargin,
Review comment:
Please match the starting and ending indentation of `"""`. You can see it
from [the deleted
code](https://github.com/apache/spark/pull/25535/files#diff-38fa80d1dc9860f07e135dd02d259269L39).
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25535: [SPARK-28835][SQL] Introduce TPCDSSchema
dongjoon-hyun commented on a change in pull request #25535: [SPARK-28835][SQL]
Introduce TPCDSSchema
URL: https://github.com/apache/spark/pull/25535#discussion_r316495246
##
File path: sql/core/src/test/scala/org/apache/spark/sql/TPCDSSchema.scala
##
@@ -0,0 +1,259 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql
+
+trait TPCDSSchema {
+
+ private val tableColumns = Map(
+"call_center" ->
Review comment:
@dbaliafroozeh . I'm just wondering you changed the order of tables from
the original code? For me,
1. This is not consistent with the original code (It starts with
`catalog_page` table.)
- This is the best for review.
2. This is not consistent with TPCDS spec document. (Usually, it starts with
`Fact Table Definition`: `store_sales` table)
- This is the best to compare with TPCDS spec doc.
3. This is not alphabetic.
- This is the best for human readability and to lookup on GitHub.
While you are here, could you choose one of the above and update this PR?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25535: [SPARK-28835][SQL] Introduce TPCDSSchema
dongjoon-hyun commented on a change in pull request #25535: [SPARK-28835][SQL]
Introduce TPCDSSchema
URL: https://github.com/apache/spark/pull/25535#discussion_r316495246
##
File path: sql/core/src/test/scala/org/apache/spark/sql/TPCDSSchema.scala
##
@@ -0,0 +1,259 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql
+
+trait TPCDSSchema {
+
+ private val tableColumns = Map(
+"call_center" ->
Review comment:
@dbaliafroozeh . I'm just wondering the reason you changed the order of
tables from the original code. For me,
1. This is not consistent with the original code (It starts with
`catalog_page` table.)
- This is the best for review.
2. This is not consistent with TPCDS spec document. (Usually, it starts with
`Fact Table Definition`: `store_sales` table)
- This is the best to compare with TPCDS spec doc.
3. This is not alphabetic.
- This is the best for human readability and to lookup on GitHub.
While you are here, could you choose one of the above and update this PR?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25540: [SPARK-28830][DOC][SQL]Document UNCACHE TABLE statement in SQL Reference
AmplabJenkins removed a comment on issue #25540: [SPARK-28830][DOC][SQL]Document UNCACHE TABLE statement in SQL Reference URL: https://github.com/apache/spark/pull/25540#issuecomment-523746369 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/109550/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25540: [SPARK-28830][DOC][SQL]Document UNCACHE TABLE statement in SQL Reference
AmplabJenkins removed a comment on issue #25540: [SPARK-28830][DOC][SQL]Document UNCACHE TABLE statement in SQL Reference URL: https://github.com/apache/spark/pull/25540#issuecomment-523746362 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25540: [SPARK-28830][DOC][SQL]Document UNCACHE TABLE statement in SQL Reference
AmplabJenkins commented on issue #25540: [SPARK-28830][DOC][SQL]Document UNCACHE TABLE statement in SQL Reference URL: https://github.com/apache/spark/pull/25540#issuecomment-523746362 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] triplesheep commented on issue #25538: [SPARK-28844][SQL][MINOR] Fix typo in SQLConf FILE_COMRESSION_FACTOR
triplesheep commented on issue #25538: [SPARK-28844][SQL][MINOR] Fix typo in SQLConf FILE_COMRESSION_FACTOR URL: https://github.com/apache/spark/pull/25538#issuecomment-523746406 cc @srowen @triplesheep @dongjoon-hyun could someone allow me to start the jenkins test ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25540: [SPARK-28830][DOC][SQL]Document UNCACHE TABLE statement in SQL Reference
AmplabJenkins commented on issue #25540: [SPARK-28830][DOC][SQL]Document UNCACHE TABLE statement in SQL Reference URL: https://github.com/apache/spark/pull/25540#issuecomment-523746369 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/109550/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #25540: [SPARK-28830][DOC][SQL]Document UNCACHE TABLE statement in SQL Reference
SparkQA removed a comment on issue #25540: [SPARK-28830][DOC][SQL]Document UNCACHE TABLE statement in SQL Reference URL: https://github.com/apache/spark/pull/25540#issuecomment-523744321 **[Test build #109550 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109550/testReport)** for PR 25540 at commit [`ca03005`](https://github.com/apache/spark/commit/ca03005a2371bd5b23b16414b51a1290660b65e0). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #25540: [SPARK-28830][DOC][SQL]Document UNCACHE TABLE statement in SQL Reference
SparkQA commented on issue #25540: [SPARK-28830][DOC][SQL]Document UNCACHE TABLE statement in SQL Reference URL: https://github.com/apache/spark/pull/25540#issuecomment-523746276 **[Test build #109550 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109550/testReport)** for PR 25540 at commit [`ca03005`](https://github.com/apache/spark/commit/ca03005a2371bd5b23b16414b51a1290660b65e0). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25540: [SPARK-28830][DOC][SQL]Document UNCACHE TABLE statement in SQL Reference
AmplabJenkins removed a comment on issue #25540: [SPARK-28830][DOC][SQL]Document UNCACHE TABLE statement in SQL Reference URL: https://github.com/apache/spark/pull/25540#issuecomment-523745382 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/14607/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25540: [SPARK-28830][DOC][SQL]Document UNCACHE TABLE statement in SQL Reference
AmplabJenkins removed a comment on issue #25540: [SPARK-28830][DOC][SQL]Document UNCACHE TABLE statement in SQL Reference URL: https://github.com/apache/spark/pull/25540#issuecomment-523745377 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25540: [SPARK-28830][DOC][SQL]Document UNCACHE TABLE statement in SQL Reference
AmplabJenkins commented on issue #25540: [SPARK-28830][DOC][SQL]Document UNCACHE TABLE statement in SQL Reference URL: https://github.com/apache/spark/pull/25540#issuecomment-523745382 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/14607/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25540: [SPARK-28830][DOC][SQL]Document UNCACHE TABLE statement in SQL Reference
AmplabJenkins commented on issue #25540: [SPARK-28830][DOC][SQL]Document UNCACHE TABLE statement in SQL Reference URL: https://github.com/apache/spark/pull/25540#issuecomment-523745377 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25535: [SPARK-28835][SQL] Introduce TPCDSSchema
dongjoon-hyun commented on a change in pull request #25535: [SPARK-28835][SQL]
Introduce TPCDSSchema
URL: https://github.com/apache/spark/pull/25535#discussion_r316493610
##
File path: sql/core/src/test/scala/org/apache/spark/sql/TPCDSSchema.scala
##
@@ -0,0 +1,259 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql
+
+trait TPCDSSchema {
+
+ private val tableColumns = Map(
+"call_center" ->
+ """
+|`cc_call_center_sk` INT, `cc_call_center_id` STRING,
`cc_rec_start_date` DATE,
+|`cc_rec_end_date` DATE, `cc_closed_date_sk` INT, `cc_open_date_sk`
INT, `cc_name` STRING,
+|`cc_class` STRING, `cc_employees` INT, `cc_sq_ft` INT, `cc_hours`
STRING,
+|`cc_manager` STRING, `cc_mkt_id` INT, `cc_mkt_class` STRING,
`cc_mkt_desc` STRING,
+|`cc_market_manager` STRING, `cc_division` INT, `cc_division_name`
STRING,
+|`cc_company` INT, `cc_company_name` STRING, `cc_street_number` STRING,
+|`cc_street_name` STRING, `cc_street_type` STRING, `cc_suite_number`
STRING,
+|`cc_city` STRING, `cc_county` STRING, `cc_state` STRING, `cc_zip`
STRING,
+|`cc_country` STRING, `cc_gmt_offset` DECIMAL(5,2),
`cc_tax_percentage` DECIMAL(5,2)
+|""".stripMargin,
+"customer" ->
+ """
+|`c_customer_sk` INT, `c_customer_id` STRING, `c_current_cdemo_sk` INT,
+|`c_current_hdemo_sk` INT, `c_current_addr_sk` INT,
`c_first_shipto_date_sk` INT,
+|`c_first_sales_date_sk` INT, `c_salutation` STRING, `c_first_name`
STRING,
+|`c_last_name` STRING, `c_preferred_cust_flag` STRING, `c_birth_day`
INT,
+|`c_birth_month` INT, `c_birth_year` INT, `c_birth_country` STRING,
`c_login` STRING,
+|`c_email_address` STRING, `c_last_review_date` INT
+|""".stripMargin,
+"customer_address" ->
+ """
+|`ca_address_sk` INT, `ca_address_id` STRING, `ca_street_number`
STRING,
+|`ca_street_name` STRING, `ca_street_type` STRING, `ca_suite_number`
STRING,
+|`ca_city` STRING, `ca_county` STRING, `ca_state` STRING, `ca_zip`
STRING,
+|`ca_country` STRING, `ca_gmt_offset` DECIMAL(5,2), `ca_location_type`
STRING
+|""".stripMargin,
+"customer_demographics" ->
+ """
+|`cd_demo_sk` INT, `cd_gender` STRING, `cd_marital_status` STRING,
+|`cd_education_status` STRING, `cd_purchase_estimate` INT,
`cd_credit_rating` STRING,
+|`cd_dep_count` INT, `cd_dep_employed_count` INT,
`cd_dep_college_count` INT
+|""".stripMargin,
+"household_demographics" ->
+ """
+|`hd_demo_sk` INT, `hd_income_band_sk` INT, `hd_buy_potential` STRING,
`hd_dep_count` INT,
+|`hd_vehicle_count` INT
+|""".stripMargin,
+"inventory" ->
+ """
+|`inv_date_sk` INT, `inv_item_sk` INT, `inv_warehouse_sk` INT,
+|`inv_quantity_on_hand` INT
+|""".stripMargin,
+"promotion" ->
+ """
+|`p_promo_sk` INT, `p_promo_id` STRING, `p_start_date_sk` INT,
`p_end_date_sk` INT,
+|`p_item_sk` INT, `p_cost` DECIMAL(15,2), `p_response_target` INT,
`p_promo_name` STRING,
+|`p_channel_dmail` STRING, `p_channel_email` STRING,
`p_channel_catalog` STRING,
+|`p_channel_tv` STRING, `p_channel_radio` STRING, `p_channel_press`
STRING,
+|`p_channel_event` STRING, `p_channel_demo` STRING,
`p_channel_details` STRING,
+|`p_purpose` STRING, `p_discount_active` STRING
+|""".stripMargin,
+"ship_mode" ->
+ """
+|`sm_ship_mode_sk` INT, `sm_ship_mode_id` STRING, `sm_type` STRING,
`sm_code` STRING,
+|`sm_carrier` STRING, `sm_contract` STRING
+|""".stripMargin,
+"store_returns" ->
+ """
+|`sr_returned_date_sk` BIGINT, `sr_return_time_sk` BIGINT,
`sr_item_sk` BIGINT,
+|`sr_customer_sk` BIGINT, `sr_cdemo_sk` BIGINT, `sr_hdemo_sk` BIGINT,
`sr_addr_sk` BIGINT,
+|`sr_store_sk` BIGINT, `sr_reason_sk` BIGINT, `sr_ticket_number`
BIGINT,
+|`sr_return_quantity` INT, `sr_return_amt` DECIMAL(7,2),
`sr_return_tax` DECIMAL(7,2),
+|`sr_return_amt_inc_tax` DECIMAL(7,2), `sr_fee` DECIMAL(7,2),
+
[GitHub] [spark] SparkQA commented on issue #25540: [SPARK-28830][DOC][SQL]Document UNCACHE TABLE statement in SQL Reference
SparkQA commented on issue #25540: [SPARK-28830][DOC][SQL]Document UNCACHE TABLE statement in SQL Reference URL: https://github.com/apache/spark/pull/25540#issuecomment-523744321 **[Test build #109550 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109550/testReport)** for PR 25540 at commit [`ca03005`](https://github.com/apache/spark/commit/ca03005a2371bd5b23b16414b51a1290660b65e0). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] huaxingao edited a comment on issue #25540: [SPARK-28830][DOC][SQL]Document UNCACHE TABLE statement in SQL Reference
huaxingao edited a comment on issue #25540: [SPARK-28830][DOC][SQL]Document UNCACHE TABLE statement in SQL Reference URL: https://github.com/apache/spark/pull/25540#issuecomment-523693037  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on issue #25545: [SPARK-28846][PYTHON] Set OMP_NUM_THREADS to executor cores for python
dongjoon-hyun edited a comment on issue #25545: [SPARK-28846][PYTHON] Set OMP_NUM_THREADS to executor cores for python URL: https://github.com/apache/spark/pull/25545#issuecomment-523736916 Hi, @rdblue . I. update the title slightly. ~BTW, could you file a JIRA for this improvement, please?~ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #25544: [SPARK-17875][CORE][BUILD] Remove dependency on Netty 3
dongjoon-hyun closed pull request #25544: [SPARK-17875][CORE][BUILD] Remove dependency on Netty 3 URL: https://github.com/apache/spark/pull/25544 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
