[GitHub] spark issue #21448: [SPARK-24408][SQL][DOC] Move abs, bitwiseNOT, isnan, nan...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21448 **[Test build #92437 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92437/testReport)** for PR 21448 at commit [`d11dbb9`](https://github.com/apache/spark/commit/d11dbb96eac48c3f69b78b8bc2d16498dd74683b). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21448: [SPARK-24408][SQL][DOC] Move abs, bitwiseNOT, isnan, nan...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21448 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/553/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21448: [SPARK-24408][SQL][DOC] Move abs, bitwiseNOT, isnan, nan...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21448 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21448: [SPARK-24408][SQL][DOC] Move abs, bitwiseNOT, isnan, nan...
Github user holdenk commented on the issue: https://github.com/apache/spark/pull/21448 Cool, let me know when you get a chance to update the PR @jaceklaskowski :) --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21448: [SPARK-24408][SQL][DOC] Move abs, bitwiseNOT, isnan, nan...
Github user holdenk commented on the issue: https://github.com/apache/spark/pull/21448 @jaceklaskowski how would you feel about just moving abs as suggested by @rxin? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21448: [SPARK-24408][SQL][DOC] Move abs, bitwiseNOT, isnan, nan...
Github user holdenk commented on the issue: https://github.com/apache/spark/pull/21448 So, I personally don't have strong feelings about which groups these functions should be in, but just a reminder we should unify with PySpark with whatever our decision is. In PySpark bitwiseNot is under math, abs is currently grouped with some string operators. Less important since its just code organization there but while were thinking about it anyways. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21448: [SPARK-24408][SQL][DOC] Move abs, bitwiseNOT, isnan, nan...
Github user rxin commented on the issue: https://github.com/apache/spark/pull/21448 I'd only move abs and nothing else. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21448: [SPARK-24408][SQL][DOC] Move abs, bitwiseNOT, isnan, nan...
Github user holdenk commented on the issue: https://github.com/apache/spark/pull/21448 If itâs ok Iâll take a quick look at this on Friday as discussed with Jacek. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21448: [SPARK-24408][SQL][DOC] Move abs, bitwiseNOT, isnan, nan...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/21448 `abs` does seem to belong with math functions. `isnan` and `nanvl` are sort of math related but to me feel more like `isnull`. It's more about testing representations of a value, not math on them (NaN isn't a mathematical notion, note). I'd leave it. Those methods in the JDK aren't in java.lang.Math, FWIW. `bitwiseNOT` sure seems like an odd man out. The other bitwise functions are defined in `Column.scala` I don't see why, other than that 'not' is a unary operator. This came from https://github.com/apache/spark/pull/5867#discussion-diff-29559385 but looks like that was a comment about `functions.py`. Although its location is odd, I guess I'd leave it unless @Shiti or @rxin say it's OK to move. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21448: [SPARK-24408][SQL][DOC] Move abs, bitwiseNOT, isnan, nan...
Github user jaceklaskowski commented on the issue: https://github.com/apache/spark/pull/21448 It is such a small change that I don't think it's going to take long to get merged. Reaching out to friendly folks to reach a consensus on it :) /cc @srowen @holdenk --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21448: [SPARK-24408][SQL][DOC] Move abs, bitwiseNOT, isnan, nan...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21448 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91250/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21448: [SPARK-24408][SQL][DOC] Move abs, bitwiseNOT, isnan, nan...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21448 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21448: [SPARK-24408][SQL][DOC] Move abs, bitwiseNOT, isnan, nan...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21448 **[Test build #91250 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91250/testReport)** for PR 21448 at commit [`487a467`](https://github.com/apache/spark/commit/487a467219014ea2e322861c3053d2a374740058). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21448: [SPARK-24408][SQL][DOC] Move abs, bitwiseNOT, isnan, nan...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21448 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3663/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21448: [SPARK-24408][SQL][DOC] Move abs, bitwiseNOT, isnan, nan...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21448 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21448: [SPARK-24408][SQL][DOC] Move abs, bitwiseNOT, isnan, nan...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21448 **[Test build #91250 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91250/testReport)** for PR 21448 at commit [`487a467`](https://github.com/apache/spark/commit/487a467219014ea2e322861c3053d2a374740058). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21448: [SPARK-24408][SQL][DOC] Move abs, bitwiseNOT, isnan, nan...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21448 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21448: [SPARK-24408][SQL][DOC] Move abs, bitwiseNOT, isnan, nan...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21448 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3660/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21448: [SPARK-24408][SQL][DOC] Move abs, bitwiseNOT, isnan, nan...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21448 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91247/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21448: [SPARK-24408][SQL][DOC] Move abs, bitwiseNOT, isnan, nan...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21448 **[Test build #91247 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91247/testReport)** for PR 21448 at commit [`25fe97f`](https://github.com/apache/spark/commit/25fe97f05aac5c4f44bea9d1356722e6735cc940). * This patch **fails Scala style tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21448: [SPARK-24408][SQL][DOC] Move abs, bitwiseNOT, isnan, nan...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21448 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21448: [SPARK-24408][SQL][DOC] Move abs, bitwiseNOT, isnan, nan...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21448 **[Test build #91247 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91247/testReport)** for PR 21448 at commit [`25fe97f`](https://github.com/apache/spark/commit/25fe97f05aac5c4f44bea9d1356722e6735cc940). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
