Re: [sane-devel] Happy new year- time for a sane-backends release!
Hi, OK, I think I have done that. Because we are short on time I cut and pasted the release note fragments from my spreadsheet into the NEWS file with Apostrophe MD file editor and whipped them into shape manually. First time using it and it is pretty good. Obviously, this was a manual process, but it wasn't too onerous. I couldn't get the towncrier thingy to work anyway. I don't really have much experience with python and pip. Python seems an awful lot more complicated since the last time I used it :( I have pushed the release notes in NEWS to your branch. Cheers, Ralph On 2023-02-04 18:18, m. allan noah wrote: Awesome, thanks! I'm working on updating doc/releases.md, which I find to be hard to use. Maybe if you keep some notes on what you did, I can incorporate your method instead of towncrier. allan On Sat, Feb 4, 2023 at 9:12 PM Ralph Little wrote: Hi, In this case I didn't generate the towncrier files. It's a lot of faff if you don't do it as you go along. I just put them into a spreadsheet. I will try to generate the release notes from that. Cheers, Ralph On 2023-02-04 17:57, m. allan noah wrote: I have pushed a branch called 'release-1.2.x'. I don't have this 'towncrier' thing, so maybe you can run that and merge the release notes? allan On Wed, Feb 1, 2023 at 11:39 AM m. allan noah wrote: Awesome, thanks! I'll probably take a first stab at it on the 4th, and see if I can follow our current instructions. allan On Sat, Jan 28, 2023 at 8:43 PM Ralph Little wrote: Hi, I have prepared the release notes whenever you are ready! Cheers, Ralph On 2023-01-24 08:33, m. allan noah wrote: Sounds good to me, thanks for your help. I'm traveling this week, and won't be able to work on this until the weekend. On Tue, Jan 24, 2023, 10:47 AM Ralph Little wrote: Hi, On 2023-01-01 15:54, m. allan noah wrote: > It has been nearly a year since our last release, and there have been > many changes and bug fixes. I'd like to get 1.2.1 released in early > February. I've not done it in a few years, but I am certainly willing > to make the release package. > > Any objections to a code freeze on Jan 22, and a release on Feb 5? > > allan I think if we are going for your proposed plan, then we are official in code freeze for 1.2.1. If you want to proceed, I can prepare release notes. Cheers, Ralph -- "well, I stand up next to a mountain- and I chop it down with the edge of my hand" -- "well, I stand up next to a mountain- and I chop it down with the edge of my hand" -- "well, I stand up next to a mountain- and I chop it down with the edge of my hand"
Re: [sane-devel] Happy new year- time for a sane-backends release!
Awesome, thanks! I'm working on updating doc/releases.md, which I find to be hard to use. Maybe if you keep some notes on what you did, I can incorporate your method instead of towncrier. allan On Sat, Feb 4, 2023 at 9:12 PM Ralph Little wrote: > Hi, > In this case I didn't generate the towncrier files. It's a lot of faff if > you don't do it as you go along. > I just put them into a spreadsheet. > > I will try to generate the release notes from that. > > Cheers, > Ralph > > On 2023-02-04 17:57, m. allan noah wrote: > > I have pushed a branch called 'release-1.2.x'. I don't have this > 'towncrier' thing, so maybe you can run that and merge the release notes? > > allan > > On Wed, Feb 1, 2023 at 11:39 AM m. allan noah wrote: > >> Awesome, thanks! I'll probably take a first stab at it on the 4th, and >> see if I can follow our current instructions. >> >> allan >> >> On Sat, Jan 28, 2023 at 8:43 PM Ralph Little wrote: >> >>> Hi, >>> I have prepared the release notes whenever you are ready! >>> >>> Cheers, >>> Ralph >>> >>> On 2023-01-24 08:33, m. allan noah wrote: >>> >>> Sounds good to me, thanks for your help. I'm traveling this week, and >>> won't be able to work on this until the weekend. >>> >>> On Tue, Jan 24, 2023, 10:47 AM Ralph Little wrote: >>> Hi, On 2023-01-01 15:54, m. allan noah wrote: > It has been nearly a year since our last release, and there have been > many changes and bug fixes. I'd like to get 1.2.1 released in early > February. I've not done it in a few years, but I am certainly willing > to make the release package. > > Any objections to a code freeze on Jan 22, and a release on Feb 5? > > allan I think if we are going for your proposed plan, then we are official in code freeze for 1.2.1. If you want to proceed, I can prepare release notes. Cheers, Ralph >>> >>> >> >> -- >> "well, I stand up next to a mountain- and I chop it down with the edge of >> my hand" >> > > > -- > "well, I stand up next to a mountain- and I chop it down with the edge of > my hand" > > > -- "well, I stand up next to a mountain- and I chop it down with the edge of my hand"
Re: [sane-devel] Happy new year- time for a sane-backends release!
Hi, In this case I didn't generate the towncrier files. It's a lot of faff if you don't do it as you go along. I just put them into a spreadsheet. I will try to generate the release notes from that. Cheers, Ralph On 2023-02-04 17:57, m. allan noah wrote: I have pushed a branch called 'release-1.2.x'. I don't have this 'towncrier' thing, so maybe you can run that and merge the release notes? allan On Wed, Feb 1, 2023 at 11:39 AM m. allan noah wrote: Awesome, thanks! I'll probably take a first stab at it on the 4th, and see if I can follow our current instructions. allan On Sat, Jan 28, 2023 at 8:43 PM Ralph Little wrote: Hi, I have prepared the release notes whenever you are ready! Cheers, Ralph On 2023-01-24 08:33, m. allan noah wrote: Sounds good to me, thanks for your help. I'm traveling this week, and won't be able to work on this until the weekend. On Tue, Jan 24, 2023, 10:47 AM Ralph Little wrote: Hi, On 2023-01-01 15:54, m. allan noah wrote: > It has been nearly a year since our last release, and there have been > many changes and bug fixes. I'd like to get 1.2.1 released in early > February. I've not done it in a few years, but I am certainly willing > to make the release package. > > Any objections to a code freeze on Jan 22, and a release on Feb 5? > > allan I think if we are going for your proposed plan, then we are official in code freeze for 1.2.1. If you want to proceed, I can prepare release notes. Cheers, Ralph -- "well, I stand up next to a mountain- and I chop it down with the edge of my hand" -- "well, I stand up next to a mountain- and I chop it down with the edge of my hand"
Re: [sane-devel] Happy new year- time for a sane-backends release!
I have pushed a branch called 'release-1.2.x'. I don't have this 'towncrier' thing, so maybe you can run that and merge the release notes? allan On Wed, Feb 1, 2023 at 11:39 AM m. allan noah wrote: > Awesome, thanks! I'll probably take a first stab at it on the 4th, and see > if I can follow our current instructions. > > allan > > On Sat, Jan 28, 2023 at 8:43 PM Ralph Little wrote: > >> Hi, >> I have prepared the release notes whenever you are ready! >> >> Cheers, >> Ralph >> >> On 2023-01-24 08:33, m. allan noah wrote: >> >> Sounds good to me, thanks for your help. I'm traveling this week, and >> won't be able to work on this until the weekend. >> >> On Tue, Jan 24, 2023, 10:47 AM Ralph Little wrote: >> >>> Hi, >>> >>> On 2023-01-01 15:54, m. allan noah wrote: >>> > It has been nearly a year since our last release, and there have been >>> > many changes and bug fixes. I'd like to get 1.2.1 released in early >>> > February. I've not done it in a few years, but I am certainly willing >>> > to make the release package. >>> > >>> > Any objections to a code freeze on Jan 22, and a release on Feb 5? >>> > >>> > allan >>> >>> I think if we are going for your proposed plan, then we are official in >>> code freeze for 1.2.1. >>> If you want to proceed, I can prepare release notes. >>> >>> Cheers, >>> Ralph >>> >> >> > > -- > "well, I stand up next to a mountain- and I chop it down with the edge of > my hand" > -- "well, I stand up next to a mountain- and I chop it down with the edge of my hand"
Re: [sane-devel] scanimage does not recognize basic long options
Hi, I have checked in a change to scanimage in master and it should be in 1.2.1. @karl, perhaps pull the change and make sure it is good for you? Cheers, Ralph On 2023-02-04 11:47, m. allan noah wrote: I'm ok with breaking code freeze if you want On Sat, Feb 4, 2023, 2:41 PM Ralph Little wrote: Hi, On 2023-02-04 10:38, Karl Weber wrote: > Hi Ralf, > > On Saturday, 4 February 2023 18:06:41 CET Ralph Little wrote: >> The condition on SANE_OPTION_IS_SETTABLE(opt->cap) has been removed in >> version >>> 1.1.1 and this causes the problem. >> I'm a bit confused by this comment. I thought that your issue was caused >> by the backend sending NULL. >> Which problem do you believe this causes? Or are you saying that the >> NULL options issue is revealed by this change? That is certainly possible. > Yes, you may also say that the NULL options issue has been revealed by this > change. I didn't know, why this check has been removed and I don't know why it > had been there beforehand. I am really new to sane! I started to look at the > code two days ago. Before I was only an ignorant user of scanimage. So please > excuse me. > > But irrespective of the wording, are you going to do something about it? Or > where would be the right place to fix this problem? Currently I have no idea, > whether hplip-sane is open source and what the chances would be, to get a fix > in there, if this would be the right place for a fix. I don't even know, > whether it is part of the SANE API specification, that there must not be NULL > options. I suspect that the hpaio backend is doing something improper. However, we must deal with it somehow. I will do a fix. Cheers, Ralph
Re: [sane-devel] scanimage does not recognize basic long options
I'm ok with breaking code freeze if you want On Sat, Feb 4, 2023, 2:41 PM Ralph Little wrote: > Hi, > > On 2023-02-04 10:38, Karl Weber wrote: > > Hi Ralf, > > > > On Saturday, 4 February 2023 18:06:41 CET Ralph Little wrote: > >> The condition on SANE_OPTION_IS_SETTABLE(opt->cap) has been removed in > >> version > >>> 1.1.1 and this causes the problem. > >> I'm a bit confused by this comment. I thought that your issue was caused > >> by the backend sending NULL. > >> Which problem do you believe this causes? Or are you saying that the > >> NULL options issue is revealed by this change? That is certainly > possible. > > Yes, you may also say that the NULL options issue has been revealed by > this > > change. I didn't know, why this check has been removed and I don't know > why it > > had been there beforehand. I am really new to sane! I started to look at > the > > code two days ago. Before I was only an ignorant user of scanimage. So > please > > excuse me. > > > > But irrespective of the wording, are you going to do something about it? > Or > > where would be the right place to fix this problem? Currently I have no > idea, > > whether hplip-sane is open source and what the chances would be, to get > a fix > > in there, if this would be the right place for a fix. I don't even know, > > whether it is part of the SANE API specification, that there must not be > NULL > > options. > I suspect that the hpaio backend is doing something improper. However, > we must deal with it somehow. > I will do a fix. > > Cheers, > Ralph > >
Re: [sane-devel] scanimage does not recognize basic long options
Hi, On 2023-02-04 10:38, Karl Weber wrote: Hi Ralf, On Saturday, 4 February 2023 18:06:41 CET Ralph Little wrote: The condition on SANE_OPTION_IS_SETTABLE(opt->cap) has been removed in version 1.1.1 and this causes the problem. I'm a bit confused by this comment. I thought that your issue was caused by the backend sending NULL. Which problem do you believe this causes? Or are you saying that the NULL options issue is revealed by this change? That is certainly possible. Yes, you may also say that the NULL options issue has been revealed by this change. I didn't know, why this check has been removed and I don't know why it had been there beforehand. I am really new to sane! I started to look at the code two days ago. Before I was only an ignorant user of scanimage. So please excuse me. But irrespective of the wording, are you going to do something about it? Or where would be the right place to fix this problem? Currently I have no idea, whether hplip-sane is open source and what the chances would be, to get a fix in there, if this would be the right place for a fix. I don't even know, whether it is part of the SANE API specification, that there must not be NULL options. I suspect that the hpaio backend is doing something improper. However, we must deal with it somehow. I will do a fix. Cheers, Ralph
Re: [sane-devel] scanimage does not recognize basic long options
Hi Ralf, On Saturday, 4 February 2023 18:06:41 CET Ralph Little wrote: > The condition on SANE_OPTION_IS_SETTABLE(opt->cap) has been removed in > version > > 1.1.1 and this causes the problem. > > I'm a bit confused by this comment. I thought that your issue was caused > by the backend sending NULL. > Which problem do you believe this causes? Or are you saying that the > NULL options issue is revealed by this change? That is certainly possible. Yes, you may also say that the NULL options issue has been revealed by this change. I didn't know, why this check has been removed and I don't know why it had been there beforehand. I am really new to sane! I started to look at the code two days ago. Before I was only an ignorant user of scanimage. So please excuse me. But irrespective of the wording, are you going to do something about it? Or where would be the right place to fix this problem? Currently I have no idea, whether hplip-sane is open source and what the chances would be, to get a fix in there, if this would be the right place for a fix. I don't even know, whether it is part of the SANE API specification, that there must not be NULL options. But even if it is a bug in hplip-sane, or the scanner-firmware itself, couldn't it be wise, to include a check against NULL options in scanimage? If my test revealed this problem, couldn't it show up with other backends as well? I have absolutely no idea, what and how you test before you release a new version of sane. Regards Karl
Re: [sane-devel] scanimage does not recognize basic long options
Hi, On 2023-02-04 01:15, Karl Weber wrote: Hi, On Friday, 3 February 2023 21:11:11 CET Karl Weber wrote: It is easy, to fix this. After if (opt->type == SANE_TYPE_GROUP) continue; one may to add if (opt->name == NULL) continue; The sources that come with my distribution, i.e. version 1.0.32, have the different check in fetch_options: /* create command line option only for settable options */ if (!SANE_OPTION_IS_SETTABLE (opt->cap) || opt->type == SANE_TYPE_GROUP) continue; The condition on SANE_OPTION_IS_SETTABLE(opt->cap) has been removed in version 1.1.1 and this causes the problem. I'm a bit confused by this comment. I thought that your issue was caused by the backend sending NULL. Which problem do you believe this causes? Or are you saying that the NULL options issue is revealed by this change? That is certainly possible. That specific change was introduced to avoid readonly options being reported as "invalid" which is confusing to the user, as they are obviously valid, yet cannot be set. It now reports that the option is readonly. Cheers, Ralph
Re: [sane-devel] scanimage does not recognize basic long options
Hi, On Friday, 3 February 2023 21:11:11 CET Karl Weber wrote: > It is easy, to fix this. After > > if (opt->type == SANE_TYPE_GROUP) > continue; > > one may to add > > if (opt->name == NULL) > continue; The sources that come with my distribution, i.e. version 1.0.32, have the different check in fetch_options: /* create command line option only for settable options */ if (!SANE_OPTION_IS_SETTABLE (opt->cap) || opt->type == SANE_TYPE_GROUP) continue; The condition on SANE_OPTION_IS_SETTABLE(opt->cap) has been removed in version 1.1.1 and this causes the problem. Are you going to change this in version 1.1.1 back to the condition in version 1.0.32? Should I write a bug report about this? Thanks, Karl
