[webkit-changes] [WebKit/WebKit] 70d5e6: Unreviewed build fix after 263393@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 70d5e6affd81582bc06b51cc8a6dbfb6fe8c736b https://github.com/WebKit/WebKit/commit/70d5e6affd81582bc06b51cc8a6dbfb6fe8c736b Author: Ryosuke Niwa Date: 2023-04-25 (Tue, 25 Apr 2023) Changed paths: M Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm Log Message: --- Unreviewed build fix after 263393@main. * Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm: Canonical link: https://commits.webkit.org/263403@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] de85e9: [JSC] Clean up JSObject allocation in C++
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: de85e95599abdc0819d949f06c77ca960b6a2293 https://github.com/WebKit/WebKit/commit/de85e95599abdc0819d949f06c77ca960b6a2293 Author: Yusuke Suzuki Date: 2023-04-25 (Tue, 25 Apr 2023) Changed paths: M Source/JavaScriptCore/API/JSAPIValueWrapper.h M Source/JavaScriptCore/bytecode/CodeBlock.cpp M Source/JavaScriptCore/debugger/DebuggerScope.cpp M Source/JavaScriptCore/heap/Allocator.cpp M Source/JavaScriptCore/heap/Allocator.h M Source/JavaScriptCore/heap/AllocatorInlines.h M Source/JavaScriptCore/heap/CompleteSubspace.cpp M Source/JavaScriptCore/heap/CompleteSubspaceInlines.h M Source/JavaScriptCore/heap/FreeList.h M Source/JavaScriptCore/heap/FreeListInlines.h M Source/JavaScriptCore/heap/IsoSubspaceInlines.h M Source/JavaScriptCore/heap/LocalAllocator.cpp M Source/JavaScriptCore/heap/LocalAllocator.h M Source/JavaScriptCore/heap/LocalAllocatorInlines.h M Source/JavaScriptCore/runtime/AuxiliaryBarrier.h M Source/JavaScriptCore/runtime/BrandedStructure.cpp M Source/JavaScriptCore/runtime/Exception.cpp M Source/JavaScriptCore/runtime/Exception.h M Source/JavaScriptCore/runtime/FunctionExecutable.cpp M Source/JavaScriptCore/runtime/FunctionExecutable.h M Source/JavaScriptCore/runtime/FunctionRareData.cpp M Source/JavaScriptCore/runtime/InternalFunction.cpp M Source/JavaScriptCore/runtime/IntlSegmentIterator.cpp M Source/JavaScriptCore/runtime/IntlSegmentIterator.h M Source/JavaScriptCore/runtime/IntlSegments.cpp M Source/JavaScriptCore/runtime/IntlSegments.h M Source/JavaScriptCore/runtime/JSBoundFunction.cpp M Source/JavaScriptCore/runtime/JSCallee.cpp M Source/JavaScriptCore/runtime/JSCellInlines.h M Source/JavaScriptCore/runtime/JSGlobalProxy.h M Source/JavaScriptCore/runtime/JSLexicalEnvironment.h M Source/JavaScriptCore/runtime/JSModuleEnvironment.cpp M Source/JavaScriptCore/runtime/JSModuleEnvironment.h M Source/JavaScriptCore/runtime/JSObject.h M Source/JavaScriptCore/runtime/JSPropertyNameEnumerator.cpp M Source/JavaScriptCore/runtime/JSRemoteFunction.cpp M Source/JavaScriptCore/runtime/JSScope.h M Source/JavaScriptCore/runtime/JSWithScope.cpp M Source/JavaScriptCore/runtime/ProxyRevoke.cpp M Source/JavaScriptCore/runtime/ProxyRevoke.h M Source/JavaScriptCore/runtime/ScopedArguments.cpp M Source/JavaScriptCore/runtime/ScopedArguments.h M Source/JavaScriptCore/runtime/Structure.cpp M Source/JavaScriptCore/runtime/Structure.h M Source/JavaScriptCore/runtime/StructureChain.cpp M Source/JavaScriptCore/runtime/StructureRareData.cpp M Source/JavaScriptCore/runtime/TypeInfoBlob.h M Source/JavaScriptCore/runtime/WriteBarrier.h M Source/JavaScriptCore/tools/JSDollarVM.cpp M Source/JavaScriptCore/wasm/js/JSWebAssemblyInstance.cpp M Source/JavaScriptCore/wasm/js/JSWebAssemblyInstance.h M Source/JavaScriptCore/wasm/js/WebAssemblyFunction.cpp M Source/JavaScriptCore/wasm/js/WebAssemblyFunction.h M Source/JavaScriptCore/wasm/js/WebAssemblyFunctionBase.cpp M Source/JavaScriptCore/wasm/js/WebAssemblyFunctionBase.h M Source/JavaScriptCore/wasm/js/WebAssemblyWrapperFunction.cpp M Source/JavaScriptCore/wasm/js/WebAssemblyWrapperFunction.h M Source/WebCore/bindings/js/JSWindowProxy.cpp Log Message: --- [JSC] Clean up JSObject allocation in C++ https://bugs.webkit.org/show_bug.cgi?id=255906 rdar://108488362 Reviewed by Michael Saboff. 1. Compute cellSize and propagate it instead of loading it. In many cases, it can be constant-folded since allocated JSCell type is known in IsoSubspace case. 2. Load 4byte Structure Blob and store it in initialization of JSCell. 3. Remove write barrier for butterfly. Since JSObject is newly-allocated and it is before calling finishCreation, it is not exposed to GC yet, and write-barrier is not necessary. 4. Add WriteBarrierEarlyInit tag for WriteBarrier<> / AuxiliaryBarrier<> initialization in the constructor. In this case, we do not need a write barrier since the cell is not exposed to GC yet. Before: (fast path only) JSC::JSArray::createWithButterfly(JSC::VM&, JSC::GCDeferralContext*, JSC::Structure*, JSC::Butterfly*): 00914500pacibsp 00914504sub sp, sp, #0x50 00914508stp x22, x21, [sp, #0x20] 0091450cstp x20, x19, [sp, #0x30] 00914510stp x29, x30, [sp, #0x40] 00914514add x29, sp, #0x40 00914518mov x19, x0 0091451cmov w8, #0x8fe8 00914520add x8, x0, x8 00914524add x0, x0, #0x88 00914528ldp x20, x9, [x8] 0091452ccmp x20, x9 00914530b.hs
[webkit-changes] [WebKit/WebKit] 5ce845: REGRESSION(263338@main) [Win] JSTests/stress/setti...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5ce84537546780563ba28ecf43a06396eb106f9b https://github.com/WebKit/WebKit/commit/5ce84537546780563ba28ecf43a06396eb106f9b Author: Fujii Hironori Date: 2023-04-25 (Tue, 25 Apr 2023) Changed paths: M Source/WTF/wtf/win/RunLoopWin.cpp Log Message: --- REGRESSION(263338@main) [Win] JSTests/stress/settimeout-starvation.js is timing out https://bugs.webkit.org/show_bug.cgi?id=255908 Reviewed by Ross Kirsling. stress/settimeout-starvation.js was timing out after 263338@main. It changed RunLoop::stop to post WM_CLOSE to close a window. settimeout-starvation.js does setTimeout in the timeout callback infinitely. The WM_CLOSE message in the message queue never be dispatched. Reverted 263338@main. Use DestroyWindow in ~RunLoop to close the window. * Source/WTF/wtf/win/RunLoopWin.cpp: (WTF::RunLoop::stop): (WTF::RunLoop::~RunLoop): Canonical link: https://commits.webkit.org/263401@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0c64ef: Async scrolling on Mac creates implicit CA transac...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0c64efa347b930a2ae3dbeea7d0ad20373c1bf61 https://github.com/WebKit/WebKit/commit/0c64efa347b930a2ae3dbeea7d0ad20373c1bf61 Author: Matt Woodrow Date: 2023-04-25 (Tue, 25 Apr 2023) Changed paths: M Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingTree.cpp M Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingTree.h M Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeEventDispatcher.cpp M Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteScrollingTreeMac.h M Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteScrollingTreeMac.mm Log Message: --- Async scrolling on Mac creates implicit CA transactions. https://bugs.webkit.org/show_bug.cgi?id=255960 Reviewed by Simon Fraser. RemoteScrollingTreeMac can mutate the layer tree on the scrolling thread, which creates implicit CA transactions. Some clients aren't expecting this, so we should instead create explicit transactions when needed. * Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingTree.cpp: (WebKit::RemoteScrollingTree::tryToApplyLayerPositions): * Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingTree.h: (WebKit::RemoteScrollingTree::beginTransactionOnScrollingThread): (WebKit::RemoteScrollingTree::commitTransactionOnScrollingThread): (WebKit::RemoteScrollingTreeTransactionHolder::RemoteScrollingTreeTransactionHolder): (WebKit::RemoteScrollingTreeTransactionHolder::~RemoteScrollingTreeTransactionHolder): * Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeEventDispatcher.cpp: (WebKit::RemoteLayerTreeEventDispatcher::scrollingThreadHandleWheelEvent): * Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteScrollingTreeMac.h: * Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteScrollingTreeMac.mm: (WebKit::RemoteScrollingTreeMac::beginTransactionOnScrollingThread): (WebKit::RemoteScrollingTreeMac::commitTransactionOnScrollingThread): Canonical link: https://commits.webkit.org/263400@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7f2402: [Windows] Allow bmalloc build for Windows platform.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7f2402e915287f01288f7061e71be2de40cc98a8 https://github.com/WebKit/WebKit/commit/7f2402e915287f01288f7061e71be2de40cc98a8 Author: Basuke Suzuki Date: 2023-04-25 (Tue, 25 Apr 2023) Changed paths: M Source/WTF/wtf/PlatformUse.h M Source/bmalloc/CMakeLists.txt M Source/cmake/OptionsWin.cmake Log Message: --- [Windows] Allow bmalloc build for Windows platform. https://bugs.webkit.org/show_bug.cgi?id=255943 Reviewed by Yusuke Suzuki. This is the patch for Windows bmalloc implementation part 1 of N. On Windows port, USE_SYSTEM_MALLOC is hard coded and cannot enable by cmake option USE_SYSTEM_MALLOC=Off. This patch removes the restriction by removing that code. Note the default value of USE_SYSTEM_MALLOC on Windows port is still on. There's no actual effect unless passing the cmake arg explicitly. * Source/WTF/wtf/PlatformUse.h: * Source/bmalloc/CMakeLists.txt: * Source/cmake/OptionsWin.cmake: Canonical link: https://commits.webkit.org/263399@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e44bd7: [margin-trim][block layout] Trimmed block-end marg...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e44bd7f346a1ce7ccfffd73e4192ded629c708ff https://github.com/WebKit/WebKit/commit/e44bd7f346a1ce7ccfffd73e4192ded629c708ff Author: Sammy Gill Date: 2023-04-25 (Tue, 25 Apr 2023) Changed paths: A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/computed-margin-values/block-container-block-end-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/computed-margin-values/block-container-block-end-nested-child-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/computed-margin-values/block-container-block-end-nested-child.html A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/computed-margin-values/block-container-block-end-with-self-collapsing-children-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/computed-margin-values/block-container-block-end-with-self-collapsing-children.html A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/computed-margin-values/block-container-block-end.html M Source/WebCore/css/ComputedStyleExtractor.cpp M Source/WebCore/rendering/RenderBlockFlow.cpp M Source/WebCore/rendering/RenderBox.cpp M Source/WebCore/rendering/RenderBox.h Log Message: --- [margin-trim][block layout] Trimmed block-end margins should be reflected in computed style in a horizontal writing-mode BFC. https://bugs.webkit.org/show_bug.cgi?id=253610 rdar://106454992 Reviewed by Alan Baradlay. We currently perform margin trimming by doing some backtracking after a block container with block-end margin trim has completed layout (261750@main). In order to make sure that these margins are properly shown in their computed style value, we need a way for ComputedStyleExtractor to know that the block-end margin for the renderer has been trimmed. This can be done by setting the margin-trim rare data bit for that renderer. Whenever we trim a margin in RenderBlockFlow::trimBlockEndChildrenMargins, we can replace the calls to setMarginAfterForChild with setTrimmedMarginForChild which will both trim the margin and set the rare data bit for the renderer. Later on when ComputedStyleExtractor tries to determine the value of a bottom margin for a renderer it can first use hasTrimmedMargin on the renderer in order to determine if that specific margin is trimmed. While creating this patch and testing the logic, I found that certain margins are not being trimmed correctly. It seems like particularly that self collapsing children that has other nested self collapsing content do not have the nested content trimmed properly. Whenever we have a self collapsing child, we need to also go inside and trim the margins of any other children (and perhaps perform this logic for any other children that are nested inside that). For example In this scenario the content itself looks fine as if margin-trimming occurred correctly, however when looking at the computed margin-bottom values of the nested self collapsing children we can see that their margins were not trimmed. Currently we fail the tests in these scenarios that are introduced in this patch because of this. I plan on addressing this in a separate patch following this one. * LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/computed-margin-values/block-container-block-end-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/computed-margin-values/block-container-block-end-nested-child-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/computed-margin-values/block-container-block-end-nested-child.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/computed-margin-values/block-container-block-end-with-self-collapsing-children-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/computed-margin-values/block-container-block-end-with-self-collapsing-children.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/computed-margin-values/block-container-block-end.html: Added. * Source/WebCore/css/ComputedStyleExtractor.cpp: (WebCore::rendererCanHaveTrimmedMargin): * Source/WebCore/rendering/RenderBlockFlow.cpp: (WebCore::RenderBlockFlow::trimBlockEndChildrenMargins): * Source/WebCore/rendering/RenderBox.cpp: (WebCore::RenderBox::physicalToFlowRelativeDirectionMapping const): (WebCore::RenderBox::hasTrimmedMargin const): (WebCore::RenderBox::hasTrimmedMargin const): * Source/WebCore/rendering/RenderBox.h: (WebCore::RenderBox::isBlockLevelBox const): Canonical link: https://commits.webkit.org/263398@main ___ webkit-changes mailing list
[webkit-changes] [WebKit/WebKit] ce99b4: [Shape Detection] [Cocoa] Implement first draft of...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ce99b4d5dd33bd28ffb58899e356841cb5ed7285 https://github.com/WebKit/WebKit/commit/ce99b4d5dd33bd28ffb58899e356841cb5ed7285 Author: Myles C. Maxfield Date: 2023-04-25 (Tue, 25 Apr 2023) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WTF/wtf/PlatformHave.h M Source/WTF/wtf/PlatformUse.h M Source/WebCore/Modules/ShapeDetection/Implementation/Cocoa/BarcodeDetectorImplementation.h M Source/WebCore/Modules/ShapeDetection/Implementation/Cocoa/BarcodeDetectorImplementation.mm M Source/WebCore/Modules/ShapeDetection/Implementation/Cocoa/FaceDetectorImplementation.h M Source/WebCore/Modules/ShapeDetection/Implementation/Cocoa/FaceDetectorImplementation.mm M Source/WebCore/Modules/ShapeDetection/Implementation/Cocoa/TextDetectorImplementation.h M Source/WebCore/Modules/ShapeDetection/Implementation/Cocoa/TextDetectorImplementation.mm A Source/WebCore/Modules/ShapeDetection/Implementation/Cocoa/VisionUtilities.h A Source/WebCore/Modules/ShapeDetection/Implementation/Cocoa/VisionUtilities.mm M Source/WebCore/Modules/async-clipboard/ClipboardImageReader.h M Source/WebCore/PAL/pal/spi/cocoa/SpeechSPI.h M Source/WebCore/SourcesCocoa.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj Log Message: --- [Shape Detection] [Cocoa] Implement first draft of the shape detection API using the Vision framework https://bugs.webkit.org/show_bug.cgi?id=255803 rdar://108380805 Reviewed by Mike Wyrzykowski. This is the first draft implementation of the shape detection API. This patch makes WebCore.framework link with Vision.framework. The shape detection API is very very similar to Vision's API, so the implementation is almost trivial: each call to detect() just turns into the creation of a VNRequest and a VNRequestHandler, and calls performRequests() on the request handler. VNRequest has a callback-based codepath, where you can say -[VNRequest initWithCompletionHandler:], but this isn't really suitable for our purposes, at least right out-of-the-box, for 2 reasons: 1. Even if you set up the VNRequest this way, the call to -[VNImageRequestHandler performRequest:error:] is still synchronous. It blocks until all the requests are complete, and AFAICT there's no way to make it not block. So, using the callback doesn't actually free up the main thread to do other work. (The purpose of the completion handler is when you pass many requests to a single performRequests: call, you can be notified as the requests complete, one by one - *not* so that the call to performRequests: can be asynchronous. If you want the call to performRequests: to be asynchronous, you're supposed to call it from a background thread yourself.) 2. The callbacks are called on another thread internal to Vision, so if we wanted to use them, we'd have to immediately bounce back to the RemoteRenderingBackend's worker thread in WebKit2, or the main thread in WebKitLegacy. This means the Shape Detection objects would have to have more plumbing to take a generic handler which can schedule work on the right thread. At some point, it probably would make sense to do this plumbing work + calling Vision on a background thread, but it isn't really necessary for this first-draft implementation. I haven't profiled these calls yet to know if they're even expensive enough to be worth calling on a background thread or not. This patch also sets the usesCPUOnly flag, because otherwise the API wouldn't work in WebKit 2, because the GPU Process's sandbox is blocking the connection to aned on Apple Silicon devices (I haven't tried on Intel devices, maybe it works using the GPU there?). I'm working with Per Arne to see what we can do about this. If you manually disable the sandbox, this flag isn't necessary. The tests for this patch are at https://github.com/web-platform-tests/wpt/commit/b5a2b1e1b0bd51817dca49b49eb3e8825833b216. I will import them in a follow-up patch. This patch marks the shape detection as "testable." * Source/WebCore/Modules/ShapeDetection/Implementation/Cocoa/BarcodeDetectorImplementation.h: * Source/WebCore/Modules/ShapeDetection/Implementation/Cocoa/BarcodeDetectorImplementation.mm: (WebCore::ShapeDetection::convertSymbology): (WebCore::ShapeDetection::convertBarcodeFormat): (WebCore::ShapeDetection::convertRequestedBarcodeFormatSet): (WebCore::ShapeDetection::BarcodeDetectorImpl::BarcodeDetectorImpl): (WebCore::ShapeDetection::request): (WebCore::ShapeDetection::BarcodeDetectorImpl::getSupportedFormats): (WebCore::ShapeDetection::BarcodeDetectorImpl::detect): * Source/WebCore/Modules/ShapeDetection/Implementation/Cocoa/FaceDetectorImplementation.h: * Source/WebCore/Modules/ShapeDetection/Implementation/Cocoa/FaceDetectorImplementation.mm:
[webkit-changes] [WebKit/WebKit] ec2049: Fix useGC option
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ec2049381d4bd1d8fced27ee6ded876fde47f2a4 https://github.com/WebKit/WebKit/commit/ec2049381d4bd1d8fced27ee6ded876fde47f2a4 Author: Yijia Huang Date: 2023-04-25 (Tue, 25 Apr 2023) Changed paths: M Source/JavaScriptCore/heap/Heap.cpp Log Message: --- Fix useGC option https://bugs.webkit.org/show_bug.cgi?id=255792 rdar://108370700 Reviewed by Yusuke Suzuki. Fix `useGC` option by forcing to disable any GC activities. * Source/JavaScriptCore/heap/Heap.cpp: (JSC::Heap::sweepSynchronously): (JSC::Heap::collect): (JSC::Heap::collectNow): (JSC::Heap::collectAsync): (JSC::Heap::collectSync): (JSC::Heap::notifyIsSafeToCollect): Canonical link: https://commits.webkit.org/263396@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 80c703: Disable strict decoding for NSParagraphStyle
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 80c70373dae3e577d3abdd25dd9a959802ac4c28 https://github.com/WebKit/WebKit/commit/80c70373dae3e577d3abdd25dd9a959802ac4c28 Author: Alex Christensen Date: 2023-04-25 (Tue, 25 Apr 2023) Changed paths: M Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm Log Message: --- Disable strict decoding for NSParagraphStyle https://bugs.webkit.org/show_bug.cgi?id=255966 rdar://108038436 Reviewed by Wenson Hsieh. * Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm: (IPC::shouldEnableStrictMode): Canonical link: https://commits.webkit.org/263395@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a7fe66: [results.webkit.org] Fix commit view with multiple...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a7fe669e401f00f010211619ea5d98016395ca00 https://github.com/WebKit/WebKit/commit/a7fe669e401f00f010211619ea5d98016395ca00 Author: Jonathan Bedard Date: 2023-04-25 (Tue, 25 Apr 2023) Changed paths: M Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/templates/commit.html Log Message: --- [results.webkit.org] Fix commit view with multiple emails https://bugs.webkit.org/show_bug.cgi?id=255959 rdar://108529029 Reviewed by Ryan Haddad. * Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/templates/commit.html: Seperate multiple emails with commas. Canonical link: https://commits.webkit.org/263394@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d55e3c: Use WKDataTask for SystemPreview downloads
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d55e3cae6649895b6d2aeb7235ba879bdb403868 https://github.com/WebKit/WebKit/commit/d55e3cae6649895b6d2aeb7235ba879bdb403868 Author: Dean Jackson Date: 2023-04-25 (Tue, 25 Apr 2023) Changed paths: M Source/WebCore/PAL/pal/spi/cocoa/FoundationSPI.h M Source/WebCore/html/HTMLAnchorElement.cpp M Source/WebCore/page/ChromeClient.h M Source/WebCore/page/Page.cpp M Source/WebCore/page/Page.h M Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivateForTesting.h M Source/WebKit/UIProcess/API/Cocoa/WKWebViewTesting.mm M Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm M Source/WebKit/UIProcess/SystemPreviewController.h M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/UIProcess/WebPageProxy.messages.in M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj M Tools/TestWebKitAPI/Tests/WebKitCocoa/SystemPreview.mm A Tools/TestWebKitAPI/Tests/WebKitCocoa/UnitBox.usdz M Tools/TestWebKitAPI/Tests/WebKitCocoa/system-preview-trigger.html A Tools/TestWebKitAPI/Tests/WebKitCocoa/system-preview.html Log Message: --- Use WKDataTask for SystemPreview downloads https://bugs.webkit.org/show_bug.cgi?id=255954 rdar://108524222 Reviewed by Tim Horton. Migrate away from LegacyDownloadClient and instead handle System Previews directly. This will allow us to remove the horrible code in the download client, as well eventually allow 3rd-party engines to use ARQL. The fix is to intercept the HTMLAnchorElement click for a system preview, and send that directly to the SystemPreviewController in the UI Process. That object then creates a WKDataTask for the download and presents ARQL as normal. A followup patch will remove the old code. * Source/WebCore/html/HTMLAnchorElement.cpp: * Source/WebCore/page/ChromeClient.h: * Source/WebCore/page/Page.cpp: * Source/WebCore/page/Page.h: * Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivateForTesting.h: * Source/WebKit/UIProcess/API/Cocoa/WKWebViewTesting.mm: * Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm: * Source/WebKit/UIProcess/SystemPreviewController.h: * Source/WebKit/UIProcess/WebPageProxy.cpp: * Source/WebKit/UIProcess/WebPageProxy.h: * Source/WebKit/UIProcess/WebPageProxy.messages.in: * Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp: * Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h: * Tools/TestWebKitAPI/Tests/WebKitCocoa/SystemPreview.mm: (-[TestSystemPreviewUIDelegate _presentingViewControllerForWebView:]): (TestWebKitAPI::TEST): * Tools/TestWebKitAPI/Tests/WebKitCocoa/UnitBox.usdz: Added. * Tools/TestWebKitAPI/Tests/WebKitCocoa/system-preview-trigger.html: * Tools/TestWebKitAPI/Tests/WebKitCocoa/system-preview.html: Added. Canonical link: https://commits.webkit.org/263393@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 05aaf4: Remove LegacyDownloadClient code for SystemPreview
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 05aaf4a5692421321939630ecd0612308082ed21 https://github.com/WebKit/WebKit/commit/05aaf4a5692421321939630ecd0612308082ed21 Author: Dean Jackson Date: 2023-04-25 (Tue, 25 Apr 2023) Changed paths: M Source/WebCore/html/HTMLAnchorElement.cpp M Source/WebCore/loader/FrameLoadRequest.cpp M Source/WebCore/loader/FrameLoadRequest.h M Source/WebCore/loader/FrameLoader.cpp M Source/WebCore/loader/FrameLoader.h M Source/WebCore/loader/FrameLoaderTypes.h M Source/WebCore/platform/network/ResourceRequestBase.cpp M Source/WebCore/platform/network/ResourceRequestBase.h M Source/WebCore/platform/network/cf/ResourceRequest.h M Source/WebCore/platform/network/cocoa/ResourceRequestCocoa.mm M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in M Source/WebKit/UIProcess/API/APINavigation.h M Source/WebKit/UIProcess/Cocoa/LegacyDownloadClient.h M Source/WebKit/UIProcess/Cocoa/LegacyDownloadClient.mm M Source/WebKit/UIProcess/Downloads/DownloadProxy.h M Source/WebKit/UIProcess/WebPageProxy.cpp Log Message: --- Remove LegacyDownloadClient code for SystemPreview https://bugs.webkit.org/show_bug.cgi?id=255957 rdar://108526852 Reviewed by Tim Horton. https://bugs.webkit.org/show_bug.cgi?id=255954 implements a new way to trigger this code, so the old way can be deleted. This will make Alex happy. * Source/WebCore/html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::handleClick): * Source/WebCore/loader/FrameLoadRequest.cpp: (WebCore::FrameLoadRequest::FrameLoadRequest): * Source/WebCore/loader/FrameLoadRequest.h: (WebCore::FrameLoadRequest::FrameLoadRequest): (WebCore::FrameLoadRequest::isSystemPreview const): Deleted. (WebCore::FrameLoadRequest::systemPreviewInfo const): Deleted. * Source/WebCore/loader/FrameLoader.cpp: (WebCore::FrameLoader::changeLocation): (WebCore::FrameLoader::loadURL): * Source/WebCore/loader/FrameLoader.h: * Source/WebCore/loader/FrameLoaderTypes.h: * Source/WebCore/platform/network/ResourceRequestBase.cpp: (WebCore::ResourceRequestBase::isSystemPreview const): Deleted. (WebCore::ResourceRequestBase::systemPreviewInfo const): Deleted. (WebCore::ResourceRequestBase::setSystemPreviewInfo): Deleted. * Source/WebCore/platform/network/ResourceRequestBase.h: * Source/WebCore/platform/network/cf/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest): * Source/WebCore/platform/network/cocoa/ResourceRequestCocoa.mm: (WebCore::ResourceRequest::ResourceRequest): (WebCore::ResourceRequest::fromResourceRequestData): * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: * Source/WebKit/UIProcess/API/APINavigation.h: (API::Navigation::isSystemPreview const): Deleted. * Source/WebKit/UIProcess/Cocoa/LegacyDownloadClient.h: * Source/WebKit/UIProcess/Cocoa/LegacyDownloadClient.mm: (WebKit::LegacyDownloadClient::legacyDidStart): (WebKit::LegacyDownloadClient::didReceiveResponse): (WebKit::LegacyDownloadClient::didReceiveData): (WebKit::LegacyDownloadClient::didCreateDestination): (WebKit::LegacyDownloadClient::processDidCrash): (WebKit::LegacyDownloadClient::decideDestinationWithSuggestedFilename): (WebKit::LegacyDownloadClient::didFinish): (WebKit::LegacyDownloadClient::didFail): (WebKit::LegacyDownloadClient::legacyDidCancel): (WebKit::systemPreviewController): Deleted. (WebKit::LegacyDownloadClient::takeActivityToken): Deleted. (WebKit::LegacyDownloadClient::releaseActivityTokenIfNecessary): Deleted. * Source/WebKit/UIProcess/Downloads/DownloadProxy.h: (WebKit::DownloadProxy::isSystemPreviewDownload const): Deleted. (WebKit::DownloadProxy::systemPreviewDownloadInfo const): Deleted. * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::receivedNavigationPolicyDecision): Canonical link: https://commits.webkit.org/263392@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d280ee: [getComputedStyle][padding] isLayoutDependent shou...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d280ee73cbe4ab156ed2bfc05b65aec892881bb4 https://github.com/WebKit/WebKit/commit/d280ee73cbe4ab156ed2bfc05b65aec892881bb4 Author: Alan Baradlay Date: 2023-04-25 (Tue, 25 Apr 2023) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-logical/parsing/padding-block-inline-computed-expected.txt M LayoutTests/platform/mac/TestExpectations M Source/WebCore/css/ComputedStyleExtractor.cpp Log Message: --- [getComputedStyle][padding] isLayoutDependent should handle flow relative padding values https://bugs.webkit.org/show_bug.cgi?id=255895 Reviewed by Antti Koivisto. * LayoutTests/imported/w3c/web-platform-tests/css/css-logical/parsing/padding-block-inline-computed-expected.txt: * LayoutTests/platform/mac/TestExpectations: * Source/WebCore/css/ComputedStyleExtractor.cpp: (WebCore::toPaddingOrMarginPropertyID): (WebCore::isLayoutDependent): (WebCore::toMarginPropertyID): Deleted. Canonical link: https://commits.webkit.org/263391@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2092e7: [Cocoa] Add plumbing for a couple more platform fl...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2092e7169114e46d8dc8ac71dad797f3c33bdc9e https://github.com/WebKit/WebKit/commit/2092e7169114e46d8dc8ac71dad797f3c33bdc9e Author: Wenson Hsieh Date: 2023-04-25 (Tue, 25 Apr 2023) Changed paths: M Source/WebCore/platform/network/ResourceRequestBase.cpp M Source/WebCore/platform/network/ResourceRequestBase.h M Source/WebCore/platform/network/cf/ResourceRequest.h M Source/WebCore/platform/network/cf/ResourceRequestCFNet.cpp M Source/WebCore/platform/network/cocoa/ResourceRequestCocoa.mm M Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.serialization.in M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in Log Message: --- [Cocoa] Add plumbing for a couple more platform flags on ResourceRequest https://bugs.webkit.org/show_bug.cgi?id=255927 rdar://105895713 Reviewed by Tim Horton and Matthew Finkel. Add plumbing for two flags on `ResourceRequest`: `PrivacyProxyFailClosedForUnreachableNonMainHosts` and `UseNetworkConnectionIntegrity`, which both map to SPI properties on `NSURLRequest`. In a subsequent patch, this will make it possible for WebKit clients to specify these flags on a URL request when loading a web view, and have this state propagate to everywhere (including the resource request used for performing preconnect). * Source/WebCore/platform/network/ResourceRequestBase.cpp: (WebCore::ResourceRequestBase::setAsIsolatedCopy): (WebCore::ResourceRequestBase::setIsAppInitiated): (WebCore::ResourceRequestBase::setPrivacyProxyFailClosedForUnreachableNonMainHosts): (WebCore::ResourceRequestBase::setUseNetworkConnectionIntegrity): Add support for the new flags here; this closely follows the existing pattern used to plumb whether or not the request is app-initiated through `ResourceRequest`. * Source/WebCore/platform/network/ResourceRequestBase.h: (WebCore::ResourceRequestBase::RequestData::RequestData): (WebCore::ResourceRequestBase::privacyProxyFailClosedForUnreachableNonMainHosts const): (WebCore::ResourceRequestBase::useNetworkConnectionIntegrity const): * Source/WebCore/platform/network/cf/ResourceRequest.h: * Source/WebCore/platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::updateFromDelegatePreservingOldProperties): * Source/WebCore/platform/network/cocoa/ResourceRequestCocoa.mm: (WebCore::ResourceRequest::ResourceRequest): (WebCore::ResourceRequest::getResourceRequestPlatformData const): (WebCore::configureRequestWithData): Add a new helper method to set some policy flags on the platform URL request, to avoid duplicating this logic in the two methods below. (WebCore::ResourceRequest::doUpdatePlatformRequest): (WebCore::ResourceRequest::doUpdatePlatformHTTPBody): * Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.serialization.in: * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: Add IPC encoding/decoding support for the platform flags. Canonical link: https://commits.webkit.org/263390@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0756ac: [git-webkit] Allow alternative publication account
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0756acde44477062e7240b9ea1556be6835c32b4 https://github.com/WebKit/WebKit/commit/0756acde44477062e7240b9ea1556be6835c32b4 Author: Jonathan Bedard Date: 2023-04-25 (Tue, 25 Apr 2023) Changed paths: M Tools/Scripts/libraries/webkitscmpy/setup.py M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/publish.py M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/setup.py M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/bitbucket.py M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/scm.py M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/svn.py M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/git_unittest.py M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/svn_unittest.py Log Message: --- [git-webkit] Allow alternative publication account https://bugs.webkit.org/show_bug.cgi?id=255934 rdar://108510545 Reviewed by Elliott Williams. Support a --user option in `git-webkit publish` to allow an alternative account from a user's regular development account to perform the push. * Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/publish.py: (Publish.parser): Add --user option. (Publish.main): Prompt user for password if --user specified, pass that password via environment variable to `git push` commands. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/setup.py: (Setup.git): Add credential helper, event if the checkout is not a HTTPs checkout. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/bitbucket.py: (BitBucket.checkout_url): Return ssh and http checkout URL. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py: (GitHub.checkout_url): Return ssh and http checkout URL. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/scm.py: (Scm.checkout_url): Added. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/svn.py: (Svn.checkout_url): Return http checkout URL. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/git_unittest.py: (TestGitHub.test_checkout_url): (TestBitBucket.test_checkout_url): * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/svn_unittest.py: (TestRemoteSvn.test_checkout_url): Canonical link: https://commits.webkit.org/263389@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 811567: Remove leftover ASSERT_NOT_REACHED from rendererCa...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 81156754a3c65cf7f5c3206676d23e4b90eae537 https://github.com/WebKit/WebKit/commit/81156754a3c65cf7f5c3206676d23e4b90eae537 Author: Alan Baradlay Date: 2023-04-25 (Tue, 25 Apr 2023) Changed paths: M Source/WebCore/css/ComputedStyleExtractor.cpp Log Message: --- Remove leftover ASSERT_NOT_REACHED from rendererCanHaveTrimmedMargin https://bugs.webkit.org/show_bug.cgi?id=255950 Reviewed by Antti Koivisto. This was originally added for testing purposes (and got accidentally left in). * Source/WebCore/css/ComputedStyleExtractor.cpp: (WebCore::rendererCanHaveTrimmedMargin): Canonical link: https://commits.webkit.org/263388@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5d4b6d: Cherry-pick 263378@main (3161dda2cc0e). https://bu...
Branch: refs/heads/webkitglib/2.40 Home: https://github.com/WebKit/WebKit Commit: 5d4b6d638d141efa5761a9ded8412c630e73122f https://github.com/WebKit/WebKit/commit/5d4b6d638d141efa5761a9ded8412c630e73122f Author: Adrian Perez de Castro Date: 2023-04-25 (Tue, 25 Apr 2023) Changed paths: M Source/WebCore/platform/graphics/nicosia/NicosiaPaintingEngine.cpp Log Message: --- Cherry-pick 263378@main (3161dda2cc0e). https://bugs.webkit.org/show_bug.cgi?id=255923 [GLib] Choose amount of painting threads depending on available CPU cores https://bugs.webkit.org/show_bug.cgi?id=255923 Reviewed by Michael Catanzaro. Pick default number of painting threads between 1 and 8, depending on the amount of CPU cores. While at it, rework the environment variable parsing to use WTF::parseInteger() and log the actual default number of threads when the environment variable cannot be parsed or has a value bigger than eight. * Source/WebCore/platform/graphics/nicosia/NicosiaPaintingEngine.cpp: (Nicosia::PaintingEngine::create): Canonical link: https://commits.webkit.org/263378@main Commit: cfa5e2a8dab746c14c2e5876a48ff0d66cdf7486 https://github.com/WebKit/WebKit/commit/cfa5e2a8dab746c14c2e5876a48ff0d66cdf7486 Author: Don Olmstead Date: 2023-04-25 (Tue, 25 Apr 2023) Changed paths: M Source/WebCore/page/MemoryRelease.cpp Log Message: --- Cherry-pick 262461@main (b36decf27ea9). https://bugs.webkit.org/show_bug.cgi?id=254852 Fix !ENABLE(WEB_AUDIO) build after 262451@main https://bugs.webkit.org/show_bug.cgi?id=254852 Unreviewed build fix. Add !ENABLE(WEB_AUDIO) guard. * Source/WebCore/page/MemoryRelease.cpp: Canonical link: https://commits.webkit.org/262461@main Compare: https://github.com/WebKit/WebKit/compare/ef62197ab1bb...cfa5e2a8dab7 ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d573b8: [ews] Expected additionalArguments frequently miss...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d573b83aa2c218b96c855021965c9a683f231274 https://github.com/WebKit/WebKit/commit/d573b83aa2c218b96c855021965c9a683f231274 Author: Aakash Jain Date: 2023-04-25 (Tue, 25 Apr 2023) Changed paths: M Tools/CISupport/ews-build/steps.py Log Message: --- [ews] Expected additionalArguments frequently missing from iOS layout test queues https://bugs.webkit.org/show_bug.cgi?id=255742 Reviewed by Ryan Haddad. additionalArguments were missing because in CompileWebKit class (and sub-classes), we were inadvertently removing them. Especially compile-webkit-without-change step was the one removing the additionalArguments. This accessed build property and removed various values from it, buy since a list is accessed by reference, original property was also modified. * Tools/CISupport/ews-build/steps.py: (CompileWebKit): Do not explicitly remove arguments, instead just check if the additionalArguments is within valid list for that step. (RunWebKitTests): Drive-by fix. Code refactoring to adopt clener approach to handle additionalArguments, using ENABLE_ADDITIONAL_ARGUMENTS. (RunWebKitTestsInStressMode): Ditto. (RunWebKitTestsInStressMode.setLayoutTestCommand): Ditto. (Trigger.propertiesToPassToTriggers): Revert previous attempt to fix this issue. Canonical link: https://commits.webkit.org/263387@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ec6cec: Fix the build
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ec6cecdeecdec249ed4bf2aec7a6cfc762474fe4 https://github.com/WebKit/WebKit/commit/ec6cecdeecdec249ed4bf2aec7a6cfc762474fe4 Author: Tim Horton Date: 2023-04-25 (Tue, 25 Apr 2023) Changed paths: M Source/WebKit/mac/replace-webkit-additions-includes.py Log Message: --- Fix the build https://bugs.webkit.org/show_bug.cgi?id=255938 rdar://108513290 Unreviewed build fix. * Source/WebKit/mac/replace-webkit-additions-includes.py: (check_should_do_replacement): Canonical link: https://commits.webkit.org/263386@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c356d9: REGRESSION (262691@main?): [ iOS ] TestWebKitAPI.D...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c356d9f402c22d334ae2c14b498c3a7013b2b9fa https://github.com/WebKit/WebKit/commit/c356d9f402c22d334ae2c14b498c3a7013b2b9fa Author: Ryosuke Niwa Date: 2023-04-25 (Tue, 25 Apr 2023) Changed paths: M Tools/TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm Log Message: --- REGRESSION (262691@main?): [ iOS ] TestWebKitAPI.DocumentEditingContext.RequestRectsInTextAreaInsideScrolledIFrame is a near-constant failure. https://bugs.webkit.org/show_bug.cgi?id=255246 Reviewed by Antti Koivisto. The flakiness was caused by the race condition between scrolling initiated by focus() and window.scrollTo. Specify preventScroll: true in focus() call to avoid the race condition. * Tools/TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: (TEST): Canonical link: https://commits.webkit.org/263385@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5cf6af: Generate serialization code for WebProcessCreation...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5cf6af95512167d181adc90b152feb667dd69b95 https://github.com/WebKit/WebKit/commit/5cf6af95512167d181adc90b152feb667dd69b95 Author: Alex Christensen Date: 2023-04-25 (Tue, 25 Apr 2023) Changed paths: M Source/WebKit/CMakeLists.txt M Source/WebKit/DerivedSources-input.xcfilelist M Source/WebKit/DerivedSources.make M Source/WebKit/Shared/API/APIData.cpp M Source/WebKit/Shared/API/APIData.h A Source/WebKit/Shared/API/APIData.serialization.in M Source/WebKit/Shared/UserData.cpp R Source/WebKit/Shared/WebProcessCreationParameters.cpp M Source/WebKit/Shared/WebProcessCreationParameters.h A Source/WebKit/Shared/WebProcessCreationParameters.serialization.in M Source/WebKit/Sources.txt M Source/WebKit/WebKit.xcodeproj/project.pbxproj Log Message: --- Generate serialization code for WebProcessCreationParameters https://bugs.webkit.org/show_bug.cgi?id=255891 rdar://108472857 Reviewed by Chris Dumez. To get it to compile I had to also migrate API::Data. The API::Data::create function that took a DataReference was unused, so changing it to not return null for an empty data reference does not change any behavior. * Source/WebKit/CMakeLists.txt: * Source/WebKit/DerivedSources-input.xcfilelist: * Source/WebKit/DerivedSources.make: * Source/WebKit/Shared/API/APIData.cpp: (API::Data::createFromIPC): (API::Data::encode const): Deleted. (API::Data::decode): Deleted. * Source/WebKit/Shared/API/APIData.h: * Source/WebKit/Shared/API/APIData.serialization.in: Added. * Source/WebKit/Shared/WebProcessCreationParameters.cpp: Removed. * Source/WebKit/Shared/WebProcessCreationParameters.h: * Source/WebKit/Shared/WebProcessCreationParameters.serialization.in: * Source/WebKit/Sources.txt: * Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm: (WebKit::WebProcessPool::platformInitializeWebProcess): * Source/WebKit/WebKit.xcodeproj/project.pbxproj: Canonical link: https://commits.webkit.org/263384@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8b65ac: REGRESSION(263322@main): Cannot build ANGLE due to...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8b65ac68c424f9ff7f84b752ff460de53ad5c8aa https://github.com/WebKit/WebKit/commit/8b65ac68c424f9ff7f84b752ff460de53ad5c8aa Author: Michael Catanzaro Date: 2023-04-25 (Tue, 25 Apr 2023) Changed paths: M Source/ThirdParty/ANGLE/src/common/base/anglebase/sha1.h Log Message: --- REGRESSION(263322@main): Cannot build ANGLE due to missing declaration of uint8_t https://bugs.webkit.org/show_bug.cgi?id=255933 Unreviewed build fix. * Source/ThirdParty/ANGLE/src/common/base/anglebase/sha1.h: Canonical link: https://commits.webkit.org/263383@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d901ad: Wake Lock permission denied after visibilitychange
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d901ad78bdb6536b4c0bdcbf85b1c1e40b8bdfc4 https://github.com/WebKit/WebKit/commit/d901ad78bdb6536b4c0bdcbf85b1c1e40b8bdfc4 Author: Chris Dumez Date: 2023-04-25 (Tue, 25 Apr 2023) Changed paths: A LayoutTests/http/wpt/screen-wake-lock/sticky-permission-after-transient-activation-expected.txt A LayoutTests/http/wpt/screen-wake-lock/sticky-permission-after-transient-activation.html M Source/WebCore/Modules/screen-wake-lock/WakeLock.cpp M Source/WebCore/Modules/screen-wake-lock/WakeLock.h Log Message: --- Wake Lock permission denied after visibilitychange https://bugs.webkit.org/show_bug.cgi?id=255363 rdar://108279602 Reviewed by Geoffrey Garen. Unlike other browser engines, WebKit requires a transient activation to acquire a screen wake lock. While this is fine for the initial request, this seems a bit restrictive for follow-up requests, especially considering that the screen wake lock gets released when the document is no longer visible. It is also common on the web to try and re-acquire the screen wake lock when the document becomes visible again (in the visibilitychange event), in which case the JS doesn't have transient activation. To address this issue, we make the authorization from transient activation sticky. If the page has previously acquired a screen wake lock with transient activation, we will remember this permission for the lifetime of the document. * LayoutTests/http/wpt/screen-wake-lock/sticky-permission-after-transient-activation-expected.txt: Added. * LayoutTests/http/wpt/screen-wake-lock/sticky-permission-after-transient-activation.html: Added. * Source/WebCore/Modules/screen-wake-lock/WakeLock.cpp: (WebCore::WakeLock::request): * Source/WebCore/Modules/screen-wake-lock/WakeLock.h: Canonical link: https://commits.webkit.org/263382@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e22594: [ iOS ] 2x imported/w3c/web-platform-tests/screen-...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e22594d0492e1693065b3c54e7b8298a8195 https://github.com/WebKit/WebKit/commit/e22594d0492e1693065b3c54e7b8298a8195 Author: Bri Harris Date: 2023-04-25 (Tue, 25 Apr 2023) Changed paths: M LayoutTests/platform/ios/TestExpectations Log Message: --- [ iOS ] 2x imported/w3c/web-platform-tests/screen-orientation are near-constant text failures. https://bugs.webkit.org/show_bug.cgi?id=255931 rdar://108508861 Unreviewed test gardening. Setting expectations while failures are investigated. * LayoutTests/platform/ios/TestExpectations: Canonical link: https://commits.webkit.org/263381@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f10510: CSSPropertyMargin shorthand in isLayoutDependent s...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f105104bc47e9e03d5395e4b1863e7c6c869266e https://github.com/WebKit/WebKit/commit/f105104bc47e9e03d5395e4b1863e7c6c869266e Author: Alan Baradlay Date: 2023-04-25 (Tue, 25 Apr 2023) Changed paths: M Source/WebCore/css/ComputedStyleExtractor.cpp Log Message: --- CSSPropertyMargin shorthand in isLayoutDependent should use CSSPropertyMarginBlock/CSSPropertyMarginInline https://bugs.webkit.org/show_bug.cgi?id=255893 Reviewed by Antti Koivisto. * Source/WebCore/css/ComputedStyleExtractor.cpp: (WebCore::rendererCanHaveTrimmedMargin): (WebCore::isLayoutDependent): Canonical link: https://commits.webkit.org/263380@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2670ad: AX: Accessible name computed incorrectly for displ...
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 2670ad167491169737014d794154a0005d400eb0
https://github.com/WebKit/WebKit/commit/2670ad167491169737014d794154a0005d400eb0
Author: Tyler Wilcock
Date: 2023-04-25 (Tue, 25 Apr 2023)
Changed paths:
M LayoutTests/accessibility/mac/figure-element-expected.txt
M LayoutTests/accessibility/mac/figure-element.html
M Source/WebCore/accessibility/AccessibilityNodeObject.cpp
M Source/WebCore/accessibility/AccessibilityNodeObject.h
M Source/WebCore/accessibility/AccessibilityRenderObject.cpp
Log Message:
---
AX: Accessible name computed incorrectly for display:contents elements that
rely on labels or captions ("title UI elements")
https://bugs.webkit.org/show_bug.cgi?id=255910
rdar://problem/108492642
Reviewed by Chris Fleizach.
Move non-renderer-specific behavior from AccessibilityRenderObject to
AccessibilityNodeObject.
* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
* Source/WebCore/accessibility/AccessibilityNodeObject.h:
* Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
* LayoutTests/accessibility/mac/figure-element-expected.txt:
* LayoutTests/accessibility/mac/figure-element.html:
Canonical link: https://commits.webkit.org/263379@main
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3161dd: [GLib] Choose amount of painting threads depending...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3161dda2cc0ef51c2526aa3ce64d43c031990c83 https://github.com/WebKit/WebKit/commit/3161dda2cc0ef51c2526aa3ce64d43c031990c83 Author: Adrian Perez de Castro Date: 2023-04-25 (Tue, 25 Apr 2023) Changed paths: M Source/WebCore/platform/graphics/nicosia/NicosiaPaintingEngine.cpp Log Message: --- [GLib] Choose amount of painting threads depending on available CPU cores https://bugs.webkit.org/show_bug.cgi?id=255923 Reviewed by Michael Catanzaro. Pick default number of painting threads between 1 and 8, depending on the amount of CPU cores. While at it, rework the environment variable parsing to use WTF::parseInteger() and log the actual default number of threads when the environment variable cannot be parsed or has a value bigger than eight. * Source/WebCore/platform/graphics/nicosia/NicosiaPaintingEngine.cpp: (Nicosia::PaintingEngine::create): Canonical link: https://commits.webkit.org/263378@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2c5a97: Regression(255052@main) Some streaming sites fail ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2c5a97645ec0a3eb6a9bf8d1c64888c47cca5c6c https://github.com/WebKit/WebKit/commit/2c5a97645ec0a3eb6a9bf8d1c64888c47cca5c6c Author: Chris Dumez Date: 2023-04-25 (Tue, 25 Apr 2023) Changed paths: A LayoutTests/fast/dom/object-load-pdf-data-url-expected.txt A LayoutTests/fast/dom/object-load-pdf-data-url.html M Source/WebCore/html/HTMLImageLoader.cpp M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm Log Message: --- Regression(255052@main) Some streaming sites fail with an Embedded Video Sandbox Browser Error https://bugs.webkit.org/show_bug.cgi?id=255900 Reviewed by Tim Horton and Darin Adler. Some streaming sites fail with an Embedded Video Sandbox Browser Error since 255052@main. 255052@main seems correct per the specification but exposing the "Chrome PDF Viewer" caused those sites to use a different code path for validating iframe sandboxing. They now try to load a data URL with a pdf MIME type inside an element and this was firing an error event on iOS, which was causing the site's logic to display the sandbox error. There is logic inside WebFrameLoaderClient::objectContentType() that is iOS specific and causes us to try to load PDF as an image when inside an . This is because we don't support loadings such PDFs as plugins on iOS. However, WebKit, in general, doesn't fire load/error events on elements that are loaded as plugins. It only does so when loading the as an image. I propose that we stop firing the load/error events for loads of PDFs on iOS, to make it look like they were loaded as plugins and avoid firing events that could confuse sites such as the ones in the radar. * LayoutTests/fast/dom/object-load-pdf-data-url-expected.txt: Added. * LayoutTests/fast/dom/object-load-pdf-data-url.html: Added. * Source/WebCore/html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::dispatchLoadEvent(): Canonical link: https://commits.webkit.org/263377@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c12b24: Branch point for webkit-2022.12-embargoed
Branch: refs/heads/webkit-2022.12-embargoed Home: https://github.com/WebKit/WebKit Commit: c12b24a039e42f65fde9a72cb9c2d4ec46f0c4ee https://github.com/WebKit/WebKit/commit/c12b24a039e42f65fde9a72cb9c2d4ec46f0c4ee Author: Jonathan Bedard Date: 2022-11-18 (Fri, 18 Nov 2022) Changed paths: Log Message: --- Branch point for webkit-2022.12-embargoed Canonical link: https://commits.webkit.org/256843.1@webkit-2022.12-embargoed Commit: 155bed7390009a843b69d83e18f31097c198f7d7 https://github.com/WebKit/WebKit/commit/155bed7390009a843b69d83e18f31097c198f7d7 Author: Claudio Saavedra Date: 2022-12-05 (Mon, 05 Dec 2022) Changed paths: A LayoutTests/http/tests/security/embedded-self-reference-after-url-modified-expected.txt A LayoutTests/http/tests/security/embedded-self-reference-after-url-modified.html M Source/WebCore/html/HTMLFrameOwnerElement.cpp Log Message: --- HTMLFrameOwnerElement: use Document::creationURL() for self-reference check https://bugs.webkit.org/show_bug.cgi?id=248469 Reviewed by Darin Adler. Document::url() can be changed through the History API, therefore it's not a reliable source to verify whether a given URL is self-referencing. Use creationURL instead, which is immutable. * LayoutTests/http/tests/security/embedded-self-reference-after-url-modified-expected.txt: Added. * LayoutTests/http/tests/security/embedded-self-reference-after-url-modified.html: Added. * Source/WebCore/html/HTMLFrameOwnerElement.cpp: (WebCore::HTMLFrameOwnerElement::isProhibitedSelfReference const): Canonical link: https://commits.webkit.org/256843.2@webkit-2022.12-embargoed Commit: 1d7abcd180abe9c3164366f5b6c0fb86e69790b5 https://github.com/WebKit/WebKit/commit/1d7abcd180abe9c3164366f5b6c0fb86e69790b5 Author: Rob Buis Date: 2022-12-08 (Thu, 08 Dec 2022) Changed paths: A LayoutTests/fast/block/crash-empty-layoutStateStack-expected.txt A LayoutTests/fast/block/crash-empty-layoutStateStack.html M Source/WebCore/rendering/RenderBlock.cpp Log Message: --- Protect against empty layout state https://bugs.webkit.org/show_bug.cgi?id=248771 Reviewed by Alan Baradlay. Protect against empty layout state. * LayoutTests/fast/block/crash-empty-layoutStateStack-expected.txt: Added. * LayoutTests/fast/block/crash-empty-layoutStateStack.html: Added. * Source/WebCore/rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutPositionedObject): (WebCore::RenderBlock::markForPaginationRelayoutIfNeeded): Canonical link: https://commits.webkit.org/256843.3@webkit-2022.12-embargoed Commit: 6234ec9c65b9f2d07fc59985ffba242fdd0da686 https://github.com/WebKit/WebKit/commit/6234ec9c65b9f2d07fc59985ffba242fdd0da686 Author: Rob Buis Date: 2022-12-16 (Fri, 16 Dec 2022) Changed paths: A LayoutTests/fast/table/table-cell-crash-when-detached-state-2-expected.txt A LayoutTests/fast/table/table-cell-crash-when-detached-state-2.html M Source/WebCore/rendering/RenderLayerModelObject.cpp Log Message: --- Do not issue repaints when in detached state https://bugs.webkit.org/show_bug.cgi?id=248773 Reviewed by Antti Koivisto. Do not issue repaints when the RenderObject is in detached state while removing render subtrees. * LayoutTests/fast/table/table-cell-crash-when-detached-state-2-expected.txt: Added. * LayoutTests/fast/table/table-cell-crash-when-detached-state-2.html: Added. * Source/WebCore/rendering/RenderLayerModelObject.cpp: (WebCore::RenderTableCell::willBeRemovedFromTree const): Canonical link: https://commits.webkit.org/256843.4@webkit-2022.12-embargoed Commit: 312254f5776dd16bde18cd4d99444d81a0c331d6 https://github.com/WebKit/WebKit/commit/312254f5776dd16bde18cd4d99444d81a0c331d6 Author: Rob Buis Date: 2022-12-16 (Fri, 16 Dec 2022) Changed paths: A LayoutTests/fast/css/content/quote-display-contents-crash-expected.txt A LayoutTests/fast/css/content/quote-display-contents-crash.html M Source/WebCore/dom/ContainerNode.cpp M Source/WebCore/dom/Element.cpp Log Message: --- Check displayContentsChanged in destroyRenderTreeIfNeeded https://bugs.webkit.org/show_bug.cgi?id=248776 rdar://102807985> Reviewed by Antti Koivisto. Check displayContentsChanged in destroyRenderTreeIfNeeded since display: contents may be removed due to focus removal while removing subtrees but we still need to clean up pseudo elements. * LayoutTests/fast/css/content/quote-display-contents-crash-expected.txt: Added. * LayoutTests/fast/css/content/quote-display-contents-crash.html: Added. * Source/WebCore/dom/ContainerNode.cpp: (WebCore::destroyRenderTreeIfNeeded): * Source/WebCore/dom/Element.cpp: (WebCore::Element::resolveComputedStyle): Canonical link: https://commits.webkit.org/256843.5@webkit-2022.12-embargoed Commit: c4c0ef6360b2aa3fd32b1b9f6a5b6b5ccaa61a98
[webkit-changes] [WebKit/WebKit] 47b0e0: [Stress Test EWS] failing to find modified layout ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 47b0e0b8761c4448ed18afada58e146f30b1cf14 https://github.com/WebKit/WebKit/commit/47b0e0b8761c4448ed18afada58e146f30b1cf14 Author: Jonathan Bedard Date: 2023-04-25 (Tue, 25 Apr 2023) Changed paths: M Tools/CISupport/ews-build/steps.py Log Message: --- [Stress Test EWS] failing to find modified layout tests for pull requests https://bugs.webkit.org/show_bug.cgi?id=246323 rdar://101034678 Reviewed by Aakash Jain. By default, buildbot uses an updated source stamp when triggering builds, which will strip the list of changed files we gathered when processing the hook from GitHub. We should use the source stamp of the triggering build by default. * Tools/CISupport/ews-build/steps.py: (Trigger.__init__): Use source stamp of the triggering build by default. (Trigger.propertiesToPassToTriggers): Pass commit classification and codebase. Canonical link: https://commits.webkit.org/263376@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b6dd51: Change type of FrameLoader opener and ScriptContro...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b6dd5136a4bb992aa4e1a10923f03a36e8486d24 https://github.com/WebKit/WebKit/commit/b6dd5136a4bb992aa4e1a10923f03a36e8486d24 Author: J Pascoe Date: 2023-04-25 (Tue, 25 Apr 2023) Changed paths: M Source/WebCore/bindings/js/JSDOMWindowBase.cpp M Source/WebCore/bindings/js/ScriptController.h M Source/WebCore/dom/Document.cpp M Source/WebCore/loader/DocumentLoader.cpp M Source/WebCore/loader/FrameLoader.cpp M Source/WebCore/loader/FrameLoader.h M Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp M Source/WebKit/WebProcess/WebCoreSupport/WebResourceLoadObserver.cpp M Source/WebKitLegacy/mac/WebView/WebFrame.mm Log Message: --- Change type of FrameLoader opener and ScriptController globalObject https://bugs.webkit.org/show_bug.cgi?id=255743 rdar://10835 Reviewed by Chris Dumez. This patch does some refactoring required for PSON in windows opened via window.open. The first part is changing the type of opener in FrameLoader to accept a Frame instead of a LocalFrame. The second part is changing the type of ScriptController's globalObject method to return a global object instead of a local window. * Source/WebCore/bindings/js/JSDOMWindowBase.cpp: (WebCore::toJSLocalDOMWindow): * Source/WebCore/bindings/js/ScriptController.h: (WebCore::ScriptController::globalObject): * Source/WebCore/dom/Document.cpp: (WebCore::Document::fallbackBaseURL const): (WebCore::Document::canNavigateInternal): (WebCore::Document::initSecurityContext): (WebCore::Document::initContentSecurityPolicy): * Source/WebCore/loader/DocumentLoader.cpp: (WebCore::DocumentLoader::doCrossOriginOpenerHandlingOfResponse): * Source/WebCore/loader/FrameLoader.cpp: (WebCore::FrameLoader::detachFromAllOpenedFrames): (WebCore::FrameLoader::opener): (WebCore::FrameLoader::opener const): (WebCore::FrameLoader::setOpener): (WebCore::FrameLoader::setOriginalURLForDownloadRequest): (WebCore::FrameLoader::updateRequestAndAddExtraFields): (WebCore::FrameLoader::effectiveReferrerPolicy const): * Source/WebCore/loader/FrameLoader.h: * Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp: (WebKit::WebLoaderStrategy::scheduleLoadFromNetworkProcess): * Source/WebKit/WebProcess/WebCoreSupport/WebResourceLoadObserver.cpp: (WebKit::WebResourceLoadObserver::logUserInteractionWithReducedTimeResolution): * Source/WebKitLegacy/mac/WebView/WebFrame.mm: (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]): Canonical link: https://commits.webkit.org/263375@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0f7e57: [WTR] Watchdog timer should not default to zero se...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0f7e57b5ef162bacc8d7e0444735262f122a68ec https://github.com/WebKit/WebKit/commit/0f7e57b5ef162bacc8d7e0444735262f122a68ec Author: Alicia Boya Garcia Date: 2023-04-25 (Tue, 25 Apr 2023) Changed paths: M Tools/WebKitTestRunner/TestInvocation.cpp Log Message: --- [WTR] Watchdog timer should not default to zero seconds https://bugs.webkit.org/show_bug.cgi?id=255920 Reviewed by Carlos Garcia Campos. TestInvocation::m_timeout can have two special values: zero, for a default timeout, and -1 for no timeout. The current implementation of initializeWaitToDumpWatchdogTimerIfNeeded() was not taking this into consideration, which caused tests to immediately timeout (0 second timeout) when invoking WebKitTestRunner without --no-timeout. * Tools/WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::initializeWaitToDumpWatchdogTimerIfNeeded): Canonical link: https://commits.webkit.org/263374@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4d11cf: [GLib] Arrange to call malloc_trim on process susp...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4d11cf4168d7abf139506605c081b3aaaf33afbb https://github.com/WebKit/WebKit/commit/4d11cf4168d7abf139506605c081b3aaaf33afbb Author: Adrian Perez de Castro Date: 2023-04-25 (Tue, 25 Apr 2023) Changed paths: M Source/WebKit/WebProcess/WebProcess.cpp M Source/WebKit/WebProcess/WebProcess.h M Source/WebKit/WebProcess/glib/WebProcessGLib.cpp Log Message: --- [GLib] Arrange to call malloc_trim on process suspension https://bugs.webkit.org/show_bug.cgi?id=255919 Reviewed by Carlos Garcia Campos. * Source/WebKit/WebProcess/WebProcess.cpp: (WebKit::WebProcess::nonVisibleProcessEarlyMemoryCleanupTimerFired): Also call releaseSystemMallocMemory() for the WPE and GTK ports. * Source/WebKit/WebProcess/WebProcess.h: Declare releaseSystemMallocMemory() for the WPE and GTK ports. * Source/WebKit/WebProcess/glib/WebProcessGLib.cpp: (WebKit::WebProcess::releaseSystemMallocMemory): Call malloc_trim(0) where the function is available. Canonical link: https://commits.webkit.org/263373@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0f0879: [getComputedStyle][margin] isLayoutDependent shoul...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0f08796bbe0ade29bb6e7bd050dc4215cec9f92a https://github.com/WebKit/WebKit/commit/0f08796bbe0ade29bb6e7bd050dc4215cec9f92a Author: Alan Baradlay Date: 2023-04-25 (Tue, 25 Apr 2023) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-logical/parsing/margin-block-inline-computed-expected.txt M LayoutTests/platform/mac-wk1/TestExpectations M LayoutTests/platform/mac/TestExpectations M Source/WebCore/css/ComputedStyleExtractor.cpp Log Message: --- [getComputedStyle][margin] isLayoutDependent should handle flow relative margin values https://bugs.webkit.org/show_bug.cgi?id=255890 Reviewed by Antti Koivisto. Shorthand values should simply resolve for individual css property values. * LayoutTests/imported/w3c/web-platform-tests/css/css-logical/parsing/margin-block-inline-computed-expected.txt: * LayoutTests/platform/mac-wk1/TestExpectations: * LayoutTests/platform/mac/TestExpectations: * Source/WebCore/css/ComputedStyleExtractor.cpp: (WebCore::formattingContextRootStyle): (WebCore::physicalToFlowRelativeDirection): (WebCore::flowRelativeToPhysicalDirection): (WebCore::toMarginPropertyID): (WebCore::isLayoutDependent): Canonical link: https://commits.webkit.org/263372@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 33f895: [GTK] Gardening after `263291@main`
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 33f895345c20ece1769f663be117b36c9d731264 https://github.com/WebKit/WebKit/commit/33f895345c20ece1769f663be117b36c9d731264 Author: Vitaly Dyachkov Date: 2023-04-25 (Tue, 25 Apr 2023) Changed paths: M LayoutTests/platform/glib/accessibility/table-attributes-expected.txt M LayoutTests/platform/glib/accessibility/table-cells-expected.txt M LayoutTests/platform/glib/accessibility/table-one-cell-expected.txt M LayoutTests/platform/glib/css1/box_properties/float_on_text_elements-expected.txt M LayoutTests/platform/glib/fast/css-generated-content/table-row-group-to-inline-expected.txt M LayoutTests/platform/glib/fast/css-generated-content/table-row-group-with-before-expected.txt M LayoutTests/platform/glib/fast/css-generated-content/table-row-with-before-expected.txt M LayoutTests/platform/glib/fast/css-generated-content/table-with-before-expected.txt M LayoutTests/platform/glib/fast/css/font-smoothing-expected.txt M LayoutTests/platform/glib/fast/css/outline-narrowLine-expected.txt M LayoutTests/platform/glib/fast/css/rtl-ordering-expected.txt M LayoutTests/platform/glib/fast/css/text-rendering-expected.txt M LayoutTests/platform/glib/fast/css/word-space-extra-expected.txt M LayoutTests/platform/glib/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.txt M LayoutTests/platform/glib/fast/dynamic/selection-highlight-adjust-expected.txt M LayoutTests/platform/glib/fast/images/image-map-anchor-children-expected.txt M LayoutTests/platform/glib/fast/inline/positionedLifetime-expected.txt M LayoutTests/platform/glib/fast/text/basic/012-expected.txt M LayoutTests/platform/glib/fast/text/international/bidi-LDB-2-CSS-expected.txt M LayoutTests/platform/glib/fast/text/international/bidi-LDB-2-HTML-expected.txt M LayoutTests/platform/glib/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt M LayoutTests/platform/glib/fonts/monospace-expected.txt M LayoutTests/platform/glib/fonts/sans-serif-expected.txt M LayoutTests/platform/glib/fonts/serif-expected.txt M LayoutTests/platform/glib/printing/iframe-print-expected.txt M LayoutTests/platform/glib/svg/as-object/object-box-sizing-no-width-height-expected.txt M LayoutTests/platform/glib/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt M LayoutTests/platform/glib/tables/mozilla/bugs/bug113235-1-expected.txt M LayoutTests/platform/glib/tables/mozilla/bugs/bug6404-expected.txt M LayoutTests/platform/glib/tables/mozilla/core/bloomberg-expected.txt M LayoutTests/platform/glib/transforms/3d/general/perspective-units-expected.txt M LayoutTests/platform/gtk/editing/deleting/delete-at-paragraph-boundaries-002-expected.txt M LayoutTests/platform/gtk/editing/deleting/delete-at-paragraph-boundaries-003-expected.txt M LayoutTests/platform/gtk/editing/deleting/delete-at-paragraph-boundaries-004-expected.txt M LayoutTests/platform/gtk/editing/deleting/delete-at-paragraph-boundaries-005-expected.txt M LayoutTests/platform/gtk/editing/deleting/delete-at-paragraph-boundaries-006-expected.txt M LayoutTests/platform/gtk/editing/deleting/delete-at-paragraph-boundaries-007-expected.txt M LayoutTests/platform/gtk/editing/deleting/delete-at-paragraph-boundaries-008-expected.txt M LayoutTests/platform/gtk/editing/deleting/delete-at-paragraph-boundaries-009-expected.txt M LayoutTests/platform/gtk/editing/deleting/delete-at-paragraph-boundaries-010-expected.txt M LayoutTests/platform/gtk/editing/deleting/delete-at-paragraph-boundaries-011-expected.txt M LayoutTests/platform/gtk/editing/deleting/non-smart-delete-expected.txt M LayoutTests/platform/gtk/editing/execCommand/5142012-2-expected.txt M LayoutTests/platform/gtk/editing/inserting/insert-br-quoted-001-expected.txt M LayoutTests/platform/gtk/editing/inserting/insert-br-quoted-002-expected.txt M LayoutTests/platform/gtk/editing/inserting/insert-br-quoted-003-expected.txt M LayoutTests/platform/gtk/editing/inserting/insert-br-quoted-004-expected.txt M LayoutTests/platform/gtk/editing/inserting/insert-br-quoted-005-expected.txt M LayoutTests/platform/gtk/editing/inserting/insert-br-quoted-006-expected.txt M LayoutTests/platform/gtk/editing/inserting/insert-div-026-expected.txt M LayoutTests/platform/gtk/editing/inserting/return-key-with-selection-001-expected.txt M LayoutTests/platform/gtk/editing/inserting/return-key-with-selection-002-expected.txt M LayoutTests/platform/gtk/editing/inserting/return-key-with-selection-003-expected.txt M LayoutTests/platform/gtk/editing/pasteboard/emacs-ctrl-k-y-001-expected.txt M LayoutTests/platform/gtk/editing/pasteboard/paste-4038267-fix-expected.txt M
[webkit-changes] [WebKit/WebKit] 3860f9: [GStreamer] Gardening after 262208@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3860f9a1c5d7ff2945dfd6064d4354a1c032ed56 https://github.com/WebKit/WebKit/commit/3860f9a1c5d7ff2945dfd6064d4354a1c032ed56 Author: Philippe Normand Date: 2023-04-25 (Tue, 25 Apr 2023) Changed paths: R LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/videoFrame-createImageBitmap.any-expected.txt Log Message: --- [GStreamer] Gardening after 262208@main https://bugs.webkit.org/show_bug.cgi?id=255925 Unreviewed. * LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/videoFrame-createImageBitmap.any-expected.txt: Removed. No longer needed. Canonical link: https://commits.webkit.org/263370@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e692cb: Cherry-pick 263276@main (1e12a811a71b). https://bu...
Branch: refs/heads/webkitglib/2.40
Home: https://github.com/WebKit/WebKit
Commit: e692cba8c592936c45b81251e6ebfc094f9812a1
https://github.com/WebKit/WebKit/commit/e692cba8c592936c45b81251e6ebfc094f9812a1
Author: Don Olmstead
Date: 2023-04-25 (Tue, 25 Apr 2023)
Changed paths:
M Source/WebCore/contentextensions/DFANode.h
Log Message:
---
Cherry-pick 263276@main (1e12a811a71b).
https://bugs.webkit.org/show_bug.cgi?id=255818
Fix compilation of DFANode
https://bugs.webkit.org/show_bug.cgi?id=255818
Reviewed by Yusuke Suzuki.
Declare `IsKilled` statically to prevent a compilation error.
* Source/WebCore/contentextensions/DFANode.h:
Canonical link: https://commits.webkit.org/263276@main
Commit: 0f326ee760e0f5f877323b480478cfc384ac2e44
https://github.com/WebKit/WebKit/commit/0f326ee760e0f5f877323b480478cfc384ac2e44
Author: Chirag M Shah
Date: 2023-04-25 (Tue, 25 Apr 2023)
Changed paths:
A LayoutTests/fast/editing/replace-selection-command-crash-expected.txt
A LayoutTests/fast/editing/replace-selection-command-crash.html
M Source/WebCore/editing/ReplaceSelectionCommand.cpp
Log Message:
---
Cherry-pick 263051@main (62a3751abfbc).
https://bugs.webkit.org/show_bug.cgi?id=255510
Fix SEGV in
ReplaceSelectionCommand::makeInsertedContentRoundTrippableWithHTMLTreeBuilder
https://bugs.webkit.org/show_bug.cgi?id=255510
rdar://107979390
Reviewed by Ryosuke Niwa.
This change fixes a crash which is caused because we end up in state
where m_lastNodeInserted is NULL after a call to
ReplaceSelectionCommand::InsertedNodes::willRemoveNode, which means that
when makeInsertedContentRoundTrippableWithHTMLTreeBuilder calls
pastLastLeaf() we trip over an assertion.
* LayoutTests/fast/editing/replace-selection-command-crash-expected.txt:
Added.
* LayoutTests/fast/editing/replace-selection-command-crash.html: Added.
* Source/WebCore/editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::InsertedNodes::willRemoveNode):
Canonical link: https://commits.webkit.org/263051@main
Commit: 3c5c6c17bf29a4585edfd136d96a06d2806a3fc8
https://github.com/WebKit/WebKit/commit/3c5c6c17bf29a4585edfd136d96a06d2806a3fc8
Author: Sam James
Date: 2023-04-25 (Tue, 25 Apr 2023)
Changed paths:
M Source/JavaScriptCore/CMakeLists.txt
Log Message:
---
Cherry-pick 262719@main (546b7119c8b7).
https://bugs.webkit.org/show_bug.cgi?id=254965
postprocess-asm rule doesn't respect RUBY_EXECUTABLE
https://bugs.webkit.org/show_bug.cgi?id=254965
Reviewed by Yusuke Suzuki.
postprocess-asm is a Ruby script with #/!/usr/bin/env ruby as its shebang
which
looks up Ruby in PATH. webkit, however, has RUBY_EXECUTABLE as a CMake
option.
It's possible for the Ruby used by CMake (and the other rules during the
build)
to be different to the first Ruby found in PATH. This makes the usage for
postprocess-asm
consistent with other uses in webkit.
* Source/JavaScriptCore/CMakeLists.txt
Canonical link: https://commits.webkit.org/262719@main
Commit: 2b76d741ada361462da3892da4822c2709084171
https://github.com/WebKit/WebKit/commit/2b76d741ada361462da3892da4822c2709084171
Author: Sammy Gill
Date: 2023-04-25 (Tue, 25 Apr 2023)
Changed paths:
A
LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/grid-item-image-percentage-min-height-computes-as-0-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/grid-item-image-percentage-min-height-computes-as-0.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/nested-flexbox-image-percentage-max-height-computes-as-none-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/nested-flexbox-image-percentage-max-height-computes-as-none.html
M Source/WebCore/rendering/RenderBox.cpp
Log Message:
---
Cherry-pick 262342@main (d4ec309d5e67).
https://bugs.webkit.org/show_bug.cgi?id=254603
REGRESSION (259663@main): lowes.com: Product image is blank
https://bugs.webkit.org/show_bug.cgi?id=254603
rdar://106926883
Reviewed by Alan Baradlay.
The product image on Lowes had a structure that is very similar
to the following that results in the product image not rendering
correctly (having a width and height of 0). I made some slight
modifications to make it easier to digest, but the following is
indicative of the issue that is causing the image to show up as blank.
body {
height: 50px;
}
img {
position: relative;
max-width: 100%;
max-height: 100%;
}
.outer-flexbox {
display: flex;
width: 100%;
height: 100%;
}
.outer-flexbox-item {
position: relative;
min-width: 100%;
}
.inner-flexbox {
position: absolute;
display: flex;
[webkit-changes] [WebKit/WebKit] 984732: [GTK] Remove TEST_RUNNER_TEST_PLUGIN_PATH
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 984732ae28a9ad9a2d55c026bd665326f035e59d https://github.com/WebKit/WebKit/commit/984732ae28a9ad9a2d55c026bd665326f035e59d Author: Alicia Boya Garcia Date: 2023-04-25 (Tue, 25 Apr 2023) Changed paths: M Tools/Scripts/run-jsc-benchmarks M Tools/Scripts/webkitdirs.pm M Tools/Scripts/webkitpy/port/glib.py M Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp Log Message: --- [GTK] Remove TEST_RUNNER_TEST_PLUGIN_PATH https://bugs.webkit.org/show_bug.cgi?id=254814 Reviewed by Carlos Garcia Campos. This patch removes the remaining references to TEST_RUNNER_TEST_PLUGIN_PATH in the GTK test runner. As support for plugins has long been removed from WebKit, no plugins were compiled already, but because of these lingering references WebKitTestRunner still refused to run in GTK without that variable set, even though it's value was unused. By fixing that, this patch makes it more intuitive to run the WebKitTestRunner independently of the full blown LayoutTestRunner. For instance, if you want to see the visual output of a page using the testing internals API used by LayoutTests, you can run: WebKitTestRunner --no-timeout --show-window Before this worked only if a TEST_RUNNER_TEST_PLUGIN_PATH environment variable was passed with a dummy value. * Tools/Scripts/run-jsc-benchmarks: * Tools/Scripts/webkitdirs.pm: (setupUnixWebKitEnvironment): * Tools/Scripts/webkitpy/port/glib.py: (GLibPort.setup_environ_for_server): * Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp: (WTR::TestController::initializeTestPluginDirectory): Canonical link: https://commits.webkit.org/263369@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2fb6b6: Move physicalToFlowRelativeDirection from RenderBo...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2fb6b67825702db7105f0b934899dc6b558709db https://github.com/WebKit/WebKit/commit/2fb6b67825702db7105f0b934899dc6b558709db Author: Alan Baradlay Date: 2023-04-25 (Tue, 25 Apr 2023) Changed paths: M Source/WebCore/css/ComputedStyleExtractor.cpp M Source/WebCore/rendering/RenderBox.cpp M Source/WebCore/rendering/RenderBox.h Log Message: --- Move physicalToFlowRelativeDirection from RenderBox to ComputedStyleExtractor https://bugs.webkit.org/show_bug.cgi?id=255884 Reviewed by Antti Koivisto. This function (and friends) does not need to be on RenderBox. It's also in preparation for using it in isLayoutDependent to support shorthand properties. * Source/WebCore/css/ComputedStyleExtractor.cpp: (WebCore::physicalToFlowRelativeDirection): (WebCore::toMarginTrimType): (WebCore::ComputedStyleExtractor::valueForPropertyInStyle): * Source/WebCore/rendering/RenderBox.cpp: (WebCore::RenderBox::physicalToFlowRelativeDirectionMapping const): Deleted. (WebCore::flowRelativeDirectionToMarginTrimType): Deleted. * Source/WebCore/rendering/RenderBox.h: Canonical link: https://commits.webkit.org/263368@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 78d256: [WTF][GLib] Rework FileSystem::openFile()
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 78d2561b2bf73ecfc596b303f3321e6789c1f659 https://github.com/WebKit/WebKit/commit/78d2561b2bf73ecfc596b303f3321e6789c1f659 Author: Alicia Boya Garcia Date: 2023-04-25 (Tue, 25 Apr 2023) Changed paths: M Source/WTF/wtf/FileSystem.cpp M Source/WTF/wtf/FileSystem.h M Source/WTF/wtf/glib/FileSystemGlib.cpp M Source/WTF/wtf/posix/FileSystemPOSIX.cpp M Source/WebKit/NetworkProcess/cache/NetworkCacheDataGLib.cpp M Tools/TestWebKitAPI/Tests/WTF/FileSystem.cpp Log Message: --- [WTF][GLib] Rework FileSystem::openFile() https://bugs.webkit.org/show_bug.cgi?id=254813 Reviewed by Michael Catanzaro and Adrian Perez de Castro. Fixes REGRESSION(259689@main). The previous implementation failed when asked to create a file in ReadWrite mode. This patch also increases the test coverage for FileSystem::openFile(). Previously, few argument combinations where tested, which caused the regression to go unnoticed. Read requests no longer create a read-write stream. To accomodate that, PlatformFileHandle in GLib is now the generic GSeekable* rather than GFileIOStream* (which implies a read-write file handle). This patch also introduces WTF::FileSystem::posixFileDescriptor() for non-Windows platforms, which allows decoupling of the GIO API in a few places in WebKit. * Source/WTF/wtf/FileSystem.cpp: (WTF::FileSystemImpl::MappedFileData::mapFileHandle): * Source/WTF/wtf/FileSystem.h: * Source/WTF/wtf/glib/FileSystemGlib.cpp: (WTF::FileSystemImpl::genericGIOFileClose): (WTF::FileSystemImpl::genericGIOFileQueryInfo): (WTF::FileSystemImpl::genericGIOGetInputStream): (WTF::FileSystemImpl::genericGIOGetOutputStream): (WTF::FileSystemImpl::genericGIOGetFileDescriptorBased): (WTF::FileSystemImpl::posixFileDescriptor): (WTF::FileSystemImpl::fileSize): (WTF::FileSystemImpl::fileID): (WTF::FileSystemImpl::openTemporaryFile): (WTF::FileSystemImpl::openFile): (WTF::FileSystemImpl::closeFile): (WTF::FileSystemImpl::seekFile): (WTF::FileSystemImpl::truncateFile): (WTF::FileSystemImpl::flushFile): (WTF::FileSystemImpl::writeToFile): (WTF::FileSystemImpl::readFromFile): (WTF::FileSystemImpl::lockFile): (WTF::FileSystemImpl::unlockFile): * Source/WTF/wtf/posix/FileSystemPOSIX.cpp: (WTF::FileSystemImpl::posixFileDescriptor): * Source/WebKit/NetworkProcess/cache/NetworkCacheDataGLib.cpp: (WebKit::NetworkCache::Data::tryCreateSharedMemory const): * Tools/TestWebKitAPI/Tests/WTF/FileSystem.cpp: (TestWebKitAPI::TEST_F): Canonical link: https://commits.webkit.org/263367@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3db531: Unreviewed, reverting r262665@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3db5312ccb75f3b264cd85e2b0a2ff2c34cc458d https://github.com/WebKit/WebKit/commit/3db5312ccb75f3b264cd85e2b0a2ff2c34cc458d Author: Jer Noble Date: 2023-04-25 (Tue, 25 Apr 2023) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WebKit/Shared/Cocoa/WebPreferencesDefaultValuesCocoa.mm M Source/WebKit/Shared/WebPreferencesDefaultValues.h Log Message: --- Unreviewed, reverting r262665@main. https://bugs.webkit.org/show_bug.cgi?id=255902 rdar://108471471 [Cocoa] Netflix videos will not play, will eventually error Reverted changeset: "[Cocoa] Enable SampleBufferContentKeySessionSupport by default" https://bugs.webkit.org/show_bug.cgi?id=255067 https://commits.webkit.org/262665@main Canonical link: https://commits.webkit.org/263366@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 88ee43: [WPE] Enable threaded rendering by default using o...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 88ee43d6411f1d3ffb0c7f5f6f0c81629813d5a9 https://github.com/WebKit/WebKit/commit/88ee43d6411f1d3ffb0c7f5f6f0c81629813d5a9 Author: Adrian Perez de Castro Date: 2023-04-25 (Tue, 25 Apr 2023) Changed paths: M Source/WebCore/platform/graphics/nicosia/NicosiaPaintingEngine.cpp M Tools/Scripts/webkitpy/port/gtk.py M Tools/Scripts/webkitpy/port/wpe.py Log Message: --- [WPE] Enable threaded rendering by default using one paint thread https://bugs.webkit.org/show_bug.cgi?id=253953 Reviewed by Carlos Garcia Campos. Enable threaded rendering, following suit after GTK4 which enabled it in 260059@main after some back and forth which involved landing fixes to propertly synchronize access to global resources. * Source/WebCore/platform/graphics/nicosia/NicosiaPaintingEngine.cpp: (Nicosia::PaintingEngine::create): Use one paint thread also for WPE by default and remove the developer mode guard, which was already being ignored for GTK4. * Tools/Scripts/webkitpy/port/gtk.py: (GtkPort.setup_environ_for_server): Disable threaded rendering when running layout tests. * Tools/Scripts/webkitpy/port/wpe.py: (WPEPort.setup_environ_for_server): Ditto. Canonical link: https://commits.webkit.org/263365@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 574dcb: Unreviewed, reverting r262174@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 574dcb6844bb84861a36b2a6055d34dcada287bf https://github.com/WebKit/WebKit/commit/574dcb6844bb84861a36b2a6055d34dcada287bf Author: Commit Queue Date: 2023-04-25 (Tue, 25 Apr 2023) Changed paths: M Source/WebKit/Shared/WebPreferencesDefaultValues.cpp Log Message: --- Unreviewed, reverting r262174@main. https://bugs.webkit.org/show_bug.cgi?id=255918 regressions fixed Reverted changeset: "[macOS] Disable background webcontent suspension by default" https://bugs.webkit.org/show_bug.cgi?id=254535 https://commits.webkit.org/262174@main Canonical link: https://commits.webkit.org/263364@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 048fe7: Use move semantics for ShareableBitmap::Handle
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 048fe73ec43f3cff9d07ad1e28f4862e25bad9c1 https://github.com/WebKit/WebKit/commit/048fe73ec43f3cff9d07ad1e28f4862e25bad9c1 Author: Don Olmstead Date: 2023-04-25 (Tue, 25 Apr 2023) Changed paths: M Source/WebKit/GPUProcess/GPUProcess.cpp M Source/WebKit/GPUProcess/GPUProcess.h M Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp M Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.h M Source/WebKit/Shared/ContextMenuContextData.cpp M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm M Source/WebKit/Shared/ShareableBitmap.h M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm M Source/WebKit/UIProcess/API/Cocoa/_WKThumbnailView.mm M Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp M Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm M Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp M Source/WebKit/UIProcess/Automation/WebAutomationSession.h M Source/WebKit/UIProcess/Automation/cairo/WebAutomationSessionCairo.cpp M Source/WebKit/UIProcess/Automation/cocoa/WebAutomationSessionCocoa.mm M Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.h M Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm M Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm M Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp M Source/WebKit/UIProcess/GPU/GPUProcessProxy.h M Source/WebKit/UIProcess/PageClient.h M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreDMABuf.cpp M Source/WebKit/UIProcess/ios/PageClientImplIOS.h M Source/WebKit/UIProcess/ios/PageClientImplIOS.mm M Source/WebKit/UIProcess/ios/WKContentView.mm M Source/WebKit/UIProcess/ios/WKContentViewInteraction.h M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm M Source/WebKit/UIProcess/mac/PageClientImplMac.h M Source/WebKit/UIProcess/mac/PageClientImplMac.mm M Source/WebKit/UIProcess/mac/WKPrintingView.mm M Source/WebKit/UIProcess/mac/WebViewImpl.h M Source/WebKit/UIProcess/mac/WebViewImpl.mm M Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp M Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h M Source/WebKit/WebProcess/GPU/graphics/RemoteResourceCacheProxy.cpp M Source/WebKit/WebProcess/GPU/media/RemoteImageDecoderAVF.cpp M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKit/WebProcess/WebPage/WebPage.h M Source/WebKit/WebProcess/WebPage/wc/WCBackingStore.h M Source/WebKit/WebProcess/cocoa/TextTrackRepresentationCocoa.mm M Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.h M Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.mm Log Message: --- Use move semantics for ShareableBitmap::Handle https://bugs.webkit.org/show_bug.cgi?id=255815 Reviewed by Kimmo Kinnunen. Use move semantics to transfer ownership of the handle. This is a precursor to using move semantics for `SharedMemory::Handle`. * Source/WebKit/GPUProcess/GPUProcess.cpp: * Source/WebKit/GPUProcess/GPUProcess.h: * Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp: * Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.h: * Source/WebKit/Shared/ContextMenuContextData.cpp: * Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm: * Source/WebKit/Shared/ShareableBitmap.h: * Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm: * Source/WebKit/UIProcess/API/Cocoa/_WKThumbnailView.mm: * Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp: * Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm: * Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp: * Source/WebKit/UIProcess/Automation/WebAutomationSession.h: * Source/WebKit/UIProcess/Automation/cairo/WebAutomationSessionCairo.cpp: * Source/WebKit/UIProcess/Automation/cocoa/WebAutomationSessionCocoa.mm: * Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.h: * Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm: * Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm: * Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp: * Source/WebKit/UIProcess/GPU/GPUProcessProxy.h: * Source/WebKit/UIProcess/PageClient.h: * Source/WebKit/UIProcess/WebPageProxy.cpp: * Source/WebKit/UIProcess/WebPageProxy.h: * Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreDMABuf.cpp: * Source/WebKit/UIProcess/ios/PageClientImplIOS.h: * Source/WebKit/UIProcess/ios/PageClientImplIOS.mm: * Source/WebKit/UIProcess/ios/WKContentView.mm: * Source/WebKit/UIProcess/ios/WKContentViewInteraction.h: * Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm: * Source/WebKit/UIProcess/mac/PageClientImplMac.h: * Source/WebKit/UIProcess/mac/PageClientImplMac.mm: * Source/WebKit/UIProcess/mac/WKPrintingView.mm: * Source/WebKit/UIProcess/mac/WebViewImpl.h: * Source/WebKit/UIProcess/mac/WebViewImpl.mm: *
[webkit-changes] [WebKit/WebKit] 616661: Use move semantics for ShareableResource::Handle
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6166616a13801cc620575f513f196985c05f7e60 https://github.com/WebKit/WebKit/commit/6166616a13801cc620575f513f196985c05f7e60 Author: Don Olmstead Date: 2023-04-25 (Tue, 25 Apr 2023) Changed paths: M Source/WebKit/Shared/ShareableResource.h M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm M Source/WebKit/WebProcess/Network/NetworkProcessConnection.cpp M Source/WebKit/WebProcess/Network/NetworkProcessConnection.h M Source/WebKit/WebProcess/Network/WebResourceLoader.cpp M Source/WebKit/WebProcess/Network/WebResourceLoader.h Log Message: --- Use move semantics for ShareableResource::Handle https://bugs.webkit.org/show_bug.cgi?id=255805 Reviewed by Kimmo Kinnunen. Use move semantics to transfer ownership of the handle. This is a precursor to using move semantics for `SharedMemory::Handle`. * Source/WebKit/Shared/ShareableResource.h: * Source/WebKit/UIProcess/WebPageProxy.h: * Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm: * Source/WebKit/WebProcess/Network/NetworkProcessConnection.cpp: * Source/WebKit/WebProcess/Network/NetworkProcessConnection.h: * Source/WebKit/WebProcess/Network/WebResourceLoader.cpp: * Source/WebKit/WebProcess/Network/WebResourceLoader.h: Canonical link: https://commits.webkit.org/263362@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 12747e: [GTK] fails to build: error: no member named 'read...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 12747e33c41b2e8d167495c6f50aec4b0f09c1f7 https://github.com/WebKit/WebKit/commit/12747e33c41b2e8d167495c6f50aec4b0f09c1f7 Author: Antoine Jacoutot Date: 2023-04-25 (Tue, 25 Apr 2023) Changed paths: M Source/WebCore/SourcesGTK.txt Log Message: --- [GTK] fails to build: error: no member named 'read' in 'JSC::DataView' https://bugs.webkit.org/show_bug.cgi?id=253794 Reviewed by Carlos Garcia Campos. OpenBSD does not have eventfd(2) but instead relies on an external implementation (library) called epoll-shim. epoll-shim already comes with it's "read" definition which clashes with WebKit: webkitgtk40-2.39.91/webkitgtk-2.39.91/Source/WebCore/platform/graphics/iso/ISOBox.h:71:33: error: no member named 'read' in 'JSC::DataView' Using @no-unify prevents tainting the rest of the unified code and allows the build to succeed. * Source/WebCore/SourcesGTK.txt: Canonical link: https://commits.webkit.org/263361@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e535e6: Cherry-pick 263351@main (a9211716efb3). https://bu...
Branch: refs/heads/webkitglib/2.40 Home: https://github.com/WebKit/WebKit Commit: e535e62130c20c12204f5bf23b56e8a3ebaab788 https://github.com/WebKit/WebKit/commit/e535e62130c20c12204f5bf23b56e8a3ebaab788 Author: Tim Nguyen Date: 2023-04-25 (Tue, 25 Apr 2023) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-values/hypot-pow-sqrt-computed-expected.txt M Source/WebCore/platform/calc/CalcExpressionOperation.cpp Log Message: --- Cherry-pick 263351@main (a9211716efb3). https://bugs.webkit.org/show_bug.cgi?id=255905 CSS hypot() function sometimes returns the result squared https://bugs.webkit.org/show_bug.cgi?id=255905 rdar://108487071 Reviewed by Tim Horton. In cases where the result is computed by CalcExpressionOperation.cpp, the result ends up being squared, because we're missing a sqrt() operation. The result is correct for cases computed by CSSCalcOperationNode.cpp however, ideally code should be shared to prevent these types of bugs. * LayoutTests/imported/w3c/web-platform-tests/css/css-values/hypot-pow-sqrt-computed-expected.txt: * Source/WebCore/platform/calc/CalcExpressionOperation.cpp: (WebCore::CalcExpressionOperation::evaluate const): Canonical link: https://commits.webkit.org/263351@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 689746: Cherry-pick 263345@main (1643a89b579b). https://bu...
Branch: refs/heads/webkitglib/2.40 Home: https://github.com/WebKit/WebKit Commit: 6897469101a42f0e0e660fc1a2d156cd5a55119e https://github.com/WebKit/WebKit/commit/6897469101a42f0e0e660fc1a2d156cd5a55119e Author: Rob Buis Date: 2023-04-25 (Tue, 25 Apr 2023) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-values/hypot-pow-sqrt-computed-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-values/hypot-pow-sqrt-computed.html M LayoutTests/imported/w3c/web-platform-tests/css/css-values/round-mod-rem-computed-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-values/round-mod-rem-computed.html M Source/WebCore/css/calc/CSSCalcOperationNode.cpp M Source/WebCore/css/calc/CSSCalcOperationNode.h Log Message: --- Cherry-pick 263345@main (1643a89b579b). https://bugs.webkit.org/show_bug.cgi?id=254392 css/css-values/hypot-pow-sqrt-computed.html WPT crashes https://bugs.webkit.org/show_bug.cgi?id=254392 Reviewed by Tim Nguyen. When simplifying hypot CSSCalcOperationNodes we may have only one child and it may not be a CSSCalcPrimitiveValueNode, in that case do not simplify. Add a similar check and tests for round, mod and rem. * LayoutTests/imported/w3c/web-platform-tests/css/css-values/hypot-pow-sqrt-computed-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-values/hypot-pow-sqrt-computed.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-values/round-mod-rem-computed-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-values/round-mod-rem-computed.html: * Source/WebCore/css/calc/CSSCalcOperationNode.cpp: (WebCore::CSSCalcOperationNode::combineChildren): * Source/WebCore/css/calc/CSSCalcOperationNode.h: Canonical link: https://commits.webkit.org/263345@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 59088b: [IFC][Integration][Line clamp] `LineClamp.currentL...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 59088ba850576159b6e3d3bf05d2717fc6893432 https://github.com/WebKit/WebKit/commit/59088ba850576159b6e3d3bf05d2717fc6893432 Author: Ethan Wong Date: 2023-04-25 (Tue, 25 Apr 2023) Changed paths: A LayoutTests/fast/block/line-clamp-nested-blocks-with-layout-state-expected.html A LayoutTests/fast/block/line-clamp-nested-blocks-with-layout-state.html M Source/WebCore/page/LocalFrameViewLayoutContext.cpp Log Message: --- [IFC][Integration][Line clamp] `LineClamp.currentLineCount` should be propagated to the parent layoutState. https://bugs.webkit.org/show_bug.cgi?id=255487 Reviewed by Alan Baradlay. Since multiple children share the same parent context for line clamp, `LineClamp.currentLineCount` set to the individual child should be propagated to their parent layoutState. Otherwise, subsequent children may not see the current state of this value during layout, causing incorrect line clamp results. * LayoutTests/fast/block/line-clamp-nested-blocks-with-layout-state-expected.html: Added. * LayoutTests/fast/block/line-clamp-nested-blocks-with-layout-state.html: Added. * Source/WebCore/page/LocalFrameViewLayoutContext.cpp: (WebCore::LocalFrameViewLayoutContext::popLayoutState): Canonical link: https://commits.webkit.org/263360@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f6cad2: Remove DisplayContentsChanged flag
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f6cad2b8abe39ea1157c53ec640dab8295e4acc3 https://github.com/WebKit/WebKit/commit/f6cad2b8abe39ea1157c53ec640dab8295e4acc3 Author: Antti Koivisto Date: 2023-04-25 (Tue, 25 Apr 2023) Changed paths: M Source/WebCore/dom/ContainerNode.cpp M Source/WebCore/dom/Element.cpp M Source/WebCore/dom/Element.h M Source/WebCore/dom/EventTarget.h M Source/WebCore/rendering/updating/RenderTreeUpdater.cpp M Source/WebCore/style/StyleTreeResolver.cpp Log Message: --- Remove DisplayContentsChanged flag https://bugs.webkit.org/show_bug.cgi?id=254738 rdar://107417124 Reviewed by Ryosuke Niwa. It is not needed anymore with a separate field in ElementRareData for display:contents style. * Source/WebCore/dom/ContainerNode.cpp: (WebCore::hasDisplayContents): (WebCore::destroyRenderTreeIfNeeded): (WebCore::mayHaveDisplayContents): Deleted. * Source/WebCore/dom/Element.cpp: (WebCore::Element::resolveComputedStyle): (WebCore::Element::displayContentsChanged const): Deleted. (WebCore::Element::setDisplayContentsChanged): Deleted. * Source/WebCore/dom/Element.h: * Source/WebCore/dom/EventTarget.h: * Source/WebCore/rendering/updating/RenderTreeUpdater.cpp: (WebCore::RenderTreeUpdater::updateElementRenderer): * Source/WebCore/style/StyleTreeResolver.cpp: (WebCore::Style::affectsRenderedSubtree): Canonical link: https://commits.webkit.org/263359@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] db5885: REGRESSION(263331@main): [GTK] MiniBrowser cannot ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: db588508842260d4f1333bd8b68058281007e612 https://github.com/WebKit/WebKit/commit/db588508842260d4f1333bd8b68058281007e612 Author: Adrian Perez de Castro Date: 2023-04-25 (Tue, 25 Apr 2023) Changed paths: M Tools/MiniBrowser/gtk/main.c Log Message: --- REGRESSION(263331@main): [GTK] MiniBrowser cannot be built with clang due to fallthrough attribute https://bugs.webkit.org/show_bug.cgi?id=255915 Reviewed by Carlos Garcia Campos. * Tools/MiniBrowser/gtk/main.c: (parseFeaturesOptionCallback): Define and use a FALLTHROUGH macro depending on __GNUC__ and __has_attribute to maximize compiler compatibility. Canonical link: https://commits.webkit.org/263358@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a3084f: :dir pseudo class doesn't invalidate after removin...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a3084fe071c6918f900a19156c2d9e51f1c7dc10 https://github.com/WebKit/WebKit/commit/a3084fe071c6918f900a19156c2d9e51f1c7dc10 Author: Ryosuke Niwa Date: 2023-04-25 (Tue, 25 Apr 2023) Changed paths: A LayoutTests/fast/css/dir-ltr-removal-expected.html A LayoutTests/fast/css/dir-ltr-removal.html A LayoutTests/fast/css/dir-rtl-removal-expected.html A LayoutTests/fast/css/dir-rtl-removal.html M Source/WebCore/html/HTMLElement.cpp M Source/WebCore/html/HTMLElement.h Log Message: --- :dir pseudo class doesn't invalidate after removing dir content attribute from document element https://bugs.webkit.org/show_bug.cgi?id=255568 Reviewed by Tim Nguyen and Antti Koivisto. The bug was caused by dirAttributeChanged not calling HTMLElement::dirAttributeChanged not updating the effective directionality state when removing a content attribute. Fixed the bug by recursively invalidating the pseudo class state using updateEffectiveDirectionality, which is now updated to take std::optional. Also removed redundant calls to HTMLElement::setUsesEffectiveTextDirection(true) in HTMLElement::dirAttributeChanged. * LayoutTests/fast/css/dir-ltr-removal-expected.html: Added. * LayoutTests/fast/css/dir-ltr-removal.html: Added. * LayoutTests/fast/css/dir-rtl-removal-expected.html: Added. * LayoutTests/fast/css/dir-rtl-removal.html: Added. * Source/WebCore/html/HTMLElement.cpp: (WebCore::HTMLElement::dirAttributeChanged): (WebCore::HTMLElement::updateEffectiveDirectionality): Canonical link: https://commits.webkit.org/263357@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4472b6: Add a circular bit to modern media controls' Button
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4472b61acbea6174657bf7df150f2606c492c54f https://github.com/WebKit/WebKit/commit/4472b61acbea6174657bf7df150f2606c492c54f Author: Tim Horton Date: 2023-04-25 (Tue, 25 Apr 2023) Changed paths: M Source/WebCore/Modules/modern-media-controls/controls/button.css M Source/WebCore/Modules/modern-media-controls/controls/button.js M Source/WebCore/Modules/modern-media-controls/controls/inline-media-controls.css Log Message: --- Add a circular bit to modern media controls' Button https://bugs.webkit.org/show_bug.cgi?id=255904 rdar://108487065 Reviewed by Dean Jackson. * Source/WebCore/Modules/modern-media-controls/controls/button.css: (button.circular): * Source/WebCore/Modules/modern-media-controls/controls/button.js: (Button.prototype.get circular): (Button.prototype.set circular): (Button.prototype._updateImageMetrics): (Button): * Source/WebCore/Modules/modern-media-controls/controls/inline-media-controls.css: (.media-controls.inline > .controls-bar button:not(.circular)): (.media-controls.inline > .controls-bar button): Deleted. Add a bit, orthogonal to the style (because we want to use it both with Bar and Rounded buttons), indicating that a button should be fully circular, and adjust the metrics accordingly. Canonical link: https://commits.webkit.org/263356@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5186c2: [WGSL] Overload resolution shouldn't eagerly promo...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5186c242378cb9c03f6f0699cfd8029e5b618a07 https://github.com/WebKit/WebKit/commit/5186c242378cb9c03f6f0699cfd8029e5b618a07 Author: Tadeu Zagallo Date: 2023-04-25 (Tue, 25 Apr 2023) Changed paths: M Source/WebGPU/WGSL/Overload.cpp M Source/WebGPU/WGSL/tests/valid/overload.wgsl Log Message: --- [WGSL] Overload resolution shouldn't eagerly promote variables https://bugs.webkit.org/show_bug.cgi?id=255771 rdar://108361197 Reviewed by Mike Wyrzykowski. During overload resolution, when trying to assign a type to a variable we check whether it satisifies the variable's constraints. In order to satisfy a constraint we might need to promote the type being assigned to the variable. The example from the tests is when the variable requires a concrete type but we are assigning an abstract type to it. Originally, we would promote the type as soon as we assigned it to the variable, but that is not always correct. The promotion algorithm will pick the cheapest conversion, in this case it would promote an AbstractInt to an i32, which is a valid conversion. However, later we observe that the same variable is also being unified with an u32, which was also a valid conversion for the original type (AbstractInt), but since we already promoted the variable to i32, we can no longer unify the variable with u32, since we can't unify i32 and u32. The solution is faily straightforward though: we still reject types that don't satisfy the constraints, but hold off on promoting the type until we materialize the variable after determining that a given overload is a viable candidate. This guarantees that there will be a suitable promotion that will satisfy the constraints, but we delay choosing which type we'll promote to until we have looked at all arguments. * Source/WebGPU/WGSL/Overload.cpp: (WGSL::OverloadResolver::materialize const): (WGSL::OverloadResolver::assign): * Source/WebGPU/WGSL/tests/valid/overload.wgsl: Canonical link: https://commits.webkit.org/263355@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2ae8e5: Add isTabOrSpace to WTF
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2ae8e53cdb4a77a7b7ebf9c8a790fbe8099f60eb https://github.com/WebKit/WebKit/commit/2ae8e53cdb4a77a7b7ebf9c8a790fbe8099f60eb Author: Anne van Kesteren Date: 2023-04-25 (Tue, 25 Apr 2023) Changed paths: M Source/WTF/wtf/ASCIICType.h M Source/WebCore/Modules/fetch/FetchBodyConsumer.cpp M Source/WebCore/html/track/VTTCue.cpp M Source/WebCore/html/track/VTTRegion.cpp M Source/WebCore/html/track/WebVTTParser.cpp M Source/WebCore/html/track/WebVTTParser.h M Source/WebCore/loader/HTTPHeaderField.cpp M Source/WebCore/loader/HeaderFieldTokenizer.cpp M Source/WebCore/loader/LinkHeader.cpp M Source/WebCore/platform/network/HTTPParsers.cpp M Source/WebCore/platform/network/RFC7230.cpp M Source/WebCore/platform/network/RFC7230.h M Source/WebCore/platform/network/RFC8941.cpp Log Message: --- Add isTabOrSpace to WTF https://bugs.webkit.org/show_bug.cgi?id=255842 rdar://108426795 Reviewed by Darin Adler. Consolidates a number of separate initiatives at defining (and inlining) tab '\t' or space ' '. * Source/WTF/wtf/ASCIICType.h: (WTF::isASCIITabOrSpace): * Source/WebCore/Modules/fetch/FetchBodyConsumer.cpp: (WebCore::parseParameters): * Source/WebCore/html/track/VTTCue.cpp: (WebCore::VTTCue::setCueSettings): * Source/WebCore/html/track/VTTRegion.cpp: (WebCore::VTTRegion::setRegionSettings): * Source/WebCore/html/track/WebVTTParser.cpp: (WebCore::WebVTTParser::checkAndCreateRegion): (WebCore::WebVTTParser::checkStyleSheet): The comment here talks about tab or space, but this preserves the existing functionality for now, modulo using isASCIIWhitespace instead of something locally defined. This might be worth following up on. * Source/WebCore/html/track/WebVTTParser.h: * Source/WebCore/loader/HTTPHeaderField.cpp: (WebCore::HTTPHeaderField::create): * Source/WebCore/loader/HeaderFieldTokenizer.cpp: (WebCore::HeaderFieldTokenizer::consume): (WebCore::HeaderFieldTokenizer::skipSpaces): * Source/WebCore/loader/LinkHeader.cpp: (WebCore::isParameterValueChar): (WebCore::findURLBoundaries): (WebCore::parseParameterDelimiter): (WebCore::parseParameterName): (WebCore::parseParameterValue): (WebCore::isSpaceOrTab): Deleted. * Source/WebCore/platform/network/HTTPParsers.cpp: (WebCore::skipWhiteSpace): (WebCore::skipValue): (WebCore::isValidHTTPHeaderValue): (WebCore::extractMIMETypeFromMediaType): (WebCore::parseRange): (WebCore::isTabOrSpace): Deleted. * Source/WebCore/platform/network/RFC7230.cpp: (RFC7230::isQuotedTextCharacter): (RFC7230::isQuotedPairSecondOctet): (RFC7230::isCommentText): (RFC7230::isValidValue): * Source/WebCore/platform/network/RFC7230.h: (RFC7230::isWhitespace): Deleted. * Source/WebCore/platform/network/RFC8941.cpp: (RFC8941::parseDictionary): Canonical link: https://commits.webkit.org/263354@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 36c418: [WPE][GTK] Gardening `fast/writing-mode` after 263...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 36c418e29fcd0a5b23980144425e8a321b158ad1 https://github.com/WebKit/WebKit/commit/36c418e29fcd0a5b23980144425e8a321b158ad1 Author: Amanda Falke Date: 2023-04-25 (Tue, 25 Apr 2023) Changed paths: A LayoutTests/platform/glib/fast/writing-mode/basic-vertical-line-expected.png M LayoutTests/platform/glib/fast/writing-mode/basic-vertical-line-expected.txt M LayoutTests/platform/glib/fast/writing-mode/basic-vertical-line-mixed-expected.txt A LayoutTests/platform/glib/fast/writing-mode/border-vertical-lr-expected.png M LayoutTests/platform/glib/fast/writing-mode/border-vertical-lr-expected.txt A LayoutTests/platform/glib/fast/writing-mode/english-lr-text-expected.png M LayoutTests/platform/glib/fast/writing-mode/english-lr-text-expected.txt A LayoutTests/platform/glib/fast/writing-mode/fieldsets-expected.png M LayoutTests/platform/glib/fast/writing-mode/fieldsets-expected.txt R LayoutTests/platform/gtk/fast/writing-mode/basic-vertical-line-expected.png R LayoutTests/platform/gtk/fast/writing-mode/border-vertical-lr-expected.png R LayoutTests/platform/gtk/fast/writing-mode/english-lr-text-expected.png R LayoutTests/platform/gtk/fast/writing-mode/fieldsets-expected.png Log Message: --- [WPE][GTK] Gardening `fast/writing-mode` after 263291@main Unreviewed test gardening. Update baselines after after 263291@main, (in which we removed a legacy quirk that kept trailing whitespace for inline layout formatting if the whitespace was followed by a line break; now we are in parity with blink and gecko). * LayoutTests/platform/glib/fast/writing-mode/basic-vertical-line-expected.png: Added. * LayoutTests/platform/glib/fast/writing-mode/basic-vertical-line-expected.txt: * LayoutTests/platform/glib/fast/writing-mode/basic-vertical-line-mixed-expected.txt: * LayoutTests/platform/glib/fast/writing-mode/border-vertical-lr-expected.png: Added. * LayoutTests/platform/glib/fast/writing-mode/border-vertical-lr-expected.txt: * LayoutTests/platform/glib/fast/writing-mode/english-lr-text-expected.png: Added. * LayoutTests/platform/glib/fast/writing-mode/english-lr-text-expected.txt: * LayoutTests/platform/glib/fast/writing-mode/fieldsets-expected.png: Renamed from LayoutTests/platform/gtk/fast/writing-mode/fieldsets-expected.png. * LayoutTests/platform/glib/fast/writing-mode/fieldsets-expected.txt: * LayoutTests/platform/gtk/fast/writing-mode/basic-vertical-line-expected.png: Removed. * LayoutTests/platform/gtk/fast/writing-mode/border-vertical-lr-expected.png: Removed. * LayoutTests/platform/gtk/fast/writing-mode/english-lr-text-expected.png: Removed. Canonical link: https://commits.webkit.org/263353@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 536794: [Win] Initialize RunLoop class in WTF::initialize ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 536794017a946bb43409d38bc975b04baedaf8e0 https://github.com/WebKit/WebKit/commit/536794017a946bb43409d38bc975b04baedaf8e0 Author: Fujii Hironori Date: 2023-04-25 (Tue, 25 Apr 2023) Changed paths: M Source/WTF/wtf/Threading.cpp M Source/WTF/wtf/win/MainThreadWin.cpp Log Message: --- [Win] Initialize RunLoop class in WTF::initialize instead of WTF::initializeMainThread https://bugs.webkit.org/show_bug.cgi?id=255903 Reviewed by Ross Kirsling. testapi.exe and testRegExp.exe didn't work after 263194@main because RunLoop class wasn't initialized. They don't call WTF::initializeMainThread. They call WTF::initialize instead. Moved the callsite of RunLoop::registerRunLoopMessageWindowClass from WTF::initializeMainThread to WTF::initialize. * Source/WTF/wtf/Threading.cpp: (WTF::initialize): * Source/WTF/wtf/win/MainThreadWin.cpp: (WTF::initializeMainThreadPlatform): Canonical link: https://commits.webkit.org/263352@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a92117: CSS hypot() function sometimes returns the result ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a9211716efb3a877fe390339ffccfd369c3bda46 https://github.com/WebKit/WebKit/commit/a9211716efb3a877fe390339ffccfd369c3bda46 Author: Tim Nguyen Date: 2023-04-24 (Mon, 24 Apr 2023) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-values/hypot-pow-sqrt-computed-expected.txt M Source/WebCore/platform/calc/CalcExpressionOperation.cpp Log Message: --- CSS hypot() function sometimes returns the result squared https://bugs.webkit.org/show_bug.cgi?id=255905 rdar://108487071 Reviewed by Tim Horton. In cases where the result is computed by CalcExpressionOperation.cpp, the result ends up being squared, because we're missing a sqrt() operation. The result is correct for cases computed by CSSCalcOperationNode.cpp however, ideally code should be shared to prevent these types of bugs. * LayoutTests/imported/w3c/web-platform-tests/css/css-values/hypot-pow-sqrt-computed-expected.txt: * Source/WebCore/platform/calc/CalcExpressionOperation.cpp: (WebCore::CalcExpressionOperation::evaluate const): Canonical link: https://commits.webkit.org/263351@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
