[jira] Commented: (THRIFT-979) ruby bindings used to work on jruby

2010-11-03 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12927899#action_12927899 ] Kevin Clark commented on THRIFT-979: Just an update - I've got dependency issues on the

[jira] Commented: (THRIFT-697) Union support in Ruby

2010-02-16 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12834400#action_12834400 ] Kevin Clark commented on THRIFT-697: What I really meant on those getters/setters was

[jira] Commented: (THRIFT-697) Union support in Ruby

2010-02-15 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12834099#action_12834099 ] Kevin Clark commented on THRIFT-697: Generally looks fine, but could use some cleanup.

[jira] Created: (MWAR-214) packagingExcludes does not correctly parse comma delimited jars when using a string newline char (i.e. '\')

2009-12-01 Thread Kevin Clark (JIRA)
packagingExcludes does not correctly parse comma delimited jars when using a string newline char (i.e. '\') - Key: MWAR-214 URL:

[jira] Commented: (THRIFT-622) Get Thrift into releasable form (eliminate dependencies, tidy licenses, etc)

2009-11-20 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12780922#action_12780922 ] Kevin Clark commented on THRIFT-622: I agree the current patch is a little redundant,

[jira] Commented: (THRIFT-622) Get Thrift into releasable form (eliminate dependencies, tidy licenses, etc)

2009-11-10 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12776343#action_12776343 ] Kevin Clark commented on THRIFT-622: I don't think the Ruby bindings will be severely

[jira] Commented: (THRIFT-547) Thrift deserializer hangs when deserializing empty string

2009-07-30 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12737318#action_12737318 ] Kevin Clark commented on THRIFT-547: Yeah, the goal is that it doesn't, functionally,

[jira] Commented: (THRIFT-552) gem requires exactly rubygems 1.2.0

2009-07-29 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12736983#action_12736983 ] Kevin Clark commented on THRIFT-552: Looks good. +1 gem requires exactly rubygems

[jira] Commented: (THRIFT-547) Thrift deserializer hangs when deserializing empty string

2009-07-29 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12737007#action_12737007 ] Kevin Clark commented on THRIFT-547: There's a ruby-debug require in

[jira] Issue Comment Edited: (THRIFT-547) Thrift deserializer hangs when deserializing empty string

2009-07-29 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12737007#action_12737007 ] Kevin Clark edited comment on THRIFT-547 at 7/29/09 10:52 PM: --

[jira] Commented: (THRIFT-485) Generated validate methods that reference external thrift files' types are not referenced correctly

2009-05-05 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12706125#action_12706125 ] Kevin Clark commented on THRIFT-485: Looks like a good fix. +1 Generated validate

[jira] Commented: (THRIFT-481) indentation of ruby classes is off by a few

2009-05-04 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12705781#action_12705781 ] Kevin Clark commented on THRIFT-481: So, it *used* to do this because the indentation

[jira] Commented: (THRIFT-439) Release 0.1

2009-05-04 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12705807#action_12705807 ] Kevin Clark commented on THRIFT-439: I've emailed legal-discuss to see if they have our

[jira] Commented: (THRIFT-481) indentation of ruby classes is off by a few

2009-05-04 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12705834#action_12705834 ] Kevin Clark commented on THRIFT-481: That's not the case. The generator does it bits at

[jira] Resolved: (THRIFT-432) Specify version number for the Thrift Gem in the Ruby library

2009-05-04 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Clark resolved THRIFT-432. Resolution: Fixed Assignee: Kevin Clark (was: Bryan Duxbury) In 771513, thanks for the

[jira] Commented: (THRIFT-439) Release 0.1

2009-05-04 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12705852#action_12705852 ] Kevin Clark commented on THRIFT-439: I've branched our code in prep for an RC:

[jira] Closed: (THRIFT-442) Rebrand to Apache Podling-Thrift in docs and website

2009-04-08 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Clark closed THRIFT-442. -- Resolution: Invalid I think we're ok on this one. Rebrand to Apache Podling-Thrift in docs and

[jira] Commented: (THRIFT-356) Python tests fail

2009-04-07 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12696591#action_12696591 ] Kevin Clark commented on THRIFT-356: @David: Would it be reasonable to apply and

[jira] Updated: (THRIFT-403) Generated Java code does not compile if struct contains fields that are all uppercase

2009-04-07 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Clark updated THRIFT-403: --- Affects Version/s: 0.1 Fix Version/s: (was: 0.1) 0.2 I'm moving

[jira] Commented: (THRIFT-431) capitalize namespace values

2009-04-07 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12696712#action_12696712 ] Kevin Clark commented on THRIFT-431: Doh, this breaks the tests in test/rb (which

[jira] Commented: (THRIFT-431) capitalize namespace values

2009-04-07 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12696657#action_12696657 ] Kevin Clark commented on THRIFT-431: +1 capitalize namespace values

[jira] Commented: (THRIFT-431) capitalize namespace values

2009-04-07 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12696665#action_12696665 ] Kevin Clark commented on THRIFT-431: Doh, looks like it may not actually handle

[jira] Commented: (THRIFT-431) capitalize namespace values

2009-04-07 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12696721#action_12696721 ] Kevin Clark commented on THRIFT-431: Scratch that. Bug in THRIFT-421 which I apparently

[jira] Updated: (THRIFT-339) THRIFT-242 is incompatible with arguments with empty key fields

2009-04-07 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Clark updated THRIFT-339: --- Fix Version/s: 0.1 Shooting for 0.1, if we get review. THRIFT-242 is incompatible with arguments

[jira] Closed: (THRIFT-421) underscore output file names and require file statements

2009-04-07 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Clark closed THRIFT-421. -- Resolution: Fixed Fix Version/s: 0.1 Ok, pushed in 762907, and noted in the changelog in

[jira] Updated: (THRIFT-395) Python library + compiler does not support unicode strings

2009-04-07 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Clark updated THRIFT-395: --- Fix Version/s: (was: 0.1) 0.2 I think it's clear that we've still got issues

[jira] Created: (THRIFT-439) Release 0.1

2009-04-07 Thread Kevin Clark (JIRA)
Release 0.1 --- Key: THRIFT-439 URL: https://issues.apache.org/jira/browse/THRIFT-439 Project: Thrift Issue Type: Task Components: Compiler (C#), Compiler (C++), Compiler (Cocoa), Compiler (Erlang), Compiler (General),

[jira] Created: (THRIFT-440) VOTE on -dev list

2009-04-07 Thread Kevin Clark (JIRA)
VOTE on -dev list - Key: THRIFT-440 URL: https://issues.apache.org/jira/browse/THRIFT-440 Project: Thrift Issue Type: Sub-task Reporter: Kevin Clark We need to send out a VOTE on the public -dev list, and need

[jira] Created: (THRIFT-441) VOTE on Incubator PMC's general@ list

2009-04-07 Thread Kevin Clark (JIRA)
VOTE on Incubator PMC's general@ list - Key: THRIFT-441 URL: https://issues.apache.org/jira/browse/THRIFT-441 Project: Thrift Issue Type: Sub-task Reporter: Kevin Clark

[jira] Created: (THRIFT-442) Rebrand to Apache Podling-Thrift in docs and website

2009-04-07 Thread Kevin Clark (JIRA)
Rebrand to Apache Podling-Thrift in docs and website Key: THRIFT-442 URL: https://issues.apache.org/jira/browse/THRIFT-442 Project: Thrift Issue Type: Sub-task Reporter: Kevin

[jira] Updated: (THRIFT-442) Rebrand to Apache Podling-Thrift in docs and website

2009-04-07 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Clark updated THRIFT-442: --- Description: Per http://incubator.apache.org/guides/branding.html Rebrand to Apache Podling-Thrift

[jira] Created: (THRIFT-443) Add Incubator disclaimer

2009-04-07 Thread Kevin Clark (JIRA)
Add Incubator disclaimer Key: THRIFT-443 URL: https://issues.apache.org/jira/browse/THRIFT-443 Project: Thrift Issue Type: Sub-task Reporter: Kevin Clark -- This message is automatically generated

[jira] Updated: (THRIFT-162) Thrift structures are unhashable, preventing them from being used as set elements

2009-04-07 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Clark updated THRIFT-162: --- Fix Version/s: 0.2 Thrift structures are unhashable, preventing them from being used as set

[jira] Resolved: (THRIFT-431) capitalize namespace values

2009-04-07 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Clark resolved THRIFT-431. Resolution: Fixed Fix Version/s: 0.1 In 763022. Thanks! capitalize namespace values

[jira] Commented: (THRIFT-442) Rebrand to Apache Podling-Thrift in docs and website

2009-04-07 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12696829#action_12696829 ] Kevin Clark commented on THRIFT-442: I'm unsure. They have some specific restrictions

[jira] Commented: (THRIFT-421) underscore output file names and require file statements

2009-04-03 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12695514#action_12695514 ] Kevin Clark commented on THRIFT-421: Yup, +1 as well. underscore output file names

[jira] Commented: (THRIFT-276) Ruby libraries should have one class per file

2009-04-03 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12695624#action_12695624 ] Kevin Clark commented on THRIFT-276: +1. We look like a real ruby library. Yay. Ruby

[jira] Closed: (THRIFT-419) Comments in Ruby library still reference T* classes (TMemoryBuffer, etc)

2009-04-03 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Clark closed THRIFT-419. -- Resolution: Fixed Fixed in THRIFT-276 Comments in Ruby library still reference T* classes

[jira] Commented: (THRIFT-395) Python library + compiler does not support unicode strings

2009-04-02 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12694903#action_12694903 ] Kevin Clark commented on THRIFT-395: One of the Ruby guys here. *waves* @David: As

[jira] Issue Comment Edited: (THRIFT-395) Python library + compiler does not support unicode strings

2009-04-02 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12694903#action_12694903 ] Kevin Clark edited comment on THRIFT-395 at 4/2/09 1:01 AM: One

[jira] Commented: (THRIFT-276) Ruby libraries should have one class per file

2009-04-02 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12695247#action_12695247 ] Kevin Clark commented on THRIFT-276: Oh. Real encoding handling. Neat. This looks

[jira] Commented: (THRIFT-417) BufferedTransport can enter an infinite loop

2009-04-01 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12694701#action_12694701 ] Kevin Clark commented on THRIFT-417: I'm getting a failure from java due to the mods on

[jira] Commented: (THRIFT-417) BufferedTransport can enter an infinite loop

2009-04-01 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12694705#action_12694705 ] Kevin Clark commented on THRIFT-417: Looks good to me, apart from the Java error. Re:

[jira] Commented: (THRIFT-276) Ruby libraries should have one class per file

2009-04-01 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12694823#action_12694823 ] Kevin Clark commented on THRIFT-276: Yup, I'd rather see classes pulled into their own

[jira] Commented: (THRIFT-175) Specs in Ruby library should be run during make check

2009-03-30 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12693865#action_12693865 ] Kevin Clark commented on THRIFT-175: If I recall, this is because of a bug in

[jira] Created: (THRIFT-408) Ruby C extension doesn't build on 1.8.5

2009-03-25 Thread Kevin Clark (JIRA)
Ruby C extension doesn't build on 1.8.5 --- Key: THRIFT-408 URL: https://issues.apache.org/jira/browse/THRIFT-408 Project: Thrift Issue Type: Bug Components: Compiler (Ruby) Affects

[jira] Updated: (THRIFT-408) Ruby C extension doesn't build on 1.8.5

2009-03-25 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Clark updated THRIFT-408: --- Component/s: (was: Compiler (Ruby)) Library (Ruby) Description: The C

[jira] Closed: (THRIFT-401) ruby transport class read buffer very slow due to usage of slice!

2009-03-25 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Clark closed THRIFT-401. -- Resolution: Fixed Awesome. Pushed in 758510. Do you have any benchmarks you want to show off? ruby

[jira] Commented: (THRIFT-408) Ruby C extension doesn't build on 1.8.5

2009-03-25 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12689356#action_12689356 ] Kevin Clark commented on THRIFT-408: +1 Ruby C extension doesn't build on 1.8.5

[jira] Updated: (THRIFT-323) TJSONProtocol

2009-03-24 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Clark updated THRIFT-323: --- Fix Version/s: 0.2 TJSONProtocol - Key: THRIFT-323

[jira] Updated: (THRIFT-323) TJSONProtocol

2009-03-24 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Clark updated THRIFT-323: --- Fix Version/s: (was: 0.2) 0.1 Feel like this should go in to 0.1 as long as

[jira] Closed: (THRIFT-397) remove unnecessary redefinition of generate_program()

2009-03-24 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Clark closed THRIFT-397. -- Resolution: Fixed Fix Version/s: 0.1 Cool, in r757824. remove unnecessary redefinition of

[jira] Closed: (THRIFT-398) Remove unnecessary parens from generated type annotations

2009-03-24 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Clark closed THRIFT-398. -- Resolution: Fixed Ok, in r757825. Remove unnecessary parens from generated type annotations

[jira] Commented: (THRIFT-263) Ruby tests should use autogenerated structures, not pregenerated fixtures

2009-03-24 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12688708#action_12688708 ] Kevin Clark commented on THRIFT-263: I *though* we'd set it up so most of the fixtures

[jira] Issue Comment Edited: (THRIFT-263) Ruby tests should use autogenerated structures, not pregenerated fixtures

2009-03-24 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12688708#action_12688708 ] Kevin Clark edited comment on THRIFT-263 at 3/24/09 8:11 AM: - I

[jira] Created: (THRIFT-400) Test failures in one language shouldn't keep test suites in other languages from firing

2009-03-24 Thread Kevin Clark (JIRA)
Test failures in one language shouldn't keep test suites in other languages from firing --- Key: THRIFT-400 URL: https://issues.apache.org/jira/browse/THRIFT-400

[jira] Commented: (THRIFT-257) Support validation of required fields

2009-03-24 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12688717#action_12688717 ] Kevin Clark commented on THRIFT-257: Is it just a test case holding this up? Support

[jira] Closed: (THRIFT-161) Generated code doesn't honor optional flag when marshaling struct, and uses invalid HashSet class for setfoo

2009-03-24 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Clark closed THRIFT-161. -- Resolution: Fixed Fix Version/s: 0.1 Ok, I'm tentatively closing this. If it's still an issue

[jira] Updated: (THRIFT-372) Ruby lib doesn't rescue properly from lack of native_thrift extension

2009-03-24 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Clark updated THRIFT-372: --- Description: Files that try to load thrift_native need to rescue from LoadError. LoadError isn't a

[jira] Closed: (THRIFT-399) Fix set and number issues in generated constant code

2009-03-24 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Clark closed THRIFT-399. -- Resolution: Fixed In r757864. Fix set and number issues in generated constant code

[jira] Closed: (THRIFT-192) TBinaryProtocol In Erlang always reads booleans as true

2009-03-24 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Clark closed THRIFT-192. -- Resolution: Fixed Fix Version/s: 0.1 Assignee: David Reiss In r757870.

[jira] Closed: (THRIFT-245) FIELDS constant should contain name of enumerated type for enum fields

2009-03-24 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Clark closed THRIFT-245. -- FIELDS constant should contain name of enumerated type for enum fields

[jira] Closed: (THRIFT-382) Unused imports in generated code

2009-03-24 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Clark closed THRIFT-382. -- Unused imports in generated code Key: THRIFT-382

[jira] Closed: (THRIFT-385) 64-bit integer and double types incorrectly serialized on 32-bit platforms

2009-03-24 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Clark closed THRIFT-385. -- 64-bit integer and double types incorrectly serialized on 32-bit platforms

[jira] Closed: (THRIFT-332) Compact Protocol in Ruby

2009-03-24 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Clark closed THRIFT-332. -- Compact Protocol in Ruby Key: THRIFT-332

[jira] Closed: (THRIFT-260) Some Protocol methods shouldn't have default nil implementations

2009-03-24 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Clark closed THRIFT-260. -- Some Protocol methods shouldn't have default nil implementations

[jira] Closed: (THRIFT-362) Fix Python fastbinary.so build on Solaris

2009-03-24 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Clark closed THRIFT-362. -- Assignee: Nicolas Trangez Fix Python fastbinary.so build on Solaris

[jira] Commented: (THRIFT-374) ruby 1.9 compatibility

2009-03-24 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12688767#action_12688767 ] Kevin Clark commented on THRIFT-374: We *should* support 1.8.6. Adoption of 1.8.7 has

[jira] Commented: (THRIFT-374) ruby 1.9 compatibility

2009-03-24 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12688776#action_12688776 ] Kevin Clark commented on THRIFT-374: I think 1.8.6 is probably fine. We're on 1.8.5 at

[jira] Commented: (THRIFT-401) ruby transport class read buffer very slow due to usage of slice!

2009-03-24 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12688812#action_12688812 ] Kevin Clark commented on THRIFT-401: On face this looks good. Though I could have sworn

[jira] Commented: (THRIFT-401) ruby transport class read buffer very slow due to usage of slice!

2009-03-24 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12688856#action_12688856 ] Kevin Clark commented on THRIFT-401: Doh, looks like debug_proto_test maybe didn't get

[jira] Commented: (THRIFT-192) TBinaryProtocol In Erlang always reads booleans as true

2009-03-24 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12688857#action_12688857 ] Kevin Clark commented on THRIFT-192: Doh, must have missed adding the test to svn. I'll

[jira] Commented: (THRIFT-402) MemoryBuffer 4096 bytes will truncate remaining bytes

2009-03-24 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12688866#action_12688866 ] Kevin Clark commented on THRIFT-402: +1 MemoryBuffer 4096 bytes will truncate

[jira] Commented: (THRIFT-391) Memory leak in fastbinary

2009-03-23 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12688378#action_12688378 ] Kevin Clark commented on THRIFT-391: Ok, if there's no objection today, I'll push the

[jira] Updated: (THRIFT-356) Python tests fail

2009-03-23 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Clark updated THRIFT-356: --- Component/s: Library (Python) Priority: Blocker (was: Major) Fix Version/s: 0.1 This

[jira] Commented: (THRIFT-136) Rename async void to noreturn void or just noreturn

2009-03-20 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12683788#action_12683788 ] Kevin Clark commented on THRIFT-136: +1 for oneway. I think it reads better. Rename

[jira] Commented: (THRIFT-332) Compact Protocol in Ruby

2009-03-19 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12683337#action_12683337 ] Kevin Clark commented on THRIFT-332: In general this looks great. Good work. re: sets

[jira] Commented: (THRIFT-236) Structs should be serialized in a consistent order

2009-03-19 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12683696#action_12683696 ] Kevin Clark commented on THRIFT-236: Is this something we want to move forward on?

[jira] Commented: (THRIFT-146) Make Thrift EventMachine Compatible

2009-03-19 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12683698#action_12683698 ] Kevin Clark commented on THRIFT-146: Sorry to take so long to weigh in on this. I'm

[jira] Commented: (THRIFT-158) Some of the C# runtime library files say Copyright (C) 2007 imeem, inc. http://www.imeem.com All rights reserved.

2009-03-19 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12683701#action_12683701 ] Kevin Clark commented on THRIFT-158: Do I need to commit this? Sorry, I thought someone

[jira] Commented: (THRIFT-313) BinaryProtocolAccelerated and BinaryProtocol don't produce the same bytes when writes aren't strict

2009-03-19 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12683717#action_12683717 ] Kevin Clark commented on THRIFT-313: +1 BinaryProtocolAccelerated and BinaryProtocol

[jira] Assigned: (THRIFT-158) Some of the C# runtime library files say Copyright (C) 2007 imeem, inc. http://www.imeem.com All rights reserved.

2009-03-19 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Clark reassigned THRIFT-158: -- Assignee: Michael Greene Some of the C# runtime library files say Copyright (C) 2007 imeem,

[jira] Commented: (THRIFT-387) Add appropriate Apache header to all code files

2009-03-19 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12683746#action_12683746 ] Kevin Clark commented on THRIFT-387: I just added the header to everything in rb/lib

[jira] Commented: (THRIFT-373) make dist misses a lot of files and includes some bad files

2009-03-18 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12683234#action_12683234 ] Kevin Clark commented on THRIFT-373: Looks good to me. +1 make dist misses a lot of

[jira] Commented: (THRIFT-360) fastbinary fails if field has another type

2009-03-18 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12683303#action_12683303 ] Kevin Clark commented on THRIFT-360: Do you need review on this Alexander? Might want

[jira] Commented: (THRIFT-362) Fix Python fastbinary.so build on Solaris

2009-03-18 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12683304#action_12683304 ] Kevin Clark commented on THRIFT-362: Does this need to be closed? Fix Python

[jira] Closed: (THRIFT-300) configure shouldn't abruptly stop when you don't have Java

2009-03-18 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Clark closed THRIFT-300. -- Resolution: Fixed This was pushed in 753428. configure shouldn't abruptly stop when you don't have

[jira] Closed: (THRIFT-357) Buffer and Connection bloat in TNonBlockingServer

2009-03-18 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Clark closed THRIFT-357. -- Resolution: Fixed Assignee: Anthony Giardullo Hey sorry, spaced on this one. Pushed in r755824.

[jira] Commented: (THRIFT-278) #validate exceptions should contain the offending value

2009-03-13 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12681914#action_12681914 ] Kevin Clark commented on THRIFT-278: Looks fine to me. #validate exceptions should

[jira] Updated: (THRIFT-278) #validate exceptions should contain the offending value

2009-03-13 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Clark updated THRIFT-278: --- Component/s: (was: Compiler (Ruby)) Compiler (Java) #validate exceptions

[jira] Commented: (THRIFT-370) unset fields in structs in c++ have __isset set to true

2009-03-13 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12681916#action_12681916 ] Kevin Clark commented on THRIFT-370: +1 to getting this fixed. Seems like the default

[jira] Created: (THRIFT-371) Redefining initialize in generated thrift exceptions produces a warning

2009-03-13 Thread Kevin Clark (JIRA)
Redefining initialize in generated thrift exceptions produces a warning --- Key: THRIFT-371 URL: https://issues.apache.org/jira/browse/THRIFT-371 Project: Thrift Issue

[jira] Updated: (THRIFT-371) Redefining initialize in generated thrift exceptions produces a warning

2009-03-13 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Clark updated THRIFT-371: --- Priority: Minor (was: Major) Redefining initialize in generated thrift exceptions produces a

[jira] Created: (THRIFT-372) Ruby lib doesn't rescue properly from lack of native_thrift extension

2009-03-13 Thread Kevin Clark (JIRA)
Ruby lib doesn't rescue properly from lack of native_thrift extension - Key: THRIFT-372 URL: https://issues.apache.org/jira/browse/THRIFT-372 Project: Thrift Issue Type:

[jira] Commented: (THRIFT-229) ruby client timeout does not affect connect()

2009-03-06 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12679697#action_12679697 ] Kevin Clark commented on THRIFT-229: Sorry for the wait on feedback for this one Robey.

[jira] Commented: (THRIFT-357) Buffer and Connection bloat in TNonBlockingServer

2009-03-06 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12679698#action_12679698 ] Kevin Clark commented on THRIFT-357: Ahh, quite right. Seems I need more sleep before

[jira] Commented: (THRIFT-105) make a thrift_spec for a structures with negative tags

2009-03-06 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12679723#action_12679723 ] Kevin Clark commented on THRIFT-105: Is this good to go? make a thrift_spec for a

[jira] Commented: (THRIFT-105) make a thrift_spec for a structures with negative tags

2009-03-06 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12679737#action_12679737 ] Kevin Clark commented on THRIFT-105: Sure, just checking in. make a thrift_spec for a

[jira] Commented: (THRIFT-96) TSocket.peek fails on FreeBSD

2009-03-05 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12679238#action_12679238 ] Kevin Clark commented on THRIFT-96: --- Last call. I'm going to push in the next few hours

[jira] Commented: (THRIFT-358) Change how external thrift files' generated code is required

2009-03-05 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12679329#action_12679329 ] Kevin Clark commented on THRIFT-358: +1 Hardcoding the path feels wrong. This is

  1   2   3   >