[kudu-CR] [java] KUDU-1644 Simplify IN-list predicate values during token building

2019-12-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/14706 ) Change subject: [java] KUDU-1644 Simplify IN-list predicate values during token building .. Patch Set 5: (1 comment)

[kudu-CR] Update to LLVM 9.0.0

2019-12-03 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14817 to look at the new patch set (#3). Change subject: Update to LLVM 9.0.0 .. Update to LLVM 9.0.0 This

[kudu-CR] Update to LLVM 9.0.0

2019-12-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/14817 ) Change subject: Update to LLVM 9.0.0 .. Patch Set 2: (2 comments)

[kudu-CR] Update to LLVM 9.0.0

2019-12-03 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14817 to look at the new patch set (#2). Change subject: Update to LLVM 9.0.0 .. Update to LLVM 9.0.0 This

[kudu-CR] Update to LLVM 9.0.0

2019-12-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/14817 ) Change subject: Update to LLVM 9.0.0 .. Patch Set 1: (1 comment) Looks like we need something like

[kudu-CR] Update to LLVM 9.0.0

2019-12-02 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14817 Change subject: Update to LLVM 9.0.0 .. Update to LLVM 9.0.0 This bumps to the latest LLVM release. I checked codegen-test for any

[kudu-CR] Import Impala's blocked based BloomFilter

2019-11-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/14745 ) Change subject: Import Impala's blocked based BloomFilter .. Patch Set 5: (7 comments)

[kudu-CR] [java] fixed bug in the connection negotiation code

2019-11-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/14713 ) Change subject: [java] fixed bug in the connection negotiation code .. Patch Set 5: Code-Review+2 -- To view, visit

[kudu-CR] [cfile] Improve the hash function of pair

2019-11-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/14644 ) Change subject: [cfile] Improve the hash function of pair .. Patch Set 3: did you see this being a perf hotspot anywhere? if so we

[kudu-CR] KUDU-2990: remove memkind/libnuma and dynamically link memkind at runtime

2019-11-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/14620 ) Change subject: KUDU-2990: remove memkind/libnuma and dynamically link memkind at runtime .. Patch Set 3: Code-Review+2 (2 comments)

[kudu-CR] KUDU-2989. Work around SASL bug when FQDN is >d characters

2019-11-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14609 ) Change subject: KUDU-2989. Work around SASL bug when FQDN is >=64 characters .. KUDU-2989. Work around SASL bug when FQDN is

[Impala-ASF-CR] IMPALA-9116: KUDU-2989. Work around SASL bug when FQDN is >d characters

2019-11-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/14614 ) Change subject: IMPALA-9116: KUDU-2989. Work around SASL bug when FQDN is >=64 characters .. Patch Set 1: Code-Review+2 -- To view,

[kudu-CR] KUDU-2989. Work around SASL bug when FQDN is >d characters

2019-10-31 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/14609 ) Change subject: KUDU-2989. Work around SASL bug when FQDN is >=64 characters .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-2989. Work around SASL bug when FQDN is >d characters

2019-10-31 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14609 Change subject: KUDU-2989. Work around SASL bug when FQDN is >=64 characters .. KUDU-2989. Work around SASL bug when FQDN is >=64

[Impala-ASF-CR] IMPALA-7506: support global INVALIDATE METADATA in local catalog mode

2019-10-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/14307 ) Change subject: IMPALA-7506: support global INVALIDATE METADATA in local catalog mode .. Patch Set 8: (3 comments) I generally like

[Impala-ASF-CR] IMPALA-9001: Fix SPNEGO for requests with no 'Authorization'

2019-10-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/14352 ) Change subject: IMPALA-9001: Fix SPNEGO for requests with no 'Authorization' .. Patch Set 1: Code-Review+2 I suppose adding a test for

[Impala-ASF-CR] IMPALA-8228: Ownership support for Ranger authz

2019-09-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/14106 ) Change subject: IMPALA-8228: Ownership support for Ranger authz .. Patch Set 11: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-8228: Ownership support for Ranger authz

2019-09-10 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/14106 ) Change subject: IMPALA-8228: Ownership support for Ranger authz .. Patch Set 6: (4 comments)

[kudu-CR] KUDU-2921: Exposing the table statistics to spark relation.

2019-08-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/14107 ) Change subject: KUDU-2921: Exposing the table statistics to spark relation. .. Patch Set 1: > Patch Set 1: > > Did you consider adding

[Impala-ASF-CR] [WIP] IMPALA-8228: Ownership support for Ranger authz

2019-08-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/14106 ) Change subject: [WIP] IMPALA-8228: Ownership support for Ranger authz .. Patch Set 2: (9 comments)

[Impala-ASF-CR] IMPALA-8869: Fix handling of HTTP keep-alive when returning 401

2019-08-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/14076 ) Change subject: IMPALA-8869: Fix handling of HTTP keep-alive when returning 401 .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [tserver] Move cell and probe key size checking to prepare phase

2019-08-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13470 ) Change subject: [tserver] Move cell and probe key size checking to prepare phase .. Patch Set 10: Code-Review+2 Took a quick look and

[kudu-CR] KUDU-2915 Support to delete dead tservers from CLI

2019-08-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/14048 ) Change subject: KUDU-2915 Support to delete dead tservers from CLI .. Patch Set 1: Have we considered alternatives here? eg if the

[Impala-ASF-CR] IMPALA-8661 : Add randomized tests to stress MetastoreEventsProcessor

2019-07-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13932 ) Change subject: IMPALA-8661 : Add randomized tests to stress MetastoreEventsProcessor .. Patch Set 2: I'm out the next two weeks on

[Impala-ASF-CR] IMPALA-8783: Add Kerberos SPNEGO support to the http hs2 server

2019-07-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13918 ) Change subject: IMPALA-8783: Add Kerberos SPNEGO support to the http hs2 server .. Patch Set 7: Code-Review+2 k, seems like this is

[kudu-CR] KUDU-1938 Add non-copy setters to partial row pt 3

2019-07-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13928 ) Change subject: KUDU-1938 Add non-copy setters to partial row pt 3 .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-8783: Add Kerberos SPNEGO support to the http hs2 server

2019-07-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13918 ) Change subject: IMPALA-8783: Add Kerberos SPNEGO support to the http hs2 server .. Patch Set 6: (3 comments)

[Impala-ASF-CR] IMPALA-8783: Add Kerberos SPNEGO support to the http hs2 server

2019-07-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13918 ) Change subject: IMPALA-8783: Add Kerberos SPNEGO support to the http hs2 server .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-8783: Add Kerberos SPNEGO support to the http hs2 server

2019-07-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13918 ) Change subject: IMPALA-8783: Add Kerberos SPNEGO support to the http hs2 server .. Patch Set 1: (2 comments)

[kudu-CR] Deprecated TabletLocationsPB.ReplicaPB message

2019-07-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13908 ) Change subject: Deprecated TabletLocationsPB.ReplicaPB message .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-2847: Optimize iteration over selection vector in SerializeRowBlock

2019-07-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new patch set (#6) to the change originally created by ZhangYao. ( http://gerrit.cloudera.org:8080/13721 ) Change subject: KUDU-2847: Optimize iteration over selection vector in SerializeRowBlock ..

[kudu-CR] KUDU-2847: Optimize iteration over selection vector in SerializeRowBlock

2019-07-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13721 ) Change subject: KUDU-2847: Optimize iteration over selection vector in SerializeRowBlock .. Patch Set 4: Talked to ZhangYao offline

[kudu-CR] KUDU-2847: Optimize iteration over selection vector in SerializeRowBlock

2019-07-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new patch set (#5) to the change originally created by ZhangYao. ( http://gerrit.cloudera.org:8080/13721 ) Change subject: KUDU-2847: Optimize iteration over selection vector in SerializeRowBlock ..

[kudu-CR] KUDU-2897 Making the -mavx2 flag contingent on the architecture rather than the OS alone

2019-07-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13884 ) Change subject: KUDU-2897 Making the -mavx2 flag contingent on the architecture rather than the OS alone .. Patch Set 2: Code-Review+2

[kudu-CR] KUDU-2847: Optimize iteration over selection vector in SerializeRowBlock

2019-07-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13721 ) Change subject: KUDU-2847: Optimize iteration over selection vector in SerializeRowBlock .. Patch Set 2: I played a bit with this

[kudu-CR] KUDU-2847: Optimize iteration over selection vector in SerializeRowBlock

2019-07-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13721 ) Change subject: KUDU-2847: Optimize iteration over selection vector in SerializeRowBlock .. Patch Set 2: (3 comments)

[kudu-CR] benchmarks.sh: fix wire protocol-test runs

2019-07-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13867 ) Change subject: benchmarks.sh: fix wire_protocol-test runs .. Patch Set 1: -Verified Code-Review+2 Oops wrong button -- To view,

[kudu-CR] benchmarks.sh: fix wire protocol-test runs

2019-07-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13867 ) Change subject: benchmarks.sh: fix wire_protocol-test runs .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] Support SPNEGO for Impala webserver

2019-07-11 Thread Todd Lipcon (Code Review)
Hello Thomas Tauber-Marshall, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13774 to look at the new patch set (#4). Change subject: Support SPNEGO for Impala webserver

[kudu-CR] Separate benchmark to single test

2019-07-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13832 ) Change subject: Separate benchmark to single test .. Separate benchmark to single test Separate the total benchmark to single

[kudu-CR] Separate benchmark to single test

2019-07-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13832 ) Change subject: Separate benchmark to single test .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] Support SPNEGO for Impala webserver

2019-07-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13774 ) Change subject: Support SPNEGO for Impala webserver .. Patch Set 1: (4 comments)

[Impala-ASF-CR] Support SPNEGO for Impala webserver

2019-07-09 Thread Todd Lipcon (Code Review)
Hello Thomas Tauber-Marshall, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13774 to look at the new patch set (#2). Change subject: Support SPNEGO for Impala webserver

[kudu-CR] Extend benchmark for ColumnarRowBlockToPB.

2019-07-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13749 ) Change subject: Extend benchmark for ColumnarRowBlockToPB. .. Extend benchmark for ColumnarRowBlockToPB. Extend the origin

[kudu-CR] Extend benchmark for ColumnarRowBlockToPB.

2019-07-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13749 ) Change subject: Extend benchmark for ColumnarRowBlockToPB. .. Patch Set 5: Code-Review+2 -- To view, visit

[kudu-CR] Extend benchmark for ColumnarRowBlockToPB.

2019-07-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13749 ) Change subject: Extend benchmark for ColumnarRowBlockToPB. .. Patch Set 4: (5 comments)

[Impala-ASF-CR] IMPALA-8748: Always pass hostname to RpcMgr::GetProxy()

2019-07-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13818 ) Change subject: IMPALA-8748: Always pass hostname to RpcMgr::GetProxy() .. Patch Set 1: Code-Review+2 (1 comment) +2 pending one issue

[Impala-ASF-CR] IMPALA-8663 : FileMetadataLoader should skip hidden and tmp directories

2019-07-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13665 ) Change subject: IMPALA-8663 : FileMetadataLoader should skip hidden and tmp directories .. Patch Set 12: Code-Review+2 -- To view,

[Impala-ASF-CR] build: use thin static archives

2019-07-02 Thread Todd Lipcon (Code Review)
Hello Tim Armstrong, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13775 to look at the new patch set (#2). Change subject: build: use thin static archives

[Impala-ASF-CR] build: use thin static archives

2019-07-02 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13775 ) Change subject: build: use thin static archives .. Patch Set 1: > Patch Set 1: > > I tried this out and I couldn't tell a difference

[Impala-ASF-CR] Support SPNEGO for Impala webserver

2019-07-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13774 Change subject: Support SPNEGO for Impala webserver .. Support SPNEGO for Impala webserver This ports over changes from kudu commit

[Impala-ASF-CR] build: use thin static archives

2019-07-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13775 Change subject: build: use thin static archives .. build: use thin static archives This enables thin static archives for our internal

[Impala-ASF-CR] IMPALA-8663 : FileMetadataLoader should skip hidden and tmp directories

2019-07-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13665 ) Change subject: IMPALA-8663 : FileMetadataLoader should skip hidden and tmp directories .. Patch Set 11: (3 comments)

[kudu-CR] webserver: update to latest squeasel build

2019-07-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13728 ) Change subject: webserver: update to latest squeasel build .. webserver: update to latest squeasel build The newest version of

[Impala-ASF-CR] Update squeasel to 7973705170f4744d1806e32695f7ea1e8308ee95

2019-07-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13768 ) Change subject: Update squeasel to 7973705170f4744d1806e32695f7ea1e8308ee95 .. Patch Set 3: Code-Review+2 ps2 fixes the whitespace, ps3

[Impala-ASF-CR] Update squeasel to 7973705170f4744d1806e32695f7ea1e8308ee95

2019-07-01 Thread Todd Lipcon (Code Review)
Hello Michael Ho, Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13768 to look at the new patch set (#2). Change subject: Update squeasel to 7973705170f4744d1806e32695f7ea1e8308ee95

[Impala-ASF-CR] IMPALA-6159 / KUDU-2192: Enable TCP keepalive for all outbound connections

2019-06-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13764 ) Change subject: IMPALA-6159 / KUDU-2192: Enable TCP keepalive for all outbound connections .. Patch Set 1: Code-Review+2 -- To view,

[Impala-ASF-CR] Update squeasel to 7973705170f4744d1806e32695f7ea1e8308ee95

2019-06-28 Thread Todd Lipcon (Code Review)
Hello Michael Ho, Lars Volker, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/13768 to review the following change. Change subject: Update squeasel to 7973705170f4744d1806e32695f7ea1e8308ee95

[Impala-ASF-CR] Update kudu/security from 9ebcb77aa911aae76c48e717af24e643cb81908d

2019-06-28 Thread Todd Lipcon (Code Review)
Hello Michael Ho, Lars Volker, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/13767 to review the following change. Change subject: Update kudu/security from 9ebcb77aa911aae76c48e717af24e643cb81908d

[kudu-CR] KUDU-2866. Optimize CFileSet::Iterator::FinishBatch

2019-06-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13666 ) Change subject: KUDU-2866. Optimize CFileSet::Iterator::FinishBatch .. KUDU-2866. Optimize CFileSet::Iterator::FinishBatch I

[kudu-CR] Extend benchmark for ColumnarRowBlockToPB.

2019-06-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13749 ) Change subject: Extend benchmark for ColumnarRowBlockToPB. .. Patch Set 2: (10 comments)

[kudu-CR] webserver: update to latest squeasel build

2019-06-27 Thread Todd Lipcon (Code Review)
Hello Will Berkeley, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13728 to look at the new patch set (#2). Change subject: webserver: update to latest squeasel build

[kudu-CR] KUDU-2192: Enable TCP keepalive for all outbound connections

2019-06-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13702 ) Change subject: KUDU-2192: Enable TCP keepalive for all outbound connections .. KUDU-2192: Enable TCP keepalive for all outbound

[Impala-ASF-CR] IMPALA-8585: Insert data into ACID table during dataload

2019-06-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13633 ) Change subject: IMPALA-8585: Insert data into ACID table during dataload .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-8663 : FileMetadataLoader should skip hidden and tmp directories

2019-06-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13665 ) Change subject: IMPALA-8663 : FileMetadataLoader should skip hidden and tmp directories .. Patch Set 8: (6 comments)

[kudu-CR] KUDU-2866. Optimize CFileSet::Iterator::FinishBatch

2019-06-27 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13666 to look at the new patch set (#3). Change subject: KUDU-2866. Optimize CFileSet::Iterator::FinishBatch

[kudu-CR] KUDU-2192: Enable TCP keepalive for all outbound connections

2019-06-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13702 ) Change subject: KUDU-2192: Enable TCP keepalive for all outbound connections .. Patch Set 4: Code-Review+2 -- To view, visit

[kudu-CR] webserver: update to latest squeasel build

2019-06-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13728 ) Change subject: webserver: update to latest squeasel build .. Patch Set 1: fixed in this upstream PR:

[kudu-CR] KUDU-2867. Optimize delta timestamp decoding

2019-06-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13667 ) Change subject: KUDU-2867. Optimize delta timestamp decoding .. KUDU-2867. Optimize delta timestamp decoding When using hybrid

[kudu-CR] KUDU-2847: Optimize iteration over selection vector in SerializeRowBlock

2019-06-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13721 ) Change subject: KUDU-2847: Optimize iteration over selection vector in SerializeRowBlock .. Patch Set 1: I chatted with Zhang Yao last

[kudu-CR] thirdparty: fix build-if-necessary in tarballs pt 2

2019-06-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13729 ) Change subject: thirdparty: fix build-if-necessary in tarballs pt 2 .. Patch Set 1: Code-Review+2 Woops, sorry! -- To view, visit

[kudu-CR] webserver: update to latest squeasel build

2019-06-25 Thread Todd Lipcon (Code Review)
Hello Will Berkeley, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/13728 to review the following change. Change subject: webserver: update to latest squeasel build .. webserver: update to

[kudu-CR] KUDU-2483 (part 1/3) Add bloom filter predicate for Java API

2019-06-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13703 ) Change subject: KUDU-2483 (part 1/3) Add bloom filter predicate for Java API .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-8627: re-enable catalog v2 in containers

2019-06-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13708 ) Change subject: IMPALA-8627: re-enable catalog v2 in containers .. Patch Set 2: (1 comment)

[kudu-CR] thirdparty: fix build-if-necessary in tarballs

2019-06-21 Thread Todd Lipcon (Code Review)
Hello Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/13706 to review the following change. Change subject: thirdparty: fix build-if-necessary in tarballs .. thirdparty: fix

[Impala-ASF-CR] IMPALA-8682: Add authorized proxy user/group test coverage with Ranger

2019-06-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13679 ) Change subject: IMPALA-8682: Add authorized proxy user/group test coverage with Ranger .. Patch Set 5: Code-Review+2 -- To view,

[kudu-CR] KUDU-2192: Enable TCP keepalive for all outbound connections

2019-06-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13702 ) Change subject: KUDU-2192: Enable TCP keepalive for all outbound connections .. Patch Set 3: > Patch Set 3: > > The server shutdown

[kudu-CR] KUDU-2192: Enable TCP keepalive for all outbound connections

2019-06-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13702 ) Change subject: KUDU-2192: Enable TCP keepalive for all outbound connections .. Patch Set 3: (1 comment) Were you able to test this in

[Impala-ASF-CR] IMPALA-8682: Add authorized proxy user/group test coverage with Ranger

2019-06-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13679 ) Change subject: IMPALA-8682: Add authorized proxy user/group test coverage with Ranger .. Patch Set 4: (2 comments)

[Impala-ASF-CR] Backport KUDU-2871 (part 1): disable TLS 1.3.

2019-06-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13689 ) Change subject: Backport KUDU-2871 (part 1): disable TLS 1.3. .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2871 (part 1): disable TLS 1.3.

2019-06-20 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/13683 to review the following change. Change subject: KUDU-2871 (part 1): disable TLS 1.3. .. KUDU-2871 (part 1):

[Impala-ASF-CR] IMPALA-7534. Handle invalidation races in CatalogdMetaProvider

2019-06-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13664 ) Change subject: IMPALA-7534. Handle invalidation races in CatalogdMetaProvider .. Patch Set 5: (3 comments)

[Impala-ASF-CR] IMPALA-7534. Handle invalidation races in CatalogdMetaProvider

2019-06-19 Thread Todd Lipcon (Code Review)
Hello Bharath Vissapragada, Vihang Karajgaonkar, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13664 to look at the new patch set (#5). Change subject: IMPALA-7534. Handle invalidation races in CatalogdMetaProvider

[kudu-CR] KUDU-2869. Fix compiler error with devtoolset-7 (gcc 7)

2019-06-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13676 ) Change subject: KUDU-2869. Fix compiler error with devtoolset-7 (gcc 7) .. KUDU-2869. Fix compiler error with devtoolset-7 (gcc

[kudu-CR] KUDU-2869. Fix compiler error with devtoolset-7 (gcc 7)

2019-06-19 Thread Todd Lipcon (Code Review)
Hello Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/13676 to review the following change. Change subject: KUDU-2869. Fix compiler error with devtoolset-7 (gcc 7) ..

[kudu-CR] DeltaPreparer: use vectors instead of deques

2019-06-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13668 ) Change subject: DeltaPreparer: use vectors instead of deques .. DeltaPreparer: use vectors instead of deques We had a few

[kudu-CR](gh-pages) [site] update copyright year to 2019 in html footer

2019-06-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13675 ) Change subject: [site] update copyright year to 2019 in html footer .. Patch Set 1: Verified+1 -- To view, visit

[kudu-CR](gh-pages) [site] update copyright year to 2019 in html footer

2019-06-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13675 ) Change subject: [site] update copyright year to 2019 in html footer .. [site] update copyright year to 2019 in html footer

[kudu-CR](gh-pages) [site] update copyright year to 2019 in html footer

2019-06-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13675 ) Change subject: [site] update copyright year to 2019 in html footer .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2866. Optimize CFileSet::Iterator::FinishBatch

2019-06-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13666 ) Change subject: KUDU-2866. Optimize CFileSet::Iterator::FinishBatch .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-7534. Handle invalidation races in CatalogdMetaProvider

2019-06-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13664 ) Change subject: IMPALA-7534. Handle invalidation races in CatalogdMetaProvider .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-7534. Handle invalidation races in CatalogdMetaProvider

2019-06-18 Thread Todd Lipcon (Code Review)
Hello Bharath Vissapragada, Vihang Karajgaonkar, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13664 to look at the new patch set (#4). Change subject: IMPALA-7534. Handle invalidation races in CatalogdMetaProvider

[Impala-ASF-CR] IMPALA-7534. Handle invalidation races in CatalogdMetaProvider

2019-06-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13664 ) Change subject: IMPALA-7534. Handle invalidation races in CatalogdMetaProvider .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-7534. Handle invalidation races in CatalogdMetaProvider

2019-06-18 Thread Todd Lipcon (Code Review)
Hello Bharath Vissapragada, Vihang Karajgaonkar, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13664 to look at the new patch set (#3). Change subject: IMPALA-7534. Handle invalidation races in CatalogdMetaProvider

[Impala-ASF-CR] IMPALA-7534. Handle invalidation races in CatalogdMetaProvider

2019-06-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13664 ) Change subject: IMPALA-7534. Handle invalidation races in CatalogdMetaProvider .. Patch Set 2: (4 comments)

[Impala-ASF-CR] IMPALA-8584: Add cookie support to the HTTP HS2 server

2019-06-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13672 ) Change subject: IMPALA-8584: Add cookie support to the HTTP HS2 server .. Patch Set 2: (5 comments) didn't look in detail yet, a

[Impala-ASF-CR] IMPALA-8667. Remove --pull incremental stats flag

2019-06-18 Thread Todd Lipcon (Code Review)
Hello Bharath Vissapragada, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/13671 to review the following change. Change subject: IMPALA-8667. Remove --pull_incremental_stats flag ..

[Impala-ASF-CR] IMPALA-7534. Handle invalidation races in CatalogdMetaProvider

2019-06-18 Thread Todd Lipcon (Code Review)
Hello Bharath Vissapragada, Vihang Karajgaonkar, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13664 to look at the new patch set (#2). Change subject: IMPALA-7534. Handle invalidation races in CatalogdMetaProvider

[Impala-ASF-CR] WIP: IMPALA-7434. Handle invalidation races in CatalogdMetaProvider

2019-06-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13664 ) Change subject: WIP: IMPALA-7434. Handle invalidation races in CatalogdMetaProvider .. Patch Set 1: > Patch Set 1: > > I'm trying to

[kudu-CR] KUDU-2867. Optimize delta timestamp decoding

2019-06-18 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13667 to look at the new patch set (#2). Change subject: KUDU-2867. Optimize delta timestamp decoding ..

<    1   2   3   4   5   6   7   8   9   10   >