Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22612#discussion_r231980219
--- Diff:
core/src/main/scala/org/apache/spark/executor/ProcfsBasedSystems.scala ---
@@ -0,0 +1,222 @@
+/*
+ * Licensed to the Apache Software
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22612#discussion_r23535
--- Diff:
core/src/main/scala/org/apache/spark/metrics/ExecutorMetricType.scala ---
@@ -19,18 +19,31 @@ package org.apache.spark.metrics
import
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22612#discussion_r23970
--- Diff:
core/src/main/scala/org/apache/spark/metrics/ExecutorMetricType.scala ---
@@ -95,10 +148,18 @@ private[spark] object ExecutorMetricType
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22612#discussion_r231982148
--- Diff:
core/src/main/scala/org/apache/spark/executor/ProcfsBasedSystems.scala ---
@@ -0,0 +1,222 @@
+/*
+ * Licensed to the Apache Software
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22612#discussion_r231980858
--- Diff:
core/src/main/scala/org/apache/spark/executor/ProcfsBasedSystems.scala ---
@@ -0,0 +1,222 @@
+/*
+ * Licensed to the Apache Software
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22612#discussion_r232224769
--- Diff: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala ---
@@ -394,10 +394,13 @@ private[spark] object JsonProtocol
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22612#discussion_r231925282
--- Diff:
core/src/main/scala/org/apache/spark/executor/ProcfsBasedSystems.scala ---
@@ -0,0 +1,222 @@
+/*
+ * Licensed to the Apache Software
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22612#discussion_r232221783
--- Diff:
core/src/main/scala/org/apache/spark/metrics/ExecutorMetricType.scala ---
@@ -19,18 +19,31 @@ package org.apache.spark.metrics
import
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22612#discussion_r231926797
--- Diff:
core/src/main/scala/org/apache/spark/executor/ProcfsBasedSystems.scala ---
@@ -0,0 +1,266 @@
+/*
+ * Licensed to the Apache Software
Github user squito commented on the issue:
https://github.com/apache/spark/pull/22818
argh, sorry about the mistake, thank you for the fix @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user squito commented on the issue:
https://github.com/apache/spark/pull/22818
@cloud-fan oh good point, sorry that was an oversight on my part. Since it
was clean I just pushed it directly here:
https://github.com/apache/spark/commit/47a668c2f03d77078259531ddaccf80b001a8b5c
Github user squito closed the pull request at:
https://github.com/apache/spark/pull/22983
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
GitHub user squito opened a pull request:
https://github.com/apache/spark/pull/22983
[SPARK-25904][CORE] Allocate arrays smaller than Int.MaxValue
JVMs can't allocate arrays of length exactly Int.MaxValue, so ensure we
never try to allocate an array that big. This commit changes
Github user squito commented on the issue:
https://github.com/apache/spark/pull/22818
merged to master
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user squito commented on the issue:
https://github.com/apache/spark/pull/22818
thanks for the review @attilapiros, fixed the style issue, I think the
other one is OK as is.
---
-
To unsubscribe, e-mail
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22818#discussion_r231129421
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -287,7 +286,7 @@ class Dataset[T] private[sql](
_numRows: Int
Github user squito commented on the issue:
https://github.com/apache/spark/pull/22882
ah right, sorry I hadn't updated this after that merged. I just updated it.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user squito commented on the issue:
https://github.com/apache/spark/pull/22882
the problem is that the WAL expects `hflush()` & `append()` to work, but
they don't for EC files. So if you have hdfs configured to use EC by default,
then anytime you try to use the streaming
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22288#discussion_r230682694
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/TaskSchedulerImplSuite.scala ---
@@ -503,6 +507,182 @@ class TaskSchedulerImplSuite extends
Github user squito commented on the issue:
https://github.com/apache/spark/pull/22504
Jenkins, add to whitelist
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user squito commented on the issue:
https://github.com/apache/spark/pull/22927
good catch, I should have checked this case too.
lgtm
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user squito commented on the issue:
https://github.com/apache/spark/pull/22916
I messed up branches & naming enough I thought it would be simpler to just
open a new PR here: https://github.com/apache/spark/pull/2
GitHub user squito opened a pull request:
https://github.com/apache/spark/pull/22917
[SPARK-25827][CORE] Encrypted blocks can be over 2GB.
## What changes were proposed in this pull request?
Avoid converting encrypted bocks to regular ByteBuffers.
Also updates some
Github user squito closed the pull request at:
https://github.com/apache/spark/pull/22916
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
GitHub user squito opened a pull request:
https://github.com/apache/spark/pull/22916
[SPARK-25855][CORE] Encrypted blocks can be over 2GB.
## What changes were proposed in this pull request?
Avoid converting encrypted bocks to regular ByteBuffers.
Also updates some
Github user squito commented on the issue:
https://github.com/apache/spark/pull/22818
I also changed the issue to SPARK-25904 -- there are some other things
related to encryption that it makes more sense to handle under SPARK-25827
Github user squito commented on the issue:
https://github.com/apache/spark/pull/22818
@kiszk I've updated this to cover more cases. I didn't cover some of them
in mllib-local, as ByteArrayMethods isn't visible there, and it would really
only very slightly improve an error msg, so
Github user squito commented on the issue:
https://github.com/apache/spark/pull/22288
You mentioned in the description that you did some manual testing -- since
this has been through some changes since the initial versions, can you do that
again? please be sure to run some manual
Github user squito commented on the issue:
https://github.com/apache/spark/pull/22624
merged to master
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user squito commented on the issue:
https://github.com/apache/spark/pull/22884
merged to master
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user squito commented on the issue:
https://github.com/apache/spark/pull/22624
any more comments @ifilonenko @skonto ?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user squito commented on the issue:
https://github.com/apache/spark/pull/22881
jenkins, retest this please
known flaky: https://issues.apache.org/jira/browse/SPARK-24285
---
-
To unsubscribe, e-mail
Github user squito commented on the issue:
https://github.com/apache/spark/pull/22884
good catch, lgtm
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user squito commented on the issue:
https://github.com/apache/spark/pull/22881
thanks for the review @vanzin & @kiszk , updated
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22881#discussion_r229172448
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala
---
@@ -471,4 +473,42 @@ object SparkHadoopUtil {
hadoopConf.set
GitHub user squito opened a pull request:
https://github.com/apache/spark/pull/22882
[SPARK-25871][STREAMING][WIP] Don't use EC for streaming WAL
## What changes were proposed in this pull request?
The write ahead log expects to be able to call hflush, but that is a no-op
GitHub user squito opened a pull request:
https://github.com/apache/spark/pull/22881
[SPARK-25855][CORE] Don't use erasure coding for event logs by default
## What changes were proposed in this pull request?
This turns off hdfs erasure coding by default for event logs
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22624#discussion_r229068643
--- Diff:
core/src/main/scala/org/apache/spark/deploy/security/HadoopDelegationTokenManager.scala
---
@@ -17,76 +17,175 @@
package
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22624#discussion_r229067463
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
---
@@ -230,7 +242,7 @@ class
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22624#discussion_r229010495
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
---
@@ -230,7 +242,7 @@ class
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22288#discussion_r228788350
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
@@ -415,9 +420,54 @@ private[spark] class TaskSchedulerImpl
Github user squito commented on the issue:
https://github.com/apache/spark/pull/22624
one minor comment about the `start` api, but otherwise lgtm from the yarn
side. would need a bit more time to look at the other cluster managers if
nobody else can vouch for those
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22624#discussion_r228788072
--- Diff:
core/src/main/scala/org/apache/spark/deploy/security/HadoopDelegationTokenManager.scala
---
@@ -17,76 +17,175 @@
package
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22288#discussion_r228675680
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
@@ -415,9 +420,54 @@ private[spark] class TaskSchedulerImpl
Github user squito commented on the issue:
https://github.com/apache/spark/pull/22624
>> Is there any place which documents this overall flow?
>
> Not yet. I plan to write a README.md explaining this, separately, since
there's a lot of
confusion not just ab
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22624#discussion_r228644038
--- Diff:
core/src/main/scala/org/apache/spark/deploy/security/HadoopDelegationTokenManager.scala
---
@@ -17,76 +17,175 @@
package
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22288#discussion_r228642238
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
@@ -415,9 +420,54 @@ private[spark] class TaskSchedulerImpl
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22288#discussion_r228642015
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
@@ -415,9 +420,54 @@ private[spark] class TaskSchedulerImpl
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22288#discussion_r228608360
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/TaskSchedulerImplSuite.scala ---
@@ -503,6 +507,145 @@ class TaskSchedulerImplSuite extends
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22288#discussion_r228609147
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/TaskSchedulerImplSuite.scala ---
@@ -503,6 +507,181 @@ class TaskSchedulerImplSuite extends
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22288#discussion_r228605235
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
@@ -415,9 +420,54 @@ private[spark] class TaskSchedulerImpl
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22288#discussion_r228609353
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/TaskSchedulerImplSuite.scala ---
@@ -503,6 +507,181 @@ class TaskSchedulerImplSuite extends
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22288#discussion_r228606711
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/TaskSchedulerImplSuite.scala ---
@@ -503,6 +507,181 @@ class TaskSchedulerImplSuite extends
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22288#discussion_r228604552
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
@@ -415,9 +420,54 @@ private[spark] class TaskSchedulerImpl
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22288#discussion_r228604322
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
@@ -415,9 +420,54 @@ private[spark] class TaskSchedulerImpl
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22624#discussion_r228400112
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/security/KubernetesHadoopDelegationTokenManager.scala
---
@@ -18,45
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22624#discussion_r228398765
--- Diff:
core/src/main/scala/org/apache/spark/deploy/security/HadoopDelegationTokenManager.scala
---
@@ -110,32 +209,105 @@ private[spark] class
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22624#discussion_r228400837
--- Diff:
core/src/main/scala/org/apache/spark/deploy/security/HadoopDelegationTokenManager.scala
---
@@ -17,76 +17,175 @@
package
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22624#discussion_r228400760
--- Diff:
core/src/main/scala/org/apache/spark/deploy/security/HadoopDelegationTokenManager.scala
---
@@ -17,76 +17,175 @@
package
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22624#discussion_r228397209
--- Diff:
core/src/main/scala/org/apache/spark/deploy/security/HadoopDelegationTokenManager.scala
---
@@ -17,76 +17,175 @@
package
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22624#discussion_r228398489
--- Diff:
core/src/main/scala/org/apache/spark/deploy/security/HadoopDelegationTokenManager.scala
---
@@ -110,32 +209,105 @@ private[spark] class
Github user squito commented on the issue:
https://github.com/apache/spark/pull/22818
Actually there are quite a few more uses, even of `Int.MaxValue`, which I
find suspicious, but for the moment I only wanted to touch the cases I
understood better. For example
Github user squito commented on the issue:
https://github.com/apache/spark/pull/22818
@kiszk
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
GitHub user squito opened a pull request:
https://github.com/apache/spark/pull/22818
[SPARK-25827][CORE] Allocate arrays smaller than Int.MaxValue
JVMs don't you allocate arrays of length exactly Int.MaxValue, so leave
a little extra room.
You can merge this pull request
Github user squito commented on the issue:
https://github.com/apache/spark/pull/22504
known test failure addressed here:
https://github.com/apache/spark/pull/22808
---
-
To unsubscribe, e-mail: reviews-unsubscr
GitHub user squito opened a pull request:
https://github.com/apache/spark/pull/22799
[SPARK-25805][SQL][TEST] Fix test for SPARK-25159
The original test would sometimes fail if the listener bus did not keep
up, so just wait till the listener bus is empty. Tested by adding
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22288#discussion_r227112966
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
@@ -415,9 +420,55 @@ private[spark] class TaskSchedulerImpl
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22288#discussion_r227111412
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
@@ -415,9 +420,55 @@ private[spark] class TaskSchedulerImpl
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22612#discussion_r227082371
--- Diff:
core/src/main/scala/org/apache/spark/executor/ProcfsBasedSystems.scala ---
@@ -0,0 +1,226 @@
+/*
+ * Licensed to the Apache Software
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22612#discussion_r227080176
--- Diff:
core/src/main/scala/org/apache/spark/executor/ProcfsBasedSystems.scala ---
@@ -0,0 +1,226 @@
+/*
+ * Licensed to the Apache Software
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22288#discussion_r227067905
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
@@ -415,9 +420,55 @@ private[spark] class TaskSchedulerImpl
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22288#discussion_r227069285
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
@@ -415,9 +420,55 @@ private[spark] class TaskSchedulerImpl
Github user squito commented on the issue:
https://github.com/apache/spark/pull/22288
you're still mentioning dynamic allocation in the description, but this
isn't actually dynamic allocation specific
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22288#discussion_r227064894
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/TaskSchedulerImplSuite.scala ---
@@ -503,6 +507,145 @@ class TaskSchedulerImplSuite extends
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22288#discussion_r227062956
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/TaskSchedulerImplSuite.scala ---
@@ -503,6 +507,145 @@ class TaskSchedulerImplSuite extends
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22288#discussion_r227061320
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/TaskSchedulerImplSuite.scala ---
@@ -82,10 +84,12 @@ class TaskSchedulerImplSuite extends
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22288#discussion_r227061367
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/TaskSchedulerImplSuite.scala ---
@@ -503,6 +507,145 @@ class TaskSchedulerImplSuite extends
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22288#discussion_r227060905
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
@@ -453,6 +504,25 @@ private[spark] class TaskSchedulerImpl
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22288#discussion_r227070407
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
@@ -453,6 +504,25 @@ private[spark] class TaskSchedulerImpl
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22288#discussion_r227069559
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
@@ -415,9 +420,55 @@ private[spark] class TaskSchedulerImpl
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22612#discussion_r227054255
--- Diff:
core/src/main/scala/org/apache/spark/executor/ProcfsBasedSystems.scala ---
@@ -0,0 +1,226 @@
+/*
+ * Licensed to the Apache Software
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22612#discussion_r227054038
--- Diff:
core/src/main/scala/org/apache/spark/executor/ProcfsBasedSystems.scala ---
@@ -0,0 +1,226 @@
+/*
+ * Licensed to the Apache Software
Github user squito commented on the issue:
https://github.com/apache/spark/pull/22705
merged to master / 2.4.
Something went wrong w/ the merge script when putting it on 2.4 (I think I
accidentally had a dirty working dir at the time), but it was actually a clean
cherry pick
Github user squito closed the pull request at:
https://github.com/apache/spark/pull/22710
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22771#discussion_r226522963
--- Diff: core/src/test/scala/org/apache/spark/SparkContextSuite.scala ---
@@ -672,6 +674,55 @@ class SparkContextSuite extends SparkFunSuite
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22612#discussion_r226522081
--- Diff: core/src/main/scala/org/apache/spark/Heartbeater.scala ---
@@ -59,12 +60,13 @@ private[spark] class Heartbeater
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22612#discussion_r226519694
--- Diff:
core/src/main/scala/org/apache/spark/executor/ProcfsBasedSystems.scala ---
@@ -0,0 +1,226 @@
+/*
+ * Licensed to the Apache Software
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22612#discussion_r226519208
--- Diff:
core/src/main/scala/org/apache/spark/executor/ProcfsBasedSystems.scala ---
@@ -0,0 +1,266 @@
+/*
+ * Licensed to the Apache Software
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22612#discussion_r226520380
--- Diff:
core/src/main/scala/org/apache/spark/executor/ProcfsBasedSystems.scala ---
@@ -0,0 +1,226 @@
+/*
+ * Licensed to the Apache Software
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22612#discussion_r226519417
--- Diff:
core/src/main/scala/org/apache/spark/executor/ProcfsBasedSystems.scala ---
@@ -0,0 +1,226 @@
+/*
+ * Licensed to the Apache Software
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22612#discussion_r226519607
--- Diff:
core/src/main/scala/org/apache/spark/executor/ProcfsBasedSystems.scala ---
@@ -0,0 +1,226 @@
+/*
+ * Licensed to the Apache Software
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22612#discussion_r226522582
--- Diff:
core/src/main/scala/org/apache/spark/metrics/ExecutorMetricType.scala ---
@@ -48,17 +56,47 @@ private[spark] abstract class
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22612#discussion_r226521801
--- Diff:
core/src/main/scala/org/apache/spark/metrics/ExecutorMetricType.scala ---
@@ -95,10 +135,29 @@ private[spark] object ExecutorMetricType
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22612#discussion_r226520198
--- Diff:
core/src/main/scala/org/apache/spark/executor/ProcfsBasedSystems.scala ---
@@ -0,0 +1,226 @@
+/*
+ * Licensed to the Apache Software
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22612#discussion_r226519831
--- Diff:
core/src/main/scala/org/apache/spark/executor/ProcfsBasedSystems.scala ---
@@ -0,0 +1,226 @@
+/*
+ * Licensed to the Apache Software
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22288#discussion_r226478269
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -679,20 +679,28 @@ private[spark] class TaskSetManager
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22288#discussion_r226464912
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
@@ -415,9 +420,65 @@ private[spark] class TaskSchedulerImpl
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22288#discussion_r226476094
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
@@ -415,9 +420,65 @@ private[spark] class TaskSchedulerImpl
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22288#discussion_r226477452
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
@@ -415,9 +420,65 @@ private[spark] class TaskSchedulerImpl
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22288#discussion_r226475523
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
@@ -415,9 +419,61 @@ private[spark] class TaskSchedulerImpl
101 - 200 of 3521 matches
Mail list logo
