Re: Weston at bootup

2018-09-18 Thread Daniel Stone
Hi Deepan, On Tue, 18 Sep 2018 at 17:24, deepan muthusamy wrote: > Did you launched as session service? > > I want to launch as system service. Have you tried that? > It sounds like you are having a problem, but there aren't enough details in your mails for us to help you. Have you already

Re: [Mesa-dev] Lets talk about autotools

2018-09-17 Thread Daniel Stone
Hi, On Mon, 17 Sep 2018 at 22:31, Marek Olšák wrote: > Is there any documentation for configure options? Or do I have to do > "grep get_option meson.build" to get the list at least? Most of these questions can be answered by running: meson configure $builddir More documentation is available

Re: Building weston

2018-09-17 Thread Daniel Stone
Hi Rohan, On Sat, 1 Sep 2018 at 11:28, rohan julka wrote: > how can I check if there is a compilation error after editing the code in > Weston , apologies for the rookie question I am just trying to understand on > how to build and run Weston , it seems a bit confusing any help would be >

Re: Add new DIRTY fb flags to pass interlaced alternate fields

2018-09-17 Thread Daniel Stone
Hi Satish, On Fri, 7 Sep 2018 at 23:04, Satish Nagireddy wrote: > The requirement is to render interlaced alternate buffers. In case of > alternate, top field and bottom field are in two different buffers. > > The question is, can we pass existing flags DRM_MODE_PRESENT_TOP_FIELD > and

Re: [PATCH libdrm] CONTRIBUTING: clarify how to request a Developer role

2018-09-17 Thread Daniel Stone
Hi, On Sat, 15 Sep 2018 at 00:56, Lucas De Marchi wrote: > -To apply for commit rights ("Developer" role in gitlab) send a mail to > -dri-devel@lists.freedesktop.org and please ping the maintainers if your > request > -is stuck. > +To apply for commit rights ("Developer" role in gitlab), check

Re: [PATCH] RFC: CONTRIBUTING: Embrace gitlab

2018-09-13 Thread Daniel Stone
Hey Ville, On Thu, 13 Sep 2018 at 11:52, Ville Syrjälä wrote: > On Thu, Sep 13, 2018 at 11:31:31AM +0100, Daniel Stone wrote: > > On Thu, 13 Sep 2018 at 09:54, Jani Nikula wrote:> > > > > If the acks and reviews aren't recorded in git log for each commit

Re: [PATCH] RFC: CONTRIBUTING: Embrace gitlab

2018-09-13 Thread Daniel Stone
Hi, On Thu, 13 Sep 2018 at 09:54, Jani Nikula wrote: > On Wed, 12 Sep 2018, Daniel Vetter wrote: > > On Wed, Sep 12, 2018 at 7:50 PM, Sean Paul wrote: > >> Given the size of this repo and the number of contributors, I'm not > >> convinced either of these should be blockers. We should avoid

Re: [PATCH] RFC: CONTRIBUTING: Embrace gitlab

2018-09-12 Thread Daniel Stone
On Wed, 12 Sep 2018 at 17:47, Daniel Vetter wrote: > +Patches should be sent via `GitLab merge requests > +`_. > +maintainer-tools are hosted on `freedesktop.org's GitLab > +`_:

Re: [PATCH] dim: Remove upgrade logic

2018-09-12 Thread Daniel Stone
On Wed, 12 Sep 2018 at 15:21, Daniel Vetter wrote: > On Wed, Sep 12, 2018 at 4:01 PM, Daniel Stone wrote: > > On Wed, 12 Sep 2018 at 14:53, Jani Nikula > > wrote: > >> On Wed, 12 Sep 2018, Daniel Stone wrote: > >> > I can stick a hard block on

Re: drm | Pipeline #4114 has failed for master | c55f1b9b

2018-09-06 Thread Daniel Stone
Hi, On Thu, 6 Sep 2018 at 10:11, Lucas De Marchi wrote: > On Wed, Sep 5, 2018 at 7:00 PM Rodrigo Vivi wrote: > > well it builds for me. > > > > but any idea what might be wrong here on gitlab ci? You can simulate what happens in CI by running the same script inside the same container.

[PATCH libdrm] CI: Capture test logs as GitLab artifacts

2018-09-06 Thread Daniel Stone
GitLab CI already captures all the stdout/stderr output from the build process as the log. However, some other important information is hidden in other log files. Taken from Wayland, capture logs from the configuration process as well as from every check. Signed-off-by: Daniel Stone Cc: Rodrigo

Re: Smooth gdm -> GNOME3 session transition broken with 1.20 modesetting driver

2018-09-05 Thread Daniel Stone
Hi Hans, On Wed, 5 Sep 2018 at 19:23, Hans de Goede wrote: > Under Fedora 29 (xserver-1.20) the transition from GDM to > the GNOME3 session is no longer smooth, it seems that the > screen is cleared to black when the Xserver starts instead > of inheriting the framebuffer contents from GDM as

Re: did the weston do the YUV to RGB convert internally?

2018-09-04 Thread Daniel Stone
Hi, On Tue, 4 Sep 2018 at 13:15, tugouxp <13824125...@163.com> wrote: > i launch a pipe line with with gstreamer command as below: > gst-launch-1.0 filesrc location=/mnt/UDISK/N_1080P_AVC_60F.avi ! avidemux > ! h264parse ! omxh264dec ! queue ! waylandsink > the target sink i use was

Re: [RFC] drm/amdgpu: Add macros and documentation for format modifiers.

2018-09-04 Thread Daniel Stone
Hi, On Tue, 4 Sep 2018 at 11:44, Christian König wrote: > Am 04.09.2018 um 12:15 schrieb Daniel Stone: > > Right. The conclusion, after people went through and started sorting > > out the kinds of formats for which they would _actually_ export real > > colour buffers f

Re: [RFC] drm/amdgpu: Add macros and documentation for format modifiers.

2018-09-04 Thread Daniel Stone
Hi, On Tue, 4 Sep 2018 at 11:44, Christian König wrote: > Am 04.09.2018 um 12:15 schrieb Daniel Stone: > > Right. The conclusion, after people went through and started sorting > > out the kinds of formats for which they would _actually_ export real > > colour buffers f

Re: [RFC] drm/amdgpu: Add macros and documentation for format modifiers.

2018-09-04 Thread Daniel Stone
Hi, On Tue, 4 Sep 2018 at 11:05, Daniel Vetter wrote: > On Tue, Sep 4, 2018 at 3:00 AM, Bas Nieuwenhuizen > wrote: > > +/* The chip this is compatible with. > > + * > > + * If compression is disabled, use > > + * - AMDGPU_CHIP_TAHITI for GFX6-GFX8 > > + * - AMDGPU_CHIP_VEGA10 for GFX9+ > >

Re: [RFC] drm/amdgpu: Add macros and documentation for format modifiers.

2018-09-04 Thread Daniel Stone
Hi, On Tue, 4 Sep 2018 at 11:05, Daniel Vetter wrote: > On Tue, Sep 4, 2018 at 3:00 AM, Bas Nieuwenhuizen > wrote: > > +/* The chip this is compatible with. > > + * > > + * If compression is disabled, use > > + * - AMDGPU_CHIP_TAHITI for GFX6-GFX8 > > + * - AMDGPU_CHIP_VEGA10 for GFX9+ > >

Re: [PATCH libdrm] add gitlab-ci builds of libdrm

2018-09-03 Thread Daniel Stone
> > --- > > See it in action on my fork: > > https://gitlab.freedesktop.org/eric/libdrm/pipelines/3885 > > With the --no-check-certificate things explained: > > Reviewed-by: Daniel Vetter Indeed, and also: Reviewed-by: Daniel Stone Thanks for doing this! Cheers, Daniel

[Mesa-dev] [PATCH] st/dri: Don't expose sRGB formats to clients

2018-08-31 Thread Daniel Stone
, preventing us from tripping over an assert. Signed-off-by: Daniel Stone Reported-by: Michel Dänzer Fixes: 8c1b9882b2e0 ("egl/dri2: Guard against invalid fourcc formats") Cc: Jason Ekstrand --- src/gallium/state_trackers/dri/dri2.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/s

Re: [PATCH libdrm] add gitlab-ci builds of libdrm

2018-08-31 Thread Daniel Stone
Hi Eric, On Fri, 31 Aug 2018 at 15:22, Eric Engestrom wrote: > +- LIBPCIACCESS_VERSION=libpciaccess-0.10 && > + wget --no-check-certificate > https://xorg.freedesktop.org/releases/individual/lib/$LIBPCIACCESS_VERSION.tar.bz2 > && Why are you using --no-check-certificate?! Cheers,

Re: Error while installing weston

2018-08-31 Thread Daniel Stone
Hi Rohan, On Fri, 31 Aug 2018 at 13:04, rohan julka wrote: > I am installing Weston on Ubuntu and it shows this error > > “ libdrm is a hard build-time dependency for libweston core, > but a sufficient version was not found. However, libdrm > is not a runtime dependency unless you

Re: [Mesa-dev] [PATCH v2] egl/wayland: do not leak wl_buffer when it is locked

2018-08-31 Thread Daniel Stone
nlock only or free wl_buffer too (Daniel) > > This also fixes dEQP-EGL.functional.swap_buffers_with_damage.* tests. Thanks Juan! Reviewed-by: Daniel Stone ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 3/3] i965/screen: Allow modifiers on sRGB formats

2018-08-31 Thread Daniel Stone
ts[i].fourcc == __DRI_IMAGE_FOURCC_SARGB > > > || > > > + intel_image_formats[i].fourcc == __DRI_IMAGE_FOURCC_SABGR) > > > + return false; > > > > > > > This should be a continue. Fixed locally. > > With that, the series is > Reviewed-by: Eric Engestrom ... and also: Reviewed-by: Daniel Stone ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: is there any way to use display "overlay layer" when playing video?

2018-08-31 Thread Daniel Stone
On Fri, 31 Aug 2018 at 09:00, tugouxp <13824125...@163.com> wrote: >my target platform display engine device support two type of layers, they > are "GUI" and "YUV", the GUI layer use to draw OSD screens with data type > RGB, and "YUV" only support video data with "yuv" format. > > but when i

Re: [PATCH wayland v4 1/5] build/doc: Ensure destination dir exists despite VPATH

2018-08-30 Thread Daniel Stone
On Wed, 29 Aug 2018 at 17:46, Emil Velikov wrote: > On 28 August 2018 at 23:19, Daniel Stone wrote: > > Change the alldirs target list to be absolute paths, so VPATH will not > > be consulted and defeat the entire point of what we're trying to do. > > This fixes the Meson

Re: [PATCH wayland 6/6] tests: Remove memory leak checking infrastructure

2018-08-30 Thread Daniel Stone
Hi, On Wed, 29 Aug 2018 at 17:37, Emil Velikov wrote: > On 29 August 2018 at 07:17, Daniel Stone wrote: > > There are far better ways to detect memory leaks, such as either > > valgrind or ASan. Having Meson makes it really easy to use these tools > > in our tests, and

Re: [PATCH wayland 5/6] tests: Overly elaborate compiler warning workaround

2018-08-30 Thread Daniel Stone
Hi Emil, On Wed, 29 Aug 2018 at 17:33, Emil Velikov wrote: > On 29 August 2018 at 07:17, Daniel Stone wrote: > > -static const struct sockaddr_un example_sockaddr_un; > > +static struct sockaddr_un example_sockaddr_un; > > > > #define TOO_LONG (1 + sizeof e

Re: [PATCH wayland 0/6] Minor test/scanner fixes

2018-08-29 Thread Daniel Stone
On Wed, 29 Aug 2018 at 09:51, Pekka Paalanen wrote: > On Wed, 29 Aug 2018 07:17:09 +0100 Daniel Stone wrote: > > These first 5 patches fix some issues I found by running the test suite > > under an expanded set of toolchains, including the ASan address > > sanitiser and Cl

Re: EXT: [PATCH wayland 6/6] tests: Remove memory leak checking infrastructure

2018-08-29 Thread Daniel Stone
Hi Ian, On Wed, 29 Aug 2018 at 07:45, Ray, Ian (GE Healthcare) wrote: > > On 29 Aug 2018, at 9.17, Daniel Stone wrote: > > @@ -200,7 +147,7 @@ run_test(const struct test *t) > > assert(sigaction(SIGALRM, , NULL) == 0); > > } > > > > -

Re: [PATCH] Migrate to Gitlab

2018-08-29 Thread Daniel Stone
mit, which would stop auto-upgrading from happening. Since we have a script which already rewrites remotes for upgrades, might as well just have it properly EOLed in the old location whilst moving from a branch to a separate repo. Reviewed-by: Danie

[PATCH wayland 1/6] scanner: Plug two memory leaks

2018-08-29 Thread Daniel Stone
Found with both ASan leak sanitizer and Valgrind. We were trivially leaking the enum name for every arg parsed by the scanner which had one. If libxml-based DTD validation was enabled, we would also leak the DTD itself, despite diligently freeing the document, context, etc. Signed-off-by: Daniel

[PATCH wayland 5/6] tests: Overly elaborate compiler warning workaround

2018-08-29 Thread Daniel Stone
Clang will rightly point out that example_sockaddr_un in socket-test will get discarded from the compilation unit as it is completely unused. Put in a couple of lines which of no value other than stopping Clang from complaining. Signed-off-by: Daniel Stone --- tests/socket-test.c | 7 ++- 1

[PATCH wayland 4/6] tests: Use volatile pointer for NULL dereference

2018-08-29 Thread Daniel Stone
Clang warns that it can silently discard a non-volatile write to a NULL pointer (perhaps it constitutes undefined behaviour?), and recommends changing it to volatile. This patch slavishly complies with the demand of the unfeeling machine. Signed-off-by: Daniel Stone --- tests/sanity-test.c | 4

[PATCH wayland 2/6] scanner: Mark fail() as noreturn

2018-08-29 Thread Daniel Stone
Help static analysers by letting them know that once we fail(), execution will terminally complete. Signed-off-by: Daniel Stone --- src/scanner.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/scanner.c b/src/scanner.c index 3afc3d3d..084f196d 100644 --- a/src/scanner.c

[PATCH wayland 3/6] scanner: Reverse expat/libxml include order

2018-08-29 Thread Daniel Stone
. Luckily we can get around this by just reversing the include order: cdecl is a no-op on Unix-like systems, so by having libxml first define XMLCALL to nothing and including Expat afterwards, we avoid the warning and lose nothing. Signed-off-by: Daniel Stone --- src/scanner.c | 3 ++- 1 file changed

[PATCH wayland 6/6] tests: Remove memory leak checking infrastructure

2018-08-29 Thread Daniel Stone
powerful options. Signed-off-by: Daniel Stone --- tests/sanity-test.c | 66 ++ tests/test-compositor.c | 5 ++- tests/test-runner.c | 79 ++--- tests/test-runner.h | 13 +++ 4 files changed, 20 insertions(+), 143

[PATCH wayland 0/6] Minor test/scanner fixes

2018-08-29 Thread Daniel Stone
Hi, These first 5 patches fix some issues I found by running the test suite under an expanded set of toolchains, including the ASan address sanitiser and Clang's static analyser. Patch 6 removes the leak checking from the test suite completely. Previously due to toolchain immaturity, it was

Re: [PATCH wayland v4 3/5] Add Meson build to Wayland

2018-08-28 Thread Daniel Stone
Hi, On Tue, 28 Aug 2018 at 23:19, Daniel Stone wrote: > Meson is a next generation build system, simpler than Autotools and, > more importantly, faster and more portable. While the latter > consideration is of lesser importance for Wayland, being easier to > understand and faster are

[PATCH wayland v4 3/5] Add Meson build to Wayland

2018-08-28 Thread Daniel Stone
, remove pre-pkg-config Expat support, added missing include paths to wayland-egl and cpp-compile-test, added GitLab CI. Bumped version, removed unnecessary pkg-config paths.] Reviewed-by: Daniel Stone Acked-by: Emre Ucan Acked-by: Peter Hutterer --- .gitlab-ci.yml

[PATCH wayland v4 5/5] meson: Generate man pages

2018-08-28 Thread Daniel Stone
From: Emmanuele Bassi There are ancillary man pages not built by Doxygen that we need to generate an install. --- doc/man/meson.build | 64 + doc/meson.build | 1 + 2 files changed, 65 insertions(+) create mode 100644 doc/man/meson.build diff

[PATCH wayland v4 1/5] build/doc: Ensure destination dir exists despite VPATH

2018-08-28 Thread Daniel Stone
build will fail. Change the alldirs target list to be absolute paths, so VPATH will not be consulted and defeat the entire point of what we're trying to do. This fixes the Meson build, where we later create doc/doxygen/xml/meson.build. Signed-off-by: Daniel Stone --- doc/doxygen/Makefile.am | 13

[PATCH wayland v4 4/5] meson: Run Doxygen on the Meson build

2018-08-28 Thread Daniel Stone
From: Emmanuele Bassi Add a script which generates the desired Doxygen configuration for our various output formats and executes it using that configuration. [daniels: Properly install into mandir/man3 via some gross paramaterisation, generate real stamp files.] Reviewed-by: Daniel

[PATCH wayland v4 2/5] Support running tests from different build directories

2018-08-28 Thread Daniel Stone
to control what's the location of the test binaries, and fall back to the current directory if the variable is unset. Reviewed-by: Daniel Stone --- tests/test-helpers.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/tests/test-helpers.c b/tests/test-helpers.c

Re: [PATCH] xwayland: fix access to invalid pointer

2018-08-28 Thread Daniel Stone
imensions - you disconnect one of them - you want newly-connected legacy clients to get the correct DPI value through the connection handshake I'm finding that usecase hard to care enough about that to justify how ugly it is compared to this, so this patch is: Reviewed-by: Daniel Stone Cheers,

Re: Window scaling (aka owner sizes)

2018-08-27 Thread Daniel Stone
On Mon, 27 Aug 2018 at 19:19, Keith Packard wrote: > Daniel Stone writes: > > It's the other way around. Wayland only has surface-relative > > co-ordinates, so we take those and then translate them back into the > > X11 global co-ordinate space. > > Oh, so if we k

Re: Window scaling (aka owner sizes)

2018-08-27 Thread Daniel Stone
Hi, On Mon, 27 Aug 2018 at 18:45, Keith Packard wrote: > Robert Mader writes: > > I can post my WIP work (will have to clean it up and rebase to current > > master). > > That said, I'm very interested to see this go forward and am very > > willing to help :) > > I don't know how device

Re: [PATCH weston v5 03/14] libweston: add weston_debug API and implementation

2018-08-27 Thread Daniel Stone
Hi Pekka, On Fri, 24 Aug 2018 at 09:12, Pekka Paalanen wrote: > On Thu, 23 Aug 2018 17:53:07 +0100 Daniel Stone wrote: > > The users introduced in this patchset already check if the scope is > > enabled, which bails out if the scope is NULL. Given that, and that I > >

Re: [PATCH weston v5 03/14] libweston: add weston_debug API and implementation

2018-08-27 Thread Daniel Stone
Hi Pekka, On Mon, 6 Aug 2018 at 14:05, Pekka Paalanen wrote: > On Fri, 20 Jul 2018 20:03:24 +0100 Daniel Stone wrote: > > + while (len_ > 0) { > > + ret = write(stream->fd, data, len_); > > + e = errno; > > + if (ret <

Re: [PATCH] drm/kms/crtc: Improving the func drm_mode_setcrtc

2018-08-24 Thread Daniel Stone
Hi Satendra, On Fri, 27 Jul 2018 at 11:13, Satendra Singh Thakur wrote: > Following changes are done to this func: I would certainly agree with Sean, Martin, and Jani's comments. This patch was difficult to follow as it made so many changes at once. Being a crucial function which has many

Re: [PATCH weston v5 03/14] libweston: add weston_debug API and implementation

2018-08-23 Thread Daniel Stone
Hi Pekka, On Mon, 6 Aug 2018 at 12:16, Pekka Paalanen wrote: > On Fri, 20 Jul 2018 20:03:24 +0100 Daniel Stone wrote: > > +/** Format current time as a string > > + * and append the debug scope name to it > > + * > > + * \param scope[in] debug scope. > > +

Re: Wayland/weston opens files in suspend/resume

2018-08-23 Thread Daniel Stone
Hi, On Thu, 23 Aug 2018 at 08:18, Pekka Paalanen wrote: > On Thu, 23 Aug 2018 08:30:35 +0300 Teemu K wrote: > > Well, since it's i.MX6 and NXP (still) doesn't provide proper video > > driver so proprietary EGL driver is being used. I think they even made > > their own fork for Weston 2.0.0

Re: [Intel-gfx] [igt-dev] RFC: Migration to Gitlab

2018-08-22 Thread Daniel Stone
Hi Rodrigo, On Wed, 22 Aug 2018 at 17:06, Rodrigo Vivi wrote: > On Wed, Aug 22, 2018 at 10:19:19AM -0400, Adam Jackson wrote: > > On Wed, 2018-08-22 at 16:13 +0300, Jani Nikula wrote: > > > - Sticking to fdo bugzilla and disabling gitlab issues for at least > > > drm-intel for the time being.

Re: [igt-dev] RFC: Migration to Gitlab

2018-08-22 Thread Daniel Stone
Hi Rodrigo, On Wed, 22 Aug 2018 at 17:06, Rodrigo Vivi wrote: > On Wed, Aug 22, 2018 at 10:19:19AM -0400, Adam Jackson wrote: > > On Wed, 2018-08-22 at 16:13 +0300, Jani Nikula wrote: > > > - Sticking to fdo bugzilla and disabling gitlab issues for at least > > > drm-intel for the time being.

Re: [igt-dev] RFC: Migration to Gitlab

2018-08-22 Thread Daniel Stone
Hi Rodrigo, On Wed, 22 Aug 2018 at 17:06, Rodrigo Vivi wrote: > On Wed, Aug 22, 2018 at 10:19:19AM -0400, Adam Jackson wrote: > > On Wed, 2018-08-22 at 16:13 +0300, Jani Nikula wrote: > > > - Sticking to fdo bugzilla and disabling gitlab issues for at least > > > drm-intel for the time being.

Re: [igt-dev] RFC: Migration to Gitlab

2018-08-22 Thread Daniel Stone
Hi, On Wed, 22 Aug 2018 at 15:44, Daniel Vetter wrote: > On Wed, Aug 22, 2018 at 3:13 PM, Jani Nikula > wrote: > > Just a couple of concerns from drm/i915 perspective for starters: > > > > - Patchwork integration. I think we'll want to keep patchwork for at > > least intel-gfx etc. for the

Re: [igt-dev] RFC: Migration to Gitlab

2018-08-22 Thread Daniel Stone
Hi, On Wed, 22 Aug 2018 at 15:44, Daniel Vetter wrote: > On Wed, Aug 22, 2018 at 3:13 PM, Jani Nikula > wrote: > > Just a couple of concerns from drm/i915 perspective for starters: > > > > - Patchwork integration. I think we'll want to keep patchwork for at > > least intel-gfx etc. for the

Re: [igt-dev] RFC: Migration to Gitlab

2018-08-22 Thread Daniel Stone
Hi, On Wed, 22 Aug 2018 at 15:44, Daniel Vetter wrote: > On Wed, Aug 22, 2018 at 3:13 PM, Jani Nikula > wrote: > > Just a couple of concerns from drm/i915 perspective for starters: > > > > - Patchwork integration. I think we'll want to keep patchwork for at > > least intel-gfx etc. for the

Re: [Intel-gfx] [igt-dev] RFC: Migration to Gitlab

2018-08-22 Thread Daniel Stone
Hi, On Wed, 22 Aug 2018 at 15:44, Daniel Vetter wrote: > On Wed, Aug 22, 2018 at 3:13 PM, Jani Nikula > wrote: > > Just a couple of concerns from drm/i915 perspective for starters: > > > > - Patchwork integration. I think we'll want to keep patchwork for at > > least intel-gfx etc. for the

Re: RFC: Migration to Gitlab

2018-08-22 Thread Daniel Stone
Hi, On Wed, 22 Aug 2018 at 16:02, Emil Velikov wrote: > On 22 August 2018 at 12:44, Daniel Vetter wrote: > > I think it's time to brainstorm a bit about the gitlab migration. Basic > > reasons: > > > > - fd.o admins want to deprecate shell accounts and hand-rolled > > infrastructure, because

Re: RFC: Migration to Gitlab

2018-08-22 Thread Daniel Stone
Hi, On Wed, 22 Aug 2018 at 16:02, Emil Velikov wrote: > On 22 August 2018 at 12:44, Daniel Vetter wrote: > > I think it's time to brainstorm a bit about the gitlab migration. Basic > > reasons: > > > > - fd.o admins want to deprecate shell accounts and hand-rolled > > infrastructure, because

Re: RFC: Migration to Gitlab

2018-08-22 Thread Daniel Stone
Hi, On Wed, 22 Aug 2018 at 16:02, Emil Velikov wrote: > On 22 August 2018 at 12:44, Daniel Vetter wrote: > > I think it's time to brainstorm a bit about the gitlab migration. Basic > > reasons: > > > > - fd.o admins want to deprecate shell accounts and hand-rolled > > infrastructure, because

Re: [Intel-gfx] RFC: Migration to Gitlab

2018-08-22 Thread Daniel Stone
Hi, On Wed, 22 Aug 2018 at 16:02, Emil Velikov wrote: > On 22 August 2018 at 12:44, Daniel Vetter wrote: > > I think it's time to brainstorm a bit about the gitlab migration. Basic > > reasons: > > > > - fd.o admins want to deprecate shell accounts and hand-rolled > > infrastructure, because

Re: [Mesa-dev] [PATCH libdrm] Add basic CONTRIBUTING file

2018-08-22 Thread Daniel Stone
On Wed, 22 Aug 2018 at 11:51, Daniel Vetter wrote: > +See the gitlab project owners for contact details of the libdrm maintainers. Think this should be 'See MAINTAINERS' ... ? The rest looks good to me, though I would encourage linking to Patchwork so people can find patches from others, as

Re: [Mesa-dev] [PATCH libdrm] Add basic CONTRIBUTING file

2018-08-22 Thread Daniel Stone
On Wed, 22 Aug 2018 at 11:51, Daniel Vetter wrote: > +See the gitlab project owners for contact details of the libdrm maintainers. Think this should be 'See MAINTAINERS' ... ? The rest looks good to me, though I would encourage linking to Patchwork so people can find patches from others, as

Re: [Mesa-dev] [PATCH mesa] egl: add helper to combine two u32 into one u64

2018-08-21 Thread Daniel Stone
r treated as signed. Might be worth a note in the commit about signedness. Reviewed-by: Daniel Stone Cheers, Daniel ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[jira] [Created] (CB-14271) onPause event not fired on app close?

2018-08-15 Thread Daniel Stone (JIRA)
Daniel Stone created CB-14271: - Summary: onPause event not fired on app close? Key: CB-14271 URL: https://issues.apache.org/jira/browse/CB-14271 Project: Apache Cordova Issue Type: Bug

Re: [Mesa-dev] [PATCH 1/3] egl/drm: use gbm_dri_device() wrapper

2018-08-13 Thread Daniel Stone
new ones. So, series is: Acked-by: Daniel Stone Cheers, Daniel ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [PATCH libinput] doc/user: expand the Contributing document

2018-08-13 Thread Daniel Stone
/wayland/weston/blob/master/CONTRIBUTING.md>`_, > > + many thanks to the authors for their efforts. > > Hi Peter, > > personally I would be ok with this note being just in the commit > message. AOL, it's a lovely acknowledgement but irrelevant to the target

Re: [ANN] edid-decode maintenance info

2018-08-13 Thread Daniel Stone
Hi, On Sun, 12 Aug 2018 at 21:53, Alan Coopersmith wrote: > On 06/22/18 01:12 AM, Hans Verkuil wrote: > > Thank you for this information. I looked through all the bug reports and > > 100607, 100340 and 93366 were already fixed before I took over maintenance. > > > > I just fixed 89348 and 93777

Re: [Mesa-dev] [PATCH] egl/wayland: do not leak wl_buffer when it is locked

2018-08-08 Thread Daniel Stone
Hi Juan, On Wed, 8 Aug 2018 at 17:40, Juan A. Suarez Romero wrote: > On Wed, 2018-08-08 at 17:21 +0100, Daniel Stone wrote: > > On Thu, 2 Aug 2018 at 10:02, Juan A. Suarez Romero > > wrote: > > > If color buffer is locked, do not set its wayland buffer to NULL

Re: [Mesa-dev] [PATCH 0/3] Use GitLab CI to build Mesa

2018-08-08 Thread Daniel Stone
You can eke out a little bit of a speed improvement by using the go-faster runes from before 'apt-get update' here: https://gitlab.freedesktop.org/wayland/weston/blob/master/.gitlab-ci.yml#L6 Anyway, this all looks great, and I'm really excited to see it! The series is: Acked-by: Daniel Stone

Re: [Mesa-dev] [PATCH v4 2/2] wayland/egl: update surface size on window resize

2018-08-08 Thread Daniel Stone
tely, > and if user calls eglQuerySurface() it will return the new resized > values. I'm pretty confident that these two patches do the right thing; series is: Reviewed-by: Daniel Stone Thanks a lot for your patience & persistence! Cheers, Daniel __

Re: [Mesa-dev] [PATCH] egl/wayland: do not leak wl_buffer when it is locked

2018-08-08 Thread Daniel Stone
ll buffers to be released) by the time they destroy their EGLSurface, but that's of course never going to happen. So, assuming there's no unexpected consequences I haven't seen, this is: Reviewed-by: Daniel Stone Cheers, Daniel ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[ANNOUNCE] Weston now uses GitLab for review

2018-08-07 Thread Daniel Stone
Hi all, Weston is now using GitLab merge requests for patch submission and review, rather than the mailing list and Patchwork. \o/ The contribution guide covers how to create a merge request and the review process in general:

Re: [PATCH libdrm v3] tests/modetest: Add atomic support

2018-08-07 Thread Daniel Stone
Hi Emil, This is off-topic for the list, but ... On Tue, 7 Aug 2018 at 14:46, Emil Velikov wrote: > Aside: libdrm following X/Wayland in that it lacks contributor/push access > docs. > Might be worth, copying the Mesa ones and adding a doc in-tree.

Re: [PATCH weston 3/5] README: Move to Markdown, rewrite introduction

2018-08-07 Thread Daniel Stone
Hi Pekka, On Tue, 7 Aug 2018 at 14:25, Pekka Paalanen wrote: > On Mon, 6 Aug 2018 12:09:22 +0100 Daniel Stone wrote: > > Move the README file to Markdown, and update it to attempt to explain > > the current status and use of Weston. > > > > The first sections a

Re: [Mesa-dev] [PATCH] wayland/egl: initialize window surface size to window size

2018-08-06 Thread Daniel Stone
Hi Juan, On Tue, 5 Jun 2018 at 18:23, Juan A. Suarez Romero wrote: > On Tue, 2018-06-05 at 12:41 +0100, Daniel Stone wrote: > > > - In Wayland/Mesa, the surface is not resized at the time the native > > > window is > > > resized; this is done in *eglSw

[PATCH weston 2/5] doc: Update CONTRIBUTING for Weston

2018-08-06 Thread Daniel Stone
Change some Wayland-specific references to instead refer to Weston. Signed-off-by: Daniel Stone Reviewed-by: Quentin Glidic Reviewed-by: Pekka Paalanen --- CONTRIBUTING.md | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index

[PATCH weston 4/5] doc: Use GitLab MRs for patches, not the list

2018-08-06 Thread Daniel Stone
rebasing microcommit workflow. Signed-off-by: Daniel Stone Reviewed-by: Quentin Glidic Reviewed-by: Pekka Paalanen --- CONTRIBUTING.md | 143 1 file changed, 73 insertions(+), 70 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index

[PATCH wayland 5/5] contributing: Weston now uses GitLab MRs

2018-08-06 Thread Daniel Stone
Note that Weston uses GitLab MRs for review, not mail. Signed-off-by: Daniel Stone --- CONTRIBUTING.md | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 4273d99d..686ed63f 100644 --- a/CONTRIBUTING.md +++ b

[PATCH weston 1/5] Add CONTRIBUTING.md document

2018-08-06 Thread Daniel Stone
From: Pekka Paalanen Taken from Pekka's wayland/wayland@630c25f4c160 and follow-ups, use Wayland's CONTRIBUTING document as a basis for Weston. Signed-off-by: Daniel Stone Reviewed-by: Quentin Glidic Reviewed-by: Pekka Paalanen --- CONTRIBUTING.md | 343

[PATCH 0/5] Weston contributing doc, GitLab MRs

2018-08-06 Thread Daniel Stone
Hi, Thanks to Pekka and Quentin for the review: this fixes some errors in the original README/CONTRIBUTING doc submission for Weston, retaining the GitLab MR move. It also adds a patch to Wayland's CONTRIBUTING.md, severing the two sets of instructions. Cheers, Daniel

Re: [PATCH weston 4/4] doc: Use GitLab MRs for patches, not the list

2018-08-06 Thread Daniel Stone
Hi Pekka, On Fri, 3 Aug 2018 at 12:05, Pekka Paalanen wrote: > I'm happy to move to MR-based work flow immediately. \o/ > From the above link, I found this: > http://www.bitsnbites.eu/git-history-work-log-vs-recipe/ > which explain the below in more words. Maybe include this link as well? > >

Re: [v2, weston] gl-renderer.c: Use gr->egl_config to create pbuffer surface

2018-08-03 Thread Daniel Stone
Hi Adam, On Fri, 3 Aug 2018 at 19:05, Adam Jackson wrote: > On Thu, 2018-08-02 at 17:21 -0700, Madhurkiran Harikrishnan wrote: > > The original implementation always chose first egl config for pbuffer > > surface type, however the returned configs are implementation specific > > and egl config

Re: [PATCH v3 weston 4/5] tests: add test for setting gamma

2018-08-03 Thread Daniel Stone
Hi Harsha, On Tue, 24 Jul 2018 at 10:11, Harsha Manjula Mallikarjun (RBEI/ECF3) wrote: > > So, I understand this would be a manual test where the user would > > visually verify that the gamma is changing in the way they would > > expect? I have no problem with that, but it would be nice to see

Re: Weston default pixel format

2018-08-03 Thread Daniel Stone
Hi Santiago, On Fri, 3 Aug 2018 at 09:28, Santiago Otero wrote: > El 03/08/18 a las 09:35, Pekka Paalanen escribió: >> No, you cannot use another KMS application at the same time as Weston >> is active. The kernel DRM core will forbid access (denies DRM Master >> status) if there is already

Re: [PATCH 0/2] Automatically build docs through GitLab CI

2018-08-03 Thread Daniel Stone
aniel if that's ok. Strictly thinking we'd need to > wait for the final Wayland release before merging these, but I'd be ok > landing these earlier too, the patches do not touch Wayland bits but > only the CI bits. I was waiting for the changes Peter requested; with those changes, the serie

Re: [prefix=PATCH weston] gl-renderer.c: Pass visual ID for choosing egl configs for pbuffer

2018-08-02 Thread Daniel Stone
Hi Madhurkiran, On Tue, 31 Jul 2018 at 02:02, Madhurkiran Harikrishnan wrote: > Thanks for the comments. For a not having configless_context, can you > explain why should I check gr->egl_config, because the attributes passed > while getting this gr->egl_config does not have EGL_PBUFFER_BIT

Re: [PATCH wayland-protocols 2/2] tests: Make wayland-scanner strict

2018-07-30 Thread Daniel Stone
Hi Jonas, On Mon, 30 Jul 2018 at 16:10, Jonas Ådahl wrote: > Pass --strict to wayland-scanner in order to make it exit with failure > if something wasn't correct. The series is: Reviewed-by: Daniel Stone It might be nice to autodetect whether or not wayland-scanner is new enough to s

Re: [PATCH weston 3/4] README: Move to Markdown, rewrite introduction

2018-07-30 Thread Daniel Stone
Hi, On Fri, 20 Jul 2018 at 11:08, Quentin Glidic wrote: > Then, all four patches are: > Reviewed-by: Quentin Glidic > (With or without the split.) So from mail, that's myself, Quentin, Emre, Erik, and Pekka supporting the move, with qualified support (... semi-enthusiasm?) from Jonas. From

Re: gitlab migration (including account update plans, please read)

2018-07-29 Thread Daniel Stone
Hi Alan, On Sun, 29 Jul 2018 at 16:53, Alan Coopersmith wrote: > On 07/29/18 03:07 AM, Daniel Stone wrote: > > This took a little longer than hoped, but all the repos have now been moved. > > Huge thanks for doing this. > > I updated all my local clones with: > > git

Re: gitlab migration (including account update plans, please read)

2018-07-29 Thread Daniel Stone
Hi, On Mon, 23 Jul 2018 at 16:24, Adam Jackson wrote: > My earlier assertion about the git url not being changed is only true > for pulls. For pushes, you will indeed need to update the remote to the > new URL: > > $ git remote set-url origin ssh://g...@gitlab.freedesktop.org/xorg/xserver > >

Re: Advertising supported Dmabuf modifiers of DRM device

2018-07-27 Thread Daniel Stone
Hi Philipp, On Fri, 27 Jul 2018 at 14:10, Philipp Zabel wrote: > On Fri, 2018-07-27 at 11:23 +0100, Daniel Stone wrote: > > Taking i.MX6 as an example - if we know we can never show at least one > > view on an overlay (because it's transformed, or too many views, etc), >

Re: Advertising supported Dmabuf modifiers of DRM device

2018-07-27 Thread Daniel Stone
Hi Emre, On Fri, 27 Jul 2018 at 07:44, Ucan, Emre (ADITG/ESB) wrote: > IMO, entire point of having wayland surfaces and buffers to use them for > display scanout. > > If an application does not want to display its rendered content, it can use > surfaceless context or render to texture etc.

Re: [PATCH wayland 1/2] build: Remove execinfo.h check

2018-07-26 Thread Daniel Stone
Hi, On Thu, 26 Jul 2018 at 16:11, Emil Velikov wrote: > On 25 July 2018 at 18:36, Derek Foreman > wrote: > > On 2018-07-21 06:13 AM, Daniel Stone wrote: > >> The check for the execinfo.h header is only advisory; the build will not > >> fail if it is not pr

Re: DRM page-flip with damage for weston

2018-07-26 Thread Daniel Stone
Hi Deepak, On Wed, 25 Jul 2018 at 18:26, Deepak Singh Rawat wrote: > > The damage region received during output repaint is in Weston's global > > co-ordinate space. To shift to CRTC co-ordinates, you need to > > translate the damage region by (-output->x, -output->y). When we are > > using the

Re: Advertising supported Dmabuf modifiers of DRM device

2018-07-26 Thread Daniel Stone
Hi Emre, On Thu, 26 Jul 2018 at 14:54, Ucan, Emre (ADITG/ESB) wrote: > We are currently querying supported modifiers only from gpu drivers via > EGL_EXT_image_dma_buf_modifiers extension. > But we should also query and advertise modifiers which are supported by DRM > device. We are already

Re: [RFC libinput] dox: switch to sphinx for the user-visible documentation

2018-07-26 Thread Daniel Stone
ith Doxygen. Given that the kernel also uses Sphinx for the DRM/KMS documentation in particular, it's probably good for us to be using it as well. If it counts for anything at all: Acked-by: Daniel Stone Cheers, Daniel PS: You might want to disable syntax highlighting on the MIT license; als

Re: [Mesa-dev] [PATCH v3] dri3: For 1.2, use root window instead of pixmap drawable

2018-07-26 Thread Daniel Stone
c_render_buffer() to return NULL and breaks > rendering when using GLX_DOUBLEBUFFER on pixmaps. > > Query the root window of the pixmap on first init, and use the root > window instead of the pixmap drawable for get_supported_modifiers() > and pixmap_from_buffers(). Looks good to me, thanks

Re: [RFC weston] clients: Don't attach a buffer if mouse cursor surface is unchanged

2018-07-26 Thread Daniel Stone
Hi Jasper, On Thu, 26 Jul 2018 at 03:53, Jasper St. Pierre wrote: > From IRC conversations with krh a long time ago, this is indeed intentional > and the cursor surface should "lose its role" in modern parlance. > > The original intention was to prevent glitching of the cursor surface. e.g. >

<    2   3   4   5   6   7   8   9   10   11   >